From: Chris Morgan <macromorgan@hotmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, heiko@sntech.de,
devicetree@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
lee.jones@linaro.org
Subject: Re: [v6 1/3] mfd: Add Rockchip rk817 audio CODEC support
Date: Mon, 19 Apr 2021 12:51:12 -0500 [thread overview]
Message-ID: <SN6PR06MB534296C9BA80C56C0AD694FAA5499@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <20210419165116.GE5645@sirena.org.uk>
On Mon, Apr 19, 2021 at 05:51:16PM +0100, Mark Brown wrote:
> On Mon, Apr 19, 2021 at 10:57:16AM -0500, Chris Morgan wrote:
>
> > +#ifdef CONFIG_SND_SOC_RK817
> > + case RK817_CODEC_DTOP_LPT_SRST:
> > +#endif
>
> The register map of the device isn't going to change based on the kernel
> configuration, I wouldn't expect any ifdefs for it.
You are correct, but I was thinking that I should make the codec bits optional
in the event someone had a RK817 and didn't want to use the codec. If you think
this or the rest of the bits should not be optional please let me know. I still
think it's best that at least the cell be optional so users can build a kernel
without the audio if they so choose (I tested both building this module and
audio codec with no devicetree entry - you get a dmesg log error but nothing
else, and building with the devicetree entry but no driver - nothing happens).
If we enable the regmap bits unconditionally, is there any potential harm?
Thank you.
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macromorgan@hotmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
heiko@sntech.de, lee.jones@linaro.org, robh+dt@kernel.org,
perex@perex.cz, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [v6 1/3] mfd: Add Rockchip rk817 audio CODEC support
Date: Mon, 19 Apr 2021 12:51:12 -0500 [thread overview]
Message-ID: <SN6PR06MB534296C9BA80C56C0AD694FAA5499@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <20210419165116.GE5645@sirena.org.uk>
On Mon, Apr 19, 2021 at 05:51:16PM +0100, Mark Brown wrote:
> On Mon, Apr 19, 2021 at 10:57:16AM -0500, Chris Morgan wrote:
>
> > +#ifdef CONFIG_SND_SOC_RK817
> > + case RK817_CODEC_DTOP_LPT_SRST:
> > +#endif
>
> The register map of the device isn't going to change based on the kernel
> configuration, I wouldn't expect any ifdefs for it.
You are correct, but I was thinking that I should make the codec bits optional
in the event someone had a RK817 and didn't want to use the codec. If you think
this or the rest of the bits should not be optional please let me know. I still
think it's best that at least the cell be optional so users can build a kernel
without the audio if they so choose (I tested both building this module and
audio codec with no devicetree entry - you get a dmesg log error but nothing
else, and building with the devicetree entry but no driver - nothing happens).
If we enable the regmap bits unconditionally, is there any potential harm?
Thank you.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-04-19 17:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 15:57 [v6 1/3] mfd: Add Rockchip rk817 audio CODEC support Chris Morgan
2021-04-19 15:57 ` Chris Morgan
2021-04-19 16:51 ` Mark Brown
2021-04-19 16:51 ` Mark Brown
2021-04-19 16:51 ` Mark Brown
2021-04-19 17:51 ` Chris Morgan [this message]
2021-04-19 17:51 ` Chris Morgan
2021-04-20 12:45 ` Mark Brown
2021-04-20 12:45 ` Mark Brown
2021-04-20 12:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR06MB534296C9BA80C56C0AD694FAA5499@SN6PR06MB5342.namprd06.prod.outlook.com \
--to=macromorgan@hotmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.