From: <Don.Brace@microchip.com>
To: <vaibhavgupta40@gmail.com>, <helgaas@kernel.org>,
<bhelgaas@google.com>, <bjorn@helgaas.com>,
<vaibhav.varodek@gmail.com>, <aradford@gmail.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<aacraid@microsemi.com>, <hare@suse.com>,
<linuxdrivers@attotech.com>, <john.garry@huawei.com>,
<don.brace@microsemi.com>, <james.smart@broadcom.com>,
<dick.kennedy@broadcom.com>, <kashyap.desai@broadcom.com>,
<sumit.saxena@broadcom.com>,
<shivasharan.srikanteshwara@broadcom.com>,
<sathya.prakash@broadcom.com>, <sreekanth.reddy@broadcom.com>,
<suganath-prabu.subramani@broadcom.com>,
<jinpu.wang@cloud.ionos.com>
Cc: <skhan@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-kernel-mentees@lists.linuxfoundation.org>,
<linux-scsi@vger.kernel.org>, <esc.storagedev@microsemi.com>,
<megaraidlinux.pdl@broadcom.com>,
<MPT-FusionLinux.pdl@broadcom.com>
Subject: RE: [PATCH v2 11/15] scsi: hpsa: use generic power management
Date: Mon, 20 Jul 2020 22:23:09 +0000 [thread overview]
Message-ID: <SN6PR11MB28485B659DDF20AEA09753A2E17B0@SN6PR11MB2848.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200720133427.454400-12-vaibhavgupta40@gmail.com>
Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers.
With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs.
Change function parameter in both .suspend() and .resume() to "struct device*" type. The function body remains unchanged as it was empty.
Also, bind callbacks with "static const struct dev_pm_ops" variable.
Compile-tested only.
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Acked-by: Don Brace <don.brace@microsemi.com>
Compile-tested: no compile/sparse issues found.
Tested-by: Don Brace <don.brace@microsemi.com>
(for hpsa driver)
WARNING: multiple messages have this Message-ID (diff)
From: "Don.Brace--- via Linux-kernel-mentees" <linux-kernel-mentees@lists.linuxfoundation.org>
To: <vaibhavgupta40@gmail.com>, <helgaas@kernel.org>,
<bhelgaas@google.com>, <bjorn@helgaas.com>,
<vaibhav.varodek@gmail.com>, <aradford@gmail.com>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<aacraid@microsemi.com>, <hare@suse.com>,
<linuxdrivers@attotech.com>, <john.garry@huawei.com>,
<don.brace@microsemi.com>, <james.smart@broadcom.com>,
<dick.kennedy@broadcom.com>, <kashyap.desai@broadcom.com>,
<sumit.saxena@broadcom.com>,
<shivasharan.srikanteshwara@broadcom.com>,
<sathya.prakash@broadcom.com>, <sreekanth.reddy@broadcom.com>,
<suganath-prabu.subramani@broadcom.com>,
<jinpu.wang@cloud.ionos.com>
Cc: linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
esc.storagedev@microsemi.com, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
megaraidlinux.pdl@broadcom.com
Subject: Re: [Linux-kernel-mentees] [PATCH v2 11/15] scsi: hpsa: use generic power management
Date: Mon, 20 Jul 2020 22:23:09 +0000 [thread overview]
Message-ID: <SN6PR11MB28485B659DDF20AEA09753A2E17B0@SN6PR11MB2848.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200720133427.454400-12-vaibhavgupta40@gmail.com>
Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers.
With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs.
Change function parameter in both .suspend() and .resume() to "struct device*" type. The function body remains unchanged as it was empty.
Also, bind callbacks with "static const struct dev_pm_ops" variable.
Compile-tested only.
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Acked-by: Don Brace <don.brace@microsemi.com>
Compile-tested: no compile/sparse issues found.
Tested-by: Don Brace <don.brace@microsemi.com>
(for hpsa driver)
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-20 22:23 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 13:34 [PATCH v2 00/15] scsi: use generic power management Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 01/15] scsi: megaraid_sas: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 16:57 ` Vaibhav Gupta
2020-09-08 16:57 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:32 ` Bjorn Helgaas
2020-09-08 17:32 ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-09-09 10:03 ` Vaibhav Gupta
2020-09-09 10:03 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-09 13:23 ` Bjorn Helgaas
2020-09-09 13:23 ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-09-09 15:20 ` Vaibhav Gupta
2020-09-09 15:20 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-09 16:21 ` Bjorn Helgaas
2020-09-09 16:21 ` [Linux-kernel-mentees] " Bjorn Helgaas
2020-07-20 13:34 ` [PATCH v2 02/15] scsi: aacraid: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-23 6:58 ` Balsundar.P
2020-07-23 6:58 ` [Linux-kernel-mentees] " Balsundar.P--- via Linux-kernel-mentees
2020-09-08 16:58 ` Vaibhav Gupta
2020-09-08 16:58 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 03/15] scsi: aic7xxx: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 16:59 ` Vaibhav Gupta
2020-09-08 16:59 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 04/15] scsi: aic79xx: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 16:59 ` Vaibhav Gupta
2020-09-08 16:59 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 05/15] scsi: arcmsr: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:00 ` Vaibhav Gupta
2020-09-08 17:00 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 06/15] scsi: esas2r: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:01 ` Vaibhav Gupta
2020-09-08 17:01 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 07/15] scsi: hisi_sas_v3_hw: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-21 1:36 ` chenxiang (M)
2020-07-21 1:36 ` [Linux-kernel-mentees] " chenxiang (M)
2020-09-08 17:02 ` Vaibhav Gupta
2020-09-08 17:02 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 08/15] scsi: mpt3sas_scsih: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:03 ` Vaibhav Gupta
2020-09-08 17:03 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 09/15] scsi: lpfc: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:03 ` Vaibhav Gupta
2020-09-08 17:03 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 10/15] scsi: pm_8001: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-23 7:02 ` Jinpu Wang
2020-07-23 7:02 ` [Linux-kernel-mentees] " Jinpu Wang
2020-09-08 17:04 ` Vaibhav Gupta
2020-09-08 17:04 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 11/15] scsi: hpsa: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 22:23 ` Don.Brace [this message]
2020-07-20 22:23 ` Don.Brace--- via Linux-kernel-mentees
2020-09-08 17:05 ` Vaibhav Gupta
2020-09-08 17:05 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 12/15] scsi: 3w-9xxx: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:05 ` Vaibhav Gupta
2020-09-08 17:05 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 13/15] scsi: 3w-sas: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:06 ` Vaibhav Gupta
2020-09-08 17:06 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 14/15] scsi: mvumi: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:07 ` Vaibhav Gupta
2020-09-08 17:07 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-20 13:34 ` [PATCH v2 15/15] scsi: pmcraid: " Vaibhav Gupta
2020-07-20 13:34 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 17:08 ` Vaibhav Gupta
2020-09-08 17:08 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-08-17 8:16 ` [PATCH v2 00/15] scsi: " Vaibhav Gupta
2020-08-17 8:16 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-09-08 16:54 ` Vaibhav Gupta
2020-09-08 16:54 ` [Linux-kernel-mentees] " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB28485B659DDF20AEA09753A2E17B0@SN6PR11MB2848.namprd11.prod.outlook.com \
--to=don.brace@microchip.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=aacraid@microsemi.com \
--cc=aradford@gmail.com \
--cc=bhelgaas@google.com \
--cc=bjorn@helgaas.com \
--cc=dick.kennedy@broadcom.com \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=hare@suse.com \
--cc=helgaas@kernel.org \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.garry@huawei.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxdrivers@attotech.com \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=skhan@linuxfoundation.org \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.