From: "Voon, Weifeng" <weifeng.voon@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
"Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"qiangqing.zhang@nxp.com" <qiangqing.zhang@nxp.com>,
"Wong, Vee Khee" <vee.khee.wong@intel.com>,
"fugang.duan@nxp.com" <fugang.duan@nxp.com>,
"Chuah, Kim Tatt" <kim.tatt.chuah@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>
Subject: RE: [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed
Date: Mon, 5 Apr 2021 09:07:34 +0000 [thread overview]
Message-ID: <SN6PR11MB3136C4F44116EC909186742C88779@SN6PR11MB3136.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YGcPc3dan0ocRSG2@lunn.ch>
> On Fri, Apr 02, 2021 at 07:45:04AM +0000, Voon, Weifeng wrote:
> > > > + /* 2.5G mode only support 2500baseT full duplex only */
> > > > + if (priv->plat->has_gmac4 && priv->plat->speed_2500_en) {
> > > > + phylink_set(mac_supported, 2500baseT_Full);
> > > > + phylink_set(mask, 10baseT_Half);
> > > > + phylink_set(mask, 10baseT_Full);
> > > > + phylink_set(mask, 100baseT_Half);
> > > > + phylink_set(mask, 100baseT_Full);
> > > > + phylink_set(mask, 1000baseT_Half);
> > > > + phylink_set(mask, 1000baseT_Full);
> > > > + phylink_set(mask, 1000baseKX_Full);
> > >
> > > Why? This seems at odds to the comment above?
> >
> > > What about 2500baseX_Full ?
> >
> > The comments explain that the PCS<->PHY link is in 2500BASE-X and why
> > 10/100/1000 link speed is mutually exclusive with 2500.
> > But the connected external PHY are twisted pair cable which only
> > supports 2500baseT_full.
>
> The PHY should indicate what modes its supports. The PHY drivers
> get_features() call should set supported to only 2500baseT_Full, if that is
> all it supports.
>
> What modes are actually used should then be the intersect of what both the
> MAC and the PHY indicate they can do.
Noted Andrew. Instead of masking the 10/100/1000 mode support in the MAC, we will
set the supported modes in the PCS.
WARNING: multiple messages have this Message-ID (diff)
From: "Voon, Weifeng" <weifeng.voon@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
"Sit, Michael Wei Hong" <michael.wei.hong.sit@intel.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"qiangqing.zhang@nxp.com" <qiangqing.zhang@nxp.com>,
"Wong, Vee Khee" <vee.khee.wong@intel.com>,
"fugang.duan@nxp.com" <fugang.duan@nxp.com>,
"Chuah, Kim Tatt" <kim.tatt.chuah@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>
Subject: RE: [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed
Date: Mon, 5 Apr 2021 09:07:34 +0000 [thread overview]
Message-ID: <SN6PR11MB3136C4F44116EC909186742C88779@SN6PR11MB3136.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YGcPc3dan0ocRSG2@lunn.ch>
> On Fri, Apr 02, 2021 at 07:45:04AM +0000, Voon, Weifeng wrote:
> > > > + /* 2.5G mode only support 2500baseT full duplex only */
> > > > + if (priv->plat->has_gmac4 && priv->plat->speed_2500_en) {
> > > > + phylink_set(mac_supported, 2500baseT_Full);
> > > > + phylink_set(mask, 10baseT_Half);
> > > > + phylink_set(mask, 10baseT_Full);
> > > > + phylink_set(mask, 100baseT_Half);
> > > > + phylink_set(mask, 100baseT_Full);
> > > > + phylink_set(mask, 1000baseT_Half);
> > > > + phylink_set(mask, 1000baseT_Full);
> > > > + phylink_set(mask, 1000baseKX_Full);
> > >
> > > Why? This seems at odds to the comment above?
> >
> > > What about 2500baseX_Full ?
> >
> > The comments explain that the PCS<->PHY link is in 2500BASE-X and why
> > 10/100/1000 link speed is mutually exclusive with 2500.
> > But the connected external PHY are twisted pair cable which only
> > supports 2500baseT_full.
>
> The PHY should indicate what modes its supports. The PHY drivers
> get_features() call should set supported to only 2500baseT_Full, if that is
> all it supports.
>
> What modes are actually used should then be the intersect of what both the
> MAC and the PHY indicate they can do.
Noted Andrew. Instead of masking the 10/100/1000 mode support in the MAC, we will
set the supported modes in the PCS.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-05 9:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:01 [PATCH net-next 0/2] Enable 2.5Gbps speed for stmmac Michael Sit Wei Hong
2021-04-01 15:01 ` Michael Sit Wei Hong
2021-04-01 15:01 ` [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed Michael Sit Wei Hong
2021-04-01 15:01 ` Michael Sit Wei Hong
2021-04-01 15:10 ` Russell King - ARM Linux admin
2021-04-01 15:10 ` Russell King - ARM Linux admin
2021-04-02 7:45 ` Voon, Weifeng
2021-04-02 7:45 ` Voon, Weifeng
2021-04-02 12:34 ` Andrew Lunn
2021-04-02 12:34 ` Andrew Lunn
2021-04-05 9:07 ` Voon, Weifeng [this message]
2021-04-05 9:07 ` Voon, Weifeng
2021-04-05 12:43 ` Andrew Lunn
2021-04-05 12:43 ` Andrew Lunn
2021-04-01 15:01 ` [PATCH net-next 2/2] net: pcs: configure xpcs 2.5G speed mode Michael Sit Wei Hong
2021-04-01 15:01 ` Michael Sit Wei Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3136C4F44116EC909186742C88779@SN6PR11MB3136.namprd11.prod.outlook.com \
--to=weifeng.voon@intel.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kim.tatt.chuah@intel.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=vee.khee.wong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.