All of lore.kernel.org
 help / color / mirror / Atom feed
From: "G, GurucharanX" <gurucharanx.g@intel.com>
To: "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 5/9] ice: switch to napi_build_skb()
Date: Tue, 7 Dec 2021 10:03:17 +0000	[thread overview]
Message-ID: <SN6PR11MB3374B42800E486F22C49067BFC6E9@SN6PR11MB3374.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211123171840.157471-6-alexandr.lobakin@intel.com>



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Tuesday, November 23, 2021 10:49 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net-next 5/9] ice: switch to napi_build_skb()
> 
> napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order to save some
> cycles on freeing/allocating skbuff_heads on every new Rx or completed Tx.
> ice driver runs Tx completion polling cycle right before the Rx one and uses
> napi_consume_skb() to feed the cache with skbuff_heads of completed entries,
> so it's never empty and always warm at that moment. Switch to the
> napi_build_skb() to relax mm pressure on heavy Rx.
> 
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)

WARNING: multiple messages have this Message-ID (diff)
From: G, GurucharanX <gurucharanx.g@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 5/9] ice: switch to napi_build_skb()
Date: Tue, 7 Dec 2021 10:03:17 +0000	[thread overview]
Message-ID: <SN6PR11MB3374B42800E486F22C49067BFC6E9@SN6PR11MB3374.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211123171840.157471-6-alexandr.lobakin@intel.com>



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Alexander Lobakin
> Sent: Tuesday, November 23, 2021 10:49 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org; linux-kernel at vger.kernel.org; Jakub Kicinski
> <kuba@kernel.org>; David S. Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net-next 5/9] ice: switch to napi_build_skb()
> 
> napi_build_skb() reuses per-cpu NAPI skbuff_head cache in order to save some
> cycles on freeing/allocating skbuff_heads on every new Rx or completed Tx.
> ice driver runs Tx completion polling cycle right before the Rx one and uses
> napi_consume_skb() to feed the cache with skbuff_heads of completed entries,
> so it's never empty and always warm at that moment. Switch to the
> napi_build_skb() to relax mm pressure on heavy Rx.
> 
> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)

  reply	other threads:[~2021-12-07 10:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23 17:18 [PATCH net-next 0/9] intel: switch to napi_build_skb() Alexander Lobakin
2021-11-23 17:18 ` [Intel-wired-lan] " Alexander Lobakin
2021-11-23 17:18 ` [PATCH net-next 1/9] e1000: switch to napi_consume_skb() Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-28  0:06   ` Brelinski, Tony
2021-12-28  0:06     ` Brelinski, Tony
2021-11-23 17:18 ` [PATCH net-next 2/9] e1000: switch to napi_build_skb() Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-28  0:07   ` Brelinski, Tony
2021-12-28  0:07     ` Brelinski, Tony
2021-11-23 17:18 ` [PATCH net-next 3/9] i40e: " Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-03 14:44   ` G, GurucharanX
2021-12-03 14:44     ` G, GurucharanX
2021-11-23 17:18 ` [PATCH net-next 4/9] iavf: " Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-14 12:50   ` Jankowski, Konrad0
2021-12-14 12:50     ` Jankowski, Konrad0
2021-11-23 17:18 ` [PATCH net-next 5/9] ice: " Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-07 10:03   ` G, GurucharanX [this message]
2021-12-07 10:03     ` G, GurucharanX
2021-11-23 17:18 ` [PATCH net-next 6/9] igb: " Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-22  3:45   ` G, GurucharanX
2021-12-22  3:45     ` G, GurucharanX
2021-11-23 17:18 ` [PATCH net-next 7/9] igc: " Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-08  8:15   ` Kraus, NechamaX
2021-12-08  8:15     ` Kraus, NechamaX
2021-11-23 17:18 ` [PATCH net-next 8/9] ixgbe: " Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-03 14:45   ` G, GurucharanX
2021-12-03 14:45     ` G, GurucharanX
2021-11-23 17:18 ` [PATCH net-next 9/9] ixgbevf: " Alexander Lobakin
2021-11-23 17:18   ` [Intel-wired-lan] " Alexander Lobakin
2021-12-12 13:47   ` Jankowski, Konrad0
2021-12-12 13:47     ` Jankowski, Konrad0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3374B42800E486F22C49067BFC6E9@SN6PR11MB3374.namprd11.prod.outlook.com \
    --to=gurucharanx.g@intel.com \
    --cc=alexandr.lobakin@intel.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.