From: "Ghannam, Yazen" <Yazen.Ghannam@amd.com> To: Borislav Petkov <bp@alien8.de> Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "tony.luck@intel.com" <tony.luck@intel.com>, "x86@kernel.org" <x86@kernel.org>, "rafal@milecki.pl" <rafal@milecki.pl>, "clemej@gmail.com" <clemej@gmail.com> Subject: RE: [PATCH v2 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models Date: Fri, 22 Mar 2019 19:33:43 +0000 [thread overview] Message-ID: <SN6PR12MB2639D01961ADF8782EE36BA1F8430@SN6PR12MB2639.namprd12.prod.outlook.com> (raw) In-Reply-To: <20190322193228.GN12472@zn.tnic> > -----Original Message----- > From: linux-edac-owner@vger.kernel.org <linux-edac-owner@vger.kernel.org> On Behalf Of Borislav Petkov > Sent: Friday, March 22, 2019 2:32 PM > To: Ghannam, Yazen <Yazen.Ghannam@amd.com> > Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; tony.luck@intel.com; x86@kernel.org; rafal@milecki.pl; > clemej@gmail.com > Subject: Re: [PATCH v2 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models > > On Fri, Mar 22, 2019 at 07:24:01PM +0000, Ghannam, Yazen wrote: > > Generally, the model groups share the same hardware design and so the > > same quirks. So I'm thinking that it'd be more efficient to have a > > filter function that targets a specific group of models rather than > > one that checks all known quirks on all models. > > Or simply start with a amd_filter_mce() function and when it grows big > and unwieldy, only *then* start thinking about splitting it into models > and families. For now, you're fine with a single AMD-specific function. > Understood. > > Most of the quirks are dealt with at init time, but this needs be to > > done during run time for each MCE that is logged. So I didn't want to > > add unnecessary checks to the MCE handlers. We have quirk_no_way_out() > > that does something similar. > > I don't think a couple of instructions checking vendor and family would > be at all noticeable so let's start simple. > Okay, will do. Thanks, Yazen
WARNING: multiple messages have this Message-ID (diff)
From: Yazen Ghannam <yazen.ghannam@amd.com> To: Borislav Petkov <bp@alien8.de> Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "tony.luck@intel.com" <tony.luck@intel.com>, "x86@kernel.org" <x86@kernel.org>, "rafal@milecki.pl" <rafal@milecki.pl>, "clemej@gmail.com" <clemej@gmail.com> Subject: [v2,2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models Date: Fri, 22 Mar 2019 19:33:43 +0000 [thread overview] Message-ID: <SN6PR12MB2639D01961ADF8782EE36BA1F8430@SN6PR12MB2639.namprd12.prod.outlook.com> (raw) > -----Original Message----- > From: linux-edac-owner@vger.kernel.org <linux-edac-owner@vger.kernel.org> On Behalf Of Borislav Petkov > Sent: Friday, March 22, 2019 2:32 PM > To: Ghannam, Yazen <Yazen.Ghannam@amd.com> > Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; tony.luck@intel.com; x86@kernel.org; rafal@milecki.pl; > clemej@gmail.com > Subject: Re: [PATCH v2 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models > > On Fri, Mar 22, 2019 at 07:24:01PM +0000, Ghannam, Yazen wrote: > > Generally, the model groups share the same hardware design and so the > > same quirks. So I'm thinking that it'd be more efficient to have a > > filter function that targets a specific group of models rather than > > one that checks all known quirks on all models. > > Or simply start with a amd_filter_mce() function and when it grows big > and unwieldy, only *then* start thinking about splitting it into models > and families. For now, you're fine with a single AMD-specific function. > Understood. > > Most of the quirks are dealt with at init time, but this needs be to > > done during run time for each MCE that is logged. So I didn't want to > > add unnecessary checks to the MCE handlers. We have quirk_no_way_out() > > that does something similar. > > I don't think a couple of instructions checking vendor and family would > be at all noticeable so let's start simple. > Okay, will do. Thanks, Yazen
next prev parent reply other threads:[~2019-03-22 19:33 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-21 20:25 [PATCH v2 1/2] x86/MCE: Add function to allow filtering of MCA errors Ghannam, Yazen 2019-03-21 20:25 ` [v2,1/2] " Yazen Ghannam 2019-03-21 20:25 ` [PATCH v2 2/2] x86/MCE/AMD: Don't report L1 BTB MCA errors on some Family 17h models Ghannam, Yazen 2019-03-21 20:25 ` [v2,2/2] " Yazen Ghannam 2019-03-22 17:34 ` [PATCH v2 2/2] " Borislav Petkov 2019-03-22 17:34 ` [v2,2/2] " Borislav Petkov 2019-03-22 19:24 ` [PATCH v2 2/2] " Ghannam, Yazen 2019-03-22 19:24 ` [v2,2/2] " Yazen Ghannam 2019-03-22 19:32 ` [PATCH v2 2/2] " Borislav Petkov 2019-03-22 19:32 ` [v2,2/2] " Borislav Petkov 2019-03-22 19:33 ` Ghannam, Yazen [this message] 2019-03-22 19:33 ` Yazen Ghannam 2019-03-22 17:24 ` [PATCH v2 1/2] x86/MCE: Add function to allow filtering of MCA errors Borislav Petkov 2019-03-22 17:24 ` [v2,1/2] " Borislav Petkov 2019-03-22 19:05 ` [PATCH v2 1/2] " Ghannam, Yazen 2019-03-22 19:05 ` [v2,1/2] " Yazen Ghannam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SN6PR12MB2639D01961ADF8782EE36BA1F8430@SN6PR12MB2639.namprd12.prod.outlook.com \ --to=yazen.ghannam@amd.com \ --cc=bp@alien8.de \ --cc=clemej@gmail.com \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rafal@milecki.pl \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.