* [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
@ 2020-02-10 1:04 Pan, Xinhui
2020-09-01 12:59 ` 回复: " Liu, Monk
0 siblings, 1 reply; 5+ messages in thread
From: Pan, Xinhui @ 2020-02-10 1:04 UTC (permalink / raw)
To: amd-gfx; +Cc: Deucher, Alexander, Koenig, Christian
hit panic when we update the page tables.
<1>[ 122.103290] BUG: kernel NULL pointer dereference, address: 0000000000000008
<1>[ 122.103348] #PF: supervisor read access in kernel mode
<1>[ 122.103376] #PF: error_code(0x0000) - not-present page
<6>[ 122.103403] PGD 0 P4D 0
<4>[ 122.103421] Oops: 0000 [#1] SMP PTI
<4>[ 122.103442] CPU: 13 PID: 2133 Comm: kfdtest Tainted: G OE 5.4.0-rc7+ #7
<4>[ 122.103480] Hardware name: Supermicro SYS-7048GR-TR/X10DRG-Q, BIOS 3.0b 03/09/2018
<4>[ 122.103657] RIP: 0010:amdgpu_vm_update_pdes+0x140/0x330 [amdgpu]
<4>[ 122.103689] Code: 03 4c 89 73 08 49 89 9d c8 00 00 00 48 8b 7b f0 c6 43 10 00 45 31 c0 48 8b 87 28 04 00 00 48 85 c0 74 07 4c 8b 80 20 04 00 00 <4d> 8b 70 08 31 f6 49 8b 86 28 04 00 00 48 85 c0 74 0f 48 8b 80 28
<4>[ 122.103769] RSP: 0018:ffffb49a0a6a3a98 EFLAGS: 00010246
<4>[ 122.103797] RAX: 0000000000000000 RBX: ffff9020f823c148 RCX: dead000000000122
<4>[ 122.103831] RDX: ffff9020ece70018 RSI: ffff9020f823c0c8 RDI: ffff9010ca31c800
<4>[ 122.103865] RBP: ffffb49a0a6a3b38 R08: 0000000000000000 R09: 0000000000000001
<4>[ 122.103899] R10: 000000006044f994 R11: 00000000df57fb58 R12: ffff9020f823c000
<4>[ 122.103933] R13: ffff9020f823c000 R14: ffff9020f823c0c8 R15: ffff9010d5d20000
<4>[ 122.103968] FS: 00007f32c83dc780(0000) GS:ffff9020ff380000(0000) knlGS:0000000000000000
<4>[ 122.104006] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[ 122.104035] CR2: 0000000000000008 CR3: 0000002036bba005 CR4: 00000000003606e0
<4>[ 122.104069] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
<4>[ 122.104103] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
<4>[ 122.104137] Call Trace:
<4>[ 122.104241] vm_update_pds+0x31/0x50 [amdgpu]
<4>[ 122.104347] amdgpu_amdkfd_gpuvm_map_memory_to_gpu+0x2ef/0x690 [amdgpu]
<4>[ 122.104466] kfd_process_alloc_gpuvm+0x98/0x190 [amdgpu]
<4>[ 122.104576] kfd_process_device_init_vm.part.8+0xf3/0x1f0 [amdgpu]
<4>[ 122.104688] kfd_process_device_init_vm+0x24/0x30 [amdgpu]
<4>[ 122.104794] kfd_ioctl_acquire_vm+0xa4/0xc0 [amdgpu]
<4>[ 122.104900] kfd_ioctl+0x277/0x500 [amdgpu]
<4>[ 122.105001] ? kfd_ioctl_free_memory_of_gpu+0xc0/0xc0 [amdgpu]
<4>[ 122.105039] ? rcu_read_lock_sched_held+0x4f/0x80
<4>[ 122.105068] ? kmem_cache_free+0x2ba/0x300
<4>[ 122.105093] ? vm_area_free+0x18/0x20
<4>[ 122.105117] ? find_held_lock+0x35/0xa0
<4>[ 122.105143] do_vfs_ioctl+0xa9/0x6f0
<4>[ 122.106001] ksys_ioctl+0x75/0x80
<4>[ 122.106802] ? do_syscall_64+0x17/0x230
<4>[ 122.107605] __x64_sys_ioctl+0x1a/0x20
<4>[ 122.108378] do_syscall_64+0x5f/0x230
<4>[ 122.109118] entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4>[ 122.109842] RIP: 0033:0x7f32c6b495d7
Signed-off-by: xinhui pan <xinhui.pan@amd.com>
---
change from v1:
move root pt bo to idle state instead.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 3195bc9..c3d1af5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2619,9 +2619,12 @@ void amdgpu_vm_bo_invalidate(struct amdgpu_device *adev,
continue;
bo_base->moved = true;
- if (bo->tbo.type == ttm_bo_type_kernel)
- amdgpu_vm_bo_relocated(bo_base);
- else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
+ if (bo->tbo.type == ttm_bo_type_kernel) {
+ if (bo->parent)
+ amdgpu_vm_bo_relocated(bo_base);
+ else
+ amdgpu_vm_bo_idle(bo_base);
+ } else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
amdgpu_vm_bo_moved(bo_base);
else
amdgpu_vm_bo_invalidated(bo_base);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* 回复: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
2020-02-10 1:04 [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list Pan, Xinhui
@ 2020-09-01 12:59 ` Liu, Monk
2020-09-01 13:54 ` Christian König
0 siblings, 1 reply; 5+ messages in thread
From: Liu, Monk @ 2020-09-01 12:59 UTC (permalink / raw)
To: Pan, Xinhui, amd-gfx; +Cc: Deucher, Alexander, Koenig, Christian
[AMD Official Use Only - Internal Distribution Only]
See that we already have such logic:
282 static void amdgpu_vm_bo_relocated(struct amdgpu_vm_bo_base *vm_bo)
283 {
284 if (vm_bo->bo->parent)
285 list_move(&vm_bo->vm_status, &vm_bo->vm->relocated);
286 else
287 amdgpu_vm_bo_idle(vm_bo);
288 }
Why you need to do the bo->parent check out side ?
-----邮件原件-----
发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Pan, Xinhui
发送时间: 2020年2月10日 9:04
收件人: amd-gfx@lists.freedesktop.org
抄送: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
主题: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
hit panic when we update the page tables.
<1>[ 122.103290] BUG: kernel NULL pointer dereference, address: 0000000000000008 <1>[ 122.103348] #PF: supervisor read access in kernel mode <1>[ 122.103376] #PF: error_code(0x0000) - not-present page <6>[ 122.103403] PGD 0 P4D 0 <4>[ 122.103421] Oops: 0000 [#1] SMP PTI
<4>[ 122.103442] CPU: 13 PID: 2133 Comm: kfdtest Tainted: G OE 5.4.0-rc7+ #7
<4>[ 122.103480] Hardware name: Supermicro SYS-7048GR-TR/X10DRG-Q, BIOS 3.0b 03/09/2018 <4>[ 122.103657] RIP: 0010:amdgpu_vm_update_pdes+0x140/0x330 [amdgpu] <4>[ 122.103689] Code: 03 4c 89 73 08 49 89 9d c8 00 00 00 48 8b 7b f0 c6 43 10 00 45 31 c0 48 8b 87 28 04 00 00 48 85 c0 74 07 4c 8b 80 20 04 00 00 <4d> 8b 70 08 31 f6 49 8b 86 28 04 00 00 48 85 c0 74 0f 48 8b 80 28 <4>[ 122.103769] RSP: 0018:ffffb49a0a6a3a98 EFLAGS: 00010246 <4>[ 122.103797] RAX: 0000000000000000 RBX: ffff9020f823c148 RCX: dead000000000122 <4>[ 122.103831] RDX: ffff9020ece70018 RSI: ffff9020f823c0c8 RDI: ffff9010ca31c800 <4>[ 122.103865] RBP: ffffb49a0a6a3b38 R08: 0000000000000000 R09: 0000000000000001 <4>[ 122.103899] R10: 000000006044f994 R11: 00000000df57fb58 R12: ffff9020f823c000 <4>[ 122.103933] R13: ffff9020f823c000 R14: ffff9020f823c0c8 R15: ffff9010d5d20000 <4>[ 122.103968] FS: 00007f32c83dc780(0000) GS:ffff9020ff380000(0000) knlGS:0000000000000000 <4>[ 122.104006] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 122.104035] CR2: 0000000000000008 CR3: 0000002036bba005 CR4: 00000000003606e0 <4>[ 122.104069] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 <4>[ 122.104103] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 <4>[ 122.104137] Call Trace:
<4>[ 122.104241] vm_update_pds+0x31/0x50 [amdgpu] <4>[ 122.104347] amdgpu_amdkfd_gpuvm_map_memory_to_gpu+0x2ef/0x690 [amdgpu] <4>[ 122.104466] kfd_process_alloc_gpuvm+0x98/0x190 [amdgpu] <4>[ 122.104576] kfd_process_device_init_vm.part.8+0xf3/0x1f0 [amdgpu] <4>[ 122.104688] kfd_process_device_init_vm+0x24/0x30 [amdgpu] <4>[ 122.104794] kfd_ioctl_acquire_vm+0xa4/0xc0 [amdgpu] <4>[ 122.104900] kfd_ioctl+0x277/0x500 [amdgpu] <4>[ 122.105001] ? kfd_ioctl_free_memory_of_gpu+0xc0/0xc0 [amdgpu] <4>[ 122.105039] ? rcu_read_lock_sched_held+0x4f/0x80
<4>[ 122.105068] ? kmem_cache_free+0x2ba/0x300 <4>[ 122.105093] ? vm_area_free+0x18/0x20 <4>[ 122.105117] ? find_held_lock+0x35/0xa0 <4>[ 122.105143] do_vfs_ioctl+0xa9/0x6f0 <4>[ 122.106001] ksys_ioctl+0x75/0x80 <4>[ 122.106802] ? do_syscall_64+0x17/0x230 <4>[ 122.107605] __x64_sys_ioctl+0x1a/0x20 <4>[ 122.108378] do_syscall_64+0x5f/0x230 <4>[ 122.109118] entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4>[ 122.109842] RIP: 0033:0x7f32c6b495d7
Signed-off-by: xinhui pan <xinhui.pan@amd.com>
---
change from v1:
move root pt bo to idle state instead.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 3195bc9..c3d1af5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2619,9 +2619,12 @@ void amdgpu_vm_bo_invalidate(struct amdgpu_device *adev,
continue;
bo_base->moved = true;
-if (bo->tbo.type == ttm_bo_type_kernel)
-amdgpu_vm_bo_relocated(bo_base);
-else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
+if (bo->tbo.type == ttm_bo_type_kernel) {
+if (bo->parent)
+amdgpu_vm_bo_relocated(bo_base);
+else
+amdgpu_vm_bo_idle(bo_base);
+} else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
amdgpu_vm_bo_moved(bo_base);
else
amdgpu_vm_bo_invalidated(bo_base);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cmonk.liu%40amd.com%7C9fa67fef539f46e8d94f08d7adc52b5a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637168934683625832&sdata=nYoeBXXOdePn4Q6hxrlSTzT1PxTx%2FRwWqeKXGmQ5NPY%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: 回复: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
2020-09-01 12:59 ` 回复: " Liu, Monk
@ 2020-09-01 13:54 ` Christian König
2020-09-02 4:50 ` Pan, Xinhui
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2020-09-01 13:54 UTC (permalink / raw)
To: Liu, Monk, Pan, Xinhui, amd-gfx; +Cc: Deucher, Alexander, Koenig, Christian
Agreed, that change doesn't seem to make sense and your backtrace is
mangled so barely readable.
Christian.
Am 01.09.20 um 14:59 schrieb Liu, Monk:
> [AMD Official Use Only - Internal Distribution Only]
>
> See that we already have such logic:
>
> 282 static void amdgpu_vm_bo_relocated(struct amdgpu_vm_bo_base *vm_bo)
> 283 {
> 284 if (vm_bo->bo->parent)
> 285 list_move(&vm_bo->vm_status, &vm_bo->vm->relocated);
> 286 else
> 287 amdgpu_vm_bo_idle(vm_bo);
> 288 }
>
> Why you need to do the bo->parent check out side ?
>
> -----邮件原件-----
> 发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Pan, Xinhui
> 发送时间: 2020年2月10日 9:04
> 收件人: amd-gfx@lists.freedesktop.org
> 抄送: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
> 主题: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
>
> hit panic when we update the page tables.
>
> <1>[ 122.103290] BUG: kernel NULL pointer dereference, address: 0000000000000008 <1>[ 122.103348] #PF: supervisor read access in kernel mode <1>[ 122.103376] #PF: error_code(0x0000) - not-present page <6>[ 122.103403] PGD 0 P4D 0 <4>[ 122.103421] Oops: 0000 [#1] SMP PTI
> <4>[ 122.103442] CPU: 13 PID: 2133 Comm: kfdtest Tainted: G OE 5.4.0-rc7+ #7
> <4>[ 122.103480] Hardware name: Supermicro SYS-7048GR-TR/X10DRG-Q, BIOS 3.0b 03/09/2018 <4>[ 122.103657] RIP: 0010:amdgpu_vm_update_pdes+0x140/0x330 [amdgpu] <4>[ 122.103689] Code: 03 4c 89 73 08 49 89 9d c8 00 00 00 48 8b 7b f0 c6 43 10 00 45 31 c0 48 8b 87 28 04 00 00 48 85 c0 74 07 4c 8b 80 20 04 00 00 <4d> 8b 70 08 31 f6 49 8b 86 28 04 00 00 48 85 c0 74 0f 48 8b 80 28 <4>[ 122.103769] RSP: 0018:ffffb49a0a6a3a98 EFLAGS: 00010246 <4>[ 122.103797] RAX: 0000000000000000 RBX: ffff9020f823c148 RCX: dead000000000122 <4>[ 122.103831] RDX: ffff9020ece70018 RSI: ffff9020f823c0c8 RDI: ffff9010ca31c800 <4>[ 122.103865] RBP: ffffb49a0a6a3b38 R08: 0000000000000000 R09: 0000000000000001 <4>[ 122.103899] R10: 000000006044f994 R11: 00000000df57fb58 R12: ffff9020f823c000 <4>[ 122.103933] R13: ffff9020f823c000 R14: ffff9020f823c0c8 R15: ffff9010d5d20000 <4>[ 122.103968] FS: 00007f32c83dc780(0000) GS:ffff9020ff380000(0000) knlGS:0000000000000000 <4>[ 122.104006] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 122.104035] CR2: 0000000000000008 CR3: 0000002036bba005 CR4: 00000000003606e0 <4>[ 122.104069] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 <4>[ 122.104103] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 <4>[ 122.104137] Call Trace:
> <4>[ 122.104241] vm_update_pds+0x31/0x50 [amdgpu] <4>[ 122.104347] amdgpu_amdkfd_gpuvm_map_memory_to_gpu+0x2ef/0x690 [amdgpu] <4>[ 122.104466] kfd_process_alloc_gpuvm+0x98/0x190 [amdgpu] <4>[ 122.104576] kfd_process_device_init_vm.part.8+0xf3/0x1f0 [amdgpu] <4>[ 122.104688] kfd_process_device_init_vm+0x24/0x30 [amdgpu] <4>[ 122.104794] kfd_ioctl_acquire_vm+0xa4/0xc0 [amdgpu] <4>[ 122.104900] kfd_ioctl+0x277/0x500 [amdgpu] <4>[ 122.105001] ? kfd_ioctl_free_memory_of_gpu+0xc0/0xc0 [amdgpu] <4>[ 122.105039] ? rcu_read_lock_sched_held+0x4f/0x80
> <4>[ 122.105068] ? kmem_cache_free+0x2ba/0x300 <4>[ 122.105093] ? vm_area_free+0x18/0x20 <4>[ 122.105117] ? find_held_lock+0x35/0xa0 <4>[ 122.105143] do_vfs_ioctl+0xa9/0x6f0 <4>[ 122.106001] ksys_ioctl+0x75/0x80 <4>[ 122.106802] ? do_syscall_64+0x17/0x230 <4>[ 122.107605] __x64_sys_ioctl+0x1a/0x20 <4>[ 122.108378] do_syscall_64+0x5f/0x230 <4>[ 122.109118] entry_SYSCALL_64_after_hwframe+0x49/0xbe
> <4>[ 122.109842] RIP: 0033:0x7f32c6b495d7
>
> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
> ---
> change from v1:
> move root pt bo to idle state instead.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 3195bc9..c3d1af5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2619,9 +2619,12 @@ void amdgpu_vm_bo_invalidate(struct amdgpu_device *adev,
> continue;
> bo_base->moved = true;
>
> -if (bo->tbo.type == ttm_bo_type_kernel)
> -amdgpu_vm_bo_relocated(bo_base);
> -else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
> +if (bo->tbo.type == ttm_bo_type_kernel) {
> +if (bo->parent)
> +amdgpu_vm_bo_relocated(bo_base);
> +else
> +amdgpu_vm_bo_idle(bo_base);
> +} else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
> amdgpu_vm_bo_moved(bo_base);
> else
> amdgpu_vm_bo_invalidated(bo_base);
> --
> 2.7.4
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cmonk.liu%40amd.com%7C9fa67fef539f46e8d94f08d7adc52b5a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637168934683625832&sdata=nYoeBXXOdePn4Q6hxrlSTzT1PxTx%2FRwWqeKXGmQ5NPY%3D&reserved=0
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
2020-09-01 13:54 ` Christian König
@ 2020-09-02 4:50 ` Pan, Xinhui
2020-09-02 7:13 ` Christian König
0 siblings, 1 reply; 5+ messages in thread
From: Pan, Xinhui @ 2020-09-02 4:50 UTC (permalink / raw)
To: Koenig, Christian; +Cc: Deucher, Alexander, Pan, Xinhui, amd-gfx, Liu, Monk
> 2020年9月1日 21:54，Christian König <ckoenig.leichtzumerken@gmail.com> 写道：
>
> Agreed, that change doesn't seem to make sense and your backtrace is mangled so barely readable.
it is reply that messed up the logs.
And this patch was sent on 10th Feb.
>
> Christian.
>
> Am 01.09.20 um 14:59 schrieb Liu, Monk:
>> [AMD Official Use Only - Internal Distribution Only]
>>
>> See that we already have such logic:
>>
>> 282 static void amdgpu_vm_bo_relocated(struct amdgpu_vm_bo_base *vm_bo)
>> 283 {
>> 284 if (vm_bo->bo->parent)
>> 285 list_move(&vm_bo->vm_status, &vm_bo->vm->relocated);
>> 286 else
>> 287 amdgpu_vm_bo_idle(vm_bo);
>> 288 }
>>
>> Why you need to do the bo->parent check out side ?
because it is me that moves such logic into amdgpu_vm_bo_relocated.
>>
>> -----邮件原件-----
>> 发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Pan, Xinhui
>> 发送时间: 2020年2月10日 9:04
>> 收件人: amd-gfx@lists.freedesktop.org
>> 抄送: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
>> 主题: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
>>
>> hit panic when we update the page tables.
>>
>> <1>[ 122.103290] BUG: kernel NULL pointer dereference, address: 0000000000000008 <1>[ 122.103348] #PF: supervisor read access in kernel mode <1>[ 122.103376] #PF: error_code(0x0000) - not-present page <6>[ 122.103403] PGD 0 P4D 0 <4>[ 122.103421] Oops: 0000 [#1] SMP PTI
>> <4>[ 122.103442] CPU: 13 PID: 2133 Comm: kfdtest Tainted: G OE 5.4.0-rc7+ #7
>> <4>[ 122.103480] Hardware name: Supermicro SYS-7048GR-TR/X10DRG-Q, BIOS 3.0b 03/09/2018 <4>[ 122.103657] RIP: 0010:amdgpu_vm_update_pdes+0x140/0x330 [amdgpu] <4>[ 122.103689] Code: 03 4c 89 73 08 49 89 9d c8 00 00 00 48 8b 7b f0 c6 43 10 00 45 31 c0 48 8b 87 28 04 00 00 48 85 c0 74 07 4c 8b 80 20 04 00 00 <4d> 8b 70 08 31 f6 49 8b 86 28 04 00 00 48 85 c0 74 0f 48 8b 80 28 <4>[ 122.103769] RSP: 0018:ffffb49a0a6a3a98 EFLAGS: 00010246 <4>[ 122.103797] RAX: 0000000000000000 RBX: ffff9020f823c148 RCX: dead000000000122 <4>[ 122.103831] RDX: ffff9020ece70018 RSI: ffff9020f823c0c8 RDI: ffff9010ca31c800 <4>[ 122.103865] RBP: ffffb49a0a6a3b38 R08: 0000000000000000 R09: 0000000000000001 <4>[ 122.103899] R10: 000000006044f994 R11: 00000000df57fb58 R12: ffff9020f823c000 <4>[ 122.103933] R13: ffff9020f823c000 R14: ffff9020f823c0c8 R15: ffff9010d5d20000 <4>[ 122.103968] FS: 00007f32c83dc780(0000) GS:ffff9020ff380000(0000) knlGS:0000000000000000 <4>[ 122.104006] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 122.104035] CR2: 0000000000000008 CR3: 0000002036bba005 CR4: 00000000003606e0 <4>[ 122.104069] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 <4>[ 122.104103] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 <4>[ 122.104137] Call Trace:
>> <4>[ 122.104241] vm_update_pds+0x31/0x50 [amdgpu] <4>[ 122.104347] amdgpu_amdkfd_gpuvm_map_memory_to_gpu+0x2ef/0x690 [amdgpu] <4>[ 122.104466] kfd_process_alloc_gpuvm+0x98/0x190 [amdgpu] <4>[ 122.104576] kfd_process_device_init_vm.part.8+0xf3/0x1f0 [amdgpu] <4>[ 122.104688] kfd_process_device_init_vm+0x24/0x30 [amdgpu] <4>[ 122.104794] kfd_ioctl_acquire_vm+0xa4/0xc0 [amdgpu] <4>[ 122.104900] kfd_ioctl+0x277/0x500 [amdgpu] <4>[ 122.105001] ? kfd_ioctl_free_memory_of_gpu+0xc0/0xc0 [amdgpu] <4>[ 122.105039] ? rcu_read_lock_sched_held+0x4f/0x80
>> <4>[ 122.105068] ? kmem_cache_free+0x2ba/0x300 <4>[ 122.105093] ? vm_area_free+0x18/0x20 <4>[ 122.105117] ? find_held_lock+0x35/0xa0 <4>[ 122.105143] do_vfs_ioctl+0xa9/0x6f0 <4>[ 122.106001] ksys_ioctl+0x75/0x80 <4>[ 122.106802] ? do_syscall_64+0x17/0x230 <4>[ 122.107605] __x64_sys_ioctl+0x1a/0x20 <4>[ 122.108378] do_syscall_64+0x5f/0x230 <4>[ 122.109118] entry_SYSCALL_64_after_hwframe+0x49/0xbe
>> <4>[ 122.109842] RIP: 0033:0x7f32c6b495d7
>>
>> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
>> ---
>> change from v1:
>> move root pt bo to idle state instead.
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> index 3195bc9..c3d1af5 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -2619,9 +2619,12 @@ void amdgpu_vm_bo_invalidate(struct amdgpu_device *adev,
>> continue;
>> bo_base->moved = true;
>>
>> -if (bo->tbo.type == ttm_bo_type_kernel)
>> -amdgpu_vm_bo_relocated(bo_base);
>> -else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
>> +if (bo->tbo.type == ttm_bo_type_kernel) {
>> +if (bo->parent)
>> +amdgpu_vm_bo_relocated(bo_base);
>> +else
>> +amdgpu_vm_bo_idle(bo_base);
>> +} else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
>> amdgpu_vm_bo_moved(bo_base);
>> else
>> amdgpu_vm_bo_invalidated(bo_base);
>> --
>> 2.7.4
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CXinhui.Pan%40amd.com%7Caca3a1baae9a432d147808d84e7e9b67%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637345652969989853&sdata=N1EF7zgJjaj%2FDKyGiK9Wm5WzqaXoC%2BrdgH4yxBhBhlE%3D&reserved=0
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CXinhui.Pan%40amd.com%7Caca3a1baae9a432d147808d84e7e9b67%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637345652969989853&sdata=N1EF7zgJjaj%2FDKyGiK9Wm5WzqaXoC%2BrdgH4yxBhBhlE%3D&reserved=0
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
2020-09-02 4:50 ` Pan, Xinhui
@ 2020-09-02 7:13 ` Christian König
0 siblings, 0 replies; 5+ messages in thread
From: Christian König @ 2020-09-02 7:13 UTC (permalink / raw)
To: Pan, Xinhui; +Cc: Deucher, Alexander, amd-gfx, Liu, Monk
Am 02.09.20 um 06:50 schrieb Pan, Xinhui:
>
>> 2020年9月1日 21:54，Christian König <ckoenig.leichtzumerken@gmail.com> 写道：
>>
>> Agreed, that change doesn't seem to make sense and your backtrace is mangled so barely readable.
> it is reply that messed up the logs.
>
> And this patch was sent on 10th Feb.
Now I see it as well. I'm just not used to reading Chinese letters :)
I was already wondering why this came up again.
Regards,
Christian.
>> Christian.
>>
>> Am 01.09.20 um 14:59 schrieb Liu, Monk:
>>> [AMD Official Use Only - Internal Distribution Only]
>>>
>>> See that we already have such logic:
>>>
>>> 282 static void amdgpu_vm_bo_relocated(struct amdgpu_vm_bo_base *vm_bo)
>>> 283 {
>>> 284 if (vm_bo->bo->parent)
>>> 285 list_move(&vm_bo->vm_status, &vm_bo->vm->relocated);
>>> 286 else
>>> 287 amdgpu_vm_bo_idle(vm_bo);
>>> 288 }
>>>
>>> Why you need to do the bo->parent check out side ?
> because it is me that moves such logic into amdgpu_vm_bo_relocated.
>
>>> -----邮件原件-----
>>> 发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Pan, Xinhui
>>> 发送时间: 2020年2月10日 9:04
>>> 收件人: amd-gfx@lists.freedesktop.org
>>> 抄送: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
>>> 主题: [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list
>>>
>>> hit panic when we update the page tables.
>>>
>>> <1>[ 122.103290] BUG: kernel NULL pointer dereference, address: 0000000000000008 <1>[ 122.103348] #PF: supervisor read access in kernel mode <1>[ 122.103376] #PF: error_code(0x0000) - not-present page <6>[ 122.103403] PGD 0 P4D 0 <4>[ 122.103421] Oops: 0000 [#1] SMP PTI
>>> <4>[ 122.103442] CPU: 13 PID: 2133 Comm: kfdtest Tainted: G OE 5.4.0-rc7+ #7
>>> <4>[ 122.103480] Hardware name: Supermicro SYS-7048GR-TR/X10DRG-Q, BIOS 3.0b 03/09/2018 <4>[ 122.103657] RIP: 0010:amdgpu_vm_update_pdes+0x140/0x330 [amdgpu] <4>[ 122.103689] Code: 03 4c 89 73 08 49 89 9d c8 00 00 00 48 8b 7b f0 c6 43 10 00 45 31 c0 48 8b 87 28 04 00 00 48 85 c0 74 07 4c 8b 80 20 04 00 00 <4d> 8b 70 08 31 f6 49 8b 86 28 04 00 00 48 85 c0 74 0f 48 8b 80 28 <4>[ 122.103769] RSP: 0018:ffffb49a0a6a3a98 EFLAGS: 00010246 <4>[ 122.103797] RAX: 0000000000000000 RBX: ffff9020f823c148 RCX: dead000000000122 <4>[ 122.103831] RDX: ffff9020ece70018 RSI: ffff9020f823c0c8 RDI: ffff9010ca31c800 <4>[ 122.103865] RBP: ffffb49a0a6a3b38 R08: 0000000000000000 R09: 0000000000000001 <4>[ 122.103899] R10: 000000006044f994 R11: 00000000df57fb58 R12: ffff9020f823c000 <4>[ 122.103933] R13: ffff9020f823c000 R14: ffff9020f823c0c8 R15: ffff9010d5d20000 <4>[ 122.103968] FS: 00007f32c83dc780(0000) GS:ffff9020ff380000(0000) knlGS:0000000000000000 <4>[ 122.104006] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 122.104035] CR2: 0000000000000008 CR3: 0000002036bba005 CR4: 00000000003606e0 <4>[ 122.104069] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 <4>[ 122.104103] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 <4>[ 122.104137] Call Trace:
>>> <4>[ 122.104241] vm_update_pds+0x31/0x50 [amdgpu] <4>[ 122.104347] amdgpu_amdkfd_gpuvm_map_memory_to_gpu+0x2ef/0x690 [amdgpu] <4>[ 122.104466] kfd_process_alloc_gpuvm+0x98/0x190 [amdgpu] <4>[ 122.104576] kfd_process_device_init_vm.part.8+0xf3/0x1f0 [amdgpu] <4>[ 122.104688] kfd_process_device_init_vm+0x24/0x30 [amdgpu] <4>[ 122.104794] kfd_ioctl_acquire_vm+0xa4/0xc0 [amdgpu] <4>[ 122.104900] kfd_ioctl+0x277/0x500 [amdgpu] <4>[ 122.105001] ? kfd_ioctl_free_memory_of_gpu+0xc0/0xc0 [amdgpu] <4>[ 122.105039] ? rcu_read_lock_sched_held+0x4f/0x80
>>> <4>[ 122.105068] ? kmem_cache_free+0x2ba/0x300 <4>[ 122.105093] ? vm_area_free+0x18/0x20 <4>[ 122.105117] ? find_held_lock+0x35/0xa0 <4>[ 122.105143] do_vfs_ioctl+0xa9/0x6f0 <4>[ 122.106001] ksys_ioctl+0x75/0x80 <4>[ 122.106802] ? do_syscall_64+0x17/0x230 <4>[ 122.107605] __x64_sys_ioctl+0x1a/0x20 <4>[ 122.108378] do_syscall_64+0x5f/0x230 <4>[ 122.109118] entry_SYSCALL_64_after_hwframe+0x49/0xbe
>>> <4>[ 122.109842] RIP: 0033:0x7f32c6b495d7
>>>
>>> Signed-off-by: xinhui pan <xinhui.pan@amd.com>
>>> ---
>>> change from v1:
>>> move root pt bo to idle state instead.
>>> ---
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 9 ++++++---
>>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> index 3195bc9..c3d1af5 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> @@ -2619,9 +2619,12 @@ void amdgpu_vm_bo_invalidate(struct amdgpu_device *adev,
>>> continue;
>>> bo_base->moved = true;
>>>
>>> -if (bo->tbo.type == ttm_bo_type_kernel)
>>> -amdgpu_vm_bo_relocated(bo_base);
>>> -else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
>>> +if (bo->tbo.type == ttm_bo_type_kernel) {
>>> +if (bo->parent)
>>> +amdgpu_vm_bo_relocated(bo_base);
>>> +else
>>> +amdgpu_vm_bo_idle(bo_base);
>>> +} else if (bo->tbo.base.resv == vm->root.base.bo->tbo.base.resv)
>>> amdgpu_vm_bo_moved(bo_base);
>>> else
>>> amdgpu_vm_bo_invalidated(bo_base);
>>> --
>>> 2.7.4
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CXinhui.Pan%40amd.com%7Caca3a1baae9a432d147808d84e7e9b67%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637345652969989853&sdata=N1EF7zgJjaj%2FDKyGiK9Wm5WzqaXoC%2BrdgH4yxBhBhlE%3D&reserved=0
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CXinhui.Pan%40amd.com%7Caca3a1baae9a432d147808d84e7e9b67%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637345652969989853&sdata=N1EF7zgJjaj%2FDKyGiK9Wm5WzqaXoC%2BrdgH4yxBhBhlE%3D&reserved=0
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-02 7:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 1:04 [PATCH V2] drm/amdgpu: Do not move root PT bo to relocated list Pan, Xinhui
2020-09-01 12:59 ` 回复: " Liu, Monk
2020-09-01 13:54 ` Christian König
2020-09-02 4:50 ` Pan, Xinhui
2020-09-02 7:13 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.