[PATCH] mtd: cfi_cmdset_0002: Change write buffer to check correct value

[PATCH] mtd: cfi_cmdset_0002: Change write buffer to check correct value

[smtpuser]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

For the word write it is checked if the chip has the correct value.
But it is not checked for the write buffer as only checked if ready.
To make sure for the write buffer change to check the value.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
 drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 56aa6b75213d..5e9f2ca0a6c1 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
 		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
 			break;
 
-		if (chip_ready(map, adr)) {
+		if (chip_ready(map, adr) && chip_good(map, adr, datum)) {
 			xip_enable(map, chip, adr);
 			goto op_done;
 		}
-- 
2.16.1

RE: [PATCH] mtd: cfi_cmdset_0002: Change write buffer to check correct value

[IKEGAMI Tokunori]

Hi,

This patch has be sent by git-send-email.
Also for our company mail system the sender mail address is needed to be set as smtpuser <smtpuser at allied-telesis.co.jp>.
But do not reply to the email address smtpuser <smtpuser at allied-telesis.co.jp>.
Please reply to my email address Tokunori Ikegami <ikegami at allied-telesis.co.jp> if any comment or problem.
Sorry for inconvenient about this.

This patch is alternative solution for the patch below.
  <http://lists.infradead.org/pipermail/linux-mtd/2018-April/080530.html>

Note:
  I am thinking to change the erase functions also to retry for the wrong value case.
  It will be sent as another patch.

Regards,
Ikegami

> -----Original Message-----
> From: smtpuser
> Sent: Tuesday, May 08, 2018 1:46 PM
> To: Brian Norris
> Cc: IKEGAMI Tokunori; PACKHAM Chris; David Woodhouse; Boris Brezillon;
> Marek Vasut; Richard Weinberger; Cyrille Pitchen;
> linux-mtd@lists.infradead.org
> Subject: [PATCH] mtd: cfi_cmdset_0002: Change write buffer to check correct
> value
> 
> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> 
> For the word write it is checked if the chip has the correct value.
> But it is not checked for the write buffer as only checked if ready.
> To make sure for the write buffer change to check the value.
> 
> Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: linux-mtd@lists.infradead.org
> ---
>  drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c
> b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 56aa6b75213d..5e9f2ca0a6c1 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info
> *map, struct flchip *chip,
>  		if (time_after(jiffies, timeo) && !chip_ready(map, adr))
>  			break;
> 
> -		if (chip_ready(map, adr)) {
> +		if (chip_ready(map, adr) && chip_good(map, adr, datum))
> {
>  			xip_enable(map, chip, adr);
>  			goto op_done;
>  		}
> --
> 2.16.1

[PATCH] mtd: cfi_cmdset_0002: Change write buffer to check correct value

[IKEGAMI Tokunori]

From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>

For the word write it is checked if the chip has the correct value.
But it is not checked for the write buffer as only checked if ready.
To make sure for the write buffer change to check the value.

It is enough as this patch is only checking the last written word.
Since it is described by data sheets to check the operation status.

Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Cc: linux-mtd@lists.infradead.org
---
 drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 56aa6b75213d..5e9f2ca0a6c1 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
                if (time_after(jiffies, timeo) && !chip_ready(map, adr))
                        break;

-               if (chip_ready(map, adr)) {
+               if (chip_ready(map, adr) && chip_good(map, adr, datum)) {
                        xip_enable(map, chip, adr);
                        goto op_done;
                }
--
2.16.1

Re: [PATCH] mtd: cfi_cmdset_0002: Change write buffer to check correct value

[Boris Brezillon]

Hi,

Just a few more tips regarding the submission process:

- you can group several patches in a patch series when some are
  dependent on others. Just use 'git format-patch -<X>
  <last-commit>' where <X> is the number of patches you want to generate
  and <last-commit> is the last commit in the series. When you do that,
  it's generally a good practice to have a cover letter explaining what
  the patch series does. You can generate the cover letter with the
  --cover-letter option

- when you send a new version of a patch or a patch series it should be
  prefixed with "[PATCH vX ...]". This can be done by passing -v<X> (X
  being the version number) to git format-patch

- when you send the exact same version of a patch or patch series
  because the previous one has not been sent properly, you should
  prefix the patches with "[PATCH RESEND ...]". Again, can be done by
  passing --subject-prefix="PATCH RESEND" to git format-patch

- you should have a changelog describing what has changed between each
  version of the patch or patchset. The changelog can be placed in the
  cover-letter if you have one, or just after the "---" in the patch
  itself. You can also add extra information that you don't want to
  appear in the commit message just after this marker.

Regards,

Boris

On Wed, 9 May 2018 13:32:11 +0000
IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:

> From: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> 
> For the word write it is checked if the chip has the correct value.
> But it is not checked for the write buffer as only checked if ready.
> To make sure for the write buffer change to check the value.
> 
> It is enough as this patch is only checking the last written word.
> Since it is described by data sheets to check the operation status.
> 
> Signed-off-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> Cc: linux-mtd@lists.infradead.org
> ---
>  drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 56aa6b75213d..5e9f2ca0a6c1 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip,
>                 if (time_after(jiffies, timeo) && !chip_ready(map, adr))
>                         break;
> 
> -               if (chip_ready(map, adr)) {
> +               if (chip_ready(map, adr) && chip_good(map, adr, datum)) {
>                         xip_enable(map, chip, adr);
>                         goto op_done;
>                 }
> --
> 2.16.1
> 

RE: [PATCH] mtd: cfi_cmdset_0002: Change write buffer to check correct value

[IKEGAMI Tokunori]

Hi Boris-san,

Thank you so much for your support.
Okay I will do follow the process below.

> Just a few more tips regarding the submission process:
> 
> - you can group several patches in a patch series when some are
>   dependent on others. Just use 'git format-patch -<X>
>   <last-commit>' where <X> is the number of patches you want to generate
>   and <last-commit> is the last commit in the series. When you do that,
>   it's generally a good practice to have a cover letter explaining what
>   the patch series does. You can generate the cover letter with the
>   --cover-letter option
> 
> - when you send a new version of a patch or a patch series it should be
>   prefixed with "[PATCH vX ...]". This can be done by passing -v<X> (X
>   being the version number) to git format-patch
> 
> - when you send the exact same version of a patch or patch series
>   because the previous one has not been sent properly, you should
>   prefix the patches with "[PATCH RESEND ...]". Again, can be done by
>   passing --subject-prefix="PATCH RESEND" to git format-patch
> 
> - you should have a changelog describing what has changed between each
>   version of the patch or patchset. The changelog can be placed in the
>   cover-letter if you have one, or just after the "---" in the patch
>   itself. You can also add extra information that you don't want to
>   appear in the commit message just after this marker.

Regards,
Ikegami