RE: [PATCH 03/10] phy: renesas: rcar-gen3-usb2: Check dr_mode when not using OTG

From: Chris Brandt <Chris.Brandt@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Simon Horman <horms@verge.net.au>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 03/10] phy: renesas: rcar-gen3-usb2: Check dr_mode when not using OTG
Date: Tue, 7 May 2019 11:45:04 +0000	[thread overview]
Message-ID: <TY1PR01MB1562550164C7977D28C90F128A310@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <17bcc673-5fed-ce4f-3d61-af34bfa5d769@cogentembedded.com>

On Tue, May 07, 2019, Sergei Shtylyov wrote:
> > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> > @@ -408,7 +408,12 @@ static int rcar_gen3_phy_usb2_init(struct phy *p)
> >  		if (rcar_gen3_needs_init_otg(channel))
> >  			rcar_gen3_init_otg(channel);
> >  		rphy->otg_initialized = true;
> > -	}
> > +	} else
> 
>    Wait, don't we neeed {} here?
> 
> > +		/* Not OTG, so dr_mode should be set in PHY node */
> > +		if (usb_get_dr_mode(channel->dev) == USB_DR_MODE_PERIPHERAL)
> > +			writel(0x80000000, usb2_base + USB2_COMMCTRL);
> > +		else
> > +			writel(0x00000000, usb2_base + USB2_COMMCTRL);

Technically there is only 1 statement after the else (the 'if' which 
will also include the 'else') statement. The coding rules say not to use
{ } if there is only 1 statement.

Chris