All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 0/2] ARM: dts: rskrza1: Add I2C and remaining LEDs
Date: Fri, 22 Mar 2019 11:04:35 +0000	[thread overview]
Message-ID: <TY1PR01MB156259D3A98DC7A29890B02C8A430@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdUSxx94+-M6OR+2BOO0NgAdP27o1Af7c_xeufv1b1Hp5A@mail.gmail.com>

Hi Geert,

On Fri, Mar 22, 2019, Geert Uytterhoeven wrote:
> > Yeah, I've seen that code. Not fit for upstream ;-)
> 
> The proper way is to use that standard heartbeat LED trigger
> CONFIG_LEDS_TRIGGER_HEARTBEAT=y, configurable from
> sysfs.
> 
> For your sample DTS: you can even specify an LED trigger from DT, cfr.
> Documentation/devicetree/bindings/leds/common.txt:
> 
>     linux,default-trigger = "heartbeat"


Wow, I am such a hack when it comes to Linux!

I'm going to add this to my TODO list along with your other suggestion 
of the irqchip driver for the interrupt pins.


Thanks,
Chris

      reply	other threads:[~2019-03-22 11:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 19:44 [PATCH 0/2] ARM: dts: rskrza1: Add I2C and remaining LEDs Geert Uytterhoeven
2019-03-20 19:44 ` [PATCH 1/2] ARM: dts: rskrza1: Add I2C support Geert Uytterhoeven
2019-03-22 10:23   ` Simon Horman
2019-03-25 10:55     ` Geert Uytterhoeven
2019-03-25 10:55       ` Geert Uytterhoeven
2019-03-27 12:08       ` Simon Horman
2019-03-27 12:08         ` Simon Horman
2019-03-20 19:44 ` [PATCH 2/2] ARM: dts: rskrza1: Add remaining LEDs Geert Uytterhoeven
2019-03-27 12:09   ` Simon Horman
2019-03-20 20:41 ` [PATCH 0/2] ARM: dts: rskrza1: Add I2C and " Chris Brandt
2019-03-20 20:41   ` Chris Brandt
2019-03-21 10:02   ` Geert Uytterhoeven
2019-03-21 12:16     ` Chris Brandt
2019-03-21 12:28       ` Geert Uytterhoeven
2019-03-22  8:23     ` Geert Uytterhoeven
2019-03-22 11:04       ` Chris Brandt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY1PR01MB156259D3A98DC7A29890B02C8A430@TY1PR01MB1562.jpnprd01.prod.outlook.com \
    --to=chris.brandt@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.