* [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes
@ 2017-09-13 6:52 Yoshihiro Shimoda
2017-09-13 7:49 ` Simon Horman
2017-09-13 9:21 ` Geert Uytterhoeven
0 siblings, 2 replies; 8+ messages in thread
From: Yoshihiro Shimoda @ 2017-09-13 6:52 UTC (permalink / raw)
To: horms, magnus.damm, robh+dt, mark.rutland
Cc: devicetree, linux-renesas-soc, Yoshihiro Shimoda
This patch adds GPIO device nodes for r8a77995.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
This patch should be applied after the following patch is applied:
"gpio: rcar: Add r8a77995 (R-Car D3) support".
arch/arm64/boot/dts/renesas/r8a77995.dtsi | 112 ++++++++++++++++++++++++++++++
1 file changed, 112 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 84b6bd5..a1c9271 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -139,6 +139,118 @@
#power-domain-cells = <1>;
};
+ gpio0: gpio@e6050000 {
+ compatible = "renesas,gpio-r8a77995",
+ "renesas,rcar-gen3-gpio",
+ "renesas,gpio-rcar";
+ reg = <0 0xe6050000 0 0x50>;
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 0 9>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 912>;
+ power-domains = <&cpg>;
+ resets = <&cpg 912>;
+ };
+
+ gpio1: gpio@e6051000 {
+ compatible = "renesas,gpio-r8a77995",
+ "renesas,rcar-gen3-gpio",
+ "renesas,gpio-rcar";
+ reg = <0 0xe6051000 0 0x50>;
+ interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 32 32>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 911>;
+ power-domains = <&cpg>;
+ resets = <&cpg 911>;
+ };
+
+ gpio2: gpio@e6052000 {
+ compatible = "renesas,gpio-r8a77995",
+ "renesas,rcar-gen3-gpio",
+ "renesas,gpio-rcar";
+ reg = <0 0xe6052000 0 0x50>;
+ interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 64 32>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 910>;
+ power-domains = <&cpg>;
+ resets = <&cpg 910>;
+ };
+
+ gpio3: gpio@e6053000 {
+ compatible = "renesas,gpio-r8a77995",
+ "renesas,rcar-gen3-gpio",
+ "renesas,gpio-rcar";
+ reg = <0 0xe6053000 0 0x50>;
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 96 10>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 909>;
+ power-domains = <&cpg>;
+ resets = <&cpg 909>;
+ };
+
+ gpio4: gpio@e6054000 {
+ compatible = "renesas,gpio-r8a77995",
+ "renesas,rcar-gen3-gpio",
+ "renesas,gpio-rcar";
+ reg = <0 0xe6054000 0 0x50>;
+ interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 128 32>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 908>;
+ power-domains = <&cpg>;
+ resets = <&cpg 908>;
+ };
+
+ gpio5: gpio@e6055000 {
+ compatible = "renesas,gpio-r8a77995",
+ "renesas,rcar-gen3-gpio",
+ "renesas,gpio-rcar";
+ reg = <0 0xe6055000 0 0x50>;
+ interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 160 21>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 907>;
+ power-domains = <&cpg>;
+ resets = <&cpg 907>;
+ };
+
+ gpio6: gpio@e6055400 {
+ compatible = "renesas,gpio-r8a77995",
+ "renesas,rcar-gen3-gpio",
+ "renesas,gpio-rcar";
+ reg = <0 0xe6055400 0 0x50>;
+ interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 192 14>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 906>;
+ power-domains = <&cpg>;
+ resets = <&cpg 906>;
+ };
+
scif2: serial@e6e88000 {
compatible = "renesas,scif-r8a77995",
"renesas,rcar-gen3-scif", "renesas,scif";
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes
2017-09-13 6:52 [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes Yoshihiro Shimoda
@ 2017-09-13 7:49 ` Simon Horman
2017-09-13 7:56 ` Yoshihiro Shimoda
2017-09-13 9:21 ` Geert Uytterhoeven
1 sibling, 1 reply; 8+ messages in thread
From: Simon Horman @ 2017-09-13 7:49 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: magnus.damm, robh+dt, mark.rutland, devicetree, linux-renesas-soc
On Wed, Sep 13, 2017 at 03:52:08PM +0900, Yoshihiro Shimoda wrote:
> This patch adds GPIO device nodes for r8a77995.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> This patch should be applied after the following patch is applied:
> "gpio: rcar: Add r8a77995 (R-Car D3) support".
I think it can be applied in parallel with that patch as the driver
will match on "renesas,rcar-gen3-gpio". Right?
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 112 ++++++++++++++++++++++++++++++
> 1 file changed, 112 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 84b6bd5..a1c9271 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -139,6 +139,118 @@
> #power-domain-cells = <1>;
> };
>
> + gpio0: gpio@e6050000 {
> + compatible = "renesas,gpio-r8a77995",
> + "renesas,rcar-gen3-gpio",
> + "renesas,gpio-rcar";
> + reg = <0 0xe6050000 0 0x50>;
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + gpio-ranges = <&pfc 0 0 9>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + clocks = <&cpg CPG_MOD 912>;
> + power-domains = <&cpg>;
> + resets = <&cpg 912>;
> + };
...
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes
2017-09-13 7:49 ` Simon Horman
@ 2017-09-13 7:56 ` Yoshihiro Shimoda
0 siblings, 0 replies; 8+ messages in thread
From: Yoshihiro Shimoda @ 2017-09-13 7:56 UTC (permalink / raw)
To: Simon Horman
Cc: magnus.damm, robh+dt, mark.rutland, devicetree, linux-renesas-soc
Hi Simon-san,
> From: Simon Horman
> Sent: Wednesday, September 13, 2017 4:50 PM
>
> On Wed, Sep 13, 2017 at 03:52:08PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds GPIO device nodes for r8a77995.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> > This patch should be applied after the following patch is applied:
> > "gpio: rcar: Add r8a77995 (R-Car D3) support".
>
> I think it can be applied in parallel with that patch as the driver
> will match on "renesas,rcar-gen3-gpio". Right?
That's right.
My little concern was checkpatch.pl output warning if we didn't applied
the gpio patch :)
Best regards,
Yoshihiro Shimoda
> > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 112 ++++++++++++++++++++++++++++++
> > 1 file changed, 112 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > index 84b6bd5..a1c9271 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > @@ -139,6 +139,118 @@
> > #power-domain-cells = <1>;
> > };
> >
> > + gpio0: gpio@e6050000 {
> > + compatible = "renesas,gpio-r8a77995",
> > + "renesas,rcar-gen3-gpio",
> > + "renesas,gpio-rcar";
> > + reg = <0 0xe6050000 0 0x50>;
> > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> > + #gpio-cells = <2>;
> > + gpio-controller;
> > + gpio-ranges = <&pfc 0 0 9>;
> > + #interrupt-cells = <2>;
> > + interrupt-controller;
> > + clocks = <&cpg CPG_MOD 912>;
> > + power-domains = <&cpg>;
> > + resets = <&cpg 912>;
> > + };
>
> ...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes
2017-09-13 6:52 [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes Yoshihiro Shimoda
2017-09-13 7:49 ` Simon Horman
@ 2017-09-13 9:21 ` Geert Uytterhoeven
2017-09-13 9:35 ` Yoshihiro Shimoda
1 sibling, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2017-09-13 9:21 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree,
Linux-Renesas
Hi Shimoda-san,
On Wed, Sep 13, 2017 at 8:52 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch adds GPIO device nodes for r8a77995.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -139,6 +139,118 @@
> #power-domain-cells = <1>;
> };
>
> + gpio0: gpio@e6050000 {
> + compatible = "renesas,gpio-r8a77995",
> + "renesas,rcar-gen3-gpio",
> + "renesas,gpio-rcar";
> + reg = <0 0xe6050000 0 0x50>;
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + gpio-ranges = <&pfc 0 0 9>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + clocks = <&cpg CPG_MOD 912>;
> + power-domains = <&cpg>;
All nodes lack the power domain index (32, to be replaced by
R8A77995_PD_ALWAYS_ON later):
power-domains = <&sysc 32>;
> + resets = <&cpg 912>;
> + };
With that fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes
2017-09-13 9:21 ` Geert Uytterhoeven
@ 2017-09-13 9:35 ` Yoshihiro Shimoda
2017-09-13 11:48 ` Geert Uytterhoeven
0 siblings, 1 reply; 8+ messages in thread
From: Yoshihiro Shimoda @ 2017-09-13 9:35 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree,
Linux-Renesas
Hi Geert-san,
> From: Geert Uytterhoeven
> Sent: Wednesday, September 13, 2017 6:22 PM
>
> Hi Shimoda-san,
>
> On Wed, Sep 13, 2017 at 8:52 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > This patch adds GPIO device nodes for r8a77995.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > @@ -139,6 +139,118 @@
> > #power-domain-cells = <1>;
> > };
> >
> > + gpio0: gpio@e6050000 {
> > + compatible = "renesas,gpio-r8a77995",
> > + "renesas,rcar-gen3-gpio",
> > + "renesas,gpio-rcar";
> > + reg = <0 0xe6050000 0 0x50>;
> > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> > + #gpio-cells = <2>;
> > + gpio-controller;
> > + gpio-ranges = <&pfc 0 0 9>;
> > + #interrupt-cells = <2>;
> > + interrupt-controller;
> > + clocks = <&cpg CPG_MOD 912>;
> > + power-domains = <&cpg>;
>
> All nodes lack the power domain index (32, to be replaced by
> R8A77995_PD_ALWAYS_ON later):
>
> power-domains = <&sysc 32>;
The r8a77995.dtsi file already uses R8A77995_PD_ALWAYS_ON in scif2 node.
So, should I fix this patch like the following?
power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> > + resets = <&cpg 912>;
> > + };
>
> With that fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thank you for the review!
Best regards,
Yoshihiro Shimoda
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes
2017-09-13 9:35 ` Yoshihiro Shimoda
@ 2017-09-13 11:48 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUiZyK3xA=_rYjbAaSYhm=-p5Spug0mmLc=mf+pRfxgoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2017-09-13 11:48 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland, devicetree,
Linux-Renesas
Hi Shimoda-san,
On Wed, Sep 13, 2017 at 11:35 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>> From: Geert Uytterhoeven
>> Sent: Wednesday, September 13, 2017 6:22 PM
>> On Wed, Sep 13, 2017 at 8:52 AM, Yoshihiro Shimoda
>> <yoshihiro.shimoda.uh@renesas.com> wrote:
>> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
>> > @@ -139,6 +139,118 @@
>> > #power-domain-cells = <1>;
>> > };
>> >
>> > + gpio0: gpio@e6050000 {
>> > + compatible = "renesas,gpio-r8a77995",
>> > + "renesas,rcar-gen3-gpio",
>> > + "renesas,gpio-rcar";
>> > + reg = <0 0xe6050000 0 0x50>;
>> > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
>> > + #gpio-cells = <2>;
>> > + gpio-controller;
>> > + gpio-ranges = <&pfc 0 0 9>;
>> > + #interrupt-cells = <2>;
>> > + interrupt-controller;
>> > + clocks = <&cpg CPG_MOD 912>;
>> > + power-domains = <&cpg>;
>>
>> All nodes lack the power domain index (32, to be replaced by
>> R8A77995_PD_ALWAYS_ON later):
>>
>> power-domains = <&sysc 32>;
>
> The r8a77995.dtsi file already uses R8A77995_PD_ALWAYS_ON in scif2 node.
In my renesas-drivers it does.
In Simon's renesas/devel it doesn't, as the R8A77995_PD_* definitions
go upstream through a different branch than the DTS changes.
> So, should I fix this patch like the following?
>
> power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
For now you should use 32.
However, as soon as Simon merges v4.14-rc1 into renesas/devel, you
can start on using R8A77995_PD_ALWAYS_ON.
As that is expected to happen this Monday, he can just postpone applying
your updated patch until then, so I don't think there's a need to resend a
version with hardcoded numbers.
For R-Car V3M it's different, as the definitions for that SoC won't appear
in upstream for another full cycle, i.e. in v4.15-rc1 the earliest.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-13 12:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-13 6:52 [PATCH] arm64: dts: renesas: r8a77995: add GPIO device nodes Yoshihiro Shimoda
2017-09-13 7:49 ` Simon Horman
2017-09-13 7:56 ` Yoshihiro Shimoda
2017-09-13 9:21 ` Geert Uytterhoeven
2017-09-13 9:35 ` Yoshihiro Shimoda
2017-09-13 11:48 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUiZyK3xA=_rYjbAaSYhm=-p5Spug0mmLc=mf+pRfxgoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-13 12:06 ` Yoshihiro Shimoda
2017-09-13 12:06 ` Yoshihiro Shimoda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.