* [5/6] USB: renesas_usbhs: drop support for legacy phys
@ 2018-04-18 8:50 Yoshihiro Shimoda
0 siblings, 0 replies; 5+ messages in thread
From: Yoshihiro Shimoda @ 2018-04-18 8:50 UTC (permalink / raw)
To: Johan Hovold
Cc: Greg Kroah-Hartman, Felipe Balbi, Alan Stern, Bin Liu, linux-usb,
linux-omap
Hi,
> From: Johan Hovold, Sent: Wednesday, April 18, 2018 5:42 PM
>
> On Wed, Apr 18, 2018 at 04:22:31AM +0000, Yoshihiro Shimoda wrote:
> > Hi,
> >
> > > From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
> > >
> > > Drop support for legacy phys which hasn't been used with a mainline
> > > kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c
> > > platform init code"). Specifically, since that commit usb_get_phy_dev()
> > > have always returned -ENODEV and consequently this code has not been
> > > used.
> > >
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > ---
> > > drivers/usb/renesas_usbhs/common.h | 1 -
> > > drivers/usb/renesas_usbhs/rcar2.c | 29 -----------------------------
> > > 2 files changed, 30 deletions(-)
> >
> > Thank you for the patch!
> > The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy
> > API (usb_get_phy()).
> > Also this patch set doesn't drop the API. So, I think this subject
> > should be changed.
> > What do you think?
>
> Good point, I'll try to rephrase it.
>
> How about
>
> USB: renesas_usbhs: drop unused legacy-phy support
>
> and then I amend the commit message with a note about the legacy API
> still being used in gadget mode to bind the peripheral controller?
It sounds good to me.
When you submit v2 patch, would you add my Acked-by?
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
> > Dropping usb_get_phy_dev() from this driver is good to me.
>
> Thanks,
> Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [5/6] USB: renesas_usbhs: drop support for legacy phys
@ 2018-04-18 9:20 Johan Hovold
0 siblings, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2018-04-18 9:20 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Johan Hovold, Greg Kroah-Hartman, Felipe Balbi, Alan Stern,
Bin Liu, linux-usb, linux-omap
On Wed, Apr 18, 2018 at 08:50:10AM +0000, Yoshihiro Shimoda wrote:
> Hi,
>
> > From: Johan Hovold, Sent: Wednesday, April 18, 2018 5:42 PM
> > How about
> >
> > USB: renesas_usbhs: drop unused legacy-phy support
> >
> > and then I amend the commit message with a note about the legacy API
> > still being used in gadget mode to bind the peripheral controller?
>
> It sounds good to me.
> When you submit v2 patch, would you add my Acked-by?
>
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Will do. Thanks again!
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [5/6] USB: renesas_usbhs: drop support for legacy phys
@ 2018-04-18 8:42 Johan Hovold
0 siblings, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2018-04-18 8:42 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Johan Hovold, Greg Kroah-Hartman, Felipe Balbi, Alan Stern,
Bin Liu, linux-usb, linux-omap
On Wed, Apr 18, 2018 at 04:22:31AM +0000, Yoshihiro Shimoda wrote:
> Hi,
>
> > From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
> >
> > Drop support for legacy phys which hasn't been used with a mainline
> > kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c
> > platform init code"). Specifically, since that commit usb_get_phy_dev()
> > have always returned -ENODEV and consequently this code has not been
> > used.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > drivers/usb/renesas_usbhs/common.h | 1 -
> > drivers/usb/renesas_usbhs/rcar2.c | 29 -----------------------------
> > 2 files changed, 30 deletions(-)
>
> Thank you for the patch!
> The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy
> API (usb_get_phy()).
> Also this patch set doesn't drop the API. So, I think this subject
> should be changed.
> What do you think?
Good point, I'll try to rephrase it.
How about
USB: renesas_usbhs: drop unused legacy-phy support
and then I amend the commit message with a note about the legacy API
still being used in gadget mode to bind the peripheral controller?
> Dropping usb_get_phy_dev() from this driver is good to me.
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [5/6] USB: renesas_usbhs: drop support for legacy phys
@ 2018-04-18 4:22 Yoshihiro Shimoda
0 siblings, 0 replies; 5+ messages in thread
From: Yoshihiro Shimoda @ 2018-04-18 4:22 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman, Felipe Balbi
Cc: Alan Stern, Bin Liu, linux-usb, linux-omap
Hi,
> From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
>
> Drop support for legacy phys which hasn't been used with a mainline
> kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c
> platform init code"). Specifically, since that commit usb_get_phy_dev()
> have always returned -ENODEV and consequently this code has not been
> used.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/usb/renesas_usbhs/common.h | 1 -
> drivers/usb/renesas_usbhs/rcar2.c | 29 -----------------------------
> 2 files changed, 30 deletions(-)
Thank you for the patch!
The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy API (usb_get_phy()).
Also this patch set doesn't drop the API. So, I think this subject should be changed.
What do you think?
Dropping usb_get_phy_dev() from this driver is good to me.
Best regards,
Yoshihiro Shimoda
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [5/6] USB: renesas_usbhs: drop support for legacy phys
@ 2018-04-14 13:06 Johan Hovold
0 siblings, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2018-04-14 13:06 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi
Cc: Alan Stern, Bin Liu, linux-usb, linux-omap, Johan Hovold
Drop support for legacy phys which hasn't been used with a mainline
kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c
platform init code"). Specifically, since that commit usb_get_phy_dev()
have always returned -ENODEV and consequently this code has not been
used.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/renesas_usbhs/common.h | 1 -
drivers/usb/renesas_usbhs/rcar2.c | 29 -----------------------------
2 files changed, 30 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h
index f619afeae2b8..6137f7942c05 100644
--- a/drivers/usb/renesas_usbhs/common.h
+++ b/drivers/usb/renesas_usbhs/common.h
@@ -276,7 +276,6 @@ struct usbhs_priv {
*/
struct usbhs_fifo_info fifo_info;
- struct usb_phy *usb_phy;
struct phy *phy;
};
diff --git a/drivers/usb/renesas_usbhs/rcar2.c b/drivers/usb/renesas_usbhs/rcar2.c
index 85a0e0933917..0027092b1118 100644
--- a/drivers/usb/renesas_usbhs/rcar2.c
+++ b/drivers/usb/renesas_usbhs/rcar2.c
@@ -8,7 +8,6 @@
#include <linux/gpio.h>
#include <linux/of_gpio.h>
#include <linux/phy/phy.h>
-#include <linux/usb/phy.h>
#include "common.h"
#include "rcar2.h"
@@ -26,16 +25,6 @@ static int usbhs_rcar2_hardware_init(struct platform_device *pdev)
return 0;
}
- if (IS_ENABLED(CONFIG_USB_PHY)) {
- struct usb_phy *usb_phy = usb_get_phy_dev(&pdev->dev, 0);
-
- if (IS_ERR(usb_phy))
- return PTR_ERR(usb_phy);
-
- priv->usb_phy = usb_phy;
- return 0;
- }
-
return -ENXIO;
}
@@ -48,11 +37,6 @@ static int usbhs_rcar2_hardware_exit(struct platform_device *pdev)
priv->phy = NULL;
}
- if (priv->usb_phy) {
- usb_put_phy(priv->usb_phy);
- priv->usb_phy = NULL;
- }
-
return 0;
}
@@ -75,19 +59,6 @@ static int usbhs_rcar2_power_ctrl(struct platform_device *pdev,
}
}
- if (priv->usb_phy) {
- if (enable) {
- retval = usb_phy_init(priv->usb_phy);
-
- if (!retval)
- retval = usb_phy_set_suspend(priv->usb_phy, 0);
- } else {
- usb_phy_set_suspend(priv->usb_phy, 1);
- usb_phy_shutdown(priv->usb_phy);
- retval = 0;
- }
- }
-
return retval;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-18 9:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 8:50 [5/6] USB: renesas_usbhs: drop support for legacy phys Yoshihiro Shimoda
-- strict thread matches above, loose matches on Subject: below --
2018-04-18 9:20 Johan Hovold
2018-04-18 8:42 Johan Hovold
2018-04-18 4:22 Yoshihiro Shimoda
2018-04-14 13:06 Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.