* [RFC,balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static
@ 2017-12-13 17:20 ` kbuild test robot
0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2017-12-13 17:20 UTC (permalink / raw)
To: Yoshihiro Shimoda; +Cc: kbuild-all, linux-usb, linux-omap, Felipe Balbi
Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
rcar3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
index d657309..d0ea4ff 100644
--- a/drivers/usb/renesas_usbhs/rcar3.c
+++ b/drivers/usb/renesas_usbhs/rcar3.c
@@ -112,8 +112,8 @@ static int usbhs_rcar3_get_id(struct platform_device *pdev)
return USBHS_GADGET;
}
-int usbhs_rcar3_notifier(struct notifier_block *nb, unsigned long event,
- void *data)
+static int usbhs_rcar3_notifier(struct notifier_block *nb, unsigned long event,
+ void *data)
{
struct usbhs_priv *priv = container_of(nb, struct usbhs_priv, nb);
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [balbi-usb:testing/next 25/25] drivers/usb/renesas_usbhs/rcar3.c:115:5: sparse: symbol 'usbhs_rcar3_notifier' was not declared. Should it be static?
@ 2017-12-13 17:20 kbuild test robot
0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2017-12-13 17:20 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: kbuild-all-JC7UmRfGjtg, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
head: 3a7cce26122e3925993ee2ac0b45ac6b9bf6f65f
commit: 3a7cce26122e3925993ee2ac0b45ac6b9bf6f65f [25/25] usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel
reproduce:
# apt-get install sparse
git checkout 3a7cce26122e3925993ee2ac0b45ac6b9bf6f65f
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RFC PATCH balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static
@ 2017-12-13 17:20 ` kbuild test robot
0 siblings, 0 replies; 7+ messages in thread
From: kbuild test robot @ 2017-12-13 17:20 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: kbuild-all-JC7UmRfGjtg, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi
Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel")
Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
rcar3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
index d657309..d0ea4ff 100644
--- a/drivers/usb/renesas_usbhs/rcar3.c
+++ b/drivers/usb/renesas_usbhs/rcar3.c
@@ -112,8 +112,8 @@ static int usbhs_rcar3_get_id(struct platform_device *pdev)
return USBHS_GADGET;
}
-int usbhs_rcar3_notifier(struct notifier_block *nb, unsigned long event,
- void *data)
+static int usbhs_rcar3_notifier(struct notifier_block *nb, unsigned long event,
+ void *data)
{
struct usbhs_priv *priv = container_of(nb, struct usbhs_priv, nb);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RFC,balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static
@ 2017-12-14 1:55 ` Yoshihiro Shimoda
0 siblings, 0 replies; 7+ messages in thread
From: Yoshihiro Shimoda @ 2017-12-14 1:55 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild-all, linux-usb, linux-omap, Felipe Balbi
Hi,
> From: kbuild test robot, Sent: Thursday, December 14, 2017 2:21 AM
>
> Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [RFC PATCH balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static
@ 2017-12-14 1:55 ` Yoshihiro Shimoda
0 siblings, 0 replies; 7+ messages in thread
From: Yoshihiro Shimoda @ 2017-12-14 1:55 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all-JC7UmRfGjtg, linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi
Hi,
> From: kbuild test robot, Sent: Thursday, December 14, 2017 2:21 AM
>
> Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel")
> Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Best regards,
Yoshihiro Shimoda
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RFC,balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static
@ 2017-12-14 7:58 ` Felipe Balbi
0 siblings, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2017-12-14 7:58 UTC (permalink / raw)
To: Yoshihiro Shimoda, kbuild test robot; +Cc: kbuild-all, linux-usb, linux-omap
Hi,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
> Hi,
>
>> From: kbuild test robot, Sent: Thursday, December 14, 2017 2:21 AM
>>
>> Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel")
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
> Thank you for the patch!
>
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
amended to patch which introduced the problem, thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [RFC PATCH balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static
@ 2017-12-14 7:58 ` Felipe Balbi
0 siblings, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2017-12-14 7:58 UTC (permalink / raw)
To: Yoshihiro Shimoda, kbuild test robot
Cc: kbuild-all@01.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Hi,
Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> writes:
> Hi,
>
>> From: kbuild test robot, Sent: Thursday, December 14, 2017 2:21 AM
>>
>> Fixes: 3a7cce26122e ("usb: renesas_usbhs: add extcon notifier to set mode for non-otg channel")
>> Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Thank you for the patch!
>
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
amended to patch which introduced the problem, thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-12-14 7:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14 1:55 [RFC,balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static Yoshihiro Shimoda
2017-12-14 1:55 ` [RFC PATCH balbi-usb] " Yoshihiro Shimoda
-- strict thread matches above, loose matches on Subject: below --
2017-12-14 7:58 [RFC,balbi-usb] " Felipe Balbi
2017-12-14 7:58 ` [RFC PATCH balbi-usb] " Felipe Balbi
2017-12-13 17:20 [balbi-usb:testing/next 25/25] drivers/usb/renesas_usbhs/rcar3.c:115:5: sparse: symbol 'usbhs_rcar3_notifier' was not declared. Should it be static? kbuild test robot
2017-12-13 17:20 [RFC,balbi-usb] usb: renesas_usbhs: usbhs_rcar3_notifier() can be static kbuild test robot
2017-12-13 17:20 ` [RFC PATCH balbi-usb] " kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.