Re: [cip-dev] Is cadence-quadspi working on cyclone V?

* Re: [cip-dev] Is cadence-quadspi working on cyclone V?
@ 2021-03-15  4:32 Takuo Koguchi
  2021-03-15  5:25 ` Nobuhiro Iwamatsu
  0 siblings, 1 reply; 8+ messages in thread
From: Takuo Koguchi @ 2021-03-15  4:32 UTC (permalink / raw)
  To: cip-dev

[-- Attachment #1: Type: text/plain, Size: 3361 bytes --]

Hi Pavel,

> >> Git bisect has told me the first bad commit is
> >> 31fb632b5d43 spi: Move cadence-quadspi driver to drivers/spi/
> >
> > That's strange.
> >
> >> Does this change requires device tree modification?
> >> Any suggestions or comments would be appreciated.
> >
> > ...because that particular change does not change any C code. But it
> > touches Kconfig bits; can you check that CONFIG_SPI_CADENCE_QUADSPI is
> > enabled in the "bad" configuration?
> >
> > Do you have any local changes in
> > drivers/mtd/spi-nor/controllers/cadence-quadspi.c or
> > drivers/spi/spi-cadence-quadspi.c ?
> I have no local changes to those files.
> Maybe I lost CONFIG_SPI_CADENCE_QUADSPI accidentally while bisecting.
> I will try bisect and post the result again.
>

I redo the bisect and get the following result; 
# first bad commit: [a314f6367787ee1d767df9a2120f17e4511144d0] mtd: spi-nor: Convert cadence-quadspi to use spi-mem framework

It contains significant amount of changes;

cadence-quadspi.c |  476 +++++++++++++++++++++---------------------------------
 1 file changed, 191 insertions(+), 285 deletions(-)

With this change, cpspi_probe return 0 without any error messages, but it does not detect NOR flash on a custom cyclone V board. 

Any information will be appreciated.

Thanks,

Takuo Koguchi

> -----Original Message-----
> From: 小口琢夫 / KOGUCHI，TAKUO
> Sent: Sunday, March 14, 2021 4:37 PM
> To: cip-dev@lists.cip-project.org
> Subject: Re: [!]Re: [cip-dev] Is cadence-quadspi working on cyclone V?
> 
> Hi Pavel,
> Thank you for the response.
> 
> >> Git bisect has told me the first bad commit is
> >> 31fb632b5d43 spi: Move cadence-quadspi driver to drivers/spi
> >
> > That's strange.
> >
> >> Does this change requires device tree modification?
> >> Any suggestions or comments would be appreciated.
> >
> > ...because that particular change does not change any C code. But it
> > touches Kconfig bits; can you check that CONFIG_SPI_CADENCE_QUADSPI is
> > enabled in the "bad" configuration?
> >
> > Do you have any local changes in
> > drivers/mtd/spi-nor/controllers/cadence-quadspi.c or
> > drivers/spi/spi-cadence-quadspi.c ?
> I have no local changes to those files.
> Maybe I lost CONFIG_SPI_CADENCE_QUADSPI accidentally while bisecting.
> I will try bisect and post the result again.
> 
> Regards,
> 
> Takuo Koguchi
> 
> > 2021/03/13 8:07、Pavel Machek <pavel@denx.de>のメール:
> >
> > Hi!
> >
> >> Git bisect has told me the first bad commit is
> >> 31fb632b5d43 spi: Move cadence-quadspi driver to drivers/spi/
> >
> > That's strange.
> >
> >> Does this change requires device tree modification?
> >> Any suggestions or comments would be appreciated.
> >
> > ...because that particular change does not change any C code. But it
> > touches Kconfig bits; can you check that CONFIG_SPI_CADENCE_QUADSPI is
> > enabled in the "bad" configuration?
> >
> > Do you have any local changes in
> > drivers/mtd/spi-nor/controllers/cadence-quadspi.c or
> > drivers/spi/spi-cadence-quadspi.c ?
> >
> > Best regards,
> >                                Pavel
> > --
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> >
> > 
> >

[-- Attachment #2: Type: text/plain, Size: 428 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6281): https://lists.cip-project.org/g/cip-dev/message/6281
Mute This Topic: https://lists.cip-project.org/mt/81272003/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

^ permalink raw reply	[flat|nested] 8+ messages in thread