* [Fuego] [PATCH] IOzone: remove single quotation
@ 2021-06-22 1:23 daichi1.fukui
2021-06-22 22:34 ` Tim.Bird
0 siblings, 1 reply; 3+ messages in thread
From: daichi1.fukui @ 2021-06-22 1:23 UTC (permalink / raw)
To: fuego
[-- Attachment #1: Type: text/plain, Size: 2384 bytes --]
From 48bac4939a46eac4a5d31856a734c14fa19ef0fe Mon Sep 17 00:00:00 2001
From: Daichi Fukui <daichi1.fukui@toshiba.co.jp>
Date: Mon, 21 Jun 2021 18:54:19 +0900
Subject: [PATCH] IOzone: remove single quotation
With single quotations in TESTS variables, the specified
tests (-i) are not passed correctly to the iozone command,
ending up with testing only write/re-writes in giving
a prepared specification defined in specs.json.
Thus we should remove the single quotations so that
we can correctly pass our specified tests.
Signed-off-by: Daichi Fukui <daichi1.fukui@toshiba.co.jp>
---
tests/Benchmark.IOzone/spec.json | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/Benchmark.IOzone/spec.json b/tests/Benchmark.IOzone/spec.json
index 05af9b8..e1fbc3b 100644
--- a/tests/Benchmark.IOzone/spec.json
+++ b/tests/Benchmark.IOzone/spec.json
@@ -6,31 +6,31 @@
"MOUNT_BLOCKDEV":"$SATA_DEV",
"MOUNT_POINT":"$SATA_MP",
"FILE_SIZE":"2M",
- "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
+ "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
},
"mmc": {
"MOUNT_BLOCKDEV":"$MMC_DEV",
"MOUNT_POINT":"$MMC_MP",
"FILE_SIZE":"2M",
- "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
+ "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
},
"usb": {
"MOUNT_BLOCKDEV":"$USB_DEV",
"MOUNT_POINT":"$USB_MP",
"FILE_SIZE":"2M",
- "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
+ "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
},
"nopread": {
"MOUNT_BLOCKDEV":"ROOT",
"MOUNT_POINT":"$BOARD_TESTDIR/work",
"FILE_SIZE":"2M",
- "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8'"
+ "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8"
},
"default": {
"MOUNT_BLOCKDEV":"ROOT",
"MOUNT_POINT":"$BOARD_TESTDIR/work",
"FILE_SIZE":"2M",
- "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
+ "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
}
}
}
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 14919 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Fuego] [PATCH] IOzone: remove single quotation
2021-06-22 1:23 [Fuego] [PATCH] IOzone: remove single quotation daichi1.fukui
@ 2021-06-22 22:34 ` Tim.Bird
2021-06-24 10:58 ` daichi1.fukui
0 siblings, 1 reply; 3+ messages in thread
From: Tim.Bird @ 2021-06-22 22:34 UTC (permalink / raw)
To: daichi1.fukui, fuego
Daichi-san,
The patch looks good. I applied it and pushed it to the master branch.
When testing the patch (and running IOZone on several different platforms),
and found some other bugs. I decided to fix those, and update the version
of IOzone that Fuego uses for testing.
I upgraded to version 492 (from version 353), which resolve an issue with
a missing build setting (HAVE_PREAD) for the x86_64 architecture
(the iozone target 'linux-AMD64'). I also added a chart_type to the
chart_config.json file, and added a test.yaml file for the test as well.
All these changes have been pushed to the current master branch
of fuego-core. Can you please pull that branch, and run the Benchmark.IOzone
test to make sure that nothing has broken for your usage of the test?
Thanks very much for the patch. It was good to get this test fixed up
and cleaned up!
-- Tim
> -----Original Message-----
> From: Fuego <fuego-bounces@lists.linuxfoundation.org> On Behalf Of daichi1.fukui@toshiba.co.jp
>
> From 48bac4939a46eac4a5d31856a734c14fa19ef0fe Mon Sep 17 00:00:00 2001
>
> From: Daichi Fukui <daichi1.fukui@toshiba.co.jp>
>
> Date: Mon, 21 Jun 2021 18:54:19 +0900
>
> Subject: [PATCH] IOzone: remove single quotation
>
>
>
> With single quotations in TESTS variables, the specified
>
> tests (-i) are not passed correctly to the iozone command,
>
> ending up with testing only write/re-writes in giving
>
> a prepared specification defined in specs.json.
>
> Thus we should remove the single quotations so that
>
> we can correctly pass our specified tests.
>
>
>
> Signed-off-by: Daichi Fukui <daichi1.fukui@toshiba.co.jp>
>
> ---
>
> tests/Benchmark.IOzone/spec.json | 10 +++++-----
>
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
>
> diff --git a/tests/Benchmark.IOzone/spec.json b/tests/Benchmark.IOzone/spec.json
>
> index 05af9b8..e1fbc3b 100644
>
> --- a/tests/Benchmark.IOzone/spec.json
>
> +++ b/tests/Benchmark.IOzone/spec.json
>
> @@ -6,31 +6,31 @@
>
> "MOUNT_BLOCKDEV":"$SATA_DEV",
>
> "MOUNT_POINT":"$SATA_MP",
>
> "FILE_SIZE":"2M",
>
> - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
>
> + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
>
> },
>
> "mmc": {
>
> "MOUNT_BLOCKDEV":"$MMC_DEV",
>
> "MOUNT_POINT":"$MMC_MP",
>
> "FILE_SIZE":"2M",
>
> - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
>
> + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
>
> },
>
> "usb": {
>
> "MOUNT_BLOCKDEV":"$USB_DEV",
>
> "MOUNT_POINT":"$USB_MP",
>
> "FILE_SIZE":"2M",
>
> - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
>
> + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
>
> },
>
> "nopread": {
>
> "MOUNT_BLOCKDEV":"ROOT",
>
> "MOUNT_POINT":"$BOARD_TESTDIR/work",
>
> "FILE_SIZE":"2M",
>
> - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8'"
>
> + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8"
>
> },
>
> "default": {
>
> "MOUNT_BLOCKDEV":"ROOT",
>
> "MOUNT_POINT":"$BOARD_TESTDIR/work",
>
> "FILE_SIZE":"2M",
>
> - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
>
> + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
>
> }
>
> }
>
> }
>
> --
>
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Fuego] [PATCH] IOzone: remove single quotation
2021-06-22 22:34 ` Tim.Bird
@ 2021-06-24 10:58 ` daichi1.fukui
0 siblings, 0 replies; 3+ messages in thread
From: daichi1.fukui @ 2021-06-24 10:58 UTC (permalink / raw)
To: Tim.Bird; +Cc: fuego
Hi Tim,
I've pulled all new stuffs regarding IOzone and tested them.
The changes work fine in my customised testing environment!
Thank you for reviewing and I also appreciate your additional effort.
P.S. I should have sent the patch as an attachment... I'll do so next time.
Regards,
Fukui
> -----Original Message-----
> From: Tim.Bird@sony.com [mailto:Tim.Bird@sony.com]
> Sent: Wednesday, June 23, 2021 7:35 AM
> To: fukui daichi(福意 大智 □ＳＷＣ◯ＡＣＴ) <daichi1.fukui@toshiba.co.jp>;
> fuego@lists.linuxfoundation.org
> Subject: RE: [PATCH] IOzone: remove single quotation
>
> Daichi-san,
>
> The patch looks good. I applied it and pushed it to the master branch.
>
> When testing the patch (and running IOZone on several different platforms),
> and found some other bugs. I decided to fix those, and update the version
> of IOzone that Fuego uses for testing.
>
> I upgraded to version 492 (from version 353), which resolve an issue with
> a missing build setting (HAVE_PREAD) for the x86_64 architecture
> (the iozone target 'linux-AMD64'). I also added a chart_type to the
> chart_config.json file, and added a test.yaml file for the test as well.
>
> All these changes have been pushed to the current master branch
> of fuego-core. Can you please pull that branch, and run the Benchmark.IOzone
> test to make sure that nothing has broken for your usage of the test?
>
> Thanks very much for the patch. It was good to get this test fixed up
> and cleaned up!
> -- Tim
>
>
> > -----Original Message-----
> > From: Fuego <fuego-bounces@lists.linuxfoundation.org> On Behalf Of
> daichi1.fukui@toshiba.co.jp
> >
> > From 48bac4939a46eac4a5d31856a734c14fa19ef0fe Mon Sep 17 00:00:00 2001
> >
> > From: Daichi Fukui <daichi1.fukui@toshiba.co.jp>
> >
> > Date: Mon, 21 Jun 2021 18:54:19 +0900
> >
> > Subject: [PATCH] IOzone: remove single quotation
> >
> >
> >
> > With single quotations in TESTS variables, the specified
> >
> > tests (-i) are not passed correctly to the iozone command,
> >
> > ending up with testing only write/re-writes in giving
> >
> > a prepared specification defined in specs.json.
> >
> > Thus we should remove the single quotations so that
> >
> > we can correctly pass our specified tests.
> >
> >
> >
> > Signed-off-by: Daichi Fukui <daichi1.fukui@toshiba.co.jp>
> >
> > ---
> >
> > tests/Benchmark.IOzone/spec.json | 10 +++++-----
> >
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> >
> >
> > diff --git a/tests/Benchmark.IOzone/spec.json
> b/tests/Benchmark.IOzone/spec.json
> >
> > index 05af9b8..e1fbc3b 100644
> >
> > --- a/tests/Benchmark.IOzone/spec.json
> >
> > +++ b/tests/Benchmark.IOzone/spec.json
> >
> > @@ -6,31 +6,31 @@
> >
> > "MOUNT_BLOCKDEV":"$SATA_DEV",
> >
> > "MOUNT_POINT":"$SATA_MP",
> >
> > "FILE_SIZE":"2M",
> >
> > - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> > },
> >
> > "mmc": {
> >
> > "MOUNT_BLOCKDEV":"$MMC_DEV",
> >
> > "MOUNT_POINT":"$MMC_MP",
> >
> > "FILE_SIZE":"2M",
> >
> > - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> > },
> >
> > "usb": {
> >
> > "MOUNT_BLOCKDEV":"$USB_DEV",
> >
> > "MOUNT_POINT":"$USB_MP",
> >
> > "FILE_SIZE":"2M",
> >
> > - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> > },
> >
> > "nopread": {
> >
> > "MOUNT_BLOCKDEV":"ROOT",
> >
> > "MOUNT_POINT":"$BOARD_TESTDIR/work",
> >
> > "FILE_SIZE":"2M",
> >
> > - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8'"
> >
> > + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8"
> >
> > },
> >
> > "default": {
> >
> > "MOUNT_BLOCKDEV":"ROOT",
> >
> > "MOUNT_POINT":"$BOARD_TESTDIR/work",
> >
> > "FILE_SIZE":"2M",
> >
> > - "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > + "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> > }
> >
> > }
> >
> > }
> >
> > --
> >
> > 2.17.1
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-24 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 1:23 [Fuego] [PATCH] IOzone: remove single quotation daichi1.fukui
2021-06-22 22:34 ` Tim.Bird
2021-06-24 10:58 ` daichi1.fukui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.