From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>, Rob Herring <robh+dt@kernel.org>, Linux IOMMU <iommu@lists.linux-foundation.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: RE: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for r8a779a0 Date: Tue, 7 Sep 2021 00:02:17 +0000 [thread overview] Message-ID: <TY2PR01MB36928CB43B188D4082829A1FD8D39@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdXwf0_+VKfuiFQf6roZErz-JAm06P5RBzD-Jwm1uk=p9A@mail.gmail.com> Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, September 7, 2021 12:34 AM > > Hi Shimoda-san, > > On Wed, Sep 1, 2021 at 12:27 PM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Add support for r8a779a0 (R-Car V3U). The IPMMU hardware design > > of this SoC differs than others. So, add a new ipmmu_features for it. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > --- a/drivers/iommu/ipmmu-vmsa.c > > +++ b/drivers/iommu/ipmmu-vmsa.c > > > @@ -922,6 +922,20 @@ static const struct ipmmu_features ipmmu_features_rcar_gen3 = { > > .utlb_offset_base = 0, > > }; > > > > +static const struct ipmmu_features ipmmu_features_r8a779a0 = { > > + .use_ns_alias_offset = false, > > + .has_cache_leaf_nodes = true, > > + .number_of_contexts = 8, > > Shouldn't this be 16? > Or do you plan to add support for more than 8 contexts later, as that > would require increasing IPMMU_CTX_MAX, and updating ipmmu_ctx_reg() > to handle the second bank of 8 contexts? I would like to add support for more than 8 contexts later because I realized that ctx_offset_{base,stride} are not suitable for the second bank of 8 contexts... > Regardless, I assume this will still work when when limiting to 8 > contexts, so > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for your review! Best regards, Yoshihiro Shimoda
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux IOMMU <iommu@lists.linux-foundation.org>, Rob Herring <robh+dt@kernel.org>, Will Deacon <will@kernel.org> Subject: RE: [PATCH 2/2] iommu/ipmmu-vmsa: Add support for r8a779a0 Date: Tue, 7 Sep 2021 00:02:17 +0000 [thread overview] Message-ID: <TY2PR01MB36928CB43B188D4082829A1FD8D39@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdXwf0_+VKfuiFQf6roZErz-JAm06P5RBzD-Jwm1uk=p9A@mail.gmail.com> Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, September 7, 2021 12:34 AM > > Hi Shimoda-san, > > On Wed, Sep 1, 2021 at 12:27 PM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Add support for r8a779a0 (R-Car V3U). The IPMMU hardware design > > of this SoC differs than others. So, add a new ipmmu_features for it. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > --- a/drivers/iommu/ipmmu-vmsa.c > > +++ b/drivers/iommu/ipmmu-vmsa.c > > > @@ -922,6 +922,20 @@ static const struct ipmmu_features ipmmu_features_rcar_gen3 = { > > .utlb_offset_base = 0, > > }; > > > > +static const struct ipmmu_features ipmmu_features_r8a779a0 = { > > + .use_ns_alias_offset = false, > > + .has_cache_leaf_nodes = true, > > + .number_of_contexts = 8, > > Shouldn't this be 16? > Or do you plan to add support for more than 8 contexts later, as that > would require increasing IPMMU_CTX_MAX, and updating ipmmu_ctx_reg() > to handle the second bank of 8 contexts? I would like to add support for more than 8 contexts later because I realized that ctx_offset_{base,stride} are not suitable for the second bank of 8 contexts... > Regardless, I assume this will still work when when limiting to 8 > contexts, so > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for your review! Best regards, Yoshihiro Shimoda _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-09-07 0:02 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-01 10:27 [PATCH 0/2] iommu/ipmmu-vmsa: Add support for r8a779a0 Yoshihiro Shimoda 2021-09-01 10:27 ` Yoshihiro Shimoda 2021-09-01 10:27 ` [PATCH 1/2] dt-bindings: iommu: renesas,ipmmu-vmsa: add r8a779a0 support Yoshihiro Shimoda 2021-09-01 10:27 ` [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: " Yoshihiro Shimoda 2021-09-03 19:50 ` [PATCH 1/2] dt-bindings: iommu: renesas,ipmmu-vmsa: " Rob Herring 2021-09-03 19:50 ` [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: " Rob Herring 2021-09-06 15:31 ` [PATCH 1/2] dt-bindings: iommu: renesas,ipmmu-vmsa: " Geert Uytterhoeven 2021-09-06 15:31 ` [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: " Geert Uytterhoeven 2021-09-01 10:27 ` [PATCH 2/2] iommu/ipmmu-vmsa: Add support for r8a779a0 Yoshihiro Shimoda 2021-09-01 10:27 ` Yoshihiro Shimoda 2021-09-06 15:33 ` Geert Uytterhoeven 2021-09-06 15:33 ` Geert Uytterhoeven 2021-09-07 0:02 ` Yoshihiro Shimoda [this message] 2021-09-07 0:02 ` Yoshihiro Shimoda 2021-09-07 6:33 ` Geert Uytterhoeven 2021-09-07 6:33 ` Geert Uytterhoeven 2021-09-07 7:28 ` Yoshihiro Shimoda 2021-09-07 7:28 ` Yoshihiro Shimoda 2021-09-07 7:36 ` Geert Uytterhoeven 2021-09-07 7:36 ` Geert Uytterhoeven 2021-09-30 8:51 ` [PATCH 0/2] " Geert Uytterhoeven 2021-09-30 8:51 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TY2PR01MB36928CB43B188D4082829A1FD8D39@TY2PR01MB3692.jpnprd01.prod.outlook.com \ --to=yoshihiro.shimoda.uh@renesas.com \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.