* [PATCH 0/2] treewide: Add CAN support for r8a77961
@ 2021-03-12 2:54 Yoshihiro Shimoda
2021-03-12 2:54 ` [PATCH 1/2] dt-bindings: net: can: rcar_can: Document r8a77961 support Yoshihiro Shimoda
2021-03-12 2:54 ` [PATCH 2/2] arm64: dts: renesas: r8a77961: Add CAN nodes Yoshihiro Shimoda
0 siblings, 2 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2021-03-12 2:54 UTC (permalink / raw)
To: geert+renesas, magnus.damm, robh+dt
Cc: linux-renesas-soc, yusuke.goda.sx, devicetree, Yoshihiro Shimoda
This patch series is based on renesas-drivers-2021-02-16-v5.11 tag.
And, Goda-san tested this patch series on R-Car M3-W+ StarterKit board
with Kingfisher. (Thank you Goda-san!)
Yoshihiro Shimoda (2):
dt-bindings: net: can: rcar_can: Document r8a77961 support
arm64: dts: renesas: r8a77961: Add CAN nodes
.../devicetree/bindings/net/can/rcar_can.txt | 1 +
arch/arm64/boot/dts/renesas/r8a77961.dtsi | 26 +++++++++++++++++--
2 files changed, 25 insertions(+), 2 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: net: can: rcar_can: Document r8a77961 support
2021-03-12 2:54 [PATCH 0/2] treewide: Add CAN support for r8a77961 Yoshihiro Shimoda
@ 2021-03-12 2:54 ` Yoshihiro Shimoda
2021-03-12 7:57 ` Geert Uytterhoeven
2021-03-12 2:54 ` [PATCH 2/2] arm64: dts: renesas: r8a77961: Add CAN nodes Yoshihiro Shimoda
1 sibling, 1 reply; 6+ messages in thread
From: Yoshihiro Shimoda @ 2021-03-12 2:54 UTC (permalink / raw)
To: geert+renesas, magnus.damm, robh+dt
Cc: linux-renesas-soc, yusuke.goda.sx, devicetree, Yoshihiro Shimoda
Document SoC specific bindings for R-Car M3-W+ (r8a77961) SoC.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Documentation/devicetree/bindings/net/can/rcar_can.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt
index 6a5956347816..75ef55aa361b 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
@@ -20,6 +20,7 @@ Required properties:
"renesas,can-r8a7794" if CAN controller is a part of R8A7794 SoC.
"renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC.
"renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC.
+ "renesas,can-r8a77961" if CAN controller is a part of R8A77961 SoC.
"renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC.
"renesas,can-r8a77990" if CAN controller is a part of R8A77990 SoC.
"renesas,can-r8a77995" if CAN controller is a part of R8A77995 SoC.
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: r8a77961: Add CAN nodes
2021-03-12 2:54 [PATCH 0/2] treewide: Add CAN support for r8a77961 Yoshihiro Shimoda
2021-03-12 2:54 ` [PATCH 1/2] dt-bindings: net: can: rcar_can: Document r8a77961 support Yoshihiro Shimoda
@ 2021-03-12 2:54 ` Yoshihiro Shimoda
2021-03-12 8:03 ` Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Yoshihiro Shimoda @ 2021-03-12 2:54 UTC (permalink / raw)
To: geert+renesas, magnus.damm, robh+dt
Cc: linux-renesas-soc, yusuke.goda.sx, devicetree, Yoshihiro Shimoda
Add the device nodes for all CAN nodes on R-Car M3-W+.
Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a77961.dtsi | 26 +++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
index e8c31ebec097..d44b7fef1e8e 100644
--- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
@@ -1155,13 +1155,35 @@ avb: ethernet@e6800000 {
};
can0: can@e6c30000 {
+ compatible = "renesas,can-r8a77961",
+ "renesas,rcar-gen3-can";
reg = <0 0xe6c30000 0 0x1000>;
- /* placeholder */
+ interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 916>,
+ <&cpg CPG_CORE R8A77961_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "clkp1", "clkp2", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A77961_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
+ resets = <&cpg 916>;
+ status = "disabled";
};
can1: can@e6c38000 {
+ compatible = "renesas,can-r8a77961",
+ "renesas,rcar-gen3-can";
reg = <0 0xe6c38000 0 0x1000>;
- /* placeholder */
+ interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 915>,
+ <&cpg CPG_CORE R8A77961_CLK_CANFD>,
+ <&can_clk>;
+ clock-names = "clkp1", "clkp2", "can_clk";
+ assigned-clocks = <&cpg CPG_CORE R8A77961_CLK_CANFD>;
+ assigned-clock-rates = <40000000>;
+ power-domains = <&sysc R8A77961_PD_ALWAYS_ON>;
+ resets = <&cpg 915>;
+ status = "disabled";
};
pwm0: pwm@e6e30000 {
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: can: rcar_can: Document r8a77961 support
2021-03-12 2:54 ` [PATCH 1/2] dt-bindings: net: can: rcar_can: Document r8a77961 support Yoshihiro Shimoda
@ 2021-03-12 7:57 ` Geert Uytterhoeven
2021-03-12 8:50 ` Yoshihiro Shimoda
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-03-12 7:57 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Magnus Damm, Rob Herring, Linux-Renesas, Yusuke Goda,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Shimoda-san,
On Fri, Mar 12, 2021 at 3:54 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Document SoC specific bindings for R-Car M3-W+ (r8a77961) SoC.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> @@ -20,6 +20,7 @@ Required properties:
> "renesas,can-r8a7794" if CAN controller is a part of R8A7794 SoC.
> "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC.
> "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC.
> + "renesas,can-r8a77961" if CAN controller is a part of R8A77961 SoC.
> "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC.
> "renesas,can-r8a77990" if CAN controller is a part of R8A77990 SoC.
> "renesas,can-r8a77995" if CAN controller is a part of R8A77995 SoC.
You forgot to add R8A77961 to the paragraph about required properties.
As R8A7796 is now called R8A77960, please update those references, too.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: r8a77961: Add CAN nodes
2021-03-12 2:54 ` [PATCH 2/2] arm64: dts: renesas: r8a77961: Add CAN nodes Yoshihiro Shimoda
@ 2021-03-12 8:03 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-03-12 8:03 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: Magnus Damm, Rob Herring, Linux-Renesas, Yusuke Goda,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Fri, Mar 12, 2021 at 3:54 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Add the device nodes for all CAN nodes on R-Car M3-W+.
>
> Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.13.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/2] dt-bindings: net: can: rcar_can: Document r8a77961 support
2021-03-12 7:57 ` Geert Uytterhoeven
@ 2021-03-12 8:50 ` Yoshihiro Shimoda
0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2021-03-12 8:50 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Magnus Damm, Rob Herring, Linux-Renesas, Yusuke Goda,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Friday, March 12, 2021 4:57 PM
> On Fri, Mar 12, 2021 at 3:54 AM Yoshihiro Shimoda
> > Document SoC specific bindings for R-Car M3-W+ (r8a77961) SoC.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > @@ -20,6 +20,7 @@ Required properties:
> > "renesas,can-r8a7794" if CAN controller is a part of R8A7794 SoC.
> > "renesas,can-r8a7795" if CAN controller is a part of R8A7795 SoC.
> > "renesas,can-r8a7796" if CAN controller is a part of R8A7796 SoC.
> > + "renesas,can-r8a77961" if CAN controller is a part of R8A77961 SoC.
> > "renesas,can-r8a77965" if CAN controller is a part of R8A77965 SoC.
> > "renesas,can-r8a77990" if CAN controller is a part of R8A77990 SoC.
> > "renesas,can-r8a77995" if CAN controller is a part of R8A77995 SoC.
>
> You forgot to add R8A77961 to the paragraph about required properties.
> As R8A7796 is now called R8A77960, please update those references, too.
Oops. Thank you for your review!
I'll update this patch series.
Best regards,
Yoshihiro Shimoda
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-12 8:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 2:54 [PATCH 0/2] treewide: Add CAN support for r8a77961 Yoshihiro Shimoda
2021-03-12 2:54 ` [PATCH 1/2] dt-bindings: net: can: rcar_can: Document r8a77961 support Yoshihiro Shimoda
2021-03-12 7:57 ` Geert Uytterhoeven
2021-03-12 8:50 ` Yoshihiro Shimoda
2021-03-12 2:54 ` [PATCH 2/2] arm64: dts: renesas: r8a77961: Add CAN nodes Yoshihiro Shimoda
2021-03-12 8:03 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.