BUG report on next-20190122: could not probe the ravb driver

BUG report on next-20190122: could not probe the ravb driver

[Yoshihiro Shimoda]

Hi,

I got a report from test team that next-20190122 could not probe the ravb driver as the following.
The test team is using H3 ES3.0 Salvator-XS and I could also reproduce this issue on M3-N Salvator-XS.

[ 3.005557] ravb e6800000.ethernet: ignoring dependency for device, assuming no driver 
[ 3.013863] libphy: ravb_mii: probed 
[ 3.017743] mdio_bus e6800000.ethernet-ffffffff:00: error -2 loading PHY driver module for ID 0x00221622 
[ 3.027283] ravb e6800000.ethernet: failed to initialize MDIO 
[ 3.033157] ravb: probe of e6800000.ethernet failed with error -2

# I didn't investigate this issue yet though...

Best regards,
Yoshihiro Shimoda

Re: BUG report on next-20190122: could not probe the ravb driver

[Geert Uytterhoeven]

Hi Shimoda-san,

On Tue, Jan 22, 2019 at 11:23 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> I got a report from test team that next-20190122 could not probe the ravb driver as the following.
> The test team is using H3 ES3.0 Salvator-XS and I could also reproduce this issue on M3-N Salvator-XS.
>
> [ 3.005557] ravb e6800000.ethernet: ignoring dependency for device, assuming no driver
> [ 3.013863] libphy: ravb_mii: probed
> [ 3.017743] mdio_bus e6800000.ethernet-ffffffff:00: error -2 loading PHY driver module for ID 0x00221622
> [ 3.027283] ravb e6800000.ethernet: failed to initialize MDIO
> [ 3.033157] ravb: probe of e6800000.ethernet failed with error -2
>
> # I didn't investigate this issue yet though...

Looks like other people see this on other SoCs, too.
But I didn't see a solution mentioned in those threads.

FWIW, I'm not seeing it with the soon-to-be-released renesas-drivers of
today, so the breakage is not in net-next.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: BUG report on next-20190122: could not probe the ravb driver

[Yoshihiro Shimoda]

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Tuesday, January 22, 2019 7:59 PM
> 
> Hi Shimoda-san,
> 
> On Tue, Jan 22, 2019 at 11:23 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > I got a report from test team that next-20190122 could not probe the ravb driver as the following.
> > The test team is using H3 ES3.0 Salvator-XS and I could also reproduce this issue on M3-N Salvator-XS.
> >
> > [ 3.005557] ravb e6800000.ethernet: ignoring dependency for device, assuming no driver
> > [ 3.013863] libphy: ravb_mii: probed
> > [ 3.017743] mdio_bus e6800000.ethernet-ffffffff:00: error -2 loading PHY driver module for ID 0x00221622
> > [ 3.027283] ravb e6800000.ethernet: failed to initialize MDIO
> > [ 3.033157] ravb: probe of e6800000.ethernet failed with error -2
> >
> > # I didn't investigate this issue yet though...
> 
> Looks like other people see this on other SoCs, too.
> But I didn't see a solution mentioned in those threads.

Oh, I got it.

> FWIW, I'm not seeing it with the soon-to-be-released renesas-drivers of
> today, so the breakage is not in net-next.

It's good news! I had worried about this renesas-drivers :)

Best regards,
Yoshihiro Shimoda

Re: BUG report on next-20190122: could not probe the ravb driver

[Geert Uytterhoeven]

Hi Shimoda-san,

On Tue, Jan 22, 2019 at 12:06 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Geert Uytterhoeven, Sent: Tuesday, January 22, 2019 7:59 PM
> > On Tue, Jan 22, 2019 at 11:23 AM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > I got a report from test team that next-20190122 could not probe the ravb driver as the following.
> > > The test team is using H3 ES3.0 Salvator-XS and I could also reproduce this issue on M3-N Salvator-XS.
> > >
> > > [ 3.005557] ravb e6800000.ethernet: ignoring dependency for device, assuming no driver
> > > [ 3.013863] libphy: ravb_mii: probed
> > > [ 3.017743] mdio_bus e6800000.ethernet-ffffffff:00: error -2 loading PHY driver module for ID 0x00221622
> > > [ 3.027283] ravb e6800000.ethernet: failed to initialize MDIO
> > > [ 3.033157] ravb: probe of e6800000.ethernet failed with error -2
> > >
> > > # I didn't investigate this issue yet though...
> >
> > Looks like other people see this on other SoCs, too.
> > But I didn't see a solution mentioned in those threads.
>
> Oh, I got it.
>
> > FWIW, I'm not seeing it with the soon-to-be-released renesas-drivers of
> > today, so the breakage is not in net-next.
>
> It's good news! I had worried about this renesas-drivers :)

Unfortunately I have to amend my comment above: while the issue does not
happen with renesas_defconfig or shmobile_defconfig, it do see such failures
with other board-specific configs. Will investigate...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: BUG report on next-20190122: could not probe the ravb driver

[Geert Uytterhoeven]

Hi Shimoda-san,

On Tue, Jan 22, 2019 at 2:16 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Jan 22, 2019 at 12:06 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > From: Geert Uytterhoeven, Sent: Tuesday, January 22, 2019 7:59 PM
> > > On Tue, Jan 22, 2019 at 11:23 AM Yoshihiro Shimoda
> > > <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > > I got a report from test team that next-20190122 could not probe the ravb driver as the following.
> > > > The test team is using H3 ES3.0 Salvator-XS and I could also reproduce this issue on M3-N Salvator-XS.
> > > >
> > > > [ 3.005557] ravb e6800000.ethernet: ignoring dependency for device, assuming no driver
> > > > [ 3.013863] libphy: ravb_mii: probed
> > > > [ 3.017743] mdio_bus e6800000.ethernet-ffffffff:00: error -2 loading PHY driver module for ID 0x00221622
> > > > [ 3.027283] ravb e6800000.ethernet: failed to initialize MDIO
> > > > [ 3.033157] ravb: probe of e6800000.ethernet failed with error -2
> > > >
> > > > # I didn't investigate this issue yet though...
> > >
> > > Looks like other people see this on other SoCs, too.
> > > But I didn't see a solution mentioned in those threads.
> >
> > Oh, I got it.
> >
> > > FWIW, I'm not seeing it with the soon-to-be-released renesas-drivers of
> > > today, so the breakage is not in net-next.
> >
> > It's good news! I had worried about this renesas-drivers :)
>
> Unfortunately I have to amend my comment above: while the issue does not
> happen with renesas_defconfig or shmobile_defconfig, it do see such failures

Both have CONFIG_MODULES=n.

> with other board-specific configs. Will investigate...

With CONFIG_MODULES=y, the issue happens.
Please revert commit 13d0ab6750b20957 ("net: phy: check return code when
requesting PHY driver module") to fix it (for now).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds