From: Shengyu Qu <wiagn233@outlook.com>
To: Michael Tretter <m.tretter@pengutronix.de>,
devicetree@vger.kernel.org, ezequiel@vanguardiasur.com.ar,
frattaroli.nicolas@gmail.com, heiko@sntech.de,
jacob-chen@iotwrt.com, krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, mchehab@kernel.org,
robh+dt@kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH RESEND 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x
Date: Sat, 18 Feb 2023 00:01:19 +0800 [thread overview]
Message-ID: <TY3P286MB26118906837CC416FA56AA0698A19@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230217153214.GB28242@pengutronix.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 595 bytes --]
Hi, Michael,
> I don't think the GFP_DMA32 flag works with DmaBuf import. The buffer may be
> allocated by some other driver that is able to address more than 4G and
> imported into the RGA driver. In this case, limiting the allocations is not
> enough, but we would still need error handling in the map function for buffers
> that cannot be addressed by the RGA.
>
> I guess we need both, a limit for the allocation and error checking for the
> map.
Maybe you are right.. I haven't digged into v4l2-m2m API, so I'm not
sure about
it. Seems we need others' help.
Shengyu
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Shengyu Qu <wiagn233@outlook.com>
To: Michael Tretter <m.tretter@pengutronix.de>,
devicetree@vger.kernel.org, ezequiel@vanguardiasur.com.ar,
frattaroli.nicolas@gmail.com, heiko@sntech.de,
jacob-chen@iotwrt.com, krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, mchehab@kernel.org,
robh+dt@kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH RESEND 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x
Date: Sat, 18 Feb 2023 00:01:19 +0800 [thread overview]
Message-ID: <TY3P286MB26118906837CC416FA56AA0698A19@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230217153214.GB28242@pengutronix.de>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 595 bytes --]
Hi, Michael,
> I don't think the GFP_DMA32 flag works with DmaBuf import. The buffer may be
> allocated by some other driver that is able to address more than 4G and
> imported into the RGA driver. In this case, limiting the allocations is not
> enough, but we would still need error handling in the map function for buffers
> that cannot be addressed by the RGA.
>
> I guess we need both, a limit for the allocation and error checking for the
> map.
Maybe you are right.. I haven't digged into v4l2-m2m API, so I'm not
sure about
it. Seems we need others' help.
Shengyu
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Shengyu Qu <wiagn233@outlook.com>
To: Michael Tretter <m.tretter@pengutronix.de>,
devicetree@vger.kernel.org, ezequiel@vanguardiasur.com.ar,
frattaroli.nicolas@gmail.com, heiko@sntech.de,
jacob-chen@iotwrt.com, krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, mchehab@kernel.org,
robh+dt@kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH RESEND 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x
Date: Sat, 18 Feb 2023 00:01:19 +0800 [thread overview]
Message-ID: <TY3P286MB26118906837CC416FA56AA0698A19@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230217153214.GB28242@pengutronix.de>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 595 bytes --]
Hi, Michael,
> I don't think the GFP_DMA32 flag works with DmaBuf import. The buffer may be
> allocated by some other driver that is able to address more than 4G and
> imported into the RGA driver. In this case, limiting the allocations is not
> enough, but we would still need error handling in the map function for buffers
> that cannot be addressed by the RGA.
>
> I guess we need both, a limit for the allocation and error checking for the
> map.
Maybe you are right.. I haven't digged into v4l2-m2m API, so I'm not
sure about
it. Seems we need others' help.
Shengyu
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-17 16:01 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 9:14 [PATCH RESEND 0/2] media: rockchip: rga: Add rk3568 support Michael Tretter
2023-01-20 9:14 ` Michael Tretter
2023-01-20 9:14 ` Michael Tretter
2023-01-20 9:14 ` [PATCH RESEND 1/2] media: dt-bindings: media: rockchip-rga: add rockchip,rk3568-rga Michael Tretter
2023-01-20 9:14 ` Michael Tretter
2023-01-20 9:14 ` Michael Tretter
2023-01-20 9:28 ` Heiko Stübner
2023-01-20 9:28 ` Heiko Stübner
2023-01-20 9:28 ` Heiko Stübner
2023-01-25 11:47 ` Ezequiel Garcia
2023-01-25 11:47 ` Ezequiel Garcia
2023-01-25 11:47 ` Ezequiel Garcia
2023-01-20 9:14 ` [PATCH RESEND 2/2] arm64: dts: rockchip: Add RGA2 support to rk356x Michael Tretter
2023-01-20 9:14 ` Michael Tretter
2023-01-20 9:14 ` Michael Tretter
2023-01-21 16:50 ` Shengyu Qu
2023-01-21 16:50 ` Shengyu Qu
2023-01-21 16:50 ` Shengyu Qu
2023-02-17 11:04 ` Michael Tretter
2023-02-17 11:04 ` Michael Tretter
2023-02-17 11:04 ` Michael Tretter
2023-02-17 14:14 ` Shengyu Qu
2023-02-17 14:14 ` Shengyu Qu
2023-02-17 14:14 ` Shengyu Qu
2023-02-17 15:32 ` Michael Tretter
2023-02-17 15:32 ` Michael Tretter
2023-02-17 15:32 ` Michael Tretter
2023-02-17 16:01 ` Shengyu Qu [this message]
2023-02-17 16:01 ` Shengyu Qu
2023-02-17 16:01 ` Shengyu Qu
2023-05-17 18:39 ` Sakari Ailus
2023-05-17 18:39 ` Sakari Ailus
2023-05-17 18:39 ` Sakari Ailus
2023-05-21 10:46 ` Heiko Stübner
2023-05-21 10:46 ` Heiko Stübner
2023-05-21 10:46 ` Heiko Stübner
2023-05-22 8:58 ` Sakari Ailus
2023-05-22 8:58 ` Sakari Ailus
2023-05-22 8:58 ` Sakari Ailus
2023-01-23 19:49 ` [PATCH RESEND 0/2] media: rockchip: rga: Add rk3568 support Nicolas Dufresne
2023-01-23 19:49 ` Nicolas Dufresne
2023-01-23 19:49 ` Nicolas Dufresne
2023-05-21 10:44 ` Heiko Stuebner
2023-05-21 10:44 ` Heiko Stuebner
2023-05-21 10:44 ` Heiko Stuebner
2023-05-21 19:32 ` Diederik de Haas
2023-05-21 19:32 ` Diederik de Haas
2023-05-21 19:32 ` Diederik de Haas
2023-05-22 10:29 ` Michael Tretter
2023-05-22 10:29 ` Michael Tretter
2023-05-22 10:29 ` Michael Tretter
2023-05-23 11:13 ` Robin Murphy
2023-05-23 11:13 ` Robin Murphy
2023-05-23 11:13 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY3P286MB26118906837CC416FA56AA0698A19@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM \
--to=wiagn233@outlook.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.tretter@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.