[PATCH 0/2] Add R-Car gen3 SoC support to the CMT driver

[PATCH 0/2] Add R-Car gen3 SoC support to the CMT driver

[Sergei Shtylyov]

Hello!

Here's the set of 2 patches against the 'tip.git' repo's 'timers/core' branch
plus the driver fixup for the 64-bit machines posted recently. We're adding
support for the CMT0 and CMT1 found in the R-Car gen3 SoCs.

[1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer
[2/2] clocksource: sh_cmt: add R-Car gen3 support

MBR, Sergei

[PATCH 0/2] Add R-Car gen3 SoC support to the CMT driver

[Sergei Shtylyov]

Hello!

Here's the set of 2 patches against the 'tip.git' repo's 'timers/core' branch
plus the driver fixup for the 64-bit machines posted recently. We're adding
support for the CMT0 and CMT1 found in the R-Car gen3 SoCs.

[1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer
[2/2] clocksource: sh_cmt: add R-Car gen3 support

MBR, Sergei

[PATCH 1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer

[Sergei Shtylyov]

There's no good reason for the sh_cmt_of_table[] initializer to
violate the 80-column limit, especially after the commit 8d50e9476bb4
("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated")
partially fixed it -- fix the R-Car gen2 related entries as well.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/clocksource/sh_cmt.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Index: renesas/drivers/clocksource/sh_cmt.c
=================================--- renesas.orig/drivers/clocksource/sh_cmt.c
+++ renesas/drivers/clocksource/sh_cmt.c
@@ -937,8 +937,14 @@ static const struct of_device_id sh_cmt_
 		.compatible = "renesas,cmt-48-gen2",
 		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
 	},
-	{ .compatible = "renesas,rcar-gen2-cmt0", .data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] },
-	{ .compatible = "renesas,rcar-gen2-cmt1", .data = &sh_cmt_info[SH_CMT1_RCAR_GEN2] },
+	{
+		.compatible = "renesas,rcar-gen2-cmt0",
+		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
+	},
+	{
+		.compatible = "renesas,rcar-gen2-cmt1",
+		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

[PATCH 1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer

[Sergei Shtylyov]

There's no good reason for the sh_cmt_of_table[] initializer to
violate the 80-column limit, especially after the commit 8d50e9476bb4
("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated")
partially fixed it -- fix the R-Car gen2 related entries as well.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/clocksource/sh_cmt.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Index: renesas/drivers/clocksource/sh_cmt.c
===================================================================
--- renesas.orig/drivers/clocksource/sh_cmt.c
+++ renesas/drivers/clocksource/sh_cmt.c
@@ -937,8 +937,14 @@ static const struct of_device_id sh_cmt_
 		.compatible = "renesas,cmt-48-gen2",
 		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
 	},
-	{ .compatible = "renesas,rcar-gen2-cmt0", .data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] },
-	{ .compatible = "renesas,rcar-gen2-cmt1", .data = &sh_cmt_info[SH_CMT1_RCAR_GEN2] },
+	{
+		.compatible = "renesas,rcar-gen2-cmt0",
+		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
+	},
+	{
+		.compatible = "renesas,rcar-gen2-cmt1",
+		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

[PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
bindings as these are the R-Car gen3 SoCs for which the initial support
was done.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 Documentation/devicetree/bindings/timer/renesas,cmt.txt |    7 +++++++
 drivers/clocksource/sh_cmt.c                            |    8 ++++++++
 2 files changed, 15 insertions(+)

Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
=================================--- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt
+++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
@@ -34,6 +34,10 @@ Required Properties:
     - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793.
     - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
     - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
+    - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in r8a77970.
+    - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in r8a77970.
+    - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in r8a77980.
+    - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in r8a77980.
 
     - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
 		and RZ/G1.
@@ -41,6 +45,9 @@ Required Properties:
 		and RZ/G1.
 		These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1 entries
 		listed above.
+    - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car Gen3.
+    - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car Gen3.
+		These are fallbacks for R-Car Gen3 entries listed above.
 
   - reg: base address and length of the registers block for the timer module.
   - interrupts: interrupt-specifier for the timer, one per channel.
Index: renesas/drivers/clocksource/sh_cmt.c
=================================--- renesas.orig/drivers/clocksource/sh_cmt.c
+++ renesas/drivers/clocksource/sh_cmt.c
@@ -945,6 +945,14 @@ static const struct of_device_id sh_cmt_
 		.compatible = "renesas,rcar-gen2-cmt1",
 		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
 	},
+	{
+		.compatible = "renesas,rcar-gen3-cmt0",
+		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
+	},
+	{
+		.compatible = "renesas,rcar-gen3-cmt1",
+		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

[PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
bindings as these are the R-Car gen3 SoCs for which the initial support
was done.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 Documentation/devicetree/bindings/timer/renesas,cmt.txt |    7 +++++++
 drivers/clocksource/sh_cmt.c                            |    8 ++++++++
 2 files changed, 15 insertions(+)

Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
===================================================================
--- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt
+++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
@@ -34,6 +34,10 @@ Required Properties:
     - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793.
     - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
     - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
+    - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in r8a77970.
+    - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in r8a77970.
+    - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in r8a77980.
+    - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in r8a77980.
 
     - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
 		and RZ/G1.
@@ -41,6 +45,9 @@ Required Properties:
 		and RZ/G1.
 		These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1 entries
 		listed above.
+    - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car Gen3.
+    - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car Gen3.
+		These are fallbacks for R-Car Gen3 entries listed above.
 
   - reg: base address and length of the registers block for the timer module.
   - interrupts: interrupt-specifier for the timer, one per channel.
Index: renesas/drivers/clocksource/sh_cmt.c
===================================================================
--- renesas.orig/drivers/clocksource/sh_cmt.c
+++ renesas/drivers/clocksource/sh_cmt.c
@@ -945,6 +945,14 @@ static const struct of_device_id sh_cmt_
 		.compatible = "renesas,rcar-gen2-cmt1",
 		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
 	},
+	{
+		.compatible = "renesas,rcar-gen3-cmt0",
+		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
+	},
+	{
+		.compatible = "renesas,rcar-gen3-cmt1",
+		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

RE: [PATCH 1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer

[Chris Paterson]

SGVsbG8gU2VyZ2VpLA0KDQo+IEZyb206IGxpbnV4LXNoLW93bmVyQHZnZXIua2VybmVsLm9yZyA8
bGludXgtc2gtb3duZXJAdmdlci5rZXJuZWwub3JnPg0KPiBPbiBCZWhhbGYgT2YgU2VyZ2VpIFNo
dHlseW92DQo+IFNlbnQ6IDA1IFNlcHRlbWJlciAyMDE4IDIxOjMxDQo+IA0KPiBUaGVyZSdzIG5v
IGdvb2QgcmVhc29uIGZvciB0aGUgc2hfY210X29mX3RhYmxlW10gaW5pdGlhbGl6ZXIgdG8gdmlv
bGF0ZSB0aGUgODAtDQo+IGNvbHVtbiBsaW1pdCwgZXNwZWNpYWxseSBhZnRlciB0aGUgY29tbWl0
IDhkNTBlOTQ3NmJiNA0KPiAoImNsb2Nrc291cmNlL2RyaXZlcnMvc2hfY210OiBNYXJrICJyZW5l
c2FzLGNtdC00OC1nZW4yIiBkZXByZWNhdGVkIikNCj4gcGFydGlhbGx5IGZpeGVkIGl0IC0tIGZp
eCB0aGUgUi1DYXIgZ2VuMiByZWxhdGVkIGVudHJpZXMgYXMgd2VsbC4NCg0KU2VlbXMgc2Vuc2li
bGUgdG8gbWUuDQoNClJldmlld2VkLWJ5OiBDaHJpcyBQYXRlcnNvbiA8Y2hyaXMucGF0ZXJzb24y
QHJlbmVzYXMuY29tPg0KDQpLaW5kIHJlZ2FyZHMsIENocmlzDQoNCj4gDQo+IFNpZ25lZC1vZmYt
Ynk6IFNlcmdlaSBTaHR5bHlvdiA8c2VyZ2VpLnNodHlseW92QGNvZ2VudGVtYmVkZGVkLmNvbT4N
Cj4gDQo+IC0tLQ0KPiAgZHJpdmVycy9jbG9ja3NvdXJjZS9zaF9jbXQuYyB8ICAgMTAgKysrKysr
KystLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkN
Cj4gDQo+IEluZGV4OiByZW5lc2FzL2RyaXZlcnMvY2xvY2tzb3VyY2Uvc2hfY210LmMNCj4gPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
PiA9PT09PT09PT0NCj4gLS0tIHJlbmVzYXMub3JpZy9kcml2ZXJzL2Nsb2Nrc291cmNlL3NoX2Nt
dC5jDQo+ICsrKyByZW5lc2FzL2RyaXZlcnMvY2xvY2tzb3VyY2Uvc2hfY210LmMNCj4gQEAgLTkz
Nyw4ICs5MzcsMTQgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgc2hfY210Xw0K
PiAgCQkuY29tcGF0aWJsZSA9ICJyZW5lc2FzLGNtdC00OC1nZW4yIiwNCj4gIAkJLmRhdGEgPSAm
c2hfY210X2luZm9bU0hfQ01UMF9SQ0FSX0dFTjJdDQo+ICAJfSwNCj4gLQl7IC5jb21wYXRpYmxl
ID0gInJlbmVzYXMscmNhci1nZW4yLWNtdDAiLCAuZGF0YSA9DQo+ICZzaF9jbXRfaW5mb1tTSF9D
TVQwX1JDQVJfR0VOMl0gfSwNCj4gLQl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMscmNhci1nZW4y
LWNtdDEiLCAuZGF0YSA9DQo+ICZzaF9jbXRfaW5mb1tTSF9DTVQxX1JDQVJfR0VOMl0gfSwNCj4g
Kwl7DQo+ICsJCS5jb21wYXRpYmxlID0gInJlbmVzYXMscmNhci1nZW4yLWNtdDAiLA0KPiArCQku
ZGF0YSA9ICZzaF9jbXRfaW5mb1tTSF9DTVQwX1JDQVJfR0VOMl0NCj4gKwl9LA0KPiArCXsNCj4g
KwkJLmNvbXBhdGlibGUgPSAicmVuZXNhcyxyY2FyLWdlbjItY210MSIsDQo+ICsJCS5kYXRhID0g
JnNoX2NtdF9pbmZvW1NIX0NNVDFfUkNBUl9HRU4yXQ0KPiArCX0sDQo+ICAJeyB9DQo+ICB9Ow0K
PiAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgc2hfY210X29mX3RhYmxlKTsNCg=

RE: [PATCH 1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer

[Chris Paterson]

Hello Sergei,

> From: linux-sh-owner@vger.kernel.org <linux-sh-owner@vger.kernel.org>
> On Behalf Of Sergei Shtylyov
> Sent: 05 September 2018 21:31
> 
> There's no good reason for the sh_cmt_of_table[] initializer to violate the 80-
> column limit, especially after the commit 8d50e9476bb4
> ("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated")
> partially fixed it -- fix the R-Car gen2 related entries as well.

Seems sensible to me.

Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>

Kind regards, Chris

> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  drivers/clocksource/sh_cmt.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> Index: renesas/drivers/clocksource/sh_cmt.c
> ==========================================================
> =========
> --- renesas.orig/drivers/clocksource/sh_cmt.c
> +++ renesas/drivers/clocksource/sh_cmt.c
> @@ -937,8 +937,14 @@ static const struct of_device_id sh_cmt_
>  		.compatible = "renesas,cmt-48-gen2",
>  		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
>  	},
> -	{ .compatible = "renesas,rcar-gen2-cmt0", .data =
> &sh_cmt_info[SH_CMT0_RCAR_GEN2] },
> -	{ .compatible = "renesas,rcar-gen2-cmt1", .data =
> &sh_cmt_info[SH_CMT1_RCAR_GEN2] },
> +	{
> +		.compatible = "renesas,rcar-gen2-cmt0",
> +		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
> +	},
> +	{
> +		.compatible = "renesas,rcar-gen2-cmt1",
> +		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
> +	},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

RE: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Chris Paterson]

SGVsbG8gU2VyZ2VpLA0KDQo+IEZyb206IGRldmljZXRyZWUtb3duZXJAdmdlci5rZXJuZWwub3Jn
IDxkZXZpY2V0cmVlLQ0KPiBvd25lckB2Z2VyLmtlcm5lbC5vcmc+IE9uIEJlaGFsZiBPZiBTZXJn
ZWkgU2h0eWx5b3YNCj4gU2VudDogMDUgU2VwdGVtYmVyIDIwMTggMjE6MzINCj4gDQo+IEFkZCBz
dXBwb3J0IGZvciB0aGUgUi1DYXIgZ2VuMyBDTVQwIGFuZCBDTVQxIGJpbmRpbmdzIC0tIHRoZXkg
c2VlbSB0byBiZQ0KPiB0aGUgc2FtZSBDTVQwIGFuZCBDTVQxIGFzIGluIFItQ2FyIGdlbjIgU29D
cy4gQWxzbyBkb2N1bWVudCBSOEE3Nzl7N3w4fQ0KPiBiaW5kaW5ncyBhcyB0aGVzZSBhcmUgdGhl
IFItQ2FyIGdlbjMgU29DcyBmb3Igd2hpY2ggdGhlIGluaXRpYWwgc3VwcG9ydCB3YXMNCj4gZG9u
ZS4NCg0KSXMgaXQgYWxsb3dlZCB0byBjb21iaW5lIHRoZSBiaW5kaW5ncyBkb2MgdXBkYXRlIHdp
dGggdGhlIGRyaXZlciBjaGFuZ2U/IChJIHVzdWFsbHkgZ2V0IGEgY2hlY2twYXRjaCB3YXJuaW5n
IGZvciB0aGlzKS4NCg0KSXQgaXQncyBub3QgYSBwcm9ibGVtOg0KUmV2aWV3ZWQtYnk6IENocmlz
IFBhdGVyc29uIDxjaHJpcy5wYXRlcnNvbjJAcmVuZXNhcy5jb20+DQoNCktpbmQgcmVnYXJkcywg
Q2hyaXMNCg0KPiANCj4gU2lnbmVkLW9mZi1ieTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0
eWx5b3ZAY29nZW50ZW1iZWRkZWQuY29tPg0KPiANCj4gLS0tDQo+ICBEb2N1bWVudGF0aW9uL2Rl
dmljZXRyZWUvYmluZGluZ3MvdGltZXIvcmVuZXNhcyxjbXQudHh0IHwgICAgNyArKysrKysrDQo+
ICBkcml2ZXJzL2Nsb2Nrc291cmNlL3NoX2NtdC5jICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHwgICAgOCArKysrKysrKw0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspDQo+
IA0KPiBJbmRleDogcmVuZXNhcy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGlt
ZXIvcmVuZXNhcyxjbXQudHh0DQo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0NCj4gPT09PT09PT09DQo+IC0tLSByZW5lc2FzLm9yaWcv
RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3RpbWVyL3JlbmVzYXMsY210LnR4dA0K
PiArKysgcmVuZXNhcy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGltZXIvcmVu
ZXNhcyxjbXQudHh0DQo+IEBAIC0zNCw2ICszNCwxMCBAQCBSZXF1aXJlZCBQcm9wZXJ0aWVzOg0K
PiAgICAgIC0gInJlbmVzYXMscjhhNzc5My1jbXQxIiBmb3IgdGhlIDQ4LWJpdCBDTVQxIGRldmlj
ZSBpbmNsdWRlZCBpbiByOGE3NzkzLg0KPiAgICAgIC0gInJlbmVzYXMscjhhNzc5NC1jbXQwIiBm
b3IgdGhlIDMyLWJpdCBDTVQwIGRldmljZSBpbmNsdWRlZCBpbiByOGE3Nzk0Lg0KPiAgICAgIC0g
InJlbmVzYXMscjhhNzc5NC1jbXQxIiBmb3IgdGhlIDQ4LWJpdCBDTVQxIGRldmljZSBpbmNsdWRl
ZCBpbiByOGE3Nzk0Lg0KPiArICAgIC0gInJlbmVzYXMscjhhNzc5NzAtY210MCIgZm9yIHRoZSAz
Mi1iaXQgQ01UMCBkZXZpY2UgaW5jbHVkZWQgaW4NCj4gcjhhNzc5NzAuDQo+ICsgICAgLSAicmVu
ZXNhcyxyOGE3Nzk3MC1jbXQxIiBmb3IgdGhlIDQ4LWJpdCBDTVQxIGRldmljZSBpbmNsdWRlZCBp
bg0KPiByOGE3Nzk3MC4NCj4gKyAgICAtICJyZW5lc2FzLHI4YTc3OTgwLWNtdDAiIGZvciB0aGUg
MzItYml0IENNVDAgZGV2aWNlIGluY2x1ZGVkIGluDQo+IHI4YTc3OTgwLg0KPiArICAgIC0gInJl
bmVzYXMscjhhNzc5ODAtY210MSIgZm9yIHRoZSA0OC1iaXQgQ01UMSBkZXZpY2UgaW5jbHVkZWQg
aW4NCj4gcjhhNzc5ODAuDQo+IA0KPiAgICAgIC0gInJlbmVzYXMscmNhci1nZW4yLWNtdDAiIGZv
ciAzMi1iaXQgQ01UMCBkZXZpY2VzIGluY2x1ZGVkIGluIFItQ2FyIEdlbjINCj4gIAkJYW5kIFJa
L0cxLg0KPiBAQCAtNDEsNiArNDUsOSBAQCBSZXF1aXJlZCBQcm9wZXJ0aWVzOg0KPiAgCQlhbmQg
UlovRzEuDQo+ICAJCVRoZXNlIGFyZSBmYWxsYmFja3MgZm9yIHI4YTczYTQsIFItQ2FyIEdlbjIg
YW5kIFJaL0cxDQo+IGVudHJpZXMNCj4gIAkJbGlzdGVkIGFib3ZlLg0KPiArICAgIC0gInJlbmVz
YXMscmNhci1nZW4zLWNtdDAiIGZvciAzMi1iaXQgQ01UMCBkZXZpY2VzIGluY2x1ZGVkIGluIFIt
Q2FyDQo+IEdlbjMuDQo+ICsgICAgLSAicmVuZXNhcyxyY2FyLWdlbjMtY210MSIgZm9yIDQ4LWJp
dCBDTVQxIGRldmljZXMgaW5jbHVkZWQgaW4gUi1DYXINCj4gR2VuMy4NCj4gKwkJVGhlc2UgYXJl
IGZhbGxiYWNrcyBmb3IgUi1DYXIgR2VuMyBlbnRyaWVzIGxpc3RlZCBhYm92ZS4NCj4gDQo+ICAg
IC0gcmVnOiBiYXNlIGFkZHJlc3MgYW5kIGxlbmd0aCBvZiB0aGUgcmVnaXN0ZXJzIGJsb2NrIGZv
ciB0aGUgdGltZXIgbW9kdWxlLg0KPiAgICAtIGludGVycnVwdHM6IGludGVycnVwdC1zcGVjaWZp
ZXIgZm9yIHRoZSB0aW1lciwgb25lIHBlciBjaGFubmVsLg0KPiBJbmRleDogcmVuZXNhcy9kcml2
ZXJzL2Nsb2Nrc291cmNlL3NoX2NtdC5jDQo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4gPT09PT09PT09DQo+IC0tLSByZW5lc2Fz
Lm9yaWcvZHJpdmVycy9jbG9ja3NvdXJjZS9zaF9jbXQuYw0KPiArKysgcmVuZXNhcy9kcml2ZXJz
L2Nsb2Nrc291cmNlL3NoX2NtdC5jDQo+IEBAIC05NDUsNiArOTQ1LDE0IEBAIHN0YXRpYyBjb25z
dCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHNoX2NtdF8NCj4gIAkJLmNvbXBhdGlibGUgPSAicmVuZXNh
cyxyY2FyLWdlbjItY210MSIsDQo+ICAJCS5kYXRhID0gJnNoX2NtdF9pbmZvW1NIX0NNVDFfUkNB
Ul9HRU4yXQ0KPiAgCX0sDQo+ICsJew0KPiArCQkuY29tcGF0aWJsZSA9ICJyZW5lc2FzLHJjYXIt
Z2VuMy1jbXQwIiwNCj4gKwkJLmRhdGEgPSAmc2hfY210X2luZm9bU0hfQ01UMF9SQ0FSX0dFTjJd
DQo+ICsJfSwNCj4gKwl7DQo+ICsJCS5jb21wYXRpYmxlID0gInJlbmVzYXMscmNhci1nZW4zLWNt
dDEiLA0KPiArCQkuZGF0YSA9ICZzaF9jbXRfaW5mb1tTSF9DTVQxX1JDQVJfR0VOMl0NCj4gKwl9
LA0KPiAgCXsgfQ0KPiAgfTsNCj4gIE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIHNoX2NtdF9vZl90
YWJsZSk7DQo

RE: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Chris Paterson]

Hello Sergei,

> From: devicetree-owner@vger.kernel.org <devicetree-
> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
> Sent: 05 September 2018 21:32
> 
> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
> bindings as these are the R-Car gen3 SoCs for which the initial support was
> done.

Is it allowed to combine the bindings doc update with the driver change? (I usually get a checkpatch warning for this).

It it's not a problem:
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>

Kind regards, Chris

> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  Documentation/devicetree/bindings/timer/renesas,cmt.txt |    7 +++++++
>  drivers/clocksource/sh_cmt.c                            |    8 ++++++++
>  2 files changed, 15 insertions(+)
> 
> Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> ==========================================================
> =========
> --- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> +++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> @@ -34,6 +34,10 @@ Required Properties:
>      - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793.
>      - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
>      - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
> +    - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in
> r8a77970.
> +    - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in
> r8a77970.
> +    - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in
> r8a77980.
> +    - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in
> r8a77980.
> 
>      - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
>  		and RZ/G1.
> @@ -41,6 +45,9 @@ Required Properties:
>  		and RZ/G1.
>  		These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1
> entries
>  		listed above.
> +    - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car
> Gen3.
> +    - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car
> Gen3.
> +		These are fallbacks for R-Car Gen3 entries listed above.
> 
>    - reg: base address and length of the registers block for the timer module.
>    - interrupts: interrupt-specifier for the timer, one per channel.
> Index: renesas/drivers/clocksource/sh_cmt.c
> ==========================================================
> =========
> --- renesas.orig/drivers/clocksource/sh_cmt.c
> +++ renesas/drivers/clocksource/sh_cmt.c
> @@ -945,6 +945,14 @@ static const struct of_device_id sh_cmt_
>  		.compatible = "renesas,rcar-gen2-cmt1",
>  		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
>  	},
> +	{
> +		.compatible = "renesas,rcar-gen3-cmt0",
> +		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
> +	},
> +	{
> +		.compatible = "renesas,rcar-gen3-cmt1",
> +		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
> +	},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

RE: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Biju Das]

SGkgU2VyZ2llLA0KDQpUaGFua3MgZm9yIHRoZSBwYXRjaA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVz
c2FnZS0tLS0tDQo+IEZyb206IGRldmljZXRyZWUtb3duZXJAdmdlci5rZXJuZWwub3JnIDxkZXZp
Y2V0cmVlLQ0KPiBvd25lckB2Z2VyLmtlcm5lbC5vcmc+IE9uIEJlaGFsZiBPZiBTZXJnZWkgU2h0
eWx5b3YNCj4gU2VudDogMDUgU2VwdGVtYmVyIDIwMTggMjE6MzINCj4gVG86IERhbmllbCBMZXpj
YW5vIDxkYW5pZWwubGV6Y2Fub0BsaW5hcm8ub3JnPjsgVGhvbWFzIEdsZWl4bmVyDQo+IDx0Z2x4
QGxpbnV0cm9uaXguZGU+OyBSb2IgSGVycmluZyA8cm9iaCtkdEBrZXJuZWwub3JnPjsNCj4gZGV2
aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmcNCj4gQ2M6IGxpbnV4LXJlbmVzYXMtc29jQHZnZXIua2Vy
bmVsLm9yZzsgbGludXgtc2hAdmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFtQQVRDSCAyLzJd
IGNsb2Nrc291cmNlOiBzaF9jbXQ6IGFkZCBSLUNhciBnZW4zIHN1cHBvcnQNCj4NCj4gQWRkIHN1
cHBvcnQgZm9yIHRoZSBSLUNhciBnZW4zIENNVDAgYW5kIENNVDEgYmluZGluZ3MgLS0gdGhleSBz
ZWVtIHRvIGJlDQo+IHRoZSBzYW1lIENNVDAgYW5kIENNVDEgYXMgaW4gUi1DYXIgZ2VuMiBTb0Nz
LiBBbHNvIGRvY3VtZW50IFI4QTc3OXs3fDh9DQo+IGJpbmRpbmdzIGFzIHRoZXNlIGFyZSB0aGUg
Ui1DYXIgZ2VuMyBTb0NzIGZvciB3aGljaCB0aGUgaW5pdGlhbCBzdXBwb3J0IHdhcw0KPiBkb25l
Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBTZXJnZWkgU2h0eWx5b3YgPHNlcmdlaS5zaHR5bHlvdkBj
b2dlbnRlbWJlZGRlZC5jb20+DQo+DQo+IC0tLQ0KPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl
L2JpbmRpbmdzL3RpbWVyL3JlbmVzYXMsY210LnR4dCB8ICAgIDcgKysrKysrKw0KPiAgZHJpdmVy
cy9jbG9ja3NvdXJjZS9zaF9jbXQuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDgg
KysrKysrKysNCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKQ0KPg0KPiBJbmRl
eDogcmVuZXNhcy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGltZXIvcmVuZXNh
cyxjbXQudHh0DQo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0NCj4gPT09PT09PT09DQo+IC0tLSByZW5lc2FzLm9yaWcvRG9jdW1lbnRh
dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3RpbWVyL3JlbmVzYXMsY210LnR4dA0KPiArKysgcmVu
ZXNhcy9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdGltZXIvcmVuZXNhcyxjbXQu
dHh0DQo+IEBAIC0zNCw2ICszNCwxMCBAQCBSZXF1aXJlZCBQcm9wZXJ0aWVzOg0KPiAgICAgIC0g
InJlbmVzYXMscjhhNzc5My1jbXQxIiBmb3IgdGhlIDQ4LWJpdCBDTVQxIGRldmljZSBpbmNsdWRl
ZCBpbiByOGE3NzkzLg0KPiAgICAgIC0gInJlbmVzYXMscjhhNzc5NC1jbXQwIiBmb3IgdGhlIDMy
LWJpdCBDTVQwIGRldmljZSBpbmNsdWRlZCBpbiByOGE3Nzk0Lg0KPiAgICAgIC0gInJlbmVzYXMs
cjhhNzc5NC1jbXQxIiBmb3IgdGhlIDQ4LWJpdCBDTVQxIGRldmljZSBpbmNsdWRlZCBpbiByOGE3
Nzk0Lg0KPiArICAgIC0gInJlbmVzYXMscjhhNzc5NzAtY210MCIgZm9yIHRoZSAzMi1iaXQgQ01U
MCBkZXZpY2UgaW5jbHVkZWQgaW4NCj4gcjhhNzc5NzAuDQo+ICsgICAgLSAicmVuZXNhcyxyOGE3
Nzk3MC1jbXQxIiBmb3IgdGhlIDQ4LWJpdCBDTVQxIGRldmljZSBpbmNsdWRlZCBpbg0KPiByOGE3
Nzk3MC4NCj4gKyAgICAtICJyZW5lc2FzLHI4YTc3OTgwLWNtdDAiIGZvciB0aGUgMzItYml0IENN
VDAgZGV2aWNlIGluY2x1ZGVkIGluDQo+IHI4YTc3OTgwLg0KPiArICAgIC0gInJlbmVzYXMscjhh
Nzc5ODAtY210MSIgZm9yIHRoZSA0OC1iaXQgQ01UMSBkZXZpY2UgaW5jbHVkZWQgaW4NCj4gcjhh
Nzc5ODAuDQo+DQo+ICAgICAgLSAicmVuZXNhcyxyY2FyLWdlbjItY210MCIgZm9yIDMyLWJpdCBD
TVQwIGRldmljZXMgaW5jbHVkZWQgaW4gUi1DYXIgR2VuMg0KPiAgYW5kIFJaL0cxLg0KPiBAQCAt
NDEsNiArNDUsOSBAQCBSZXF1aXJlZCBQcm9wZXJ0aWVzOg0KPiAgYW5kIFJaL0cxLg0KPiAgVGhl
c2UgYXJlIGZhbGxiYWNrcyBmb3IgcjhhNzNhNCwgUi1DYXIgR2VuMiBhbmQgUlovRzENCj4gZW50
cmllcw0KPiAgbGlzdGVkIGFib3ZlLg0KPiArICAgIC0gInJlbmVzYXMscmNhci1nZW4zLWNtdDAi
IGZvciAzMi1iaXQgQ01UMCBkZXZpY2VzIGluY2x1ZGVkIGluIFItQ2FyDQo+IEdlbjMuDQo+ICsg
ICAgLSAicmVuZXNhcyxyY2FyLWdlbjMtY210MSIgZm9yIDQ4LWJpdCBDTVQxIGRldmljZXMgaW5j
bHVkZWQgaW4gUi1DYXINCg0KIERvIHdlIG5lZWQgdG8gbWVudGlvbiBDTVQxLzIvMyBpbnN0ZWFk
IG9mIENNVDEsIHNpbmNlIENNVDIvMyBpcyBzaW1pbGFyIHRvIENNVDE/DQoNCj4gR2VuMy4NCj4g
K1RoZXNlIGFyZSBmYWxsYmFja3MgZm9yIFItQ2FyIEdlbjMgZW50cmllcyBsaXN0ZWQgYWJvdmUu
DQo+DQo+ICAgIC0gcmVnOiBiYXNlIGFkZHJlc3MgYW5kIGxlbmd0aCBvZiB0aGUgcmVnaXN0ZXJz
IGJsb2NrIGZvciB0aGUgdGltZXIgbW9kdWxlLg0KPiAgICAtIGludGVycnVwdHM6IGludGVycnVw
dC1zcGVjaWZpZXIgZm9yIHRoZSB0aW1lciwgb25lIHBlciBjaGFubmVsLg0KPiBJbmRleDogcmVu
ZXNhcy9kcml2ZXJzL2Nsb2Nrc291cmNlL3NoX2NtdC5jDQo+ID09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCj4gPT09PT09PT09DQo+IC0t
LSByZW5lc2FzLm9yaWcvZHJpdmVycy9jbG9ja3NvdXJjZS9zaF9jbXQuYw0KPiArKysgcmVuZXNh
cy9kcml2ZXJzL2Nsb2Nrc291cmNlL3NoX2NtdC5jDQo+IEBAIC05NDUsNiArOTQ1LDE0IEBAIHN0
YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHNoX2NtdF8NCj4gIC5jb21wYXRpYmxlID0g
InJlbmVzYXMscmNhci1nZW4yLWNtdDEiLA0KPiAgLmRhdGEgPSAmc2hfY210X2luZm9bU0hfQ01U
MV9SQ0FSX0dFTjJdDQo+ICB9LA0KPiArew0KPiArLmNvbXBhdGlibGUgPSAicmVuZXNhcyxyY2Fy
LWdlbjMtY210MCIsDQo+ICsuZGF0YSA9ICZzaF9jbXRfaW5mb1tTSF9DTVQwX1JDQVJfR0VOMl0N
Cj4gK30sDQo+ICt7DQo+ICsuY29tcGF0aWJsZSA9ICJyZW5lc2FzLHJjYXItZ2VuMy1jbXQxIiwN
Cj4gKy5kYXRhID0gJnNoX2NtdF9pbmZvW1NIX0NNVDFfUkNBUl9HRU4yXQ0KPiArfSwNCj4gIHsg
fQ0KPiAgfTsNCj4gIE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIHNoX2NtdF9vZl90YWJsZSk7DQoN
CnJlZ2FyZHMsDQpCaWp1DQoNCg0KDQpSZW5lc2FzIEVsZWN0cm9uaWNzIEV1cm9wZSBMdGQsIER1
a2VzIE1lYWRvdywgTWlsbGJvYXJkIFJvYWQsIEJvdXJuZSBFbmQsIEJ1Y2tpbmdoYW1zaGlyZSwg
U0w4IDVGSCwgVUsuIFJlZ2lzdGVyZWQgaW4gRW5nbGFuZCAmIFdhbGVzIHVuZGVyIFJlZ2lzdGVy
ZWQgTm8uIDA0NTg2NzA5Lg0K

RE: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Biju Das]

Hi Sergie,

Thanks for the patch

> -----Original Message-----
> From: devicetree-owner@vger.kernel.org <devicetree-
> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
> Sent: 05 September 2018 21:32
> To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
> <tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>;
> devicetree@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org; linux-sh@vger.kernel.org
> Subject: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support
>
> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
> bindings as these are the R-Car gen3 SoCs for which the initial support was
> done.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
>  Documentation/devicetree/bindings/timer/renesas,cmt.txt |    7 +++++++
>  drivers/clocksource/sh_cmt.c                            |    8 ++++++++
>  2 files changed, 15 insertions(+)
>
> Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> ==========================================================
> =========
> --- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> +++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> @@ -34,6 +34,10 @@ Required Properties:
>      - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793.
>      - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
>      - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
> +    - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in
> r8a77970.
> +    - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in
> r8a77970.
> +    - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in
> r8a77980.
> +    - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in
> r8a77980.
>
>      - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
>  and RZ/G1.
> @@ -41,6 +45,9 @@ Required Properties:
>  and RZ/G1.
>  These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1
> entries
>  listed above.
> +    - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car
> Gen3.
> +    - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car

 Do we need to mention CMT1/2/3 instead of CMT1, since CMT2/3 is similar to CMT1?

> Gen3.
> +These are fallbacks for R-Car Gen3 entries listed above.
>
>    - reg: base address and length of the registers block for the timer module.
>    - interrupts: interrupt-specifier for the timer, one per channel.
> Index: renesas/drivers/clocksource/sh_cmt.c
> ==========================================================
> =========
> --- renesas.orig/drivers/clocksource/sh_cmt.c
> +++ renesas/drivers/clocksource/sh_cmt.c
> @@ -945,6 +945,14 @@ static const struct of_device_id sh_cmt_
>  .compatible = "renesas,rcar-gen2-cmt1",
>  .data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
>  },
> +{
> +.compatible = "renesas,rcar-gen3-cmt0",
> +.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
> +},
> +{
> +.compatible = "renesas,rcar-gen3-cmt1",
> +.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
> +},
>  { }
>  };
>  MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

regards,
Biju



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer

[Geert Uytterhoeven]

On Wed, Sep 5, 2018 at 10:31 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> There's no good reason for the sh_cmt_of_table[] initializer to
> violate the 80-column limit, especially after the commit 8d50e9476bb4
> ("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated")
> partially fixed it -- fix the R-Car gen2 related entries as well.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] clocksource: sh_cmt: properly line-wrap sh_cmt_of_table[] initializer

[Geert Uytterhoeven]

On Wed, Sep 5, 2018 at 10:31 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> There's no good reason for the sh_cmt_of_table[] initializer to
> violate the 80-column limit, especially after the commit 8d50e9476bb4
> ("clocksource/drivers/sh_cmt: Mark "renesas,cmt-48-gen2" deprecated")
> partially fixed it -- fix the R-Car gen2 related entries as well.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

Hello!

On 09/06/2018 11:27 AM, Biju Das wrote:

>> -----Original Message-----
>> From: devicetree-owner@vger.kernel.org <devicetree-
>> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
>> Sent: 05 September 2018 21:32
>> To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
>> <tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>;
>> devicetree@vger.kernel.org
>> Cc: linux-renesas-soc@vger.kernel.org; linux-sh@vger.kernel.org
>> Subject: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support
>>
>> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
>> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
>> bindings as these are the R-Car gen3 SoCs for which the initial support was
>> done.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>>  Documentation/devicetree/bindings/timer/renesas,cmt.txt |    7 +++++++
>>  drivers/clocksource/sh_cmt.c                            |    8 ++++++++
>>  2 files changed, 15 insertions(+)
>>
>> Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
>> =============================
>> ====>> --- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt
>> +++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
>> @@ -34,6 +34,10 @@ Required Properties:
>>      - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793.
>>      - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
>>      - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
>> +    - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in
>> r8a77970.
>> +    - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in
>> r8a77970.
>> +    - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in
>> r8a77980.
>> +    - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in
>> r8a77980.
>>
>>      - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
>>  and RZ/G1.
>> @@ -41,6 +45,9 @@ Required Properties:
>>  and RZ/G1.
>>  These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1
>> entries
>>  listed above.
>> +    - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car
>> Gen3.
>> +    - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car
> 
>  Do we need to mention CMT1/2/3 instead of CMT1, since CMT2/3 is similar to CMT1?

   Well, the manual only describes CMT0 and CMT1 separately. Perhaps it would have been
clearer to call them CMTT0 and CMTT1 as they stand for Compare Match Timer Type 0/1?
Note at this point we already have a history of describing CMT0/1 only in the bindings
as well...

[...]

MBR, Sergei

Re: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

Hello!

On 09/06/2018 11:27 AM, Biju Das wrote:

>> -----Original Message-----
>> From: devicetree-owner@vger.kernel.org <devicetree-
>> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
>> Sent: 05 September 2018 21:32
>> To: Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
>> <tglx@linutronix.de>; Rob Herring <robh+dt@kernel.org>;
>> devicetree@vger.kernel.org
>> Cc: linux-renesas-soc@vger.kernel.org; linux-sh@vger.kernel.org
>> Subject: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support
>>
>> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
>> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
>> bindings as these are the R-Car gen3 SoCs for which the initial support was
>> done.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>>  Documentation/devicetree/bindings/timer/renesas,cmt.txt |    7 +++++++
>>  drivers/clocksource/sh_cmt.c                            |    8 ++++++++
>>  2 files changed, 15 insertions(+)
>>
>> Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
>> ==========================================================
>> =========
>> --- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt
>> +++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt
>> @@ -34,6 +34,10 @@ Required Properties:
>>      - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793.
>>      - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
>>      - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
>> +    - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in
>> r8a77970.
>> +    - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in
>> r8a77970.
>> +    - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in
>> r8a77980.
>> +    - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in
>> r8a77980.
>>
>>      - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
>>  and RZ/G1.
>> @@ -41,6 +45,9 @@ Required Properties:
>>  and RZ/G1.
>>  These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1
>> entries
>>  listed above.
>> +    - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car
>> Gen3.
>> +    - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car
> 
>  Do we need to mention CMT1/2/3 instead of CMT1, since CMT2/3 is similar to CMT1?

   Well, the manual only describes CMT0 and CMT1 separately. Perhaps it would have been
clearer to call them CMTT0 and CMTT1 as they stand for Compare Match Timer Type 0/1?
Note at this point we already have a history of describing CMT0/1 only in the bindings
as well...

[...]

MBR, Sergei

Re: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

Hello!

On 09/06/2018 11:06 AM, Chris Paterson wrote:

>> From: devicetree-owner@vger.kernel.org <devicetree-
>> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
>> Sent: 05 September 2018 21:32
>>
>> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
>> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
>> bindings as these are the R-Car gen3 SoCs for which the initial support was
>> done.
> 
> Is it allowed to combine the bindings doc update with the driver change? (I usually get a checkpatch warning for this).

   I don't (and have double checked that this patch is checkpatch-clean).

> It it's not a problem:

   Let's hear what Rob says...
   However note that Documentation/devicetree/bindings/timer/ is
listed under the CLOCKSOURCE, CLOCKEVENT DRIVERS entry in MAINTAINERS. 

> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>

   Thank you!

> Kind regards, Chris

MBR, Sergei

Re: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

Hello!

On 09/06/2018 11:06 AM, Chris Paterson wrote:

>> From: devicetree-owner@vger.kernel.org <devicetree-
>> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
>> Sent: 05 September 2018 21:32
>>
>> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
>> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
>> bindings as these are the R-Car gen3 SoCs for which the initial support was
>> done.
> 
> Is it allowed to combine the bindings doc update with the driver change? (I usually get a checkpatch warning for this).

   I don't (and have double checked that this patch is checkpatch-clean).

> It it's not a problem:

   Let's hear what Rob says...
   However note that Documentation/devicetree/bindings/timer/ is
listed under the CLOCKSOURCE, CLOCKEVENT DRIVERS entry in MAINTAINERS. 

> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>

   Thank you!

> Kind regards, Chris

MBR, Sergei

Re: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

On 09/10/2018 10:30 PM, Sergei Shtylyov wrote:

>>> From: devicetree-owner@vger.kernel.org <devicetree-
>>> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
>>> Sent: 05 September 2018 21:32
>>>
>>> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
>>> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
>>> bindings as these are the R-Car gen3 SoCs for which the initial support was
>>> done.
>>
>> Is it allowed to combine the bindings doc update with the driver change? (I usually get a checkpatch warning for this).
> 
>    I don't (and have double checked that this patch is checkpatch-clean).

   Hm... triple checking has revealed something new: the patch is good only in the context
of tip.git, 4.19-rc3 based branch from renesas.git complains about the binding not being
in a separate patch. Well, I have to comply... :-)

[...]

>> Kind regards, Chris

MBR, Sergei

Re: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support

[Sergei Shtylyov]

On 09/10/2018 10:30 PM, Sergei Shtylyov wrote:

>>> From: devicetree-owner@vger.kernel.org <devicetree-
>>> owner@vger.kernel.org> On Behalf Of Sergei Shtylyov
>>> Sent: 05 September 2018 21:32
>>>
>>> Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be
>>> the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8}
>>> bindings as these are the R-Car gen3 SoCs for which the initial support was
>>> done.
>>
>> Is it allowed to combine the bindings doc update with the driver change? (I usually get a checkpatch warning for this).
> 
>    I don't (and have double checked that this patch is checkpatch-clean).

   Hm... triple checking has revealed something new: the patch is good only in the context
of tip.git, 4.19-rc3 based branch from renesas.git complains about the binding not being
in a separate patch. Well, I have to comply... :-)

[...]

>> Kind regards, Chris

MBR, Sergei