[SPDK] Re: Gerrit code: sock_ut is reporting error

* [SPDK] Re: Gerrit code: sock_ut is reporting error
@ 2019-12-23 23:10 
  0 siblings, 0 replies; 2+ messages in thread
From:  @ 2019-12-23 23:10 UTC (permalink / raw)
  To: spdk

[-- Attachment #1: Type: text/plain, Size: 4801 bytes --]

Hi Anil,

I can not reproduce the issue but the log says

  Test: posix_sock_close ...==6027== Syscall param sendmsg(msg.msg_iov[0]) points to uninitialised byte(s)

Do you see any change if you apply the following?

--- a/module/sock/posix/posix.c
+++ b/module/sock/posix/posix.c
@@ -440,7 +440,7 @@ _sock_flush(struct spdk_sock *sock)
        struct spdk_posix_sock *psock = __posix_sock(sock);
        struct msghdr msg = {};
        int flags;
-       struct iovec iovs[IOV_BATCH_SIZE];
+       struct iovec iovs[IOV_BATCH_SIZE] = {};
        int iovcnt;
        int retval;
        struct spdk_sock_request *req;

Thanks,
Shuhei

________________________________
差出人: anil.veerabhadrappa(a)broadcom.com <anil.veerabhadrappa(a)broadcom.com>
送信日時: 2019年12月24日 6:34
宛先: spdk(a)lists.01.org <spdk(a)lists.01.org>
件名: [!][SPDK] Gerrit code: sock_ut is reporting error

Hi,
     I am trying to submit a couple of patches to fix broken FC NVMe compilation.
However with the latest Gerrit code, unittest,sh (sock_ut) is failing and blocking
my submission. Is anybody else also hitting this issue?.

Thanks!

--- snip ---
spdk/test/unit/lib/sock/sock.c/sock_ut
==6027==


     CUnit - A unit testing framework for C - Version 2.1-3
     https://clicktime.symantec.com/3R5YRhzMpovwJ7DfyrHy4U17Vc?u=http%3A%2F%2Fcunit.sourceforge.net%2F


Suite: sock
  Test: posix_sock ...passed
  Test: ut_sock ...passed
  Test: posix_sock_group ...passed
  Test: ut_sock_group ...passed
  Test: posix_sock_group_fairness ...passed
  Test: posix_sock_close ...==6027== Syscall param sendmsg(msg.msg_iov[0]) points to uninitialised byte(s)
==6027==    at 0x58C3C40: __sendmsg_nocancel (in /usr/lib64/libpthread-2.17.so)
==6027==    by 0x402F1B: _sock_flush (posix.c:496)
==6027==    by 0x40325F: spdk_posix_sock_group_impl_poll (posix.c:824)
==6027==    by 0x40427D: spdk_sock_group_impl_poll_count (sock.c:507)
==6027==    by 0x40427D: spdk_sock_group_poll_count (sock.c:541)
==6027==    by 0x404E46: _sock_close (sock_ut.c:787)
==6027==    by 0x404E46: posix_sock_close (sock_ut.c:810)
==6027==    by 0x4E3D120: run_single_test (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3CD59: run_single_suite (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3AC84: CU_run_all_tests (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3EE9F: basic_run_all_tests (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3EC41: CU_basic_run_tests (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x401732: main (sock_ut.c:842)
==6027==  Address 0x1ffefff920 is on thread 1's stack
==6027==  in frame #4, created by posix_sock_close (sock_ut.c:809)
==6027==
==6027== Syscall param sendmsg(msg.msg_iov[1]) points to uninitialised byte(s)
==6027==    at 0x58C3C40: __sendmsg_nocancel (in /usr/lib64/libpthread-2.17.so)
==6027==    by 0x402F1B: _sock_flush (posix.c:496)
==6027==    by 0x40325F: spdk_posix_sock_group_impl_poll (posix.c:824)
==6027==    by 0x40427D: spdk_sock_group_impl_poll_count (sock.c:507)
==6027==    by 0x40427D: spdk_sock_group_poll_count (sock.c:541)
==6027==    by 0x404E46: _sock_close (sock_ut.c:787)
==6027==    by 0x404E46: posix_sock_close (sock_ut.c:810)
==6027==    by 0x4E3D120: run_single_test (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3CD59: run_single_suite (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3AC84: CU_run_all_tests (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3EE9F: basic_run_all_tests (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x4E3EC41: CU_basic_run_tests (in /usr/local/lib/libcunit.so.1.0.1)
==6027==    by 0x401732: main (sock_ut.c:842)
==6027==  Address 0x1ffefff920 is on thread 1's stack
==6027==  in frame #4, created by posix_sock_close (sock_ut.c:809)
==6027==
passed

Run Summary:    Type  Total    Ran Passed Failed Inactive
              suites      1      1    n/a      0        0
               tests      6      6      6      0        0
             asserts    213    213    213      0      n/a

Elapsed time =    0.050 seconds
==6027==
==6027== HEAP SUMMARY:
==6027==     in use at exit: 0 bytes in 0 blocks
==6027==   total heap usage: 63 allocs, 63 frees, 6,555 bytes allocated
==6027==
==6027== All heap blocks were freed -- no leaks are possible
==6027==
==6027== For counts of detected and suppressed errors, rerun with: -v
==6027== Use --track-origins=yes to see where uninitialised values come from
==6027== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 0 from 0)
#
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread