All of lore.kernel.org
 help / color / mirror / Atom feed
* [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support
@ 2019-03-22  9:19 Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core Biju Das
                   ` (8 more replies)
  0 siblings, 9 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

This patch series aims to add SMP/INTC-EX/PFC/GPIO support
for RZ/G2E SoC.

This patch series is based on linux-4.19.y-cip and all the patches
in this series are cherry-picked from linux rc tree.

This patch series is depend on the below patch series
https://patchwork.kernel.org/project/cip-dev/list/?series=94967

Biju Das (1):
  arm64: dts: renesas: r8a774c0-cat874: Add pincontrol support to scif2

Fabrizio Castro (6):
  arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core
  arm64: dts: renesas: r8a774c0: Add INTC-EX device node
  arm64: dts: renesas: r8a774c0: Add PFC support
  dt-bindings: gpio: rcar: Add r8a774a1 (RZ/G2M) support
  dt-bindings: gpio: rcar: Add r8a774c0 (RZ/G2E) support
  arm64: dts: renesas: r8a774c0: Add GPIO device nodes

Geert Uytterhoeven (2):
  pinctrl: sh-pfc: rcar: Rename automotive-only arrays to automotive
  pinctrl: sh-pfc: r8a77990: Add INTC-EX pins, groups and function

 .../devicetree/bindings/gpio/renesas,gpio-rcar.txt |   4 +-
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts    |  10 ++
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi          | 151 +++++++++++++++++++--
 drivers/pinctrl/sh-pfc/pfc-r8a7791.c               |  16 +--
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c               |  12 +-
 drivers/pinctrl/sh-pfc/pfc-r8a77990.c              |  72 +++++++++-
 6 files changed, 236 insertions(+), 29 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-04-10 23:14   ` nobuhiro1.iwamatsu at toshiba.co.jp
  2019-03-22  9:19 ` [cip-dev] [PATCH 2/9] pinctrl: sh-pfc: rcar: Rename automotive-only arrays to automotive Biju Das
                   ` (7 subsequent siblings)
  8 siblings, 1 reply; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Add a device node for the second Cortex-A53 CPU core on the Renesas
RZ/G2E (a.k.a r8a774c0) SoC, and adjust the interrupt delivery masks
for the ARM Generic Interrupt Controller and Architectured Timer.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit 9b55a05ebfbe41bfb4c2aa98a81a46f2031e599f)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 872efa7..5bea23e 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -48,7 +48,6 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		/* 1 core only at this point */
 		a53_0: cpu at 0 {
 			compatible = "arm,cortex-a53", "arm,armv8";
 			reg = <0>;
@@ -58,6 +57,15 @@
 			enable-method = "psci";
 		};
 
+		a53_1: cpu at 1 {
+			compatible = "arm,cortex-a53", "arm,armv8";
+			reg = <1>;
+			device_type = "cpu";
+			power-domains = <&sysc R8A774C0_PD_CA53_CPU1>;
+			next-level-cache = <&L2_CA53>;
+			enable-method = "psci";
+		};
+
 		L2_CA53: cache-controller-0 {
 			compatible = "cache";
 			power-domains = <&sysc R8A774C0_PD_CA53_SCU>;
@@ -82,8 +90,9 @@
 
 	pmu_a53 {
 		compatible = "arm,cortex-a53-pmu";
-		interrupts-extended = <&gic GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
-		interrupt-affinity = <&a53_0>;
+		interrupts-extended = <&gic GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
+				      <&gic GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-affinity = <&a53_0>, <&a53_1>;
 	};
 
 	psci {
@@ -423,7 +432,7 @@
 			      <0x0 0xf1040000 0 0x20000>,
 			      <0x0 0xf1060000 0 0x20000>;
 			interrupts = <GIC_PPI 9
-					(GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_HIGH)>;
+					(GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
 			clocks = <&cpg CPG_MOD 408>;
 			clock-names = "clk";
 			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
@@ -438,10 +447,10 @@
 
 	timer {
 		compatible = "arm,armv8-timer";
-		interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
-				      <&gic GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
-				      <&gic GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
-				      <&gic GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>;
+		interrupts-extended = <&gic GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+				      <&gic GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+				      <&gic GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>,
+				      <&gic GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_LOW)>;
 	};
 
 	/* External USB clocks - can be overridden by the board */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 2/9] pinctrl: sh-pfc: rcar: Rename automotive-only arrays to automotive
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 3/9] pinctrl: sh-pfc: r8a77990: Add INTC-EX pins, groups and function Biju Das
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Geert Uytterhoeven <geert+renesas@glider.be>

Renesas RZ/G SoCs are pin compatible with R-Car SoCs, but lack several
automotive-specific peripherals.

Currently pin groups and functions for automotive-specific peripherals
are grouped in arrays named after the automative SoC part numbers.
Rename them to "automotive" for clarity and consistency.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit a97f340c0a071bcb32ff68f3d19cf56a76887288)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 drivers/pinctrl/sh-pfc/pfc-r8a7791.c  | 16 ++++++++--------
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c  | 12 ++++++------
 drivers/pinctrl/sh-pfc/pfc-r8a77990.c |  8 ++++----
 3 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
index 5811784..c5144de 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -4458,7 +4458,7 @@ static const unsigned int vin2_clk_mux[] = {
 
 static const struct {
 	struct sh_pfc_pin_group common[346];
-	struct sh_pfc_pin_group r8a779x[9];
+	struct sh_pfc_pin_group automotive[9];
 } pinmux_groups = {
 	.common = {
 		SH_PFC_PIN_GROUP(audio_clk_a),
@@ -4808,7 +4808,7 @@ static const struct {
 		SH_PFC_PIN_GROUP(vin2_clkenb),
 		SH_PFC_PIN_GROUP(vin2_clk),
 	},
-	.r8a779x = {
+	.automotive = {
 		SH_PFC_PIN_GROUP(adi_common),
 		SH_PFC_PIN_GROUP(adi_chsel0),
 		SH_PFC_PIN_GROUP(adi_chsel1),
@@ -5365,7 +5365,7 @@ static const char * const vin2_groups[] = {
 
 static const struct {
 	struct sh_pfc_function common[58];
-	struct sh_pfc_function r8a779x[2];
+	struct sh_pfc_function automotive[2];
 } pinmux_functions = {
 	.common = {
 		SH_PFC_FUNCTION(audio_clk),
@@ -5427,7 +5427,7 @@ static const struct {
 		SH_PFC_FUNCTION(vin1),
 		SH_PFC_FUNCTION(vin2),
 	},
-	.r8a779x = {
+	.automotive = {
 		SH_PFC_FUNCTION(adi),
 		SH_PFC_FUNCTION(mlb),
 	}
@@ -6646,10 +6646,10 @@ const struct sh_pfc_soc_info r8a7791_pinmux_info = {
 	.nr_pins = ARRAY_SIZE(pinmux_pins),
 	.groups = pinmux_groups.common,
 	.nr_groups = ARRAY_SIZE(pinmux_groups.common) +
-		     ARRAY_SIZE(pinmux_groups.r8a779x),
+		     ARRAY_SIZE(pinmux_groups.automotive),
 	.functions = pinmux_functions.common,
 	.nr_functions = ARRAY_SIZE(pinmux_functions.common) +
-			ARRAY_SIZE(pinmux_functions.r8a779x),
+			ARRAY_SIZE(pinmux_functions.automotive),
 
 	.cfg_regs = pinmux_config_regs,
 
@@ -6670,10 +6670,10 @@ const struct sh_pfc_soc_info r8a7793_pinmux_info = {
 	.nr_pins = ARRAY_SIZE(pinmux_pins),
 	.groups = pinmux_groups.common,
 	.nr_groups = ARRAY_SIZE(pinmux_groups.common) +
-		     ARRAY_SIZE(pinmux_groups.r8a779x),
+		     ARRAY_SIZE(pinmux_groups.automotive),
 	.functions = pinmux_functions.common,
 	.nr_functions = ARRAY_SIZE(pinmux_functions.common) +
-			ARRAY_SIZE(pinmux_functions.r8a779x),
+			ARRAY_SIZE(pinmux_functions.automotive),
 
 	.cfg_regs = pinmux_config_regs,
 
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
index 067a79e..aa378e4 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7796.c
@@ -4128,7 +4128,7 @@ static const unsigned int vin5_clk_mux[] = {
 
 static const struct {
 	struct sh_pfc_pin_group common[307];
-	struct sh_pfc_pin_group r8a779x[33];
+	struct sh_pfc_pin_group automotive[33];
 } pinmux_groups = {
 	.common = {
 		SH_PFC_PIN_GROUP(audio_clk_a_a),
@@ -4439,7 +4439,7 @@ static const struct {
 		SH_PFC_PIN_GROUP(vin5_clkenb),
 		SH_PFC_PIN_GROUP(vin5_clk),
 	},
-	.r8a779x = {
+	.automotive = {
 		SH_PFC_PIN_GROUP(canfd0_data_a),
 		SH_PFC_PIN_GROUP(canfd0_data_b),
 		SH_PFC_PIN_GROUP(canfd1_data),
@@ -4971,7 +4971,7 @@ static const char * const vin5_groups[] = {
 
 static const struct {
 	struct sh_pfc_function common[45];
-	struct sh_pfc_function r8a779x[6];
+	struct sh_pfc_function automotive[6];
 } pinmux_functions = {
 	.common = {
 		SH_PFC_FUNCTION(audio_clk),
@@ -5020,7 +5020,7 @@ static const struct {
 		SH_PFC_FUNCTION(vin4),
 		SH_PFC_FUNCTION(vin5),
 	},
-	.r8a779x = {
+	.automotive = {
 		SH_PFC_FUNCTION(canfd0),
 		SH_PFC_FUNCTION(canfd1),
 		SH_PFC_FUNCTION(drif0),
@@ -6188,10 +6188,10 @@ const struct sh_pfc_soc_info r8a7796_pinmux_info = {
 	.nr_pins = ARRAY_SIZE(pinmux_pins),
 	.groups = pinmux_groups.common,
 	.nr_groups = ARRAY_SIZE(pinmux_groups.common) +
-		ARRAY_SIZE(pinmux_groups.r8a779x),
+		ARRAY_SIZE(pinmux_groups.automotive),
 	.functions = pinmux_functions.common,
 	.nr_functions = ARRAY_SIZE(pinmux_functions.common) +
-		ARRAY_SIZE(pinmux_functions.r8a779x),
+		ARRAY_SIZE(pinmux_functions.automotive),
 
 	.cfg_regs = pinmux_config_regs,
 	.drive_regs = pinmux_drive_regs,
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
index 76ac77a..663b8ce 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
@@ -2391,7 +2391,7 @@ static const unsigned int usb30_id_mux[] = {
 
 static const struct {
 	struct sh_pfc_pin_group common[117];
-	struct sh_pfc_pin_group r8a77990[0];
+	struct sh_pfc_pin_group automotive[0];
 } pinmux_groups = {
 	.common = {
 		SH_PFC_PIN_GROUP(avb_link),
@@ -2717,7 +2717,7 @@ static const char * const usb30_groups[] = {
 
 static const struct {
 	struct sh_pfc_function common[28];
-	struct sh_pfc_function r8a77990[0];
+	struct sh_pfc_function automotive[0];
 } pinmux_functions = {
 	.common = {
 		SH_PFC_FUNCTION(avb),
@@ -3509,10 +3509,10 @@ const struct sh_pfc_soc_info r8a77990_pinmux_info = {
 	.nr_pins = ARRAY_SIZE(pinmux_pins),
 	.groups = pinmux_groups.common,
 	.nr_groups = ARRAY_SIZE(pinmux_groups.common) +
-		ARRAY_SIZE(pinmux_groups.r8a77990),
+		ARRAY_SIZE(pinmux_groups.automotive),
 	.functions = pinmux_functions.common,
 	.nr_functions = ARRAY_SIZE(pinmux_functions.common) +
-		ARRAY_SIZE(pinmux_functions.r8a77990),
+		ARRAY_SIZE(pinmux_functions.automotive),
 
 	.cfg_regs = pinmux_config_regs,
 	.bias_regs = pinmux_bias_regs,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 3/9] pinctrl: sh-pfc: r8a77990: Add INTC-EX pins, groups and function
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 2/9] pinctrl: sh-pfc: rcar: Rename automotive-only arrays to automotive Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 4/9] arm64: dts: renesas: r8a774c0: Add INTC-EX device node Biju Das
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Geert Uytterhoeven <geert+renesas@glider.be>

Add pins, groups, and function for the Interrupt Controller for
External Devices (INTC-EX) on the R-Car E3 SoC.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit ef26d96023a4c34b1bcc4294f570df2b63a1b952)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 64 +++++++++++++++++++++++++++++++++--
 1 file changed, 62 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
index 663b8ce..1fdafa4 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a77990.c
@@ -1595,6 +1595,50 @@ static const unsigned int i2c7_b_mux[] = {
 	SCL7_B_MARK, SDA7_B_MARK,
 };
 
+/* - INTC-EX ---------------------------------------------------------------- */
+static const unsigned int intc_ex_irq0_pins[] = {
+	/* IRQ0 */
+	RCAR_GP_PIN(1, 0),
+};
+static const unsigned int intc_ex_irq0_mux[] = {
+	IRQ0_MARK,
+};
+static const unsigned int intc_ex_irq1_pins[] = {
+	/* IRQ1 */
+	RCAR_GP_PIN(1, 1),
+};
+static const unsigned int intc_ex_irq1_mux[] = {
+	IRQ1_MARK,
+};
+static const unsigned int intc_ex_irq2_pins[] = {
+	/* IRQ2 */
+	RCAR_GP_PIN(1, 2),
+};
+static const unsigned int intc_ex_irq2_mux[] = {
+	IRQ2_MARK,
+};
+static const unsigned int intc_ex_irq3_pins[] = {
+	/* IRQ3 */
+	RCAR_GP_PIN(1, 9),
+};
+static const unsigned int intc_ex_irq3_mux[] = {
+	IRQ3_MARK,
+};
+static const unsigned int intc_ex_irq4_pins[] = {
+	/* IRQ4 */
+	RCAR_GP_PIN(1, 10),
+};
+static const unsigned int intc_ex_irq4_mux[] = {
+	IRQ4_MARK,
+};
+static const unsigned int intc_ex_irq5_pins[] = {
+	/* IRQ5 */
+	RCAR_GP_PIN(0, 7),
+};
+static const unsigned int intc_ex_irq5_mux[] = {
+	IRQ5_MARK,
+};
+
 /* - MSIOF0 ----------------------------------------------------------------- */
 static const unsigned int msiof0_clk_pins[] = {
 	/* SCK */
@@ -2390,7 +2434,7 @@ static const unsigned int usb30_id_mux[] = {
 };
 
 static const struct {
-	struct sh_pfc_pin_group common[117];
+	struct sh_pfc_pin_group common[123];
 	struct sh_pfc_pin_group automotive[0];
 } pinmux_groups = {
 	.common = {
@@ -2425,6 +2469,12 @@ static const struct {
 		SH_PFC_PIN_GROUP(i2c6_b),
 		SH_PFC_PIN_GROUP(i2c7_a),
 		SH_PFC_PIN_GROUP(i2c7_b),
+		SH_PFC_PIN_GROUP(intc_ex_irq0),
+		SH_PFC_PIN_GROUP(intc_ex_irq1),
+		SH_PFC_PIN_GROUP(intc_ex_irq2),
+		SH_PFC_PIN_GROUP(intc_ex_irq3),
+		SH_PFC_PIN_GROUP(intc_ex_irq4),
+		SH_PFC_PIN_GROUP(intc_ex_irq5),
 		SH_PFC_PIN_GROUP(msiof0_clk),
 		SH_PFC_PIN_GROUP(msiof0_sync),
 		SH_PFC_PIN_GROUP(msiof0_ss1),
@@ -2569,6 +2619,15 @@ static const char * const i2c7_groups[] = {
 	"i2c7_b",
 };
 
+static const char * const intc_ex_groups[] = {
+	"intc_ex_irq0",
+	"intc_ex_irq1",
+	"intc_ex_irq2",
+	"intc_ex_irq3",
+	"intc_ex_irq4",
+	"intc_ex_irq5",
+};
+
 static const char * const msiof0_groups[] = {
 	"msiof0_clk",
 	"msiof0_sync",
@@ -2716,7 +2775,7 @@ static const char * const usb30_groups[] = {
 };
 
 static const struct {
-	struct sh_pfc_function common[28];
+	struct sh_pfc_function common[29];
 	struct sh_pfc_function automotive[0];
 } pinmux_functions = {
 	.common = {
@@ -2728,6 +2787,7 @@ static const struct {
 		SH_PFC_FUNCTION(i2c5),
 		SH_PFC_FUNCTION(i2c6),
 		SH_PFC_FUNCTION(i2c7),
+		SH_PFC_FUNCTION(intc_ex),
 		SH_PFC_FUNCTION(msiof0),
 		SH_PFC_FUNCTION(msiof1),
 		SH_PFC_FUNCTION(msiof2),
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 4/9] arm64: dts: renesas: r8a774c0: Add INTC-EX device node
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
                   ` (2 preceding siblings ...)
  2019-03-22  9:19 ` [cip-dev] [PATCH 3/9] pinctrl: sh-pfc: r8a77990: Add INTC-EX pins, groups and function Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 5/9] arm64: dts: renesas: r8a774c0: Add PFC support Biju Das
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Add support for the Interrupt Controller for External Devices
(INTC-EX) on RZ/G2E.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit 13fd6932045d1a5b3bbdfc1097f9065369e52e96)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 5bea23e..4f6caa7 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -135,6 +135,22 @@
 			#power-domain-cells = <1>;
 		};
 
+		intc_ex: interrupt-controller at e61c0000 {
+			compatible = "renesas,intc-ex-r8a774c0", "renesas,irqc";
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			reg = <0 0xe61c0000 0 0x200>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH
+				      GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH
+				      GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH
+				      GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH
+				      GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH
+				      GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 407>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 407>;
+		};
+
 		hscif0: serial at e6540000 {
 			compatible = "renesas,hscif-r8a774c0",
 				     "renesas,rcar-gen3-hscif",
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 5/9] arm64: dts: renesas: r8a774c0: Add PFC support
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
                   ` (3 preceding siblings ...)
  2019-03-22  9:19 ` [cip-dev] [PATCH 4/9] arm64: dts: renesas: r8a774c0: Add INTC-EX device node Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 6/9] dt-bindings: gpio: rcar: Add r8a774a1 (RZ/G2M) support Biju Das
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Add PFC support to the RZ/G2E (a.k.a. r8a774c0) SoC specific
device tree.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit 788e55b66c13e8e77003e9226677e49eaaa9f751)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 4f6caa7..8c25c06 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -114,6 +114,11 @@
 		#size-cells = <2>;
 		ranges;
 
+		pfc: pin-controller at e6060000 {
+			compatible = "renesas,pfc-r8a774c0";
+			reg = <0 0xe6060000 0 0x508>;
+		};
+
 		cpg: clock-controller at e6150000 {
 			compatible = "renesas,r8a774c0-cpg-mssr";
 			reg = <0 0xe6150000 0 0x1000>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 6/9] dt-bindings: gpio: rcar: Add r8a774a1 (RZ/G2M) support
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
                   ` (4 preceding siblings ...)
  2019-03-22  9:19 ` [cip-dev] [PATCH 5/9] arm64: dts: renesas: r8a774c0: Add PFC support Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 7/9] dt-bindings: gpio: rcar: Add r8a774c0 (RZ/G2E) support Biju Das
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Document Renesas' RZ/G2M (R8A774A1) GPIO blocks compatibility within the
relevant dt-bindings.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
(cherry picked from commit 28123791ddbe493b957423625810e75a4ce3a9ef)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
index 4018ee5..e82144a 100644
--- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
+++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
@@ -6,6 +6,7 @@ Required Properties:
     - "renesas,gpio-r8a7743": for R8A7743 (RZ/G1M) compatible GPIO controller.
     - "renesas,gpio-r8a7745": for R8A7745 (RZ/G1E) compatible GPIO controller.
     - "renesas,gpio-r8a77470": for R8A77470 (RZ/G1C) compatible GPIO controller.
+    - "renesas,gpio-r8a774a1": for R8A774A1 (RZ/G2M) compatible GPIO controller.
     - "renesas,gpio-r8a7778": for R8A7778 (R-Car M1) compatible GPIO controller.
     - "renesas,gpio-r8a7779": for R8A7779 (R-Car H1) compatible GPIO controller.
     - "renesas,gpio-r8a7790": for R8A7790 (R-Car H2) compatible GPIO controller.
@@ -22,7 +23,7 @@ Required Properties:
     - "renesas,gpio-r8a77995": for R8A77995 (R-Car D3) compatible GPIO controller.
     - "renesas,rcar-gen1-gpio": for a generic R-Car Gen1 GPIO controller.
     - "renesas,rcar-gen2-gpio": for a generic R-Car Gen2 or RZ/G1 GPIO controller.
-    - "renesas,rcar-gen3-gpio": for a generic R-Car Gen3 GPIO controller.
+    - "renesas,rcar-gen3-gpio": for a generic R-Car Gen3 or RZ/G2 GPIO controller.
     - "renesas,gpio-rcar": deprecated.
 
     When compatible with the generic version nodes must list the
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 7/9] dt-bindings: gpio: rcar: Add r8a774c0 (RZ/G2E) support
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
                   ` (5 preceding siblings ...)
  2019-03-22  9:19 ` [cip-dev] [PATCH 6/9] dt-bindings: gpio: rcar: Add r8a774a1 (RZ/G2M) support Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 8/9] arm64: dts: renesas: r8a774c0: Add GPIO device nodes Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 9/9] arm64: dts: renesas: r8a774c0-cat874: Add pincontrol support to scif2 Biju Das
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Document Renesas' RZ/G2E (R8A774C0) GPIO blocks compatibility within the
relevant dt-bindings.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
(cherry picked from commit 12d6dd06989171ba9486790116832a65c5316fb1)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
index e82144a..a67a110 100644
--- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
+++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
@@ -7,6 +7,7 @@ Required Properties:
     - "renesas,gpio-r8a7745": for R8A7745 (RZ/G1E) compatible GPIO controller.
     - "renesas,gpio-r8a77470": for R8A77470 (RZ/G1C) compatible GPIO controller.
     - "renesas,gpio-r8a774a1": for R8A774A1 (RZ/G2M) compatible GPIO controller.
+    - "renesas,gpio-r8a774c0": for R8A774C0 (RZ/G2E) compatible GPIO controller.
     - "renesas,gpio-r8a7778": for R8A7778 (R-Car M1) compatible GPIO controller.
     - "renesas,gpio-r8a7779": for R8A7779 (R-Car H1) compatible GPIO controller.
     - "renesas,gpio-r8a7790": for R8A7790 (R-Car H2) compatible GPIO controller.
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 8/9] arm64: dts: renesas: r8a774c0: Add GPIO device nodes
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
                   ` (6 preceding siblings ...)
  2019-03-22  9:19 ` [cip-dev] [PATCH 7/9] dt-bindings: gpio: rcar: Add r8a774c0 (RZ/G2E) support Biju Das
@ 2019-03-22  9:19 ` Biju Das
  2019-03-22  9:19 ` [cip-dev] [PATCH 9/9] arm64: dts: renesas: r8a774c0-cat874: Add pincontrol support to scif2 Biju Das
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Add GPIO device nodes to the DT of the r8a774c0 SoC.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit fccd45bd23c2643872dd96e52078ecc39ccfe424)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 105 ++++++++++++++++++++++++++++++
 1 file changed, 105 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 8c25c06..97ff545 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -114,6 +114,111 @@
 		#size-cells = <2>;
 		ranges;
 
+		gpio0: gpio at e6050000 {
+			compatible = "renesas,gpio-r8a774c0",
+				     "renesas,rcar-gen3-gpio";
+			reg = <0 0xe6050000 0 0x50>;
+			interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+			#gpio-cells = <2>;
+			gpio-controller;
+			gpio-ranges = <&pfc 0 0 18>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			clocks = <&cpg CPG_MOD 912>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 912>;
+		};
+
+		gpio1: gpio at e6051000 {
+			compatible = "renesas,gpio-r8a774c0",
+				     "renesas,rcar-gen3-gpio";
+			reg = <0 0xe6051000 0 0x50>;
+			interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+			#gpio-cells = <2>;
+			gpio-controller;
+			gpio-ranges = <&pfc 0 32 23>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			clocks = <&cpg CPG_MOD 911>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 911>;
+		};
+
+		gpio2: gpio at e6052000 {
+			compatible = "renesas,gpio-r8a774c0",
+				     "renesas,rcar-gen3-gpio";
+			reg = <0 0xe6052000 0 0x50>;
+			interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
+			#gpio-cells = <2>;
+			gpio-controller;
+			gpio-ranges = <&pfc 0 64 26>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			clocks = <&cpg CPG_MOD 910>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 910>;
+		};
+
+		gpio3: gpio at e6053000 {
+			compatible = "renesas,gpio-r8a774c0",
+				     "renesas,rcar-gen3-gpio";
+			reg = <0 0xe6053000 0 0x50>;
+			interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+			#gpio-cells = <2>;
+			gpio-controller;
+			gpio-ranges = <&pfc 0 96 16>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			clocks = <&cpg CPG_MOD 909>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 909>;
+		};
+
+		gpio4: gpio at e6054000 {
+			compatible = "renesas,gpio-r8a774c0",
+				     "renesas,rcar-gen3-gpio";
+			reg = <0 0xe6054000 0 0x50>;
+			interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
+			#gpio-cells = <2>;
+			gpio-controller;
+			gpio-ranges = <&pfc 0 128 11>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			clocks = <&cpg CPG_MOD 908>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 908>;
+		};
+
+		gpio5: gpio at e6055000 {
+			compatible = "renesas,gpio-r8a774c0",
+				     "renesas,rcar-gen3-gpio";
+			reg = <0 0xe6055000 0 0x50>;
+			interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+			#gpio-cells = <2>;
+			gpio-controller;
+			gpio-ranges = <&pfc 0 160 20>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			clocks = <&cpg CPG_MOD 907>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 907>;
+		};
+
+		gpio6: gpio at e6055400 {
+			compatible = "renesas,gpio-r8a774c0",
+				     "renesas,rcar-gen3-gpio";
+			reg = <0 0xe6055400 0 0x50>;
+			interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+			#gpio-cells = <2>;
+			gpio-controller;
+			gpio-ranges = <&pfc 0 192 18>;
+			#interrupt-cells = <2>;
+			interrupt-controller;
+			clocks = <&cpg CPG_MOD 906>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 906>;
+		};
+
 		pfc: pin-controller at e6060000 {
 			compatible = "renesas,pfc-r8a774c0";
 			reg = <0 0xe6060000 0 0x508>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 9/9] arm64: dts: renesas: r8a774c0-cat874: Add pincontrol support to scif2
  2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
                   ` (7 preceding siblings ...)
  2019-03-22  9:19 ` [cip-dev] [PATCH 8/9] arm64: dts: renesas: r8a774c0: Add GPIO device nodes Biju Das
@ 2019-03-22  9:19 ` Biju Das
  8 siblings, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-03-22  9:19 UTC (permalink / raw)
  To: cip-dev

This patch adds pincontrol support to scif2.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
(cherry picked from commit 4cf1f6cec1e99410b5cdc0b865b93bebf68b3fdb)
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
index 6eababc..c545ce5 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
@@ -32,6 +32,16 @@
 	clock-frequency = <48000000>;
 };
 
+&pfc {
+	scif2_pins: scif2 {
+		groups = "scif2_data_a";
+		function = "scif2";
+	};
+};
+
 &scif2 {
+	pinctrl-0 = <&scif2_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core
  2019-03-22  9:19 ` [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core Biju Das
@ 2019-04-10 23:14   ` nobuhiro1.iwamatsu at toshiba.co.jp
  2019-04-11  6:54     ` Biju Das
  0 siblings, 1 reply; 14+ messages in thread
From: nobuhiro1.iwamatsu at toshiba.co.jp @ 2019-04-10 23:14 UTC (permalink / raw)
  To: cip-dev

Hi, Diju.

> -----Original Message-----
> From: cip-dev-bounces at lists.cip-project.org
> [mailto:cip-dev-bounces at lists.cip-project.org] On Behalf Of Biju Das
> Sent: Friday, March 22, 2019 6:19 PM
> To: cip-dev at lists.cip-project.org
> Cc: Biju Das <biju.das@bp.renesas.com>
> Subject: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> secondary CA53 CPU core
> 
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Add a device node for the second Cortex-A53 CPU core on the Renesas RZ/G2E
> (a.k.a r8a774c0) SoC, and adjust the interrupt delivery masks for the
> ARM Generic Interrupt Controller and Architectured Timer.

I think that 'Architected Timer' is correct, not 'Architectured Timer'.
If my point is correct, I will fix and apply the commit message.

Other patches are looks good to me.

Best regards,
  Nobuhiro

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core
  2019-04-10 23:14   ` nobuhiro1.iwamatsu at toshiba.co.jp
@ 2019-04-11  6:54     ` Biju Das
  2019-04-11  6:59       ` Biju Das
  2019-04-11  9:34       ` Nobuhiro Iwamatsu
  0 siblings, 2 replies; 14+ messages in thread
From: Biju Das @ 2019-04-11  6:54 UTC (permalink / raw)
  To: cip-dev


Hi Nobuhiro-San,

Thanks for the feedback.

Regards,
Biju

> -----Original Message-----
> From: nobuhiro1.iwamatsu at toshiba.co.jp
> <nobuhiro1.iwamatsu@toshiba.co.jp>
> Sent: 11 April 2019 00:14
> To: Biju Das <biju.das@bp.renesas.com>; cip-dev at lists.cip-project.org
> Subject: RE: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> secondary CA53 CPU core
> 
> Hi, Diju.
> 
> > -----Original Message-----
> > From: cip-dev-bounces at lists.cip-project.org
> > [mailto:cip-dev-bounces at lists.cip-project.org] On Behalf Of Biju Das
> > Sent: Friday, March 22, 2019 6:19 PM
> > To: cip-dev at lists.cip-project.org
> > Cc: Biju Das <biju.das@bp.renesas.com>
> > Subject: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> > secondary CA53 CPU core
> >
> > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Add a device node for the second Cortex-A53 CPU core on the Renesas
> > RZ/G2E (a.k.a r8a774c0) SoC, and adjust the interrupt delivery masks
> > for the ARM Generic Interrupt Controller and Architectured Timer.
> 
> I think that 'Architected Timer' is correct, not 'Architectured Timer'.
> If my point is correct, I will fix and apply the commit message.
> 
> Other patches are looks good to me.

I believe it is correct. see the link below.

https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/arch_timer.txt

Already the cherry-picked patch from upstream is reviewed by wider people.
So I believe it is not good to change the commit messages or ordering of patches.

We have upstreamed RZ/G2[ME] patches in specific order. So we expect the same order in cip kernel as well.
Like SoC definitions,SYSC,RST,CLK,Pinctrl , SoC DTSI,Board DTSI and the rest of the drivers.

We may be wrong. So please correct us if we are wrong.

Regards,
Biju

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core
  2019-04-11  6:54     ` Biju Das
@ 2019-04-11  6:59       ` Biju Das
  2019-04-11  9:34       ` Nobuhiro Iwamatsu
  1 sibling, 0 replies; 14+ messages in thread
From: Biju Das @ 2019-04-11  6:59 UTC (permalink / raw)
  To: cip-dev

Hi Nobuhiro-San,

> -----Original Message-----
> From: Biju Das
> Sent: 11 April 2019 07:55
> To: nobuhiro1.iwamatsu at toshiba.co.jp; cip-dev at lists.cip-project.org
> Cc: Chris Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>
> Subject: RE: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> secondary CA53 CPU core
> 
> 
> Hi Nobuhiro-San,
> 
> Thanks for the feedback.
> 
> Regards,
> Biju
> 
> > -----Original Message-----
> > From: nobuhiro1.iwamatsu at toshiba.co.jp
> > <nobuhiro1.iwamatsu@toshiba.co.jp>
> > Sent: 11 April 2019 00:14
> > To: Biju Das <biju.das@bp.renesas.com>; cip-dev at lists.cip-project.org
> > Subject: RE: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> > secondary CA53 CPU core
> >
> > Hi, Diju.
> >
> > > -----Original Message-----
> > > From: cip-dev-bounces at lists.cip-project.org
> > > [mailto:cip-dev-bounces at lists.cip-project.org] On Behalf Of Biju Das
> > > Sent: Friday, March 22, 2019 6:19 PM
> > > To: cip-dev at lists.cip-project.org
> > > Cc: Biju Das <biju.das@bp.renesas.com>
> > > Subject: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> > > secondary CA53 CPU core
> > >
> > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > Add a device node for the second Cortex-A53 CPU core on the Renesas
> > > RZ/G2E (a.k.a r8a774c0) SoC, and adjust the interrupt delivery masks
> > > for the ARM Generic Interrupt Controller and Architectured Timer.
> >
> > I think that 'Architected Timer' is correct, not 'Architectured Timer'.

Yes, you are correct, as per the below link. 

https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/arch _timer.txt

> > If my point is correct, I will fix and apply the commit message.
> > Other patches are looks good to me.

> I believe it is correct. see the link below.
> 
> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/arch
> _timer.txt
> 
> Already the cherry-picked patch from upstream is reviewed by wider people.
> So I believe it is not good to change the commit messages or ordering of
> patches.
> 
> We have upstreamed RZ/G2[ME] patches in specific order. So we expect the
> same order in cip kernel as well.
> Like SoC definitions,SYSC,RST,CLK,Pinctrl , SoC DTSI,Board DTSI and the rest
> of the drivers.
> 
> We may be wrong. So please correct us if we are wrong.
> 
> Regards,
> Biju
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core
  2019-04-11  6:54     ` Biju Das
  2019-04-11  6:59       ` Biju Das
@ 2019-04-11  9:34       ` Nobuhiro Iwamatsu
  1 sibling, 0 replies; 14+ messages in thread
From: Nobuhiro Iwamatsu @ 2019-04-11  9:34 UTC (permalink / raw)
  To: cip-dev

Hi, Biju.

2019?4?11?(?) 15:55 Biju Das <biju.das@bp.renesas.com>:
>
>
> Hi Nobuhiro-San,
>
> Thanks for the feedback.
>
> Regards,
> Biju
>
> > -----Original Message-----
> > From: nobuhiro1.iwamatsu at toshiba.co.jp
> > <nobuhiro1.iwamatsu@toshiba.co.jp>
> > Sent: 11 April 2019 00:14
> > To: Biju Das <biju.das@bp.renesas.com>; cip-dev at lists.cip-project.org
> > Subject: RE: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> > secondary CA53 CPU core
> >
> > Hi, Diju.
> >
> > > -----Original Message-----
> > > From: cip-dev-bounces at lists.cip-project.org
> > > [mailto:cip-dev-bounces at lists.cip-project.org] On Behalf Of Biju Das
> > > Sent: Friday, March 22, 2019 6:19 PM
> > > To: cip-dev at lists.cip-project.org
> > > Cc: Biju Das <biju.das@bp.renesas.com>
> > > Subject: [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add
> > > secondary CA53 CPU core
> > >
> > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > Add a device node for the second Cortex-A53 CPU core on the Renesas
> > > RZ/G2E (a.k.a r8a774c0) SoC, and adjust the interrupt delivery masks
> > > for the ARM Generic Interrupt Controller and Architectured Timer.
> >
> > I think that 'Architected Timer' is correct, not 'Architectured Timer'.
> > If my point is correct, I will fix and apply the commit message.
> >
> > Other patches are looks good to me.
>
> I believe it is correct. see the link below.
>
> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/arch_timer.txt
>
> Already the cherry-picked patch from upstream is reviewed by wider people.
> So I believe it is not good to change the commit messages or ordering of patches.
>
> We have upstreamed RZ/G2[ME] patches in specific order. So we expect the same order in cip kernel as well.
> Like SoC definitions,SYSC,RST,CLK,Pinctrl , SoC DTSI,Board DTSI and the rest of the drivers.
>
> We may be wrong. So please correct us if we are wrong.

I do not intend to change the patch application order.
However, since our CIP kernel needs to be maintained on a long-term,
I think it is better to fix the problems that we noticed and include the
corrected content in the commit message.

>
> Regards,
> Biju

Best regards,
  Nobuhiro

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-04-11  9:34 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22  9:19 [cip-dev] [PATCH 0/9] Add SMP/INTC-EX/PFC/GPIO support Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 1/9] arm64: dts: renesas: r8a774c0: Add secondary CA53 CPU core Biju Das
2019-04-10 23:14   ` nobuhiro1.iwamatsu at toshiba.co.jp
2019-04-11  6:54     ` Biju Das
2019-04-11  6:59       ` Biju Das
2019-04-11  9:34       ` Nobuhiro Iwamatsu
2019-03-22  9:19 ` [cip-dev] [PATCH 2/9] pinctrl: sh-pfc: rcar: Rename automotive-only arrays to automotive Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 3/9] pinctrl: sh-pfc: r8a77990: Add INTC-EX pins, groups and function Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 4/9] arm64: dts: renesas: r8a774c0: Add INTC-EX device node Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 5/9] arm64: dts: renesas: r8a774c0: Add PFC support Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 6/9] dt-bindings: gpio: rcar: Add r8a774a1 (RZ/G2M) support Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 7/9] dt-bindings: gpio: rcar: Add r8a774c0 (RZ/G2E) support Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 8/9] arm64: dts: renesas: r8a774c0: Add GPIO device nodes Biju Das
2019-03-22  9:19 ` [cip-dev] [PATCH 9/9] arm64: dts: renesas: r8a774c0-cat874: Add pincontrol support to scif2 Biju Das

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.