All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
@ 2021-10-01  1:16 ` Krzysztof Wilczyński
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Wilczyński @ 2021-10-01  1:16 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Lorenzo Pieralisi, Nobuhiro Iwamatsu, linux-pci, linux-arm-kernel

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
  drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error

Related:
  https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/
  https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/

Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/dwc/pcie-visconti.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-visconti.c b/drivers/pci/controller/dwc/pcie-visconti.c
index a88eab6829bb..076da46726a7 100644
--- a/drivers/pci/controller/dwc/pcie-visconti.c
+++ b/drivers/pci/controller/dwc/pcie-visconti.c
@@ -282,10 +282,8 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie,
 	struct device *dev = &pdev->dev;
 
 	pp->irq = platform_get_irq_byname(pdev, "intr");
-	if (pp->irq < 0) {
-		dev_err(dev, "Interrupt intr is missing");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	pp->ops = &visconti_pcie_host_ops;
 
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
@ 2021-10-01  1:16 ` Krzysztof Wilczyński
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Wilczyński @ 2021-10-01  1:16 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Lorenzo Pieralisi, Nobuhiro Iwamatsu, linux-pci, linux-arm-kernel

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
  drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error

Related:
  https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/
  https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/

Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/dwc/pcie-visconti.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-visconti.c b/drivers/pci/controller/dwc/pcie-visconti.c
index a88eab6829bb..076da46726a7 100644
--- a/drivers/pci/controller/dwc/pcie-visconti.c
+++ b/drivers/pci/controller/dwc/pcie-visconti.c
@@ -282,10 +282,8 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie,
 	struct device *dev = &pdev->dev;
 
 	pp->irq = platform_get_irq_byname(pdev, "intr");
-	if (pp->irq < 0) {
-		dev_err(dev, "Interrupt intr is missing");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	pp->ops = &visconti_pcie_host_ops;
 
-- 
2.33.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
  2021-10-01  1:16 ` Krzysztof Wilczyński
@ 2021-10-01  4:38   ` nobuhiro1.iwamatsu
  -1 siblings, 0 replies; 6+ messages in thread
From: nobuhiro1.iwamatsu @ 2021-10-01  4:38 UTC (permalink / raw)
  To: kw, bhelgaas; +Cc: lorenzo.pieralisi, linux-pci, linux-arm-kernel

Hi,

> -----Original Message-----
> From: Krzysztof Wilczyński [mailto:kw@linux.com]
> Sent: Friday, October 1, 2021 10:16 AM
> To: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
> 
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> This change is as per suggestions from Coccinelle, e.g.,
>   drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints
> an error
> 
> Related:
>   https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/
>   https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/
> 
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---
>  drivers/pci/controller/dwc/pcie-visconti.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks for your patch.

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

> 
> diff --git a/drivers/pci/controller/dwc/pcie-visconti.c b/drivers/pci/controller/dwc/pcie-visconti.c
> index a88eab6829bb..076da46726a7 100644
> --- a/drivers/pci/controller/dwc/pcie-visconti.c
> +++ b/drivers/pci/controller/dwc/pcie-visconti.c
> @@ -282,10 +282,8 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie,
>  	struct device *dev = &pdev->dev;
> 
>  	pp->irq = platform_get_irq_byname(pdev, "intr");
> -	if (pp->irq < 0) {
> -		dev_err(dev, "Interrupt intr is missing");
> +	if (pp->irq < 0)
>  		return pp->irq;
> -	}
> 
>  	pp->ops = &visconti_pcie_host_ops;
> 
> --
> 2.33.0

Best regards,
  Nobuhiro

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
@ 2021-10-01  4:38   ` nobuhiro1.iwamatsu
  0 siblings, 0 replies; 6+ messages in thread
From: nobuhiro1.iwamatsu @ 2021-10-01  4:38 UTC (permalink / raw)
  To: kw, bhelgaas; +Cc: lorenzo.pieralisi, linux-pci, linux-arm-kernel

Hi,

> -----Original Message-----
> From: Krzysztof Wilczyński [mailto:kw@linux.com]
> Sent: Friday, October 1, 2021 10:16 AM
> To: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
> 
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> This change is as per suggestions from Coccinelle, e.g.,
>   drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints
> an error
> 
> Related:
>   https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/
>   https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/
> 
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---
>  drivers/pci/controller/dwc/pcie-visconti.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Thanks for your patch.

Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

> 
> diff --git a/drivers/pci/controller/dwc/pcie-visconti.c b/drivers/pci/controller/dwc/pcie-visconti.c
> index a88eab6829bb..076da46726a7 100644
> --- a/drivers/pci/controller/dwc/pcie-visconti.c
> +++ b/drivers/pci/controller/dwc/pcie-visconti.c
> @@ -282,10 +282,8 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie,
>  	struct device *dev = &pdev->dev;
> 
>  	pp->irq = platform_get_irq_byname(pdev, "intr");
> -	if (pp->irq < 0) {
> -		dev_err(dev, "Interrupt intr is missing");
> +	if (pp->irq < 0)
>  		return pp->irq;
> -	}
> 
>  	pp->ops = &visconti_pcie_host_ops;
> 
> --
> 2.33.0

Best regards,
  Nobuhiro
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
  2021-10-01  1:16 ` Krzysztof Wilczyński
@ 2021-10-05  8:59   ` Lorenzo Pieralisi
  -1 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2021-10-05  8:59 UTC (permalink / raw)
  To: Krzysztof Wilczyński, Bjorn Helgaas
  Cc: Lorenzo Pieralisi, Nobuhiro Iwamatsu, linux-pci, linux-arm-kernel

On Fri, 1 Oct 2021 01:16:26 +0000, Krzysztof Wilczyński wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> This change is as per suggestions from Coccinelle, e.g.,
>   drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error
> 
> [...]

Applied to pci/dwc, thanks!

[1/1] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
      https://git.kernel.org/lpieralisi/pci/c/99e8fc7d35

Thanks,
Lorenzo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
@ 2021-10-05  8:59   ` Lorenzo Pieralisi
  0 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2021-10-05  8:59 UTC (permalink / raw)
  To: Krzysztof Wilczyński, Bjorn Helgaas
  Cc: Lorenzo Pieralisi, Nobuhiro Iwamatsu, linux-pci, linux-arm-kernel

On Fri, 1 Oct 2021 01:16:26 +0000, Krzysztof Wilczyński wrote:
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
> 
> This change is as per suggestions from Coccinelle, e.g.,
>   drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error
> 
> [...]

Applied to pci/dwc, thanks!

[1/1] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
      https://git.kernel.org/lpieralisi/pci/c/99e8fc7d35

Thanks,
Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-05  9:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01  1:16 [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname() Krzysztof Wilczyński
2021-10-01  1:16 ` Krzysztof Wilczyński
2021-10-01  4:38 ` nobuhiro1.iwamatsu
2021-10-01  4:38   ` nobuhiro1.iwamatsu
2021-10-05  8:59 ` Lorenzo Pieralisi
2021-10-05  8:59   ` Lorenzo Pieralisi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.