* [PATCH 1/1] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master
@ 2021-12-08 4:41 ` Kuninori Morimoto
0 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2021-12-08 4:41 UTC (permalink / raw)
To: Mark Brown, Rob Herring; +Cc: alsa-devel, devicetree, Kuninori Morimoto
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
snd_soc_daifmt_parse_clock_provider_raw() is handling both
bitclock/frame-master, and is supporting both flag/phandle.
Current DT is assuming it is flag style.
This patch allows both case.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
.../bindings/sound/audio-graph-port.yaml | 23 +++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index 43e7f86e3b23..6c3645a0d36b 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -14,6 +14,24 @@ select: false
allOf:
- $ref: /schemas/graph.yaml#/$defs/port-base
+definitions:
+ flag_or_phandle:
+ oneOf:
+ - type: boolean
+ const: true
+ - type: 'null'
+ - type: array
+ minItems: 1
+ maxItems: 1
+ items:
+ type: array
+ items:
+ phandle: true
+ type: integer
+ maximum: 0xffffffff
+ minItems: 1
+ maxItems: 1
+
properties:
prefix:
description: "device name prefix"
@@ -42,10 +60,11 @@ patternProperties:
$ref: /schemas/types.yaml#/definitions/flag
frame-master:
description: Indicates dai-link frame master.
- $ref: /schemas/types.yaml#/definitions/phandle
+ $ref: "#/definitions/flag_or_phandle"
bitclock-master:
description: Indicates dai-link bit clock master
- $ref: /schemas/types.yaml#/definitions/phandle
+ $ref: "#/definitions/flag_or_phandle"
+
dai-format:
description: audio format.
items:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master
@ 2021-12-08 4:41 ` Kuninori Morimoto
0 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2021-12-08 4:41 UTC (permalink / raw)
To: Mark Brown, Rob Herring; +Cc: devicetree, alsa-devel, Kuninori Morimoto
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
snd_soc_daifmt_parse_clock_provider_raw() is handling both
bitclock/frame-master, and is supporting both flag/phandle.
Current DT is assuming it is flag style.
This patch allows both case.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
.../bindings/sound/audio-graph-port.yaml | 23 +++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index 43e7f86e3b23..6c3645a0d36b 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -14,6 +14,24 @@ select: false
allOf:
- $ref: /schemas/graph.yaml#/$defs/port-base
+definitions:
+ flag_or_phandle:
+ oneOf:
+ - type: boolean
+ const: true
+ - type: 'null'
+ - type: array
+ minItems: 1
+ maxItems: 1
+ items:
+ type: array
+ items:
+ phandle: true
+ type: integer
+ maximum: 0xffffffff
+ minItems: 1
+ maxItems: 1
+
properties:
prefix:
description: "device name prefix"
@@ -42,10 +60,11 @@ patternProperties:
$ref: /schemas/types.yaml#/definitions/flag
frame-master:
description: Indicates dai-link frame master.
- $ref: /schemas/types.yaml#/definitions/phandle
+ $ref: "#/definitions/flag_or_phandle"
bitclock-master:
description: Indicates dai-link bit clock master
- $ref: /schemas/types.yaml#/definitions/phandle
+ $ref: "#/definitions/flag_or_phandle"
+
dai-format:
description: audio format.
items:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH 1/1] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master
2021-12-08 4:41 ` Kuninori Morimoto
@ 2021-12-08 6:45 ` Kuninori Morimoto
-1 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2021-12-08 6:45 UTC (permalink / raw)
To: Kuninori Morimoto, Mark Brown, Rob Herring; +Cc: alsa-devel, devicetree
Hi Mark, Rob
> snd_soc_daifmt_parse_clock_provider_raw() is handling both
> bitclock/frame-master, and is supporting both flag/phandle.
> Current DT is assuming it is flag style.
> This patch allows both case.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
It was not good patch.
I will re-post v2 patch. Please drop this.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/1] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master
@ 2021-12-08 6:45 ` Kuninori Morimoto
0 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2021-12-08 6:45 UTC (permalink / raw)
To: Kuninori Morimoto, Mark Brown, Rob Herring; +Cc: devicetree, alsa-devel
Hi Mark, Rob
> snd_soc_daifmt_parse_clock_provider_raw() is handling both
> bitclock/frame-master, and is supporting both flag/phandle.
> Current DT is assuming it is flag style.
> This patch allows both case.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
It was not good patch.
I will re-post v2 patch. Please drop this.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-08 6:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 4:41 [PATCH 1/1] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master Kuninori Morimoto
2021-12-08 4:41 ` Kuninori Morimoto
2021-12-08 6:45 ` Kuninori Morimoto
2021-12-08 6:45 ` Kuninori Morimoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.