[PATCH 0/3] Minor fixes for RZ/V2M

[PATCH 0/3] Minor fixes for RZ/V2M

[Fabrizio Castro]

Dear All,

this series aims at improving a couple of couple of things
found in r9a09g011.dtsi:
* unit address error for the gic node
* SoC specific compatible string for I2C nodes

Since it's early days for r9a09g011.dtsi, and compatible
renesas,i2c-r9a09g011 isn't being actively used at the moment,
I think it's safe to change to make compatible strings less
confusing.

Thanks,
Fab

Fabrizio Castro (3):
  arm64: dts: renesas: r9a09g011: Fix unit address format error
  dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string
  arm64: dts: renesas: r9a09g011: Fix I2C SoC specific strings

 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
 arch/arm64/boot/dts/renesas/r9a09g011.dtsi               | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.34.1

[PATCH 1/3] arm64: dts: renesas: r9a09g011: Fix unit address format error

[Fabrizio Castro]

Although the HW User Manual for RZ/V2M states in the "Address Map"
section that the interrupt controller is assigned addresses starting
from 0x82000000, the memory locations from 0x82000000 0x0x8200FFFF
are marked as reserved in the "Interrupt Controller (GIC)" section
and are currently not used by the device tree, leading to the below
warning:

arch/arm64/boot/dts/renesas/r9a09g011.dtsi:51.38-63.5: Warning
(simple_bus_reg): /soc/interrupt-controller@82000000: simple-bus unit
address format error, expected "82010000"

Fix the unit address accordingly.

Fixes: fb1929b98f2e ("arm64: dts: renesas: Add initial DTSI for RZ/V2M SoC")
Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
index 9859c717bd10..1948d2e6bcae 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
@@ -48,7 +48,7 @@ soc: soc {
 		#size-cells = <2>;
 		ranges;
 
-		gic: interrupt-controller@82000000 {
+		gic: interrupt-controller@82010000 {
 			compatible = "arm,gic-400";
 			#interrupt-cells = <3>;
 			#address-cells = <0>;
-- 
2.34.1

[PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string

[Fabrizio Castro]

s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.

renesas,i2c-r9a09g011 is not actually used by the driver, therefore
changing this doesn't cause any harm.

Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")
Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
index c46378efc123..92e899905ef8 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
@@ -16,7 +16,7 @@ properties:
   compatible:
     items:
       - enum:
-          - renesas,i2c-r9a09g011  # RZ/V2M
+          - renesas,r9a09g011-i2c  # RZ/V2M
       - const: renesas,rzv2m-i2c
 
   reg:
@@ -66,7 +66,7 @@ examples:
     #include <dt-bindings/interrupt-controller/arm-gic.h>
 
     i2c0: i2c@a4030000 {
-        compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c";
+        compatible = "renesas,r9a09g011-i2c", "renesas,rzv2m-i2c";
         reg = <0xa4030000 0x80>;
         interrupts = <GIC_SPI 232 IRQ_TYPE_EDGE_RISING>,
                      <GIC_SPI 236 IRQ_TYPE_EDGE_RISING>;
-- 
2.34.1

[PATCH 3/3] arm64: dts: renesas: r9a09g011: Fix I2C SoC specific strings

[Fabrizio Castro]

s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.

renesas,i2c-r9a09g011 is not actually used by the driver, therefore
changing this doesn't cause any harm.

Fixes: 54ac6794df9d ("arm64: dts: renesas: r9a09g011: Add i2c nodes")
Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
index 1948d2e6bcae..2ccd48ee9880 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
@@ -126,7 +126,7 @@ cpg: clock-controller@a3500000 {
 		i2c0: i2c@a4030000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
-			compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c";
+			compatible = "renesas,r9a09g011-i2c", "renesas,rzv2m-i2c";
 			reg = <0 0xa4030000 0 0x80>;
 			interrupts = <GIC_SPI 232 IRQ_TYPE_EDGE_RISING>,
 				     <GIC_SPI 236 IRQ_TYPE_EDGE_RISING>;
@@ -140,7 +140,7 @@ i2c0: i2c@a4030000 {
 		i2c2: i2c@a4030100 {
 			#address-cells = <1>;
 			#size-cells = <0>;
-			compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c";
+			compatible = "renesas,r9a09g011-i2c", "renesas,rzv2m-i2c";
 			reg = <0 0xa4030100 0 0x80>;
 			interrupts = <GIC_SPI 234 IRQ_TYPE_EDGE_RISING>,
 				     <GIC_SPI 238 IRQ_TYPE_EDGE_RISING>;
-- 
2.34.1

Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string

[Krzysztof Kozlowski]

On 03/11/2022 19:06, Fabrizio Castro wrote:
> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
> 
> renesas,i2c-r9a09g011 is not actually used by the driver, therefore
> changing this doesn't cause any harm.

And what about other users of DTS? One chosen driver implementation
might not be enough...

> 
> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")

You need to explain the bug - where is the issue, how it affects users.
Otherwise it is not a bug and there is nothing to fix.


> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>  Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> index c46378efc123..92e899905ef8 100644
> --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> @@ -16,7 +16,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> -          - renesas,i2c-r9a09g011  # RZ/V2M
> +          - renesas,r9a09g011-i2c  # RZ/V2M

No.

Deprecate instead old compatible. There are already users of it, at
least in kernel. Not sure about other OS/bootloaders/firmwares.

Best regards,
Krzysztof

Re: [PATCH 1/3] arm64: dts: renesas: r9a09g011: Fix unit address format error

[Geert Uytterhoeven]

On Fri, Nov 4, 2022 at 12:07 AM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> Although the HW User Manual for RZ/V2M states in the "Address Map"
> section that the interrupt controller is assigned addresses starting
> from 0x82000000, the memory locations from 0x82000000 0x0x8200FFFF
> are marked as reserved in the "Interrupt Controller (GIC)" section
> and are currently not used by the device tree, leading to the below
> warning:
>
> arch/arm64/boot/dts/renesas/r9a09g011.dtsi:51.38-63.5: Warning
> (simple_bus_reg): /soc/interrupt-controller@82000000: simple-bus unit
> address format error, expected "82010000"
>
> Fix the unit address accordingly.
>
> Fixes: fb1929b98f2e ("arm64: dts: renesas: Add initial DTSI for RZ/V2M SoC")
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.2.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string

[Geert Uytterhoeven]

Hi Krzysztof,

On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 03/11/2022 19:06, Fabrizio Castro wrote:
> > s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
> >
> > renesas,i2c-r9a09g011 is not actually used by the driver, therefore
> > changing this doesn't cause any harm.
>
> And what about other users of DTS? One chosen driver implementation
> might not be enough...
>
> >
> > Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")
>
> You need to explain the bug - where is the issue, how it affects users.
> Otherwise it is not a bug and there is nothing to fix.

Yep.

    The preferred form is "<vendor>,<family>-<module>", blah blah ...

> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> > index c46378efc123..92e899905ef8 100644
> > --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> > @@ -16,7 +16,7 @@ properties:
> >    compatible:
> >      items:
> >        - enum:
> > -          - renesas,i2c-r9a09g011  # RZ/V2M
> > +          - renesas,r9a09g011-i2c  # RZ/V2M
>
> No.
>
> Deprecate instead old compatible. There are already users of it, at
> least in kernel. Not sure about other OS/bootloaders/firmwares.

As stated in the cover letter:

    Since it's early days for r9a09g011.dtsi, and compatible
    renesas,i2c-r9a09g011 isn't being actively used at the moment,
    I think it's safe to change to make compatible strings less
    confusing.

The bindings entered in v6.0.
The first user in the kernel is not yet in a released kernel, it will
be in v6.1. So it can still be fixed in v6.1...
Even if we don't fix it before v6.2, I don't think there is much harm in
making this change.

With the patch description improved:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string

[Krzysztof Kozlowski]

On 04/11/2022 04:55, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 03/11/2022 19:06, Fabrizio Castro wrote:
>>> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
>>>
>>> renesas,i2c-r9a09g011 is not actually used by the driver, therefore
>>> changing this doesn't cause any harm.
>>
>> And what about other users of DTS? One chosen driver implementation
>> might not be enough...
>>
>>>
>>> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C controller")
>>
>> You need to explain the bug - where is the issue, how it affects users.
>> Otherwise it is not a bug and there is nothing to fix.
> 
> Yep.
> 
>     The preferred form is "<vendor>,<family>-<module>", blah blah ...
> 
>>> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>>> ---
>>>  Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
>>> index c46378efc123..92e899905ef8 100644
>>> --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
>>> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
>>> @@ -16,7 +16,7 @@ properties:
>>>    compatible:
>>>      items:
>>>        - enum:
>>> -          - renesas,i2c-r9a09g011  # RZ/V2M
>>> +          - renesas,r9a09g011-i2c  # RZ/V2M
>>
>> No.
>>
>> Deprecate instead old compatible. There are already users of it, at
>> least in kernel. Not sure about other OS/bootloaders/firmwares.
> 
> As stated in the cover letter:
> 
>     Since it's early days for r9a09g011.dtsi, and compatible
>     renesas,i2c-r9a09g011 isn't being actively used at the moment,
>     I think it's safe to change to make compatible strings less
>     confusing.
> 
> The bindings entered in v6.0.
> The first user in the kernel is not yet in a released kernel, it will
> be in v6.1. So it can still be fixed in v6.1...
> Even if we don't fix it before v6.2, I don't think there is much harm in
> making this change.
> 

ABI break reasons should be explained in the commit because cover letter
does not get merged.

Best regards,
Krzysztof

RE: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific string

[Fabrizio Castro]

Hi Krzysztof and Geert,

Thanks for your feedback, I'll send a new version of the bindings and DT
patches to improve the changelog.

Thanks,
Fab

> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 04 November 2022 12:55
> Subject: Re: [PATCH 2/3] dt-bindings: i2c: renesas,rzv2m: Fix SoC specific
> string
> 
> On 04/11/2022 04:55, Geert Uytterhoeven wrote:
> > Hi Krzysztof,
> >
> > On Fri, Nov 4, 2022 at 2:48 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >> On 03/11/2022 19:06, Fabrizio Castro wrote:
> >>> s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency.
> >>>
> >>> renesas,i2c-r9a09g011 is not actually used by the driver, therefore
> >>> changing this doesn't cause any harm.
> >>
> >> And what about other users of DTS? One chosen driver implementation
> >> might not be enough...
> >>
> >>>
> >>> Fixes: ba7a4d15e2c4 ("dt-bindings: i2c: Document RZ/V2M I2C
> controller")
> >>
> >> You need to explain the bug - where is the issue, how it affects users.
> >> Otherwise it is not a bug and there is nothing to fix.
> >
> > Yep.
> >
> >     The preferred form is "<vendor>,<family>-<module>", blah blah ...
> >
> >>> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml | 4 ++--
> >>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> >>> index c46378efc123..92e899905ef8 100644
> >>> --- a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> >>> +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
> >>> @@ -16,7 +16,7 @@ properties:
> >>>    compatible:
> >>>      items:
> >>>        - enum:
> >>> -          - renesas,i2c-r9a09g011  # RZ/V2M
> >>> +          - renesas,r9a09g011-i2c  # RZ/V2M
> >>
> >> No.
> >>
> >> Deprecate instead old compatible. There are already users of it, at
> >> least in kernel. Not sure about other OS/bootloaders/firmwares.
> >
> > As stated in the cover letter:
> >
> >     Since it's early days for r9a09g011.dtsi, and compatible
> >     renesas,i2c-r9a09g011 isn't being actively used at the moment,
> >     I think it's safe to change to make compatible strings less
> >     confusing.
> >
> > The bindings entered in v6.0.
> > The first user in the kernel is not yet in a released kernel, it will
> > be in v6.1. So it can still be fixed in v6.1...
> > Even if we don't fix it before v6.2, I don't think there is much harm in
> > making this change.
> >
> 
> ABI break reasons should be explained in the commit because cover letter
> does not get merged.
> 
> Best regards,
> Krzysztof