From: Chris Brandt <Chris.Brandt@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>,
Linux-Renesas" <linux-renesas-soc@vger.kernel.org>,
Simon Horman <horms+renesas@verge.net.au>
Subject: RE: [PATCH v2 2/3] serial: sh-sci: Add support for separate TEI+DRI interrupts
Date: Thu, 26 Jul 2018 12:16:54 +0000 [thread overview]
Message-ID: <TYXPR01MB1568937DFF057AC653012AB78A2B0@TYXPR01MB1568.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXxyAuhW-+Vh_TE7M+uFT6HYngg2BAg8inVJB6qhOuXmg@mail.gmail.com>
Hi Geert,
On Thursday, July 26, 2018, Geert Uytterhoeven wrote:
> > +static irqreturn_t sci_br_interrupt(int irq, void *ptr);
>
> You can avoid the forward declaration by moving the whole function here.
OK.
> > @@ -2809,6 +2845,8 @@ static int sci_init_single(struct platform_device
> *dev,
> > sci_port->irqs[1] = sci_port->irqs[0];
> > sci_port->irqs[2] = sci_port->irqs[0];
> > sci_port->irqs[3] = sci_port->irqs[0];
> > + sci_port->irqs[4] = sci_port->irqs[0];
> > + sci_port->irqs[5] = sci_port->irqs[0];
>
> You may want to start using a loop from 1 to ARRAY_SIZE(sci_port->irqs) -
> 1
> instead.
OK, I'll change it.
Chris
next prev parent reply other threads:[~2018-07-26 12:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 14:38 [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2 Chris Brandt
2018-07-25 14:38 ` [PATCH v2 1/3] serial: sh-sci: Allow for compressed SCIF address space Chris Brandt
2018-07-26 11:31 ` Geert Uytterhoeven
2018-07-26 12:14 ` Chris Brandt
2018-07-26 12:14 ` Chris Brandt
2018-07-26 12:41 ` Geert Uytterhoeven
2018-07-25 14:38 ` [PATCH v2 2/3] serial: sh-sci: Add support for separate TEI+DRI interrupts Chris Brandt
2018-07-26 11:39 ` Geert Uytterhoeven
2018-07-26 12:16 ` Chris Brandt [this message]
2018-07-26 12:16 ` Chris Brandt
2018-07-25 14:38 ` [PATCH v2 3/3] serial: sh-sci: Document r7s9210 bindings Chris Brandt
2018-07-26 11:41 ` Geert Uytterhoeven
2018-07-26 12:18 ` Chris Brandt
2018-07-26 12:18 ` Chris Brandt
2018-07-30 23:19 ` Rob Herring
2018-07-26 11:43 ` [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2 Geert Uytterhoeven
2018-07-26 12:25 ` Chris Brandt
2018-07-26 12:25 ` Chris Brandt
2018-07-26 13:01 ` Geert Uytterhoeven
2018-07-26 13:10 ` Chris Brandt
2018-07-26 13:10 ` Chris Brandt
2018-07-28 14:55 ` Greg KH
2018-07-28 15:55 ` Chris Brandt
2018-07-28 15:55 ` Chris Brandt
2018-07-31 10:27 ` Simon Horman
2018-07-28 19:28 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYXPR01MB1568937DFF057AC653012AB78A2B0@TYXPR01MB1568.jpnprd01.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.