[PATCH 0/2] ARM: dts: r7s72100: Correct interrupt types

[PATCH 0/2] ARM: dts: r7s72100: Correct interrupt types

[Geert Uytterhoeven]

	Hi Simon, Magnus,

RZ/A1H peripherals use a mix of level and edge interrupts.

This patch series corrects the interrupt types for watchdog and RTC from
edge to level, to match the datasheet.

Is there any easy way to test this?
The watchdog interrupt is not used by the Linux driver.
The RTC interrupts are used, but how to trigger them?

Thanks!

Geert Uytterhoeven (2):
  ARM: dts: r7s72100: Correct watchdog timer interrupt type
  ARM: dts: r7s72100: Correct RTC interrupt types

 arch/arm/boot/dts/r7s72100.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.7.4

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] ARM: dts: r7s72100: Correct watchdog timer interrupt type

[Geert Uytterhoeven]

According to table 7.3 ("List of Interrupt IDs") in the RZ/A1H Hardware
User's Manual rev. 3.00, the watchdog timer interrupt is a level
interrupt.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r7s72100.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index 4a1aade0e751c3ff..c7b3dca6d81cc3f9 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -387,7 +387,7 @@
 		wdt: watchdog@fcfe0000 {
 			compatible = "renesas,r7s72100-wdt", "renesas,rza-wdt";
 			reg = <0xfcfe0000 0x6>;
-			interrupts = <GIC_SPI 106 IRQ_TYPE_EDGE_RISING>;
+			interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&p0_clk>;
 		};
 
-- 
2.7.4

[PATCH 2/2] ARM: dts: r7s72100: Correct RTC interrupt types

[Geert Uytterhoeven]

According to table 7.3 ("List of Interrupt IDs") in the RZ/A1H Hardware
User's Manual rev. 3.00, the realtime clock interrupts are level not
edge interrupts.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r7s72100.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index c7b3dca6d81cc3f9..eb2e6f95a2e85862 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -682,9 +682,9 @@
 		rtc: rtc@fcff1000 {
 			compatible = "renesas,r7s72100-rtc", "renesas,sh-rtc";
 			reg = <0xfcff1000 0x2e>;
-			interrupts = <GIC_SPI 276 IRQ_TYPE_EDGE_RISING
-				      GIC_SPI 277 IRQ_TYPE_EDGE_RISING
-				      GIC_SPI 278 IRQ_TYPE_EDGE_RISING>;
+			interrupts = <GIC_SPI 276 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 277 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "alarm", "period", "carry";
 			clocks = <&mstp6_clks R7S72100_CLK_RTC>, <&rtc_x1_clk>,
 				 <&rtc_x3_clk>, <&extal_clk>;
-- 
2.7.4

RE: [PATCH 0/2] ARM: dts: r7s72100: Correct interrupt types

[Chris Brandt]

Hi Geert,

On Monday, May 07, 2018, Geert Uytterhoeven wrote:
> 
> 	Hi Simon, Magnus,
> 
> RZ/A1H peripherals use a mix of level and edge interrupts.
> 
> This patch series corrects the interrupt types for watchdog and RTC from
> edge to level, to match the datasheet.
> 
> Is there any easy way to test this?
> The watchdog interrupt is not used by the Linux driver.
> The RTC interrupts are used, but how to trigger them?

Honestly, I can't remember if I did that for a reason, or it was just an
oversight.

Like you mentioned, the watchdog driver does not use interrupts, it 
simply resets system on overflow.

As for RTC, I thought I remember setting an 'alarm' and testing the code
did work. But, I can't seem to find any leftover test scripts (so did I
really do that????)

I would say make the changes anyway as they should match what is in the 
hardware manual.


Chris

Re: [PATCH 0/2] ARM: dts: r7s72100: Correct interrupt types

[Simon Horman]

On Mon, May 07, 2018 at 02:39:13PM +0000, Chris Brandt wrote:
> Hi Geert,
> 
> On Monday, May 07, 2018, Geert Uytterhoeven wrote:
> > 
> > 	Hi Simon, Magnus,
> > 
> > RZ/A1H peripherals use a mix of level and edge interrupts.
> > 
> > This patch series corrects the interrupt types for watchdog and RTC from
> > edge to level, to match the datasheet.
> > 
> > Is there any easy way to test this?
> > The watchdog interrupt is not used by the Linux driver.
> > The RTC interrupts are used, but how to trigger them?
> 
> Honestly, I can't remember if I did that for a reason, or it was just an
> oversight.
> 
> Like you mentioned, the watchdog driver does not use interrupts, it 
> simply resets system on overflow.
> 
> As for RTC, I thought I remember setting an 'alarm' and testing the code
> did work. But, I can't seem to find any leftover test scripts (so did I
> really do that????)
> 
> I would say make the changes anyway as they should match what is in the 
> hardware manual.

Thanks, applied.