[cocci] Matching an if statement with just one func call

[cocci] Matching an if statement with just one func call

[Phil Edworthy]

Hi,

I'm trying to get my coccinelle test to detect code in
the Linux kernel similar to:
if (!clk)
   clk_disable_unprepare(clk);

So far, I have got:
expression clk;
position p1,p2;
@@

if@p1 ( \( !clk \| clk != NULL \| !IS_ERR(clk) \) )
{ ...
clk_disable_unprepare@p2(clk)
}

However, I don't want to pick up code where something else is covered
by the if statement, such as:
if (!clk) {
   do_something_else;
   clk_disable_unprepare(clk);
}

I know it's related to the ... but I can't get it to work.
Sorry, I'm a coccinelle newbie.

Any help appreciated!

Thanks
Phil

Re: [cocci] Matching an if statement with just one func call

[Julia Lawall]

On Mon, 16 May 2022, Phil Edworthy wrote:

> Hi,
>
> I'm trying to get my coccinelle test to detect code in
> the Linux kernel similar to:
> if (!clk)
>    clk_disable_unprepare(clk);
>
> So far, I have got:
> expression clk;
> position p1,p2;
> @@
>
> if@p1 ( \( !clk \| clk != NULL \| !IS_ERR(clk) \) )
> { ...

Drop the ...

> clk_disable_unprepare@p2(clk)

Add a ; after the above.

julia

> }
>
> However, I don't want to pick up code where something else is covered
> by the if statement, such as:
> if (!clk) {
>    do_something_else;
>    clk_disable_unprepare(clk);
> }
>
> I know it's related to the ... but I can't get it to work.
> Sorry, I'm a coccinelle newbie.
>
> Any help appreciated!
>
> Thanks
> Phil
>

RE: [cocci] Matching an if statement with just one func call

[Phil Edworthy]

Simple as that, all working now.
Thanks Julia!

On 16 May 2022 21:22 Julia Lawall wrote:
> On Mon, 16 May 2022, Phil Edworthy wrote:
> 
> > Hi,
> >
> > I'm trying to get my coccinelle test to detect code in the Linux
> > kernel similar to:
> > if (!clk)
> >    clk_disable_unprepare(clk);
> >
> > So far, I have got:
> > expression clk;
> > position p1,p2;
> > @@
> >
> > if@p1 ( \( !clk \| clk != NULL \| !IS_ERR(clk) \) ) { ...
> 
> Drop the ...
> 
> > clk_disable_unprepare@p2(clk)
> 
> Add a ; after the above.
> 
> julia
> 
> > }
> >
> > However, I don't want to pick up code where something else is covered
> > by the if statement, such as:
> > if (!clk) {
> >    do_something_else;
> >    clk_disable_unprepare(clk);
> > }
> >
> > I know it's related to the ... but I can't get it to work.
> > Sorry, I'm a coccinelle newbie.
> >
> > Any help appreciated!
> >
> > Thanks
> > Phil
> >