All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: msm8916-ufi: make UDC dual mode
@ 2023-05-05 16:32 Yang Xiwen
  2023-05-25  4:53 ` Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Xiwen @ 2023-05-05 16:32 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski
  Cc: Nikita Travkin, ~postmarketos/upstreaming, linux-arm-msm,
	devicetree, linux-kernel

It's possible to use this device with a (non-standard) hub to get USB
working in host mode, but dr_mode="peripheral" prevents the UDC to
do so.
Remove dr_mode="peripheral" and add usb-role-switch so that it defaults
to otg mode and can be switched to host mode in userspace.

Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
 arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
index 50bae6f214f1f..08ecd901c1af6 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi
@@ -109,7 +109,7 @@ &sdhc_1 {

 &usb {
 	extcon = <&pm8916_usbin>;
-	dr_mode = "peripheral";
+	usb-role-switch;

 	status = "okay";
 };
-- 
2.39.1


-- 
Best regards,
Yang Xiwen

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: qcom: msm8916-ufi: make UDC dual mode
  2023-05-05 16:32 [PATCH] arm64: dts: qcom: msm8916-ufi: make UDC dual mode Yang Xiwen
@ 2023-05-25  4:53 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2023-05-25  4:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Yang Xiwen, Konrad Dybcio, Rob Herring, Andy Gross
  Cc: linux-kernel, linux-arm-msm, Nikita Travkin, devicetree,
	~postmarketos/upstreaming

On Sat, 6 May 2023 00:32:51 +0800, Yang Xiwen wrote:
> It's possible to use this device with a (non-standard) hub to get USB
> working in host mode, but dr_mode="peripheral" prevents the UDC to
> do so.
> Remove dr_mode="peripheral" and add usb-role-switch so that it defaults
> to otg mode and can be switched to host mode in userspace.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: msm8916-ufi: make UDC dual mode
      commit: 06a9f50c20b5d5fcec9cb0d44b759c4183c7bbd5

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-05-25  4:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-05 16:32 [PATCH] arm64: dts: qcom: msm8916-ufi: make UDC dual mode Yang Xiwen
2023-05-25  4:53 ` Bjorn Andersson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.