From: Simon Ser <contact@emersion.fr> To: Sidong Yang <realwakka@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch>, Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>, Haneen Mohammed <hamohammed.sa@gmail.com>, Emil Velikov <emil.l.velikov@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Melissa Wen <melissa.srw@gmail.com> Subject: Re: [PATCH] drm/vkms: add support for gamma_set interface Date: Mon, 31 Aug 2020 11:39:10 +0000 [thread overview] Message-ID: <UeJwFKvmNgKdZY_icN0-nrFly9R1vbzaMZ-TiyxIIPBcdl278uZsK6YdTTdRl6rFukBAmN-eyCFpnfsIB-El9QpyYiutdcpgJg64n4tsRRc=@emersion.fr> (raw) In-Reply-To: <20200829140647.7626-1-realwakka@gmail.com> On Saturday, August 29, 2020 4:06 PM, Sidong Yang <realwakka@gmail.com> wrote: > Currently vkms module doesn't support gamma function for userspace. so igt > subtests in kms_plane(pixel-format-pipe-A-plan) failed for calling > drmModeCrtcSetGamma(). It doesn't seem like this IGT test's goal is to exercise support for gamma LUTs. Does the test just tries to reset the gamma LUT to linear? If so, I think the IGT test should be fixed to ignore "I don't support gamma" errors. > This patch set gamma_set interface in vkms_crtc_funcs for > support gamma function. With initializing crtc, added calls for setting gamma > size. it pass the test after this patch. > > Cc: Daniel Vetter<daniel@ffwll.ch> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > Cc: Haneen Mohammed <hamohammed.sa@gmail.com> > > Signed-off-by: Sidong Yang <realwakka@gmail.com> > --- > drivers/gpu/drm/vkms/vkms_crtc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > index ac85e17428f8..643435fb2ee6 100644 > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > @@ -160,6 +160,7 @@ static const struct drm_crtc_funcs vkms_crtc_funcs = { > .get_crc_sources = vkms_get_crc_sources, > .set_crc_source = vkms_set_crc_source, > .verify_crc_source = vkms_verify_crc_source, > + .gamma_set = drm_atomic_helper_legacy_gamma_set, Why does VKMS need to use a legacy helper? It seems like this patch just advertises support for gamma LUTs, but ignores any value set by user-space. If VKMS advertises support for gamma LUTs, it needs to take the LUT into account when blending planes. > }; > > static int vkms_crtc_atomic_check(struct drm_crtc *crtc, > @@ -275,6 +276,13 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > return ret; > } > > + ret = drm_mode_crtc_set_gamma_size(crtc, 256); > + if (ret) { > + DRM_ERROR("Failed to set gamma size\n"); > + return ret; > + } > + drm_crtc_enable_color_mgmt(crtc, 0, false, 256); > + > drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs); > > spin_lock_init(&vkms_out->lock); > -- > 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Simon Ser <contact@emersion.fr> To: Sidong Yang <realwakka@gmail.com> Cc: Haneen Mohammed <hamohammed.sa@gmail.com>, Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>, Emil Velikov <emil.l.velikov@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, Melissa Wen <melissa.srw@gmail.com> Subject: Re: [PATCH] drm/vkms: add support for gamma_set interface Date: Mon, 31 Aug 2020 11:39:10 +0000 [thread overview] Message-ID: <UeJwFKvmNgKdZY_icN0-nrFly9R1vbzaMZ-TiyxIIPBcdl278uZsK6YdTTdRl6rFukBAmN-eyCFpnfsIB-El9QpyYiutdcpgJg64n4tsRRc=@emersion.fr> (raw) In-Reply-To: <20200829140647.7626-1-realwakka@gmail.com> On Saturday, August 29, 2020 4:06 PM, Sidong Yang <realwakka@gmail.com> wrote: > Currently vkms module doesn't support gamma function for userspace. so igt > subtests in kms_plane(pixel-format-pipe-A-plan) failed for calling > drmModeCrtcSetGamma(). It doesn't seem like this IGT test's goal is to exercise support for gamma LUTs. Does the test just tries to reset the gamma LUT to linear? If so, I think the IGT test should be fixed to ignore "I don't support gamma" errors. > This patch set gamma_set interface in vkms_crtc_funcs for > support gamma function. With initializing crtc, added calls for setting gamma > size. it pass the test after this patch. > > Cc: Daniel Vetter<daniel@ffwll.ch> > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> > Cc: Haneen Mohammed <hamohammed.sa@gmail.com> > > Signed-off-by: Sidong Yang <realwakka@gmail.com> > --- > drivers/gpu/drm/vkms/vkms_crtc.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > index ac85e17428f8..643435fb2ee6 100644 > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > @@ -160,6 +160,7 @@ static const struct drm_crtc_funcs vkms_crtc_funcs = { > .get_crc_sources = vkms_get_crc_sources, > .set_crc_source = vkms_set_crc_source, > .verify_crc_source = vkms_verify_crc_source, > + .gamma_set = drm_atomic_helper_legacy_gamma_set, Why does VKMS need to use a legacy helper? It seems like this patch just advertises support for gamma LUTs, but ignores any value set by user-space. If VKMS advertises support for gamma LUTs, it needs to take the LUT into account when blending planes. > }; > > static int vkms_crtc_atomic_check(struct drm_crtc *crtc, > @@ -275,6 +276,13 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > return ret; > } > > + ret = drm_mode_crtc_set_gamma_size(crtc, 256); > + if (ret) { > + DRM_ERROR("Failed to set gamma size\n"); > + return ret; > + } > + drm_crtc_enable_color_mgmt(crtc, 0, false, 256); > + > drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs); > > spin_lock_init(&vkms_out->lock); > -- > 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-31 11:39 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-29 14:06 [PATCH] drm/vkms: add support for gamma_set interface Sidong Yang 2020-08-29 14:06 ` Sidong Yang 2020-08-31 11:39 ` Simon Ser [this message] 2020-08-31 11:39 ` Simon Ser 2020-08-31 13:38 ` Sidong Yang 2020-08-31 13:38 ` Sidong Yang 2020-08-31 13:48 ` Ville Syrjälä 2020-08-31 13:48 ` Ville Syrjälä 2020-09-01 8:57 ` Simon Ser 2020-09-01 8:57 ` Simon Ser 2020-09-01 13:26 ` Daniel Vetter 2020-09-01 13:26 ` Daniel Vetter 2020-09-02 9:09 ` Simon Ser 2020-09-02 9:09 ` Simon Ser 2020-09-02 11:51 ` Ville Syrjälä 2020-09-02 11:51 ` Ville Syrjälä
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='UeJwFKvmNgKdZY_icN0-nrFly9R1vbzaMZ-TiyxIIPBcdl278uZsK6YdTTdRl6rFukBAmN-eyCFpnfsIB-El9QpyYiutdcpgJg64n4tsRRc=@emersion.fr' \ --to=contact@emersion.fr \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.l.velikov@gmail.com \ --cc=hamohammed.sa@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=melissa.srw@gmail.com \ --cc=realwakka@gmail.com \ --cc=rodrigosiqueiramelo@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.