All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] board: fsl: lx2160aqds: fix 'compatible' property
@ 2019-08-19 15:56 Florin Chiculita
       [not found] ` <VI1PR0402MB3854698D2B304CE5663412DD978C0@VI1PR0402MB3854.eurprd04.prod.outlook.com>
  0 siblings, 1 reply; 2+ messages in thread
From: Florin Chiculita @ 2019-08-19 15:56 UTC (permalink / raw)
  To: u-boot

The code that generates the compatible property concatenates the
ethernet phy id and clause-compatible information without
separating them with a comma, therefore no ethernet phy driver will
be loaded by Linux kernel.

Signed-off-by: Florin Chiculita <florinlaurentiu.chiculita@nxp.com>
---
 board/freescale/lx2160a/eth_lx2160aqds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/freescale/lx2160a/eth_lx2160aqds.c b/board/freescale/lx2160a/eth_lx2160aqds.c
index f6e22d7..e8e4dd8 100644
--- a/board/freescale/lx2160a/eth_lx2160aqds.c
+++ b/board/freescale/lx2160a/eth_lx2160aqds.c
@@ -685,7 +685,7 @@ int fdt_create_phy_node(void *fdt, int offset, u8 phyaddr, int *subnodeoffset,
 			struct phy_device *phy_dev, int phandle)
 {
 	char phy_node_name[] = "ethernet-phy at 00";
-	char phy_id_compatible_str[] = "ethernet-phy-id0000.0000";
+	char phy_id_compatible_str[] = "ethernet-phy-id0000.0000,";
 	int ret;
 
 	sprintf(phy_node_name, "ethernet-phy@%x", phyaddr);
@@ -699,7 +699,7 @@ int fdt_create_phy_node(void *fdt, int offset, u8 phyaddr, int *subnodeoffset,
 		return *subnodeoffset;
 	}
 
-	sprintf(phy_id_compatible_str, "ethernet-phy-id%04x.%04x",
+	sprintf(phy_id_compatible_str, "ethernet-phy-id%04x.%04x,",
 		phy_dev->phy_id >> 16, phy_dev->phy_id & 0xFFFF);
 	debug("phy_id_compatible_str %s\n", phy_id_compatible_str);
 
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] board: fsl: lx2160aqds: fix 'compatible' property
       [not found] ` <VI1PR0402MB3854698D2B304CE5663412DD978C0@VI1PR0402MB3854.eurprd04.prod.outlook.com>
@ 2019-09-16  6:10   ` Priyanka Jain
  0 siblings, 0 replies; 2+ messages in thread
From: Priyanka Jain @ 2019-09-16  6:10 UTC (permalink / raw)
  To: u-boot

>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Florin Chiculita
>Sent: Monday, August 19, 2019 9:27 PM
>To: u-boot at lists.denx.de
>Subject: [U-Boot] [PATCH] board: fsl: lx2160aqds: fix 'compatible' property
>
>The code that generates the compatible property concatenates the ethernet phy
>id and clause-compatible information without separating them with a comma,
>therefore no ethernet phy driver will be loaded by Linux kernel.
>
>Signed-off-by: Florin Chiculita <florinlaurentiu.chiculita@nxp.com>
>---
Slight update in subject and description
Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-16  6:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 15:56 [U-Boot] [PATCH] board: fsl: lx2160aqds: fix 'compatible' property Florin Chiculita
     [not found] ` <VI1PR0402MB3854698D2B304CE5663412DD978C0@VI1PR0402MB3854.eurprd04.prod.outlook.com>
2019-09-16  6:10   ` Priyanka Jain

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.