* [meta-oe][PATCH] volatile-binds: add /srv to mount and install
@ 2020-11-18 22:37 Sinan Kaya
2020-11-18 22:40 ` [OE-core] " Konrad Weihmann
0 siblings, 1 reply; 4+ messages in thread
From: Sinan Kaya @ 2020-11-18 22:37 UTC (permalink / raw)
To: openembedded-core; +Cc: Sinan Kaya
We are installing a service to volatile mount /srv
directory but we are not creating it on the target.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
meta/recipes-core/volatile-binds/volatile-binds.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb
index b273293e9a8..08bda6d14bc 100644
--- a/meta/recipes-core/volatile-binds/volatile-binds.bb
+++ b/meta/recipes-core/volatile-binds/volatile-binds.bb
@@ -36,6 +36,7 @@ def volatile_systemd_services(d):
SYSTEMD_SERVICE_${PN} = "${@volatile_systemd_services(d)}"
FILES_${PN} += "${systemd_unitdir}/system/*.service"
+FILES_${PN}_append = " ${servicedir}"
do_compile () {
while read spec mountpoint; do
@@ -64,6 +65,7 @@ do_compile[dirs] = "${WORKDIR}"
do_install () {
install -d ${D}${base_sbindir}
+ install -d ${D}${servicedir}
install -m 0755 mount-copybind ${D}${base_sbindir}/
install -d ${D}${systemd_unitdir}/system
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core] [meta-oe][PATCH] volatile-binds: add /srv to mount and install
2020-11-18 22:37 [meta-oe][PATCH] volatile-binds: add /srv to mount and install Sinan Kaya
@ 2020-11-18 22:40 ` Konrad Weihmann
2020-11-18 22:53 ` Sinan Kaya
0 siblings, 1 reply; 4+ messages in thread
From: Konrad Weihmann @ 2020-11-18 22:40 UTC (permalink / raw)
To: openembedded-core, okaya
On 18.11.20 23:37, Sinan Kaya wrote:
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> meta/recipes-core/volatile-binds/volatile-binds.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb
> index b273293e9a8..08bda6d14bc 100644
> --- a/meta/recipes-core/volatile-binds/volatile-binds.bb
> +++ b/meta/recipes-core/volatile-binds/volatile-binds.bb
> @@ -36,6 +36,7 @@ def volatile_systemd_services(d):
> SYSTEMD_SERVICE_${PN} = "${@volatile_systemd_services(d)}"
>
> FILES_${PN} += "${systemd_unitdir}/system/*.service"
> +FILES_${PN}_append = " ${servicedir}"
Just out of interest, why does that need to be an append?
Why can't that be part of the line above?
>
> do_compile () {
> while read spec mountpoint; do
> @@ -64,6 +65,7 @@ do_compile[dirs] = "${WORKDIR}"
>
> do_install () {
> install -d ${D}${base_sbindir}
> + install -d ${D}${servicedir}
> install -m 0755 mount-copybind ${D}${base_sbindir}/
>
> install -d ${D}${systemd_unitdir}/system
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [meta-oe][PATCH] volatile-binds: add /srv to mount and install
2020-11-18 22:40 ` [OE-core] " Konrad Weihmann
@ 2020-11-18 22:53 ` Sinan Kaya
2020-11-18 22:54 ` Konrad Weihmann
0 siblings, 1 reply; 4+ messages in thread
From: Sinan Kaya @ 2020-11-18 22:53 UTC (permalink / raw)
To: Konrad Weihmann, openembedded-core
On 11/18/2020 5:40 PM, Konrad Weihmann wrote:
>> FILES_${PN} += "${systemd_unitdir}/system/*.service"
>> +FILES_${PN}_append = " ${servicedir}"
>
> Just out of interest, why does that need to be an append?
> Why can't that be part of the line above?
I can fix that. I copied from a bbappend file.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [meta-oe][PATCH] volatile-binds: add /srv to mount and install
2020-11-18 22:53 ` Sinan Kaya
@ 2020-11-18 22:54 ` Konrad Weihmann
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Weihmann @ 2020-11-18 22:54 UTC (permalink / raw)
To: Sinan Kaya, openembedded-core
On 18.11.20 23:53, Sinan Kaya wrote:
> On 11/18/2020 5:40 PM, Konrad Weihmann wrote:
>>> FILES_${PN} += "${systemd_unitdir}/system/*.service"
>>> +FILES_${PN}_append = " ${servicedir}"
>>
>> Just out of interest, why does that need to be an append?
>> Why can't that be part of the line above?
>
> I can fix that. I copied from a bbappend file.
>
Yeah please do so, appends are pretty invasive, better leave them out if
there is no real need for them
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-18 22:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 22:37 [meta-oe][PATCH] volatile-binds: add /srv to mount and install Sinan Kaya
2020-11-18 22:40 ` [OE-core] " Konrad Weihmann
2020-11-18 22:53 ` Sinan Kaya
2020-11-18 22:54 ` Konrad Weihmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.