From: Po Liu <po.liu@nxp.com>
To: Mark Brown <broonie@kernel.org>, Scott Wood <scott.wood@nxp.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yao Yuan <yao.yuan@nxp.com>
Subject: RE: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE
Date: Tue, 19 Apr 2016 02:30:50 +0000 [thread overview]
Message-ID: <VI1PR0401MB17091173636FAB61369B5ADE926C0@VI1PR0401MB1709.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20160418101117.GP3217@sirena.org.uk>
Hi Mark and Scott,
Thank you very much both!
The default dspi in the .dtsi setting to be Big endian as default. But it will hang at cpu setting big endian mode. After setting _format_endian = REGMAP_ENDIAN_LITTLE will fix it only in big endian mode.
We'll check it more about the val_format_endian_default.
Best regards,
Liu Po
Best regards,
Liu Po
EXT:8038
-----Original Message-----
From: Mark Brown [mailto:broonie@kernel.org]
Sent: Monday, April 18, 2016 6:11 PM
To: Scott Wood
Cc: Po Liu; linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE
On Sun, Apr 17, 2016 at 02:41:40AM +0000, Scott Wood wrote:
> Looking more closely, the binding has a big-endian property. It says
> the default if that property is absent is native endian, which is
> insane. Fix the binding to say that little endian is the default
> (this change shouldn't break any existing trees), and make sure that's
> what the code implements. I think you need val_format_endian_default,
> not val_format_endian.
The binding defaults to little endian and (in implmentation terms) always has done though that used to be unintentional. There *are* a reasonable number of devices out there which are native endian, for example most of the MIPS chips switch the endianness of the entire chip rather than just the CPU, but most of the current usage has been on ARM devices which only switch the core.
WARNING: multiple messages have this Message-ID (diff)
From: Po Liu <po.liu-3arQi8VN3Tc@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Scott Wood <scott.wood-3arQi8VN3Tc@public.gmane.org>
Cc: "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Yao Yuan <yao.yuan-3arQi8VN3Tc@public.gmane.org>
Subject: RE: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE
Date: Tue, 19 Apr 2016 02:30:50 +0000 [thread overview]
Message-ID: <VI1PR0401MB17091173636FAB61369B5ADE926C0@VI1PR0401MB1709.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20160418101117.GP3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Hi Mark and Scott,
Thank you very much both!
The default dspi in the .dtsi setting to be Big endian as default. But it will hang at cpu setting big endian mode. After setting _format_endian = REGMAP_ENDIAN_LITTLE will fix it only in big endian mode.
We'll check it more about the val_format_endian_default.
Best regards,
Liu Po
Best regards,
Liu Po
EXT:8038
-----Original Message-----
From: Mark Brown [mailto:broonie@kernel.org]
Sent: Monday, April 18, 2016 6:11 PM
To: Scott Wood
Cc: Po Liu; linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE
On Sun, Apr 17, 2016 at 02:41:40AM +0000, Scott Wood wrote:
> Looking more closely, the binding has a big-endian property. It says
> the default if that property is absent is native endian, which is
> insane. Fix the binding to say that little endian is the default
> (this change shouldn't break any existing trees), and make sure that's
> what the code implements. I think you need val_format_endian_default,
> not val_format_endian.
The binding defaults to little endian and (in implmentation terms) always has done though that used to be unintentional. There *are* a reasonable number of devices out there which are native endian, for example most of the MIPS chips switch the endianness of the entire chip rather than just the CPU, but most of the current usage has been on ARM devices which only switch the core.
next prev parent reply other threads:[~2016-04-19 3:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 11:03 [PATCH] dspi: config dspi master regmap with right mode depend on BE or LE Po Liu
2016-04-13 11:03 ` Po Liu
2016-04-13 14:06 ` Mark Brown
2016-04-13 14:06 ` Mark Brown
2016-04-17 2:41 ` Scott Wood
2016-04-18 10:11 ` Mark Brown
2016-04-18 10:11 ` Mark Brown
2016-04-19 2:30 ` Po Liu [this message]
2016-04-19 2:30 ` Po Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0401MB17091173636FAB61369B5ADE926C0@VI1PR0401MB1709.eurprd04.prod.outlook.com \
--to=po.liu@nxp.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=scott.wood@nxp.com \
--cc=yao.yuan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.