All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: ls1043a/ls2080a serial updates
@ 2016-08-26 20:46 ` Stuart Yoder
  0 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-26 20:46 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel; +Cc: shawnguo, Stuart Yoder

This patch series serial aliases for ls2080a-rdb/qds and ls1043a-rdb,
fixes the aliases in ls1043a-qds and sets stdout-path for all the
boards.

Stuart Yoder (2):
  arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards

 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 14 ++++++++------
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts |  8 ++++++++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts |  3 +++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts |  4 ++++
 4 files changed, 23 insertions(+), 6 deletions(-)

-- 
1.9.0

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 0/2] arm64: dts: ls1043a/ls2080a serial updates
@ 2016-08-26 20:46 ` Stuart Yoder
  0 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-26 20:46 UTC (permalink / raw)
  To: linux-arm-kernel

This patch series serial aliases for ls2080a-rdb/qds and ls1043a-rdb,
fixes the aliases in ls1043a-qds and sets stdout-path for all the
boards.

Stuart Yoder (2):
  arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards

 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 14 ++++++++------
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts |  8 ++++++++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts |  3 +++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts |  4 ++++
 4 files changed, 23 insertions(+), 6 deletions(-)

-- 
1.9.0

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  2016-08-26 20:46 ` Stuart Yoder
@ 2016-08-26 20:46   ` Stuart Yoder
  -1 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-26 20:46 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel; +Cc: shawnguo, Stuart Yoder

-add missing serial aliases to ls1043a-r4db
-update lss1043a-qds boards serial aliases to use the standard duarts
 instead of low power uarts

Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 10 ++++------
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts |  4 ++++
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index 9d3e9fe..f813d67 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -56,12 +56,10 @@
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
 		gpio3 = &gpio4;
-		serial0 = &lpuart0;
-		serial1 = &lpuart1;
-		serial2 = &lpuart2;
-		serial3 = &lpuart3;
-		serial4 = &lpuart4;
-		serial5 = &lpuart5;
+		serial0 = &duart0;
+		serial1 = &duart1;
+		serial2 = &duart2;
+		serial3 = &duart3;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 4084631..8031cde 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -52,6 +52,10 @@
 
 	aliases {
 		crypto = &crypto;
+		serial0 = &duart0;
+		serial1 = &duart1;
+		serial2 = &duart2;
+		serial3 = &duart3;
 	};
 };
 
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
@ 2016-08-26 20:46   ` Stuart Yoder
  0 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-26 20:46 UTC (permalink / raw)
  To: linux-arm-kernel

-add missing serial aliases to ls1043a-r4db
-update lss1043a-qds boards serial aliases to use the standard duarts
 instead of low power uarts

Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 10 ++++------
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts |  4 ++++
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index 9d3e9fe..f813d67 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -56,12 +56,10 @@
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
 		gpio3 = &gpio4;
-		serial0 = &lpuart0;
-		serial1 = &lpuart1;
-		serial2 = &lpuart2;
-		serial3 = &lpuart3;
-		serial4 = &lpuart4;
-		serial5 = &lpuart5;
+		serial0 = &duart0;
+		serial1 = &duart1;
+		serial2 = &duart2;
+		serial3 = &duart3;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 4084631..8031cde 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -52,6 +52,10 @@
 
 	aliases {
 		crypto = &crypto;
+		serial0 = &duart0;
+		serial1 = &duart1;
+		serial2 = &duart2;
+		serial3 = &duart3;
 	};
 };
 
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/2] arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards
  2016-08-26 20:46 ` Stuart Yoder
@ 2016-08-26 20:46   ` Stuart Yoder
  -1 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-26 20:46 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel; +Cc: shawnguo, Stuart Yoder

Add a default stdout-path to chosen node for ls2080a/ls1043a boards to
allow booting kernels without specifying console info in bootargs.

Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 4 ++++
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 4 ++++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts | 3 +++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts | 4 ++++
 4 files changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index f813d67..dd9e919 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -61,6 +61,10 @@
 		serial2 = &duart2;
 		serial3 = &duart3;
 	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &duart0 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 8031cde..d2313e0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -57,6 +57,10 @@
 		serial2 = &duart2;
 		serial3 = &duart3;
 	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &i2c0 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
index e8801fa..b0dd010 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
@@ -57,6 +57,9 @@
 		serial1 = &serial1;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &esdhc {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts
index e127f0b..ad0ebb8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts
@@ -56,6 +56,10 @@
 		serial0 = &serial0;
 		serial1 = &serial1;
 	};
+
+	chosen {
+		stdout-path = "serial1:115200n8";
+	};
 };
 
 &esdhc {
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/2] arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards
@ 2016-08-26 20:46   ` Stuart Yoder
  0 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-26 20:46 UTC (permalink / raw)
  To: linux-arm-kernel

Add a default stdout-path to chosen node for ls2080a/ls1043a boards to
allow booting kernels without specifying console info in bootargs.

Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 4 ++++
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 4 ++++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts | 3 +++
 arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts | 4 ++++
 4 files changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index f813d67..dd9e919 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -61,6 +61,10 @@
 		serial2 = &duart2;
 		serial3 = &duart3;
 	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &duart0 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 8031cde..d2313e0 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -57,6 +57,10 @@
 		serial2 = &duart2;
 		serial3 = &duart3;
 	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &i2c0 {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
index e8801fa..b0dd010 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dts
@@ -57,6 +57,9 @@
 		serial1 = &serial1;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &esdhc {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts
index e127f0b..ad0ebb8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dts
@@ -56,6 +56,10 @@
 		serial0 = &serial0;
 		serial1 = &serial1;
 	};
+
+	chosen {
+		stdout-path = "serial1:115200n8";
+	};
 };
 
 &esdhc {
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  2016-08-26 20:46   ` Stuart Yoder
@ 2016-08-29 11:01       ` Arnd Bergmann
  -1 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2016-08-29 11:01 UTC (permalink / raw)
  To: Stuart Yoder
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	shawnguo-DgEjT+Ai2ygdnm+yROfE0A

On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> -               serial0 = &lpuart0;
> -               serial1 = &lpuart1;
> -               serial2 = &lpuart2;
> -               serial3 = &lpuart3;
> -               serial4 = &lpuart4;
> -               serial5 = &lpuart5;
> +               serial0 = &duart0;
> +               serial1 = &duart1;
> +               serial2 = &duart2;
> +               serial3 = &duart3;

It looks like your board has six uarts that are all driven with the
lpuart driver, but after the change, you only list four. Should
the serial4 and serial5 aliases keep pointing at lpuart devices
so you can still drive all physical connectors?

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
@ 2016-08-29 11:01       ` Arnd Bergmann
  0 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2016-08-29 11:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> -               serial0 = &lpuart0;
> -               serial1 = &lpuart1;
> -               serial2 = &lpuart2;
> -               serial3 = &lpuart3;
> -               serial4 = &lpuart4;
> -               serial5 = &lpuart5;
> +               serial0 = &duart0;
> +               serial1 = &duart1;
> +               serial2 = &duart2;
> +               serial3 = &duart3;

It looks like your board has six uarts that are all driven with the
lpuart driver, but after the change, you only list four. Should
the serial4 and serial5 aliases keep pointing at lpuart devices
so you can still drive all physical connectors?

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  2016-08-26 20:46   ` Stuart Yoder
@ 2016-08-29 14:01       ` Shawn Guo
  -1 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2016-08-29 14:01 UTC (permalink / raw)
  To: Stuart Yoder
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Fri, Aug 26, 2016 at 03:46:20PM -0500, Stuart Yoder wrote:
> -add missing serial aliases to ls1043a-r4db

s/ls1043a-r4db/ls1043a-rdb

Shawn

> -update lss1043a-qds boards serial aliases to use the standard duarts
>  instead of low power uarts
> 
> Signed-off-by: Stuart Yoder <stuart.yoder-3arQi8VN3Tc@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
@ 2016-08-29 14:01       ` Shawn Guo
  0 siblings, 0 replies; 16+ messages in thread
From: Shawn Guo @ 2016-08-29 14:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Aug 26, 2016 at 03:46:20PM -0500, Stuart Yoder wrote:
> -add missing serial aliases to ls1043a-r4db

s/ls1043a-r4db/ls1043a-rdb

Shawn

> -update lss1043a-qds boards serial aliases to use the standard duarts
>  instead of low power uarts
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  2016-08-29 11:01       ` Arnd Bergmann
@ 2016-08-29 18:30         ` Stuart Yoder
  -1 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-29 18:30 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: devicetree, shawnguo, linux-arm-kernel


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Monday, August 29, 2016 6:01 AM
> To: Stuart Yoder <stuart.yoder@nxp.com>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; shawnguo@kernel.org
> Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> 
> On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > -               serial0 = &lpuart0;
> > -               serial1 = &lpuart1;
> > -               serial2 = &lpuart2;
> > -               serial3 = &lpuart3;
> > -               serial4 = &lpuart4;
> > -               serial5 = &lpuart5;
> > +               serial0 = &duart0;
> > +               serial1 = &duart1;
> > +               serial2 = &duart2;
> > +               serial3 = &duart3;
> 
> It looks like your board has six uarts that are all driven with the
> lpuart driver, but after the change, you only list four. Should
> the serial4 and serial5 aliases keep pointing at lpuart devices
> so you can still drive all physical connectors?

The only existing reference I can find to the serial aliases is if the
OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
which is why I'm proposing making the 4 DUARTs the default serial aliases
in the device tree.

There is a separate defconfig in u-boot to enable/use LPUARTs instead
of the normal DUARTs.  For that scenario, my take is that firmware should
update the DT aliases to reflect the actual use of the serial ports.

But, the default should be the DUARTs which is the normal case for this
board, which is why this patch is changing them.

Thanks,
Stuart

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
@ 2016-08-29 18:30         ` Stuart Yoder
  0 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-29 18:30 UTC (permalink / raw)
  To: linux-arm-kernel


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd at arndb.de]
> Sent: Monday, August 29, 2016 6:01 AM
> To: Stuart Yoder <stuart.yoder@nxp.com>
> Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org
> Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> 
> On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > -               serial0 = &lpuart0;
> > -               serial1 = &lpuart1;
> > -               serial2 = &lpuart2;
> > -               serial3 = &lpuart3;
> > -               serial4 = &lpuart4;
> > -               serial5 = &lpuart5;
> > +               serial0 = &duart0;
> > +               serial1 = &duart1;
> > +               serial2 = &duart2;
> > +               serial3 = &duart3;
> 
> It looks like your board has six uarts that are all driven with the
> lpuart driver, but after the change, you only list four. Should
> the serial4 and serial5 aliases keep pointing at lpuart devices
> so you can still drive all physical connectors?

The only existing reference I can find to the serial aliases is if the
OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
which is why I'm proposing making the 4 DUARTs the default serial aliases
in the device tree.

There is a separate defconfig in u-boot to enable/use LPUARTs instead
of the normal DUARTs.  For that scenario, my take is that firmware should
update the DT aliases to reflect the actual use of the serial ports.

But, the default should be the DUARTs which is the normal case for this
board, which is why this patch is changing them.

Thanks,
Stuart

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  2016-08-29 18:30         ` Stuart Yoder
@ 2016-08-29 20:38           ` Arnd Bergmann
  -1 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2016-08-29 20:38 UTC (permalink / raw)
  To: linux-arm-kernel; +Cc: devicetree, shawnguo, Stuart Yoder

On Monday 29 August 2016, Stuart Yoder wrote:
> > -----Original Message-----
> > From: Arnd Bergmann [mailto:arnd@arndb.de]
> > Sent: Monday, August 29, 2016 6:01 AM
> > To: Stuart Yoder <stuart.yoder@nxp.com>
> > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; shawnguo@kernel.org
> > Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> > 
> > On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > > -               serial0 = &lpuart0;
> > > -               serial1 = &lpuart1;
> > > -               serial2 = &lpuart2;
> > > -               serial3 = &lpuart3;
> > > -               serial4 = &lpuart4;
> > > -               serial5 = &lpuart5;
> > > +               serial0 = &duart0;
> > > +               serial1 = &duart1;
> > > +               serial2 = &duart2;
> > > +               serial3 = &duart3;
> > 
> > It looks like your board has six uarts that are all driven with the
> > lpuart driver, but after the change, you only list four. Should
> > the serial4 and serial5 aliases keep pointing at lpuart devices
> > so you can still drive all physical connectors?
> 
> The only existing reference I can find to the serial aliases is if the
> OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
> standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
> which is why I'm proposing making the 4 DUARTs the default serial aliases
> in the device tree.

Ok, so they are mutually exclusive, and the last two ports are
unavailable in the default configuration?
 
> There is a separate defconfig in u-boot to enable/use LPUARTs instead
> of the normal DUARTs.  For that scenario, my take is that firmware should
> update the DT aliases to reflect the actual use of the serial ports.

Yes, makes sense.

> But, the default should be the DUARTs which is the normal case for this
> board, which is why this patch is changing them.

Ok

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
@ 2016-08-29 20:38           ` Arnd Bergmann
  0 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2016-08-29 20:38 UTC (permalink / raw)
  To: linux-arm-kernel

On Monday 29 August 2016, Stuart Yoder wrote:
> > -----Original Message-----
> > From: Arnd Bergmann [mailto:arnd at arndb.de]
> > Sent: Monday, August 29, 2016 6:01 AM
> > To: Stuart Yoder <stuart.yoder@nxp.com>
> > Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org
> > Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> > 
> > On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > > -               serial0 = &lpuart0;
> > > -               serial1 = &lpuart1;
> > > -               serial2 = &lpuart2;
> > > -               serial3 = &lpuart3;
> > > -               serial4 = &lpuart4;
> > > -               serial5 = &lpuart5;
> > > +               serial0 = &duart0;
> > > +               serial1 = &duart1;
> > > +               serial2 = &duart2;
> > > +               serial3 = &duart3;
> > 
> > It looks like your board has six uarts that are all driven with the
> > lpuart driver, but after the change, you only list four. Should
> > the serial4 and serial5 aliases keep pointing at lpuart devices
> > so you can still drive all physical connectors?
> 
> The only existing reference I can find to the serial aliases is if the
> OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
> standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
> which is why I'm proposing making the 4 DUARTs the default serial aliases
> in the device tree.

Ok, so they are mutually exclusive, and the last two ports are
unavailable in the default configuration?
 
> There is a separate defconfig in u-boot to enable/use LPUARTs instead
> of the normal DUARTs.  For that scenario, my take is that firmware should
> update the DT aliases to reflect the actual use of the serial ports.

Yes, makes sense.

> But, the default should be the DUARTs which is the normal case for this
> board, which is why this patch is changing them.

Ok

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
  2016-08-29 20:38           ` Arnd Bergmann
@ 2016-08-29 21:10             ` Stuart Yoder
  -1 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-29 21:10 UTC (permalink / raw)
  To: Arnd Bergmann, linux-arm-kernel; +Cc: devicetree, shawnguo



> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Monday, August 29, 2016 3:38 PM
> To: linux-arm-kernel@lists.infradead.org
> Cc: Stuart Yoder <stuart.yoder@nxp.com>; devicetree@vger.kernel.org; shawnguo@kernel.org
> Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> 
> On Monday 29 August 2016, Stuart Yoder wrote:
> > > -----Original Message-----
> > > From: Arnd Bergmann [mailto:arnd@arndb.de]
> > > Sent: Monday, August 29, 2016 6:01 AM
> > > To: Stuart Yoder <stuart.yoder@nxp.com>
> > > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; shawnguo@kernel.org
> > > Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> > >
> > > On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > > > -               serial0 = &lpuart0;
> > > > -               serial1 = &lpuart1;
> > > > -               serial2 = &lpuart2;
> > > > -               serial3 = &lpuart3;
> > > > -               serial4 = &lpuart4;
> > > > -               serial5 = &lpuart5;
> > > > +               serial0 = &duart0;
> > > > +               serial1 = &duart1;
> > > > +               serial2 = &duart2;
> > > > +               serial3 = &duart3;
> > >
> > > It looks like your board has six uarts that are all driven with the
> > > lpuart driver, but after the change, you only list four. Should
> > > the serial4 and serial5 aliases keep pointing at lpuart devices
> > > so you can still drive all physical connectors?
> >
> > The only existing reference I can find to the serial aliases is if the
> > OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
> > standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
> > which is why I'm proposing making the 4 DUARTs the default serial aliases
> > in the device tree.
> 
> Ok, so they are mutually exclusive, and the last two ports are
> unavailable in the default configuration?

Yes, that's the case with u-boot's defconfig.  I'm still trying to
find out whether that mutual exlusivity was a firmware decision or
a hardware limitation.

Stuart

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
@ 2016-08-29 21:10             ` Stuart Yoder
  0 siblings, 0 replies; 16+ messages in thread
From: Stuart Yoder @ 2016-08-29 21:10 UTC (permalink / raw)
  To: linux-arm-kernel



> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd at arndb.de]
> Sent: Monday, August 29, 2016 3:38 PM
> To: linux-arm-kernel at lists.infradead.org
> Cc: Stuart Yoder <stuart.yoder@nxp.com>; devicetree at vger.kernel.org; shawnguo at kernel.org
> Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> 
> On Monday 29 August 2016, Stuart Yoder wrote:
> > > -----Original Message-----
> > > From: Arnd Bergmann [mailto:arnd at arndb.de]
> > > Sent: Monday, August 29, 2016 6:01 AM
> > > To: Stuart Yoder <stuart.yoder@nxp.com>
> > > Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; shawnguo at kernel.org
> > > Subject: Re: [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards
> > >
> > > On Friday, August 26, 2016 3:46:20 PM CEST Stuart Yoder wrote:
> > > > -               serial0 = &lpuart0;
> > > > -               serial1 = &lpuart1;
> > > > -               serial2 = &lpuart2;
> > > > -               serial3 = &lpuart3;
> > > > -               serial4 = &lpuart4;
> > > > -               serial5 = &lpuart5;
> > > > +               serial0 = &duart0;
> > > > +               serial1 = &duart1;
> > > > +               serial2 = &duart2;
> > > > +               serial3 = &duart3;
> > >
> > > It looks like your board has six uarts that are all driven with the
> > > lpuart driver, but after the change, you only list four. Should
> > > the serial4 and serial5 aliases keep pointing at lpuart devices
> > > so you can still drive all physical connectors?
> >
> > The only existing reference I can find to the serial aliases is if the
> > OF_STDOUT_VIA_ALIAS is enabled in u-boot to specify the console.  The
> > standard ls1043aqds_defconfig in u-boot specifies DUARTs for the console,
> > which is why I'm proposing making the 4 DUARTs the default serial aliases
> > in the device tree.
> 
> Ok, so they are mutually exclusive, and the last two ports are
> unavailable in the default configuration?

Yes, that's the case with u-boot's defconfig.  I'm still trying to
find out whether that mutual exlusivity was a firmware decision or
a hardware limitation.

Stuart

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2016-08-29 21:10 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 20:46 [PATCH 0/2] arm64: dts: ls1043a/ls2080a serial updates Stuart Yoder
2016-08-26 20:46 ` Stuart Yoder
2016-08-26 20:46 ` [PATCH 1/2] arm64: dts: updates serial aliases for ls1043a rdb and qds boards Stuart Yoder
2016-08-26 20:46   ` Stuart Yoder
     [not found]   ` <1472244381-1766-2-git-send-email-stuart.yoder-3arQi8VN3Tc@public.gmane.org>
2016-08-29 11:01     ` Arnd Bergmann
2016-08-29 11:01       ` Arnd Bergmann
2016-08-29 18:30       ` Stuart Yoder
2016-08-29 18:30         ` Stuart Yoder
2016-08-29 20:38         ` Arnd Bergmann
2016-08-29 20:38           ` Arnd Bergmann
2016-08-29 21:10           ` Stuart Yoder
2016-08-29 21:10             ` Stuart Yoder
2016-08-29 14:01     ` Shawn Guo
2016-08-29 14:01       ` Shawn Guo
2016-08-26 20:46 ` [PATCH 2/2] arm64: dts: add stdout-path to chosen node for ls2080a/ls1043a boards Stuart Yoder
2016-08-26 20:46   ` Stuart Yoder

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.