* [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR()
@ 2019-03-28 14:36 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-03-28 14:36 UTC (permalink / raw)
To: Horia Geantă
Cc: Aymen Sghaier, Herbert Xu, David S. Miller, linux-crypto,
kernel-janitors
create_caam_req_fq() doesn't return NULL pointers so there is no need to
check. The NULL checks are problematic because it's hard to say how a
NULL return should be handled, so removing the checks is a nice cleanup.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/crypto/caam/qi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/qi.c b/drivers/crypto/caam/qi.c
index 7cb8b1755e57..9f08f84cca59 100644
--- a/drivers/crypto/caam/qi.c
+++ b/drivers/crypto/caam/qi.c
@@ -318,7 +318,7 @@ int caam_drv_ctx_update(struct caam_drv_ctx *drv_ctx, u32 *sh_desc)
/* Create a new req FQ in parked state */
new_fq = create_caam_req_fq(drv_ctx->qidev, drv_ctx->rsp_fq,
drv_ctx->context_a, 0);
- if (IS_ERR_OR_NULL(new_fq)) {
+ if (IS_ERR(new_fq)) {
dev_err(qidev, "FQ allocation for shdesc update failed\n");
return PTR_ERR(new_fq);
}
@@ -431,7 +431,7 @@ struct caam_drv_ctx *caam_drv_ctx_init(struct device *qidev,
/* Attach request FQ */
drv_ctx->req_fq = create_caam_req_fq(qidev, drv_ctx->rsp_fq, hwdesc,
QMAN_INITFQ_FLAG_SCHED);
- if (IS_ERR_OR_NULL(drv_ctx->req_fq)) {
+ if (IS_ERR(drv_ctx->req_fq)) {
dev_err(qidev, "create_caam_req_fq failed\n");
dma_unmap_single(qidev, hwdesc, size, DMA_BIDIRECTIONAL);
kfree(drv_ctx);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR()
@ 2019-03-28 14:36 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-03-28 14:36 UTC (permalink / raw)
To: Horia Geantă
Cc: Aymen Sghaier, Herbert Xu, David S. Miller, linux-crypto,
kernel-janitors
create_caam_req_fq() doesn't return NULL pointers so there is no need to
check. The NULL checks are problematic because it's hard to say how a
NULL return should be handled, so removing the checks is a nice cleanup.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/crypto/caam/qi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/caam/qi.c b/drivers/crypto/caam/qi.c
index 7cb8b1755e57..9f08f84cca59 100644
--- a/drivers/crypto/caam/qi.c
+++ b/drivers/crypto/caam/qi.c
@@ -318,7 +318,7 @@ int caam_drv_ctx_update(struct caam_drv_ctx *drv_ctx, u32 *sh_desc)
/* Create a new req FQ in parked state */
new_fq = create_caam_req_fq(drv_ctx->qidev, drv_ctx->rsp_fq,
drv_ctx->context_a, 0);
- if (IS_ERR_OR_NULL(new_fq)) {
+ if (IS_ERR(new_fq)) {
dev_err(qidev, "FQ allocation for shdesc update failed\n");
return PTR_ERR(new_fq);
}
@@ -431,7 +431,7 @@ struct caam_drv_ctx *caam_drv_ctx_init(struct device *qidev,
/* Attach request FQ */
drv_ctx->req_fq = create_caam_req_fq(qidev, drv_ctx->rsp_fq, hwdesc,
QMAN_INITFQ_FLAG_SCHED);
- if (IS_ERR_OR_NULL(drv_ctx->req_fq)) {
+ if (IS_ERR(drv_ctx->req_fq)) {
dev_err(qidev, "create_caam_req_fq failed\n");
dma_unmap_single(qidev, hwdesc, size, DMA_BIDIRECTIONAL);
kfree(drv_ctx);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR()
2019-03-28 14:36 ` Dan Carpenter
@ 2019-04-01 12:09 ` Horia Geanta
-1 siblings, 0 replies; 6+ messages in thread
From: Horia Geanta @ 2019-04-01 12:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Aymen Sghaier, Herbert Xu, David S. Miller, linux-crypto,
kernel-janitors
On 3/28/2019 4:36 PM, Dan Carpenter wrote:
> create_caam_req_fq() doesn't return NULL pointers so there is no need to
> check. The NULL checks are problematic because it's hard to say how a
> NULL return should be handled, so removing the checks is a nice cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Thanks,
Horia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR()
@ 2019-04-01 12:09 ` Horia Geanta
0 siblings, 0 replies; 6+ messages in thread
From: Horia Geanta @ 2019-04-01 12:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Aymen Sghaier, Herbert Xu, David S. Miller, linux-crypto,
kernel-janitors
On 3/28/2019 4:36 PM, Dan Carpenter wrote:
> create_caam_req_fq() doesn't return NULL pointers so there is no need to
> check. The NULL checks are problematic because it's hard to say how a
> NULL return should be handled, so removing the checks is a nice cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Horia Geantã <horia.geanta@nxp.com>
Thanks,
Horia
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR()
2019-03-28 14:36 ` Dan Carpenter
@ 2019-04-08 6:40 ` Herbert Xu
-1 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2019-04-08 6:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Horia Geantă,
Aymen Sghaier, David S. Miller, linux-crypto, kernel-janitors
On Thu, Mar 28, 2019 at 05:36:01PM +0300, Dan Carpenter wrote:
> create_caam_req_fq() doesn't return NULL pointers so there is no need to
> check. The NULL checks are problematic because it's hard to say how a
> NULL return should be handled, so removing the checks is a nice cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/crypto/caam/qi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR()
@ 2019-04-08 6:40 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2019-04-08 6:40 UTC (permalink / raw)
To: Dan Carpenter
Cc: Horia Geantă,
Aymen Sghaier, David S. Miller, linux-crypto, kernel-janitors
On Thu, Mar 28, 2019 at 05:36:01PM +0300, Dan Carpenter wrote:
> create_caam_req_fq() doesn't return NULL pointers so there is no need to
> check. The NULL checks are problematic because it's hard to say how a
> NULL return should be handled, so removing the checks is a nice cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/crypto/caam/qi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-08 6:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-28 14:36 [PATCH] crypto: caam/qi - Change a couple IS_ERR_OR_NULL() checks to IS_ERR() Dan Carpenter
2019-03-28 14:36 ` Dan Carpenter
2019-04-01 12:09 ` Horia Geanta
2019-04-01 12:09 ` Horia Geanta
2019-04-08 6:40 ` Herbert Xu
2019-04-08 6:40 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.