All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset
@ 2019-02-28  9:06 Pramod Kumar
  2019-03-02 13:09 ` Prabhakar Kushwaha
  2019-03-04 19:21 ` Joe Hershberger
  0 siblings, 2 replies; 4+ messages in thread
From: Pramod Kumar @ 2019-02-28  9:06 UTC (permalink / raw)
  To: u-boot

Fix EC1 and EC2 read from correct offset 26, instead of 25

Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>
---
 drivers/net/ldpaa_eth/ls1088a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ldpaa_eth/ls1088a.c b/drivers/net/ldpaa_eth/ls1088a.c
index 43210532ba..c3260d318c 100644
--- a/drivers/net/ldpaa_eth/ls1088a.c
+++ b/drivers/net/ldpaa_eth/ls1088a.c
@@ -93,7 +93,7 @@ void fsl_rgmii_init(void)
 	u32 ec;
 
 #ifdef CONFIG_SYS_FSL_EC1
-	ec = gur_in32(&gur->rcwsr[FSL_CHASSIS3_EC1_REGSR - 1])
+	ec = gur_in32(&gur->rcwsr[FSL_CHASSIS3_EC1_REGSR])
 		& FSL_CHASSIS3_RCWSR25_EC1_PRTCL_MASK;
 	ec >>= FSL_CHASSIS3_RCWSR25_EC1_PRTCL_SHIFT;
 
@@ -102,7 +102,7 @@ void fsl_rgmii_init(void)
 #endif
 
 #ifdef CONFIG_SYS_FSL_EC2
-	ec = gur_in32(&gur->rcwsr[FSL_CHASSIS3_EC2_REGSR - 1])
+	ec = gur_in32(&gur->rcwsr[FSL_CHASSIS3_EC2_REGSR])
 		& FSL_CHASSIS3_RCWSR25_EC2_PRTCL_MASK;
 	ec >>= FSL_CHASSIS3_RCWSR25_EC2_PRTCL_SHIFT;
 
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset
  2019-02-28  9:06 [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset Pramod Kumar
@ 2019-03-02 13:09 ` Prabhakar Kushwaha
  2019-03-04 19:21 ` Joe Hershberger
  1 sibling, 0 replies; 4+ messages in thread
From: Prabhakar Kushwaha @ 2019-03-02 13:09 UTC (permalink / raw)
  To: u-boot

Dear Joe,

> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Pramod Kumar
> Sent: Thursday, February 28, 2019 2:37 PM
> To: u-boot at lists.denx.de
> Cc: York Sun <york.sun@nxp.com>
> Subject: [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset
> 
> Fix EC1 and EC2 read from correct offset 26, instead of 25
> 
> Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>
> ---

Please review and ack this patch. 

I want to send this via u-boot-fsl-qoriq repo.

--pk

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset
  2019-02-28  9:06 [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset Pramod Kumar
  2019-03-02 13:09 ` Prabhakar Kushwaha
@ 2019-03-04 19:21 ` Joe Hershberger
  2019-03-15 13:35   ` Prabhakar Kushwaha
  1 sibling, 1 reply; 4+ messages in thread
From: Joe Hershberger @ 2019-03-04 19:21 UTC (permalink / raw)
  To: u-boot

On Thu, Feb 28, 2019 at 3:06 AM Pramod Kumar <pramod.kumar_1@nxp.com> wrote:
>
> Fix EC1 and EC2 read from correct offset 26, instead of 25
>
> Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset
  2019-03-04 19:21 ` Joe Hershberger
@ 2019-03-15 13:35   ` Prabhakar Kushwaha
  0 siblings, 0 replies; 4+ messages in thread
From: Prabhakar Kushwaha @ 2019-03-15 13:35 UTC (permalink / raw)
  To: u-boot


> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Joe Hershberger
> Sent: Tuesday, March 5, 2019 12:51 AM
> To: Pramod Kumar <pramod.kumar_1@nxp.com>
> Cc: u-boot at lists.denx.de; York Sun <york.sun@nxp.com>
> Subject: Re: [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW
> offset
> 
> On Thu, Feb 28, 2019 at 3:06 AM Pramod Kumar <pramod.kumar_1@nxp.com>
> wrote:
> >
> > Fix EC1 and EC2 read from correct offset 26, instead of 25
> >
> > Signed-off-by: Pramod Kumar <pramod.kumar_1@nxp.com>
> 
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>


Applied to u-boot-fsl-qoriq, awating upstream

--pk

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-15 13:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28  9:06 [U-Boot] [PATCH] drivers: net: ls1088ardb: Fix EC1 and EC2 RCW offset Pramod Kumar
2019-03-02 13:09 ` Prabhakar Kushwaha
2019-03-04 19:21 ` Joe Hershberger
2019-03-15 13:35   ` Prabhakar Kushwaha

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.