[U-Boot] [PATCH v2 1/5] ppc: t2080qds: add eSDHC node

[U-Boot] [PATCH v2 1/5] ppc: t2080qds: add eSDHC node

[Yinbo Zhu]

From: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch is to add eSDHC node for t2080qds

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
Change in v2:
		add York sun for reviewing the patches set 

 arch/powerpc/dts/t2080.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/powerpc/dts/t2080.dtsi b/arch/powerpc/dts/t2080.dtsi
index db65ea5725..f895dda4d7 100644
--- a/arch/powerpc/dts/t2080.dtsi
+++ b/arch/powerpc/dts/t2080.dtsi
@@ -58,5 +58,15 @@
 			device_type = "open-pic";
 			clock-frequency = <0x0>;
 		};
+
+		esdhc: esdhc at 114000 {
+			compatible = "fsl,esdhc";
+			reg = <0x114000 0x1000>;
+			interrupts = <48 2 0 0>;
+			clock-frequency = <0>;
+			sdhci,auto-cmd12;
+			bus-width = <4>;
+			voltage-ranges = <1800 1800 3300 3300>;
+		};
 	};
 };
-- 
2.17.1

[U-Boot] [PATCH v2 2/5] mmc: fsl_esdhc: ppc: set sdhc clock

[Yinbo Zhu]

From: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch is to set sdhc clock for ppc

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
 drivers/mmc/fsl_esdhc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index 9e34557d16..a65e5c19db 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -1428,7 +1428,9 @@ void fdt_fixup_esdhc(void *blob, bd_t *bd)
 #endif
 
 #if CONFIG_IS_ENABLED(DM_MMC)
+#ifndef CONFIG_PPC
 #include <asm/arch/clock.h>
+#endif
 __weak void init_clk_usdhc(u32 index)
 {
 }
@@ -1454,7 +1456,7 @@ static int fsl_esdhc_probe(struct udevice *dev)
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
-	priv->esdhc_regs = (struct fsl_esdhc *)addr;
+	priv->esdhc_regs = (struct fsl_esdhc *)(addr);
 	priv->dev = dev;
 	priv->mode = -1;
 	if (data) {
@@ -1560,7 +1562,11 @@ static int fsl_esdhc_probe(struct udevice *dev)
 
 		priv->sdhc_clk = clk_get_rate(&priv->per_clk);
 	} else {
+#ifndef CONFIG_PPC
 		priv->sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK + dev->seq);
+#else
+		priv->sdhc_clk = gd->arch.sdhc_clk;
+#endif
 		if (priv->sdhc_clk <= 0) {
 			dev_err(dev, "Unable to get clk for %s\n", dev->name);
 			return -EINVAL;
-- 
2.17.1

[U-Boot] [PATCH v2 3/5] mmc: fsl_esdhc: ppc: adopt 32 bit address

[Yinbo Zhu]

From: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch is to adopt 32 bit address for ppc

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
 drivers/mmc/fsl_esdhc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index a65e5c19db..e5f84debad 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -1455,8 +1455,11 @@ static int fsl_esdhc_probe(struct udevice *dev)
 	addr = dev_read_addr(dev);
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;
-
+#ifdef CONFIG_PPC
+	priv->esdhc_regs = (struct fsl_esdhc *)lower_32_bits(addr);
+#else
 	priv->esdhc_regs = (struct fsl_esdhc *)(addr);
+#endif
 	priv->dev = dev;
 	priv->mode = -1;
 	if (data) {
-- 
2.17.1

[U-Boot] [PATCH v2 4/5] configs: enable device tree support for T2080QDS

[Yinbo Zhu]

From: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch is to enable device tree support for T2080QDS

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
 configs/T2080QDS_SECURE_BOOT_defconfig    | 2 ++
 configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/configs/T2080QDS_SECURE_BOOT_defconfig b/configs/T2080QDS_SECURE_BOOT_defconfig
index 9e155ee6ae..2658bf8460 100644
--- a/configs/T2080QDS_SECURE_BOOT_defconfig
+++ b/configs/T2080QDS_SECURE_BOOT_defconfig
@@ -50,3 +50,5 @@ CONFIG_RSA=y
 CONFIG_SPL_RSA=y
 CONFIG_RSA_SOFTWARE_EXP=y
 CONFIG_OF_LIBFDT=y
+CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
+CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
diff --git a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
index 9c9a436d81..8febabd84f 100644
--- a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
+++ b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
@@ -39,3 +39,6 @@ CONFIG_FSL_ESPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_OF_LIBFDT=y
+CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
+CONFIG_OF_CONTROL=y
+CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
-- 
2.17.1

[U-Boot] [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS

[Yinbo Zhu]

From: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch is to enable MMC DM for T2080QDS in uboot

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
 configs/T2080QDS_NAND_defconfig           | 3 +++
 configs/T2080QDS_SDCARD_defconfig         | 3 +++
 configs/T2080QDS_SECURE_BOOT_defconfig    | 3 +++
 configs/T2080QDS_SPIFLASH_defconfig       | 3 +++
 configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 3 +++
 configs/T2080QDS_defconfig                | 3 +++
 6 files changed, 18 insertions(+)

diff --git a/configs/T2080QDS_NAND_defconfig b/configs/T2080QDS_NAND_defconfig
index 948a05af89..02d47c9fdd 100644
--- a/configs/T2080QDS_NAND_defconfig
+++ b/configs/T2080QDS_NAND_defconfig
@@ -59,3 +59,6 @@ CONFIG_SPI=y
 CONFIG_FSL_ESPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
+CONFIG_DM_MMC=y
+CONFIG_BLK=y
+CONFIG_DM=y
diff --git a/configs/T2080QDS_SDCARD_defconfig b/configs/T2080QDS_SDCARD_defconfig
index 30e87df3bb..4ce83fe8c4 100644
--- a/configs/T2080QDS_SDCARD_defconfig
+++ b/configs/T2080QDS_SDCARD_defconfig
@@ -58,3 +58,6 @@ CONFIG_SPI=y
 CONFIG_FSL_ESPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
+CONFIG_DM_MMC=y
+CONFIG_BLK=y
+CONFIG_DM=y
diff --git a/configs/T2080QDS_SECURE_BOOT_defconfig b/configs/T2080QDS_SECURE_BOOT_defconfig
index 2658bf8460..e2a7d3fa76 100644
--- a/configs/T2080QDS_SECURE_BOOT_defconfig
+++ b/configs/T2080QDS_SECURE_BOOT_defconfig
@@ -52,3 +52,6 @@ CONFIG_RSA_SOFTWARE_EXP=y
 CONFIG_OF_LIBFDT=y
 CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
 CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
+CONFIG_DM_MMC=y
+CONFIG_BLK=y
+CONFIG_OF_CONTROL=y
diff --git a/configs/T2080QDS_SPIFLASH_defconfig b/configs/T2080QDS_SPIFLASH_defconfig
index 0cccb3a85d..641f3c0c97 100644
--- a/configs/T2080QDS_SPIFLASH_defconfig
+++ b/configs/T2080QDS_SPIFLASH_defconfig
@@ -59,3 +59,6 @@ CONFIG_SPI=y
 CONFIG_FSL_ESPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
+CONFIG_DM_MMC=y
+CONFIG_BLK=y
+CONFIG_DM=y
diff --git a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
index 8febabd84f..d2a8875aac 100644
--- a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
+++ b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
@@ -42,3 +42,6 @@ CONFIG_OF_LIBFDT=y
 CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
 CONFIG_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
+CONFIG_DM_MMC=y
+CONFIG_BLK=y
+CONFIG_DM=y
diff --git a/configs/T2080QDS_defconfig b/configs/T2080QDS_defconfig
index 79cf4424b4..d55ce771a9 100644
--- a/configs/T2080QDS_defconfig
+++ b/configs/T2080QDS_defconfig
@@ -48,3 +48,6 @@ CONFIG_SPI=y
 CONFIG_FSL_ESPI=y
 CONFIG_USB=y
 CONFIG_USB_STORAGE=y
+CONFIG_DM_MMC=y
+CONFIG_BLK=y
+CONFIG_DM=y
-- 
2.17.1

[U-Boot] [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS

[Yinbo Zhu]

Hi,
     
This patches set is for enable uboot DM for usb and sd on t2080qds, I haded tested
the io function. And I find that if the block size is less than 8, the read process
will be hung, hung’s code is in blkcache_fill’s memcpy Function,  and when memcpy 
do “*dl++ = *sl++” operation then read process will be hung.  but fsl-layerscape 
uboot DM work well. ppc non-DM work well, it seems to be block driver(CONFIG_BLK) 
issue related to PPC. Please you note.

Thanks
Best Regards,
Yinbo Zhu.

-----Original Message-----
From: Yinbo Zhu [mailto:yinbo.zhu at nxp.com] 
Sent: 2019年3月26日 11:09
To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; Ran Wang <ran.wang_1@nxp.com>; 
Jiafei Pan <jiafei.pan@nxp.com>; Y.b. Lu <yangbo.lu@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; 
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Subject: [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS

>From: Yinbo Zhu <yinbo.zhu@nxp.com>

>This patch is to enable MMC DM for T2080QDS in uboot

>Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
>---
 >configs/T2080QDS_NAND_defconfig           | 3 +++
 >configs/T2080QDS_SDCARD_defconfig         | 3 +++
 >configs/T2080QDS_SECURE_BOOT_defconfig    | 3 +++
 >configs/T2080QDS_SPIFLASH_defconfig       | 3 +++
 >configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 3 +++
 >configs/T2080QDS_defconfig                | 3 +++
 >6 files changed, 18 insertions(+)

>diff --git a/configs/T2080QDS_NAND_defconfig b/configs/T2080QDS_NAND_defconfig index 
>948a05af89..02d47c9fdd 100644
>--- a/configs/T2080QDS_NAND_defconfig
>+++ b/configs/T2080QDS_NAND_defconfig
>@@ -59,3 +59,6 @@ CONFIG_SPI=y
 >CONFIG_FSL_ESPI=y
 >CONFIG_USB=y
 >CONFIG_USB_STORAGE=y
>+CONFIG_DM_MMC=y
>+CONFIG_BLK=y
>+CONFIG_DM=y
>diff --git a/configs/T2080QDS_SDCARD_defconfig b/configs/T2080QDS_SDCARD_defconfig
>index 30e87df3bb..4ce83fe8c4 100644
>--- a/configs/T2080QDS_SDCARD_defconfig
>+++ b/configs/T2080QDS_SDCARD_defconfig
>@@ -58,3 +58,6 @@ CONFIG_SPI=y
 >CONFIG_FSL_ESPI=y
 >CONFIG_USB=y
 >CONFIG_USB_STORAGE=y
>+CONFIG_DM_MMC=y
>+CONFIG_BLK=y
>+CONFIG_DM=y
>diff --git a/configs/T2080QDS_SECURE_BOOT_defconfig b/configs/T2080QDS_SECURE_BOOT_defconfig
>index 2658bf8460..e2a7d3fa76 100644
>--- a/configs/T2080QDS_SECURE_BOOT_defconfig
>+++ b/configs/T2080QDS_SECURE_BOOT_defconfig
>@@ -52,3 +52,6 @@ CONFIG_RSA_SOFTWARE_EXP=y  CONFIG_OF_LIBFDT=y  
>CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
 >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
>+CONFIG_DM_MMC=y
>+CONFIG_BLK=y
>+CONFIG_OF_CONTROL=y
>diff --git a/configs/T2080QDS_SPIFLASH_defconfig b/configs/T2080QDS_SPIFLASH_defconfig
>index 0cccb3a85d..641f3c0c97 100644
>--- a/configs/T2080QDS_SPIFLASH_defconfig
>+++ b/configs/T2080QDS_SPIFLASH_defconfig
>@@ -59,3 +59,6 @@ CONFIG_SPI=y
 >CONFIG_FSL_ESPI=y
 >CONFIG_USB=y
 >CONFIG_USB_STORAGE=y
>+CONFIG_DM_MMC=y
>+CONFIG_BLK=y
>+CONFIG_DM=y
>diff --git a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
>index 8febabd84f..d2a8875aac 100644
>--- a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
>+++ b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
>@@ -42,3 +42,6 @@ CONFIG_OF_LIBFDT=y
 >CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
 >CONFIG_OF_CONTROL=y
 >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
>+CONFIG_DM_MMC=y
>+CONFIG_BLK=y
>+CONFIG_DM=y
>diff --git a/configs/T2080QDS_defconfig b/configs/T2080QDS_defconfig index 79cf4424b4..d55ce771a9 100644
>--- a/configs/T2080QDS_defconfig
>+++ b/configs/T2080QDS_defconfig
>@@ -48,3 +48,6 @@ CONFIG_SPI=y
 >CONFIG_FSL_ESPI=y
 >CONFIG_USB=y
 >>CONFIG_USB_STORAGE=y
>+CONFIG_DM_MMC=y
>+CONFIG_BLK=y
>+CONFIG_DM=y
--
2.17.1

[U-Boot] [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS

[Yinbo Zhu]

> -----Original Message-----
> From: Yinbo Zhu
> Sent: 2019年3月26日 17:08
> To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Xiaobo Xie <xiaobo.xie@nxp.com>; Ran Wang <ran.wang_1@nxp.com>; Jiafei
> Pan <jiafei.pan@nxp.com>; Y.b. Lu <yangbo.lu@nxp.com>; Jagdish Gediya
> <jagdish.gediya@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; 'Yinbo Zhu' <yinbo.zhu@nxp.com>
> Subject: RE: [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS
> 
> Hi,
> 
> This patches set is for enable uboot DM for usb and sd on t2080qds, I haded
> tested the io function. And I find that if the block size is less than 8, the read
> process will be hung, hung’s code is in blkcache_fill’s memcpy Function,  and
> when memcpy do “*dl++ = *sl++” operation then read process will be hung.
> but fsl-layerscape uboot DM work well. ppc non-DM work well, it seems to be
> block driver(CONFIG_BLK) issue related to PPC. Please you note.
> 
> Thanks
> Best Regards,
> Yinbo Zhu.
> 
Hi York,

Could you help me check these patches!
Thanks
    
In addition, above issue is due to the mmc read's operation address is out of memory address, not a bug.
Please you note!
> -----Original Message-----
> From: Yinbo Zhu [mailto:yinbo.zhu at nxp.com]
> Sent: 2019年3月26日 11:09
> To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; Ran
> Wang <ran.wang_1@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; Y.b. Lu
> <yangbo.lu@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; Prabhakar
> Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS
> 
> >From: Yinbo Zhu <yinbo.zhu@nxp.com>
> 
> >This patch is to enable MMC DM for T2080QDS in uboot
> 
> >Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> >---
>  >configs/T2080QDS_NAND_defconfig           | 3 +++
>  >configs/T2080QDS_SDCARD_defconfig         | 3 +++
>  >configs/T2080QDS_SECURE_BOOT_defconfig    | 3 +++
>  >configs/T2080QDS_SPIFLASH_defconfig       | 3 +++
>  >configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 3 +++
>  >configs/T2080QDS_defconfig                | 3 +++
>  >6 files changed, 18 insertions(+)
> 
> >diff --git a/configs/T2080QDS_NAND_defconfig
> >b/configs/T2080QDS_NAND_defconfig index 948a05af89..02d47c9fdd
> 100644
> >--- a/configs/T2080QDS_NAND_defconfig
> >+++ b/configs/T2080QDS_NAND_defconfig
> >@@ -59,3 +59,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_SDCARD_defconfig
> >b/configs/T2080QDS_SDCARD_defconfig
> >index 30e87df3bb..4ce83fe8c4 100644
> >--- a/configs/T2080QDS_SDCARD_defconfig
> >+++ b/configs/T2080QDS_SDCARD_defconfig
> >@@ -58,3 +58,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_SECURE_BOOT_defconfig
> >b/configs/T2080QDS_SECURE_BOOT_defconfig
> >index 2658bf8460..e2a7d3fa76 100644
> >--- a/configs/T2080QDS_SECURE_BOOT_defconfig
> >+++ b/configs/T2080QDS_SECURE_BOOT_defconfig
> >@@ -52,3 +52,6 @@ CONFIG_RSA_SOFTWARE_EXP=y  CONFIG_OF_LIBFDT=y
> >CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
>  >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_OF_CONTROL=y
> >diff --git a/configs/T2080QDS_SPIFLASH_defconfig
> >b/configs/T2080QDS_SPIFLASH_defconfig
> >index 0cccb3a85d..641f3c0c97 100644
> >--- a/configs/T2080QDS_SPIFLASH_defconfig
> >+++ b/configs/T2080QDS_SPIFLASH_defconfig
> >@@ -59,3 +59,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >index 8febabd84f..d2a8875aac 100644
> >--- a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >+++ b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >@@ -42,3 +42,6 @@ CONFIG_OF_LIBFDT=y
>  >CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
>  >CONFIG_OF_CONTROL=y
>  >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_defconfig b/configs/T2080QDS_defconfig
> >index 79cf4424b4..d55ce771a9 100644
> >--- a/configs/T2080QDS_defconfig
> >+++ b/configs/T2080QDS_defconfig
> >@@ -48,3 +48,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >>CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> --
> 2.17.1

[U-Boot] [PATCH v2 2/5] mmc: fsl_esdhc: ppc: set sdhc clock

[Prabhakar Kushwaha]

> -----Original Message-----
> From: Yinbo Zhu
> Sent: Tuesday, March 26, 2019 8:39 AM
> To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; Ran
> Wang <ran.wang_1@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; Y.b. Lu
> <yangbo.lu@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; Prabhakar
> Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: [PATCH v2 2/5] mmc: fsl_esdhc: ppc: set sdhc clock
> 
> From: Yinbo Zhu <yinbo.zhu@nxp.com>
> 
> This patch is to set sdhc clock for ppc

Can we get more description on this

> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
>  drivers/mmc/fsl_esdhc.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index
> 9e34557d16..a65e5c19db 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -1428,7 +1428,9 @@ void fdt_fixup_esdhc(void *blob, bd_t *bd)  #endif
> 
>  #if CONFIG_IS_ENABLED(DM_MMC)
> +#ifndef CONFIG_PPC
>  #include <asm/arch/clock.h>
> +#endif
>  __weak void init_clk_usdhc(u32 index)
>  {
>  }
> @@ -1454,7 +1456,7 @@ static int fsl_esdhc_probe(struct udevice *dev)
>  	if (addr == FDT_ADDR_T_NONE)
>  		return -EINVAL;
> 
> -	priv->esdhc_regs = (struct fsl_esdhc *)addr;
> +	priv->esdhc_regs = (struct fsl_esdhc *)(addr);

Why this change is required?

--pk

[U-Boot] [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS

[Prabhakar Kushwaha]

> -----Original Message-----
> From: Yinbo Zhu
> Sent: Tuesday, March 26, 2019 8:39 AM
> To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; Ran
> Wang <ran.wang_1@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; Y.b. Lu
> <yangbo.lu@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; Prabhakar
> Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS
> 
> From: Yinbo Zhu <yinbo.zhu@nxp.com>
> 
> This patch is to enable MMC DM for T2080QDS in uboot

Patch is for u-boot. No need to mention explicitly. 

--pk

[U-Boot] [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS

[Prabhakar Kushwaha]

Dear  Panto,  Jaehoon


> -----Original Message-----
> From: Yinbo Zhu
> Sent: Tuesday, March 26, 2019 2:38 PM
> To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Xiaobo Xie <xiaobo.xie@nxp.com>; Ran Wang <ran.wang_1@nxp.com>;
> Jiafei Pan <jiafei.pan@nxp.com>; Y.b. Lu <yangbo.lu@nxp.com>; Jagdish Gediya
> <jagdish.gediya@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>
> Subject: RE: [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS
> 
> Hi,
> 
> This patches set is for enable uboot DM for usb and sd on t2080qds, I haded
> tested the io function. And I find that if the block size is less than 8, the read
> process will be hung, hung’s code is in blkcache_fill’s memcpy Function,  and
> when memcpy do “*dl++ = *sl++” operation then read process will be hung.  but
> fsl-layerscape uboot DM work well. ppc non-DM work well, it seems to be block
> driver(CONFIG_BLK) issue related to PPC. Please you note.
> 


Can you please check this observarion!!



> Thanks
> Best Regards,
> Yinbo Zhu.
> 
> -----Original Message-----
> From: Yinbo Zhu [mailto:yinbo.zhu at nxp.com]
> Sent: 2019年3月26日 11:09
> To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; Ran
> Wang <ran.wang_1@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; Y.b. Lu
> <yangbo.lu@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; Prabhakar
> Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS
> 
> >From: Yinbo Zhu <yinbo.zhu@nxp.com>
> 
> >This patch is to enable MMC DM for T2080QDS in uboot
> 
> >Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> >---
>  >configs/T2080QDS_NAND_defconfig           | 3 +++
>  >configs/T2080QDS_SDCARD_defconfig         | 3 +++
>  >configs/T2080QDS_SECURE_BOOT_defconfig    | 3 +++
>  >configs/T2080QDS_SPIFLASH_defconfig       | 3 +++
>  >configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 3 +++
>  >configs/T2080QDS_defconfig                | 3 +++
>  >6 files changed, 18 insertions(+)
> 
> >diff --git a/configs/T2080QDS_NAND_defconfig
> >b/configs/T2080QDS_NAND_defconfig index 948a05af89..02d47c9fdd 100644
> >--- a/configs/T2080QDS_NAND_defconfig
> >+++ b/configs/T2080QDS_NAND_defconfig
> >@@ -59,3 +59,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_SDCARD_defconfig
> >b/configs/T2080QDS_SDCARD_defconfig
> >index 30e87df3bb..4ce83fe8c4 100644
> >--- a/configs/T2080QDS_SDCARD_defconfig
> >+++ b/configs/T2080QDS_SDCARD_defconfig
> >@@ -58,3 +58,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_SECURE_BOOT_defconfig
> >b/configs/T2080QDS_SECURE_BOOT_defconfig
> >index 2658bf8460..e2a7d3fa76 100644
> >--- a/configs/T2080QDS_SECURE_BOOT_defconfig
> >+++ b/configs/T2080QDS_SECURE_BOOT_defconfig
> >@@ -52,3 +52,6 @@ CONFIG_RSA_SOFTWARE_EXP=y  CONFIG_OF_LIBFDT=y
> >CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
>  >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_OF_CONTROL=y
> >diff --git a/configs/T2080QDS_SPIFLASH_defconfig
> >b/configs/T2080QDS_SPIFLASH_defconfig
> >index 0cccb3a85d..641f3c0c97 100644
> >--- a/configs/T2080QDS_SPIFLASH_defconfig
> >+++ b/configs/T2080QDS_SPIFLASH_defconfig
> >@@ -59,3 +59,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >index 8febabd84f..d2a8875aac 100644
> >--- a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >+++ b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> >@@ -42,3 +42,6 @@ CONFIG_OF_LIBFDT=y
>  >CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
>  >CONFIG_OF_CONTROL=y
>  >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> >diff --git a/configs/T2080QDS_defconfig b/configs/T2080QDS_defconfig
> >index 79cf4424b4..d55ce771a9 100644
> >--- a/configs/T2080QDS_defconfig
> >+++ b/configs/T2080QDS_defconfig
> >@@ -48,3 +48,6 @@ CONFIG_SPI=y
>  >CONFIG_FSL_ESPI=y
>  >CONFIG_USB=y
>  >>CONFIG_USB_STORAGE=y
> >+CONFIG_DM_MMC=y
> >+CONFIG_BLK=y
> >+CONFIG_DM=y
> --
> 2.17.1

[U-Boot] [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS

[Yinbo Zhu]

Hi,

Please ignore the observation.
This issue is due to that read mmc's addr is more than it's memory.
Sd/usb work well.

And I had send the v3 version, please help me check it.

Thanks！
Regards,
Yinbo Zhu.

> -----Original Message-----
> From: Prabhakar Kushwaha
> Sent: 2019年4月7日 17:46
> To: Yinbo Zhu <yinbo.zhu@nxp.com>; York Sun <york.sun@nxp.com>;
> u-boot at lists.denx.de; panto at antoniou-consulting.com;
> jh80.chung at samsung.com
> Cc: Xiaobo Xie <xiaobo.xie@nxp.com>; Ran Wang <ran.wang_1@nxp.com>; Jiafei
> Pan <jiafei.pan@nxp.com>; Y.b. Lu <yangbo.lu@nxp.com>; Jagdish Gediya
> <jagdish.gediya@nxp.com>
> Subject: RE: [PATCH v2 5/5] configs: enable eSDHC device module in T2080QDS
> 
> Dear  Panto,  Jaehoon
> 
> 
> > -----Original Message-----
> > From: Yinbo Zhu
> > Sent: Tuesday, March 26, 2019 2:38 PM
> > To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> > Cc: Xiaobo Xie <xiaobo.xie@nxp.com>; Ran Wang <ran.wang_1@nxp.com>;
> > Jiafei Pan <jiafei.pan@nxp.com>; Y.b. Lu <yangbo.lu@nxp.com>; Jagdish
> > Gediya <jagdish.gediya@nxp.com>; Prabhakar Kushwaha
> > <prabhakar.kushwaha@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>
> > Subject: RE: [PATCH v2 5/5] configs: enable eSDHC device module in
> > T2080QDS
> >
> > Hi,
> >
> > This patches set is for enable uboot DM for usb and sd on t2080qds, I
> > haded tested the io function. And I find that if the block size is
> > less than 8, the read process will be hung, hung’s code is in
> > blkcache_fill’s memcpy Function,  and when memcpy do “*dl++ = *sl++”
> > operation then read process will be hung.  but fsl-layerscape uboot DM
> > work well. ppc non-DM work well, it seems to be block
> > driver(CONFIG_BLK) issue related to PPC. Please you note.
> >
> 
> 
> Can you please check this observarion!!
> 
> 
> 
> > Thanks
> > Best Regards,
> > Yinbo Zhu.
> >
> > -----Original Message-----
> > From: Yinbo Zhu [mailto:yinbo.zhu at nxp.com]
> > Sent: 2019年3月26日 11:09
> > To: York Sun <york.sun@nxp.com>; u-boot at lists.denx.de
> > Cc: Yinbo Zhu <yinbo.zhu@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>;
> > Ran Wang <ran.wang_1@nxp.com>; Jiafei Pan <jiafei.pan@nxp.com>; Y.b.
> > Lu <yangbo.lu@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>;
> > Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Subject: [PATCH v2 5/5] configs: enable eSDHC device module in
> > T2080QDS
> >
> > >From: Yinbo Zhu <yinbo.zhu@nxp.com>
> >
> > >This patch is to enable MMC DM for T2080QDS in uboot
> >
> > >Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> > >---
> >  >configs/T2080QDS_NAND_defconfig           | 3 +++
> >  >configs/T2080QDS_SDCARD_defconfig         | 3 +++
> >  >configs/T2080QDS_SECURE_BOOT_defconfig    | 3 +++
> >  >configs/T2080QDS_SPIFLASH_defconfig       | 3 +++
> >  >configs/T2080QDS_SRIO_PCIE_BOOT_defconfig | 3 +++
> >  >configs/T2080QDS_defconfig                | 3 +++
> >  >6 files changed, 18 insertions(+)
> >
> > >diff --git a/configs/T2080QDS_NAND_defconfig
> > >b/configs/T2080QDS_NAND_defconfig index 948a05af89..02d47c9fdd
> 100644
> > >--- a/configs/T2080QDS_NAND_defconfig
> > >+++ b/configs/T2080QDS_NAND_defconfig
> > >@@ -59,3 +59,6 @@ CONFIG_SPI=y
> >  >CONFIG_FSL_ESPI=y
> >  >CONFIG_USB=y
> >  >CONFIG_USB_STORAGE=y
> > >+CONFIG_DM_MMC=y
> > >+CONFIG_BLK=y
> > >+CONFIG_DM=y
> > >diff --git a/configs/T2080QDS_SDCARD_defconfig
> > >b/configs/T2080QDS_SDCARD_defconfig
> > >index 30e87df3bb..4ce83fe8c4 100644
> > >--- a/configs/T2080QDS_SDCARD_defconfig
> > >+++ b/configs/T2080QDS_SDCARD_defconfig
> > >@@ -58,3 +58,6 @@ CONFIG_SPI=y
> >  >CONFIG_FSL_ESPI=y
> >  >CONFIG_USB=y
> >  >CONFIG_USB_STORAGE=y
> > >+CONFIG_DM_MMC=y
> > >+CONFIG_BLK=y
> > >+CONFIG_DM=y
> > >diff --git a/configs/T2080QDS_SECURE_BOOT_defconfig
> > >b/configs/T2080QDS_SECURE_BOOT_defconfig
> > >index 2658bf8460..e2a7d3fa76 100644
> > >--- a/configs/T2080QDS_SECURE_BOOT_defconfig
> > >+++ b/configs/T2080QDS_SECURE_BOOT_defconfig
> > >@@ -52,3 +52,6 @@ CONFIG_RSA_SOFTWARE_EXP=y
> CONFIG_OF_LIBFDT=y
> > >CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
> >  >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
> > >+CONFIG_DM_MMC=y
> > >+CONFIG_BLK=y
> > >+CONFIG_OF_CONTROL=y
> > >diff --git a/configs/T2080QDS_SPIFLASH_defconfig
> > >b/configs/T2080QDS_SPIFLASH_defconfig
> > >index 0cccb3a85d..641f3c0c97 100644
> > >--- a/configs/T2080QDS_SPIFLASH_defconfig
> > >+++ b/configs/T2080QDS_SPIFLASH_defconfig
> > >@@ -59,3 +59,6 @@ CONFIG_SPI=y
> >  >CONFIG_FSL_ESPI=y
> >  >CONFIG_USB=y
> >  >CONFIG_USB_STORAGE=y
> > >+CONFIG_DM_MMC=y
> > >+CONFIG_BLK=y
> > >+CONFIG_DM=y
> > >diff --git a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> > >b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> > >index 8febabd84f..d2a8875aac 100644
> > >--- a/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> > >+++ b/configs/T2080QDS_SRIO_PCIE_BOOT_defconfig
> > >@@ -42,3 +42,6 @@ CONFIG_OF_LIBFDT=y
> >  >CONFIG_MPC85XX_HAVE_RESET_VECTOR=y
> >  >CONFIG_OF_CONTROL=y
> >  >CONFIG_DEFAULT_DEVICE_TREE="t2080qds"
> > >+CONFIG_DM_MMC=y
> > >+CONFIG_BLK=y
> > >+CONFIG_DM=y
> > >diff --git a/configs/T2080QDS_defconfig b/configs/T2080QDS_defconfig
> > >index 79cf4424b4..d55ce771a9 100644
> > >--- a/configs/T2080QDS_defconfig
> > >+++ b/configs/T2080QDS_defconfig
> > >@@ -48,3 +48,6 @@ CONFIG_SPI=y
> >  >CONFIG_FSL_ESPI=y
> >  >CONFIG_USB=y
> >  >>CONFIG_USB_STORAGE=y
> > >+CONFIG_DM_MMC=y
> > >+CONFIG_BLK=y
> > >+CONFIG_DM=y
> > --
> > 2.17.1