All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
@ 2018-08-17 10:19 ` Prabhakar Kushwaha
  0 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-17 10:19 UTC (permalink / raw)
  To: devicetree, robh, mark.rutland, shawnguo
  Cc: Alison Wang, Prabhakar Kushwaha, Jagdish Gediya, linux-arm-kernel

Register space of IFC controller is big-endian.

So add big-endian in IFC device tree node.

Signed-off-by: Alison Wang <alison.wang@nxp.com>
Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 arch/arm/boot/dts/ls1021a.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index f18490548c78..1f9cae75bad3 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -1,5 +1,6 @@
 /*
  * Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * This file is dual-licensed: you can use it either under the terms
  * of the GPL or the X11 license, at your option. Note that this dual
@@ -154,6 +155,7 @@
 		ifc: ifc@1530000 {
 			compatible = "fsl,ifc", "simple-bus";
 			reg = <0x0 0x1530000 0x0 0x10000>;
+			big-endian;
 			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
@ 2018-08-17 10:19 ` Prabhakar Kushwaha
  0 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-17 10:19 UTC (permalink / raw)
  To: linux-arm-kernel

Register space of IFC controller is big-endian.

So add big-endian in IFC device tree node.

Signed-off-by: Alison Wang <alison.wang@nxp.com>
Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 arch/arm/boot/dts/ls1021a.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index f18490548c78..1f9cae75bad3 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -1,5 +1,6 @@
 /*
  * Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * This file is dual-licensed: you can use it either under the terms
  * of the GPL or the X11 license, at your option. Note that this dual
@@ -154,6 +155,7 @@
 		ifc: ifc at 1530000 {
 			compatible = "fsl,ifc", "simple-bus";
 			reg = <0x0 0x1530000 0x0 0x10000>;
+			big-endian;
 			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/3] ARM: dts: Add big-endian in nor node for ls1021a
  2018-08-17 10:19 ` Prabhakar Kushwaha
@ 2018-08-17 10:19   ` Prabhakar Kushwaha
  -1 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-17 10:19 UTC (permalink / raw)
  To: devicetree, robh, mark.rutland, shawnguo
  Cc: Prabhakar Kushwaha, linux-arm-kernel

NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 arch/arm/boot/dts/ls1021a-qds.dts | 2 ++
 arch/arm/boot/dts/ls1021a-twr.dts | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
index 499f41a2c6f0..923a25760516 100644
--- a/arch/arm/boot/dts/ls1021a-qds.dts
+++ b/arch/arm/boot/dts/ls1021a-qds.dts
@@ -1,5 +1,6 @@
 /*
  * Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * This file is dual-licensed: you can use it either under the terms
  * of the GPL or the X11 license, at your option. Note that this dual
@@ -235,6 +236,7 @@
 		#size-cells = <1>;
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
index f0c949d74833..8b48c3c7cd21 100644
--- a/arch/arm/boot/dts/ls1021a-twr.dts
+++ b/arch/arm/boot/dts/ls1021a-twr.dts
@@ -1,5 +1,6 @@
 /*
  * Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * This file is dual-licensed: you can use it either under the terms
  * of the GPL or the X11 license, at your option. Note that this dual
@@ -203,6 +204,7 @@
 		#size-cells = <1>;
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 2/3] ARM: dts: Add big-endian in nor node for ls1021a
@ 2018-08-17 10:19   ` Prabhakar Kushwaha
  0 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-17 10:19 UTC (permalink / raw)
  To: linux-arm-kernel

NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 arch/arm/boot/dts/ls1021a-qds.dts | 2 ++
 arch/arm/boot/dts/ls1021a-twr.dts | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts
index 499f41a2c6f0..923a25760516 100644
--- a/arch/arm/boot/dts/ls1021a-qds.dts
+++ b/arch/arm/boot/dts/ls1021a-qds.dts
@@ -1,5 +1,6 @@
 /*
  * Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * This file is dual-licensed: you can use it either under the terms
  * of the GPL or the X11 license, at your option. Note that this dual
@@ -235,6 +236,7 @@
 		#size-cells = <1>;
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts
index f0c949d74833..8b48c3c7cd21 100644
--- a/arch/arm/boot/dts/ls1021a-twr.dts
+++ b/arch/arm/boot/dts/ls1021a-twr.dts
@@ -1,5 +1,6 @@
 /*
  * Copyright 2013-2014 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * This file is dual-licensed: you can use it either under the terms
  * of the GPL or the X11 license, at your option. Note that this dual
@@ -203,6 +204,7 @@
 		#size-cells = <1>;
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 3/3] arm64: dts: Add big-endian in nor node for ls104xa
  2018-08-17 10:19 ` Prabhakar Kushwaha
@ 2018-08-17 10:19   ` Prabhakar Kushwaha
  -1 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-17 10:19 UTC (permalink / raw)
  To: devicetree, robh, mark.rutland, shawnguo
  Cc: Prabhakar Kushwaha, linux-arm-kernel

NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++
 arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index c7b8d2c009cd..dff3d648172e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -3,6 +3,7 @@
  * Device Tree Include file for Freescale Layerscape-1043A family SoC.
  *
  * Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * Mingkai Hu <Mingkai.hu@freescale.com>
  */
@@ -50,6 +51,7 @@
 	nor@0,0 {
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 7b01ba8d3b7e..17ca357e854f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -3,6 +3,7 @@
  * Device Tree Include file for Freescale Layerscape-1043A family SoC.
  *
  * Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * Mingkai Hu <Mingkai.hu@freescale.com>
  */
@@ -65,6 +66,7 @@
 			#address-cells = <1>;
 			#size-cells = <1>;
 			reg = <0x0 0x0 0x8000000>;
+			big-endian;
 			bank-width = <2>;
 			device-width = <1>;
 		};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index e69306e6b0b1..e58a8ca1386c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -3,6 +3,7 @@
  * Device Tree Include file for Freescale Layerscape-1046A family SoC.
  *
  * Copyright 2016 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * Shaohui Xie <Shaohui.Xie@nxp.com>
  */
@@ -141,6 +142,7 @@
 	nor@0,0 {
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH 3/3] arm64: dts: Add big-endian in nor node for ls104xa
@ 2018-08-17 10:19   ` Prabhakar Kushwaha
  0 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-17 10:19 UTC (permalink / raw)
  To: linux-arm-kernel

NOR and IFC controller connectivity is big-endian.
So add big-endian field in nor device tree node allowing
IFC controller to read/write data from/to the flash correctly.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++
 arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++
 arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index c7b8d2c009cd..dff3d648172e 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -3,6 +3,7 @@
  * Device Tree Include file for Freescale Layerscape-1043A family SoC.
  *
  * Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * Mingkai Hu <Mingkai.hu@freescale.com>
  */
@@ -50,6 +51,7 @@
 	nor at 0,0 {
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index 7b01ba8d3b7e..17ca357e854f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -3,6 +3,7 @@
  * Device Tree Include file for Freescale Layerscape-1043A family SoC.
  *
  * Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * Mingkai Hu <Mingkai.hu@freescale.com>
  */
@@ -65,6 +66,7 @@
 			#address-cells = <1>;
 			#size-cells = <1>;
 			reg = <0x0 0x0 0x8000000>;
+			big-endian;
 			bank-width = <2>;
 			device-width = <1>;
 		};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
index e69306e6b0b1..e58a8ca1386c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
@@ -3,6 +3,7 @@
  * Device Tree Include file for Freescale Layerscape-1046A family SoC.
  *
  * Copyright 2016 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
  *
  * Shaohui Xie <Shaohui.Xie@nxp.com>
  */
@@ -141,6 +142,7 @@
 	nor at 0,0 {
 		compatible = "cfi-flash";
 		reg = <0x0 0x0 0x8000000>;
+		big-endian;
 		bank-width = <2>;
 		device-width = <1>;
 	};
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
  2018-08-17 10:19 ` Prabhakar Kushwaha
@ 2018-08-27  7:24   ` Shawn Guo
  -1 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-08-27  7:24 UTC (permalink / raw)
  To: Prabhakar Kushwaha, Li Yang
  Cc: mark.rutland, devicetree, robh, Alison Wang, Jagdish Gediya,
	linux-arm-kernel

On Fri, Aug 17, 2018 at 03:49:18PM +0530, Prabhakar Kushwaha wrote:

Please resend the series with Li Yang <leoyang.li@nxp.com> on copy.

Shawn

> Register space of IFC controller is big-endian.
> 
> So add big-endian in IFC device tree node.
> 
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index f18490548c78..1f9cae75bad3 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
>   *
>   * This file is dual-licensed: you can use it either under the terms
>   * of the GPL or the X11 license, at your option. Note that this dual
> @@ -154,6 +155,7 @@
>  		ifc: ifc@1530000 {
>  			compatible = "fsl,ifc", "simple-bus";
>  			reg = <0x0 0x1530000 0x0 0x10000>;
> +			big-endian;
>  			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> -- 
> 2.14.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
@ 2018-08-27  7:24   ` Shawn Guo
  0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-08-27  7:24 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Aug 17, 2018 at 03:49:18PM +0530, Prabhakar Kushwaha wrote:

Please resend the series with Li Yang <leoyang.li@nxp.com> on copy.

Shawn

> Register space of IFC controller is big-endian.
> 
> So add big-endian in IFC device tree node.
> 
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index f18490548c78..1f9cae75bad3 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
>   *
>   * This file is dual-licensed: you can use it either under the terms
>   * of the GPL or the X11 license, at your option. Note that this dual
> @@ -154,6 +155,7 @@
>  		ifc: ifc at 1530000 {
>  			compatible = "fsl,ifc", "simple-bus";
>  			reg = <0x0 0x1530000 0x0 0x10000>;
> +			big-endian;
>  			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
>  		};
>  
> -- 
> 2.14.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
  2018-08-17 10:19 ` Prabhakar Kushwaha
@ 2018-08-27 19:29   ` Li Yang
  -1 siblings, 0 replies; 12+ messages in thread
From: Li Yang @ 2018-08-27 19:29 UTC (permalink / raw)
  To: Prabhakar Kushwaha
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Rob Herring, Alison Wang, jagdish.gediya, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

On Fri, Aug 17, 2018 at 5:20 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> Register space of IFC controller is big-endian.
>
> So add big-endian in IFC device tree node.

Is this change necessary?  The current binding of IFC says:

- little-endian : If this property is absent, the big-endian mode will
                  be in use as default for registers.

>
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index f18490548c78..1f9cae75bad3 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
>   *
>   * This file is dual-licensed: you can use it either under the terms
>   * of the GPL or the X11 license, at your option. Note that this dual
> @@ -154,6 +155,7 @@
>                 ifc: ifc@1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> +                       big-endian;
>                         interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> --
> 2.14.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
@ 2018-08-27 19:29   ` Li Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Li Yang @ 2018-08-27 19:29 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Aug 17, 2018 at 5:20 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> Register space of IFC controller is big-endian.
>
> So add big-endian in IFC device tree node.

Is this change necessary?  The current binding of IFC says:

- little-endian : If this property is absent, the big-endian mode will
                  be in use as default for registers.

>
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> Signed-off-by: Jagdish Gediya <jagdish.gediya@nxp.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index f18490548c78..1f9cae75bad3 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -1,5 +1,6 @@
>  /*
>   * Copyright 2013-2014 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
>   *
>   * This file is dual-licensed: you can use it either under the terms
>   * of the GPL or the X11 license, at your option. Note that this dual
> @@ -154,6 +155,7 @@
>                 ifc: ifc at 1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> +                       big-endian;
>                         interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> --
> 2.14.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* RE: [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
  2018-08-27 19:29   ` Li Yang
@ 2018-08-28  6:53     ` Prabhakar Kushwaha
  -1 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-28  6:53 UTC (permalink / raw)
  To: Leo Li
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Rob Herring, Alison Wang, Jagdish Gediya, Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi leo

> -----Original Message-----
> From: Li Yang <leoyang.li@nxp.com>
> Sent: Tuesday, August 28, 2018 1:00 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; Rob Herring <robh@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>; Shawn Guo <shawnguo@kernel.org>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel@lists.infradead.org>; Alison Wang <alison.wang@nxp.com>; Jagdish
> Gediya <jagdish.gediya@nxp.com>
> Subject: Re: [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
> 
> On Fri, Aug 17, 2018 at 5:20 AM Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> >
> > Register space of IFC controller is big-endian.
> >
> > So add big-endian in IFC device tree node.
> 
> Is this change necessary?  The current binding of IFC says:
> 
> - little-endian : If this property is absent, the big-endian mode will
>                   be in use as default for registers.
> 

I agree.. this patch is not required.

But your comments has remind me to remove big-endian property from ls1043a and ls0146a also under IFC controller.

Thanks
--pk

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
@ 2018-08-28  6:53     ` Prabhakar Kushwaha
  0 siblings, 0 replies; 12+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-28  6:53 UTC (permalink / raw)
  To: linux-arm-kernel

Hi leo

> -----Original Message-----
> From: Li Yang <leoyang.li@nxp.com>
> Sent: Tuesday, August 28, 2018 1:00 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; Rob Herring <robh@kernel.org>; Mark
> Rutland <mark.rutland@arm.com>; Shawn Guo <shawnguo@kernel.org>;
> moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm-
> kernel at lists.infradead.org>; Alison Wang <alison.wang@nxp.com>; Jagdish
> Gediya <jagdish.gediya@nxp.com>
> Subject: Re: [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A
> 
> On Fri, Aug 17, 2018 at 5:20 AM Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> >
> > Register space of IFC controller is big-endian.
> >
> > So add big-endian in IFC device tree node.
> 
> Is this change necessary?  The current binding of IFC says:
> 
> - little-endian : If this property is absent, the big-endian mode will
>                   be in use as default for registers.
> 

I agree.. this patch is not required.

But your comments has remind me to remove big-endian property from ls1043a and ls0146a also under IFC controller.

Thanks
--pk

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-08-28  6:53 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 10:19 [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A Prabhakar Kushwaha
2018-08-17 10:19 ` Prabhakar Kushwaha
2018-08-17 10:19 ` [PATCH 2/3] ARM: dts: Add big-endian in nor node for ls1021a Prabhakar Kushwaha
2018-08-17 10:19   ` Prabhakar Kushwaha
2018-08-17 10:19 ` [PATCH 3/3] arm64: dts: Add big-endian in nor node for ls104xa Prabhakar Kushwaha
2018-08-17 10:19   ` Prabhakar Kushwaha
2018-08-27  7:24 ` [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A Shawn Guo
2018-08-27  7:24   ` Shawn Guo
2018-08-27 19:29 ` Li Yang
2018-08-27 19:29   ` Li Yang
2018-08-28  6:53   ` Prabhakar Kushwaha
2018-08-28  6:53     ` Prabhakar Kushwaha

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.