RE: [RESEND PATCH 1/2] mtd: spi-nor: add macros related to MICRON flash

[Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>]

[-- Attachment #1: Type: text/plain, Size: 4282 bytes --]

Hi Tudor,

> -----Original Message-----
> From: linux-mtd [mailto:linux-mtd-bounces@lists.infradead.org] On Behalf Of
> Yogesh Narayan Gaur
> Sent: Thursday, September 20, 2018 10:02 AM
> To: Tudor Ambarus <tudor.ambarus@microchip.com>; linux-
> mtd@lists.infradead.org; linux-spi@vger.kernel.org
> Cc: marek.vasut@gmail.com; linux-kernel@vger.kernel.org;
> boris.brezillon@bootlin.com; frieder.schrempf@exceet.de;
> cyrille.pitchen@wedev4u.fr; computersforpeace@gmail.com
> Subject: RE: [RESEND PATCH 1/2] mtd: spi-nor: add macros related to MICRON
> flash
> 
> Hi Tudor,
> 
> > -----Original Message-----
> > From: Tudor Ambarus [mailto:tudor.ambarus@microchip.com]
> > Sent: Wednesday, September 19, 2018 10:00 PM
> > To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>; linux-
> > mtd@lists.infradead.org; linux-spi@vger.kernel.org
> > Cc: boris.brezillon@bootlin.com; linux-kernel@vger.kernel.org;
> > marek.vasut@gmail.com; frieder.schrempf@exceet.de;
> > cyrille.pitchen@wedev4u.fr; computersforpeace@gmail.com
> > Subject: Re: [RESEND PATCH 1/2] mtd: spi-nor: add macros related to
> > MICRON flash
> >
> > Hi,
> >
> > On 09/19/2018 07:50 AM, Yogesh Gaur wrote:
> > > Some MICRON related macros in spi-nor domain were ST.
> > > Rename entries related to STMicroelectronics under macro SNOR_MFR_ST.
> > >
> > > Added entry of MFR Id for Micron flashes, 0x002C.
> > >
> > > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> > > ---
> > >  drivers/mtd/spi-nor/spi-nor.c | 9 ++++++---
> > >  include/linux/mtd/cfi.h       | 1 +
> > >  include/linux/mtd/spi-nor.h   | 3 ++-
> > >  3 files changed, 9 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/mtd/spi-nor/spi-nor.c
> > > b/drivers/mtd/spi-nor/spi-nor.c index f028277..33a55bc 100644
> > > --- a/drivers/mtd/spi-nor/spi-nor.c
> > > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > > @@ -271,6 +271,7 @@ static inline int set_4byte(struct spi_nor *nor,
> > > const
> > struct flash_info *info,
> > >  	u8 cmd;
> > >
> > >  	switch (JEDEC_MFR(info)) {
> > > +	case SNOR_MFR_ST:
> >
[...]
> > > a/include/linux/mtd/cfi.h b/include/linux/mtd/cfi.h index
> > > 9b57a9b..cbf7716 100644
> > > --- a/include/linux/mtd/cfi.h
> > > +++ b/include/linux/mtd/cfi.h
> > > @@ -377,6 +377,7 @@ struct cfi_fixup {
> > >  #define CFI_MFR_SHARP		0x00B0
> > >  #define CFI_MFR_SST		0x00BF
> > >  #define CFI_MFR_ST		0x0020 /* STMicroelectronics */
> > > +#define CFI_MFR_MICRON		0x002C /* Micron */
> >
> > Can you point us to a datasheet to verify the id?
> >
> 
> Currently data sheet of this flash is under NDA, I have asked Micron guys to
> provide the public link of this data sheet.
> 
Please find the attached public data sheet of MT35x flash.
Micron team has added few basic information like device ID information, supported commands etc of this flash in public data-sheet.
Complete datasheet is under NDA.

--
Regards
Yogesh Gaur.

> --
> Regards
> Yogesh Gaur.
> 
> > Best,
> > ta
> >
> > >  #define CFI_MFR_TOSHIBA		0x0098
> > >  #define CFI_MFR_WINBOND		0x00DA
> > >
> > > diff --git a/include/linux/mtd/spi-nor.h
> > > b/include/linux/mtd/spi-nor.h index c922e97..f43bfc5 100644
> > > --- a/include/linux/mtd/spi-nor.h
> > > +++ b/include/linux/mtd/spi-nor.h
> > > @@ -23,7 +23,8 @@
> > >  #define SNOR_MFR_ATMEL		CFI_MFR_ATMEL
> > >  #define SNOR_MFR_GIGADEVICE	0xc8
> > >  #define SNOR_MFR_INTEL		CFI_MFR_INTEL
> > > -#define SNOR_MFR_MICRON		CFI_MFR_ST /* ST Micro <-->
> Micron
> > */
> > > +#define SNOR_MFR_ST		CFI_MFR_ST	/* ST Micro */
> > > +#define SNOR_MFR_MICRON		CFI_MFR_MICRON	/*
> Micron */
> > >  #define SNOR_MFR_MACRONIX	CFI_MFR_MACRONIX
> > >  #define SNOR_MFR_SPANSION	CFI_MFR_AMD
> > >  #define SNOR_MFR_SST		CFI_MFR_SST
> > >
> ______________________________________________________
> Linux MTD discussion mailing list
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infr
> adead.org%2Fmailman%2Flistinfo%2Flinux-
> mtd%2F&amp;data=02%7C01%7Cyogeshnarayan.gaur%40nxp.com%7Ca8587ce
> 6c75d496d021208d61eb20714%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
> %7C0%7C636730147344646202&amp;sdata=9uJcQYkFyn%2FF0WZoVhs0Ov%2F
> w0EuSCoHXpJO3xdNsDug%3D&amp;reserved=0

[-- Attachment #2: MT35X Public.pdf --]
[-- Type: application/pdf, Size: 379463 bytes --]

[-- Attachment #3: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/