All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] LS1021ATWR: Modify u-boot size for sd secureboot
@ 2017-01-20 15:32 Vinitha Pillai-B57223
  2017-01-27 17:24 ` york sun
  0 siblings, 1 reply; 3+ messages in thread
From: Vinitha Pillai-B57223 @ 2017-01-20 15:32 UTC (permalink / raw)
  To: u-boot

From: Vinitha Pillai <vinitha.pillai@nxp.com>

Raw uboot image is used in place of FIT image in secure boot.
The maximum allocated size of raw u-boot bin is 1MB in memory map.
Hence , CONFIG_SYS_MONITOR_LEN has been modified to 1 MB.
The bootscript  (BS_ADDR) and its header (BS_HDR_ADDR) offset on MMC have also been modified to accommodate the increase in uboot size.

Signed-off-by: Vinitha Pillai-B57223 <vinitha.pillai@nxp.com>
---
 arch/arm/include/asm/fsl_secure_boot.h | 4 ++--
 include/configs/ls1021atwr.h           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/include/asm/fsl_secure_boot.h b/arch/arm/include/asm/fsl_secure_boot.h
index 4525287..0ef7315 100644
--- a/arch/arm/include/asm/fsl_secure_boot.h
+++ b/arch/arm/include/asm/fsl_secure_boot.h
@@ -99,8 +99,8 @@
 /* For SD boot address and size are assigned in terms of sector
  * offset and no. of sectors respectively.
  */
-#define CONFIG_BS_HDR_ADDR_DEVICE	0x00000800
-#define CONFIG_BS_ADDR_DEVICE		0x00000840
+#define CONFIG_BS_HDR_ADDR_DEVICE	0x00000900
+#define CONFIG_BS_ADDR_DEVICE		0x00000940
 #define CONFIG_BS_HDR_SIZE		0x00000010
 #define CONFIG_BS_SIZE			0x00000008
 #else
diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h
index b48cd00..178239f 100644
--- a/include/configs/ls1021atwr.h
+++ b/include/configs/ls1021atwr.h
@@ -134,9 +134,9 @@
  * size increases then increase this size in case of secure boot as
  * it uses raw u-boot image instead of fit image.
  */
-#define CONFIG_SYS_MONITOR_LEN		(0x80000 + CONFIG_U_BOOT_HDR_SIZE)
+#define CONFIG_SYS_MONITOR_LEN		(0x100000 + CONFIG_U_BOOT_HDR_SIZE)
 #else
-#define CONFIG_SYS_MONITOR_LEN		0x80000
+#define CONFIG_SYS_MONITOR_LEN		0x100000
 #endif /* ifdef CONFIG_U_BOOT_HDR_SIZE */
 #endif
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] LS1021ATWR: Modify u-boot size for sd secureboot
  2017-01-20 15:32 [U-Boot] [PATCH] LS1021ATWR: Modify u-boot size for sd secureboot Vinitha Pillai-B57223
@ 2017-01-27 17:24 ` york sun
  2017-01-30  5:09   ` Sumit Garg
  0 siblings, 1 reply; 3+ messages in thread
From: york sun @ 2017-01-27 17:24 UTC (permalink / raw)
  To: u-boot

"Secure boot" is a two-word phrase, not one word.

On 01/20/2017 01:35 AM, Vinitha Pillai-B57223 wrote:
> From: Vinitha Pillai <vinitha.pillai@nxp.com>
>
> Raw uboot image is used in place of FIT image in secure boot.
> The maximum allocated size of raw u-boot bin is 1MB in memory map.
> Hence , CONFIG_SYS_MONITOR_LEN has been modified to 1 MB.
> The bootscript  (BS_ADDR) and its header (BS_HDR_ADDR) offset on MMC have also been modified to accommodate the increase in uboot size.

Please wrap back at or before 70 characters. Avoid putting extra white 
space in the message.

>
> Signed-off-by: Vinitha Pillai-B57223 <vinitha.pillai@nxp.com>

Sumit,

This change seems harmless. However I don't have the images setup for 
testing. Please review this patch as the secure boot maintainer.

York

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] LS1021ATWR: Modify u-boot size for sd secureboot
  2017-01-27 17:24 ` york sun
@ 2017-01-30  5:09   ` Sumit Garg
  0 siblings, 0 replies; 3+ messages in thread
From: Sumit Garg @ 2017-01-30  5:09 UTC (permalink / raw)
  To: u-boot

> -----Original Message-----
> From: york sun
> Sent: Friday, January 27, 2017 10:55 PM
> To: Vini Pillai <vinitha.pillai@nxp.com>; Sumit Garg <sumit.garg@nxp.com>
> Cc: u-boot at lists.denx.de; Ruchika Gupta <ruchika.gupta@nxp.com>;
> Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: Re: [PATCH] LS1021ATWR: Modify u-boot size for sd secureboot
> 
> "Secure boot" is a two-word phrase, not one word.
> 
> On 01/20/2017 01:35 AM, Vinitha Pillai-B57223 wrote:
> > From: Vinitha Pillai <vinitha.pillai@nxp.com>
> >
> > Raw uboot image is used in place of FIT image in secure boot.
> > The maximum allocated size of raw u-boot bin is 1MB in memory map.
> > Hence , CONFIG_SYS_MONITOR_LEN has been modified to 1 MB.
> > The bootscript  (BS_ADDR) and its header (BS_HDR_ADDR) offset on MMC
> have also been modified to accommodate the increase in uboot size.
> 
> Please wrap back at or before 70 characters. Avoid putting extra white space in
> the message.
> 
> >
> > Signed-off-by: Vinitha Pillai-B57223 <vinitha.pillai@nxp.com>
> 
> Sumit,
> 
> This change seems harmless. However I don't have the images setup for
> testing. Please review this patch as the secure boot maintainer.
> 
> York

Reviewed-by: Sumit Garg <sumit.garg@nxp.com>

Vinitha,

Please incorporate York comments.

Sumit

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-30  5:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-20 15:32 [U-Boot] [PATCH] LS1021ATWR: Modify u-boot size for sd secureboot Vinitha Pillai-B57223
2017-01-27 17:24 ` york sun
2017-01-30  5:09   ` Sumit Garg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.