[U-Boot] [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel, env

[U-Boot] [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel, env

[Bhaskar Upadhaya]

This patch adjusts memory map for images on LS1012A
    as per below memory map:
    Image                               Flash Offset
    RCW+PBI                             0x00000000
    Boot firmware (U-Boot)              0x00100000
    Boot firmware Environment           0x00300000

Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com>
---
 include/configs/ls1012a_common.h |  4 ++--
 include/configs/ls1012afrdm.h    | 16 ++++++++--------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h
index 9d85341..458a6ad 100644
--- a/include/configs/ls1012a_common.h
+++ b/include/configs/ls1012a_common.h
@@ -65,7 +65,7 @@
 #define CONFIG_ENV_OVERWRITE
 
 #define CONFIG_ENV_SIZE			0x40000          /* 256KB */
-#define CONFIG_ENV_OFFSET		0x200000        /* 2MB */
+#define CONFIG_ENV_OFFSET		0x300000        /* 3MB */
 #define CONFIG_ENV_SECT_SIZE		0x40000
 #endif
 
@@ -97,7 +97,7 @@
 	"kernel_addr=0x100000\0"		\
 	"fdt_high=0xffffffffffffffff\0"		\
 	"initrd_high=0xffffffffffffffff\0"	\
-	"kernel_start=0xa00000\0"		\
+	"kernel_start=0x1000000\0"		\
 	"kernel_load=0xa0000000\0"		\
 	"kernel_size=0x2800000\0"		\
 
diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
index 6b1ba57..8a9444d 100644
--- a/include/configs/ls1012afrdm.h
+++ b/include/configs/ls1012afrdm.h
@@ -22,14 +22,14 @@
 
 #undef CONFIG_EXTRA_ENV_SETTINGS
 #define CONFIG_EXTRA_ENV_SETTINGS              \
-       "verify=no\0"                           \
-       "loadaddr=0x80100000\0"                 \
-       "kernel_addr=0x100000\0"                \
-       "fdt_high=0xffffffffffffffff\0"         \
-       "initrd_high=0xffffffffffffffff\0"      \
-       "kernel_start=0xa00000\0"               \
-       "kernel_load=0x96000000\0"              \
-       "kernel_size=0x2800000\0"
+	"verify=no\0"                           \
+	"loadaddr=0x80100000\0"                 \
+	"kernel_addr=0x100000\0"                \
+	"fdt_high=0xffffffffffffffff\0"         \
+	"initrd_high=0xffffffffffffffff\0"      \
+	"kernel_start=0x1000000\0"               \
+	"kernel_load=0x96000000\0"              \
+	"kernel_size=0x2800000\0"
 
 /*
 * USB
-- 
1.9.1

[U-Boot] [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel, env

[York Sun]

On 09/01/2017 02:54 AM, Bhaskar Upadhaya wrote:
> This patch adjusts memory map for images on LS1012A
>      as per below memory map:
>      Image                               Flash Offset
>      RCW+PBI                             0x00000000
>      Boot firmware (U-Boot)              0x00100000

You are changing "kernel_addr" below.

<snip>
> @@ -97,7 +97,7 @@
>   	"kernel_addr=0x100000\0"		\
>   	"fdt_high=0xffffffffffffffff\0"		\
>   	"initrd_high=0xffffffffffffffff\0"	\
> -	"kernel_start=0xa00000\0"		\
> +	"kernel_start=0x1000000\0"		\
>   	"kernel_load=0xa0000000\0"		\
>   	"kernel_size=0x2800000\0"		\

York

[U-Boot] [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel, env

[Bhaskar Upadhaya]

-----Original Message-----
From: York Sun 
Sent: Wednesday, September 06, 2017 9:51 PM
To: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>; u-boot at lists.denx.de
Subject: Re: [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel,env

On 09/01/2017 02:54 AM, Bhaskar Upadhaya wrote:
> This patch adjusts memory map for images on LS1012A
>      as per below memory map:
>      Image                               Flash Offset
>      RCW+PBI                             0x00000000
>      Boot firmware (U-Boot)              0x00100000

You are changing "kernel_addr" below.
[Bhaskar] Hi York, kernel_addr is not changed, only kernel_start is changed, so please tell does the comment is to change the Commit message or something else.

<snip>
> @@ -97,7 +97,7 @@
>   	"kernel_addr=0x100000\0"		\
>   	"fdt_high=0xffffffffffffffff\0"		\
>   	"initrd_high=0xffffffffffffffff\0"	\
> -	"kernel_start=0xa00000\0"		\
> +	"kernel_start=0x1000000\0"		\
>   	"kernel_load=0xa0000000\0"		\
>   	"kernel_size=0x2800000\0"		\

York

[U-Boot] [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel, env

[York Sun]

On 10/06/2017 03:50 AM, Bhaskar Upadhaya wrote:
> 
> 
> -----Original Message-----
> From: York Sun 
> Sent: Wednesday, September 06, 2017 9:51 PM
> To: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel,env
> 
> On 09/01/2017 02:54 AM, Bhaskar Upadhaya wrote:
>> This patch adjusts memory map for images on LS1012A
>>      as per below memory map:
>>      Image                               Flash Offset
>>      RCW+PBI                             0x00000000
>>      Boot firmware (U-Boot)              0x00100000
> 
> You are changing "kernel_addr" below.
> [Bhaskar] Hi York, kernel_addr is not changed, only kernel_start is changed, so please tell does the comment is to change the Commit message or something else.

Your subject and commit message both indicate changes of memory map. But
variable kernel_start is not about memory map.

You also have more changes in ls1012afrdm.h. Are they mostly white space
change? If so, please separate whitespace change in another patch.

York