All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [v2] include/configs: ls1012a: add pfe stop command
@ 2019-11-14  4:45 Biwen Li
  2019-11-15  4:57 ` Priyanka Jain
  0 siblings, 1 reply; 3+ messages in thread
From: Biwen Li @ 2019-11-14  4:45 UTC (permalink / raw)
  To: u-boot

This adds pfe stop command before enter linux kernel
to fix a problem that ethernet won't be workable
after enter linux

Why need execute the command before enter
linux kernel?
- There is a h/w limitation in LS1012A PFE,  to
  re-initialize PFE it has to be safe shutdown,
  these steps are done through PFE stop.

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
Changes in v2:
	- trim subject
	- add why

 include/configs/ls1012a2g5rdb.h | 2 +-
 include/configs/ls1012afrdm.h   | 2 +-
 include/configs/ls1012afrwy.h   | 4 ++--
 include/configs/ls1012ardb.h    | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/configs/ls1012a2g5rdb.h b/include/configs/ls1012a2g5rdb.h
index cb329385d9..5943b69716 100644
--- a/include/configs/ls1012a2g5rdb.h
+++ b/include/configs/ls1012a2g5rdb.h
@@ -85,7 +85,7 @@
 	"installer=load mmc 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size; env exists secureboot "	\
 		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
index 8c7d4e558d..8a3ebf06f2 100644
--- a/include/configs/ls1012afrdm.h
+++ b/include/configs/ls1012afrdm.h
@@ -60,7 +60,7 @@
 	"installer=load usb 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size && bootm $load_addr#$board\0"
 
diff --git a/include/configs/ls1012afrwy.h b/include/configs/ls1012afrwy.h
index 1b0f1566d3..a2ca326cfc 100644
--- a/include/configs/ls1012afrwy.h
+++ b/include/configs/ls1012afrwy.h
@@ -109,13 +109,13 @@
 	"installer=load mmc 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size; env exists secureboot "	\
 		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
 		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
 		"bootm $load_addr#$board\0"	\
-	"sd_bootcmd=echo Trying load from sd card..;"		\
+	"sd_bootcmd=pfe stop; echo Trying load from sd card..;"		\
 		"mmcinfo; mmc read $load_addr "			\
 		"$kernel_addr_sd $kernel_size_sd ;"		\
 		"env exists secureboot && mmc read $kernelheader_addr_r "\
diff --git a/include/configs/ls1012ardb.h b/include/configs/ls1012ardb.h
index a5e27404f8..39166fea7d 100644
--- a/include/configs/ls1012ardb.h
+++ b/include/configs/ls1012ardb.h
@@ -109,7 +109,7 @@
 	"installer=load mmc 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size; env exists secureboot "	\
 		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [U-Boot] [v2] include/configs: ls1012a: add pfe stop command
  2019-11-14  4:45 [U-Boot] [v2] include/configs: ls1012a: add pfe stop command Biwen Li
@ 2019-11-15  4:57 ` Priyanka Jain
  2019-11-15  7:11   ` Biwen Li
  0 siblings, 1 reply; 3+ messages in thread
From: Priyanka Jain @ 2019-11-15  4:57 UTC (permalink / raw)
  To: u-boot



>-----Original Message-----
>From: Biwen Li <biwen.li@nxp.com>
>Sent: Thursday, November 14, 2019 10:15 AM
>To: Shengzhou Liu <shengzhou.liu@nxp.com>; Alison Wang
><alison.wang@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; Rajesh
>Bhagat <rajesh.bhagat@nxp.com>; Priyanka Jain <priyanka.jain@nxp.com>
>Cc: Jiafei Pan <jiafei.pan@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>; u-
>boot at lists.denx.de; Biwen Li <biwen.li@nxp.com>
>Subject: [v2] include/configs: ls1012a: add pfe stop command
>
>This adds pfe stop command before enter linux kernel to fix a problem that
>ethernet won't be workable after enter linux
>
>Why need execute the command before enter linux kernel?
No need to add question. The description needs to be in passive voice.
Add something like. 'pfe stop' command is required because 
>- There is a h/w limitation in LS1012A PFE,  to
>  re-initialize PFE it has to be safe shutdown,
>  these steps are done through PFE stop.
>
>Signed-off-by: Biwen Li <biwen.li@nxp.com>
>---
>Changes in v2:
>	- trim subject
>	- add why
>
<snip>
-priyankajain

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [U-Boot] [v2] include/configs: ls1012a: add pfe stop command
  2019-11-15  4:57 ` Priyanka Jain
@ 2019-11-15  7:11   ` Biwen Li
  0 siblings, 0 replies; 3+ messages in thread
From: Biwen Li @ 2019-11-15  7:11 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Priyanka Jain <priyanka.jain@nxp.com>
> Sent: 2019年11月15日 12:57
> To: Biwen Li <biwen.li@nxp.com>; Shengzhou Liu <shengzhou.liu@nxp.com>;
> Alison Wang <alison.wang@nxp.com>; Jagdish Gediya
> <jagdish.gediya@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com>
> Cc: Jiafei Pan <jiafei.pan@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>;
> u-boot at lists.denx.de; Biwen Li <biwen.li@nxp.com>
> Subject: RE: [v2] include/configs: ls1012a: add pfe stop command
> 
> 
> 
> >-----Original Message-----
> >From: Biwen Li <biwen.li@nxp.com>
> >Sent: Thursday, November 14, 2019 10:15 AM
> >To: Shengzhou Liu <shengzhou.liu@nxp.com>; Alison Wang
> ><alison.wang@nxp.com>; Jagdish Gediya <jagdish.gediya@nxp.com>; Rajesh
> >Bhagat <rajesh.bhagat@nxp.com>; Priyanka Jain <priyanka.jain@nxp.com>
> >Cc: Jiafei Pan <jiafei.pan@nxp.com>; Xiaobo Xie <xiaobo.xie@nxp.com>;
> >u- boot at lists.denx.de; Biwen Li <biwen.li@nxp.com>
> >Subject: [v2] include/configs: ls1012a: add pfe stop command
> >
> >This adds pfe stop command before enter linux kernel to fix a problem
> >that ethernet won't be workable after enter linux
> >
> >Why need execute the command before enter linux kernel?
> No need to add question. The description needs to be in passive voice.
> Add something like. 'pfe stop' command is required because
Okay, will be update in v3.
> >- There is a h/w limitation in LS1012A PFE,  to
> >  re-initialize PFE it has to be safe shutdown,
> >  these steps are done through PFE stop.
> >
> >Signed-off-by: Biwen Li <biwen.li@nxp.com>
> >---
> >Changes in v2:
> >	- trim subject
> >	- add why
> >
> <snip>
> -priyankajain

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-15  7:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14  4:45 [U-Boot] [v2] include/configs: ls1012a: add pfe stop command Biwen Li
2019-11-15  4:57 ` Priyanka Jain
2019-11-15  7:11   ` Biwen Li

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.