From: Leonard Crestez <leonard.crestez@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: Add clk_parent entry in debugfs
Date: Sat, 8 Jun 2019 07:26:11 +0000 [thread overview]
Message-ID: <VI1PR04MB5055A1DBAC2C4AAC515CB494EE110@VI1PR04MB5055.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190607190522.D276520868@mail.kernel.org
On 6/7/19 10:05 PM, Stephen Boyd wrote:
> Quoting Leonard Crestez (2019-05-24 01:25:25)
>> @@ -3040,10 +3051,11 @@ static void clk_debug_create_one(struct clk_core *core, struct dentry *pdentry)
>> debugfs_create_u32("clk_enable_count", 0444, root, &core->enable_count);
>> debugfs_create_u32("clk_protect_count", 0444, root, &core->protect_count);
>> debugfs_create_u32("clk_notifier_count", 0444, root, &core->notifier_count);
>> debugfs_create_file("clk_duty_cycle", 0444, root, core,
>> &clk_duty_cycle_fops);
>> + debugfs_create_file("clk_parent", 0444, root, core, ¤t_parent_fops);
>
> Shouldn't we skip creation of this file if core->num_parents == 0? So
> put this under the if condition below?
It's still useful to determine clk tree structure from debugfs fields,
otherwise you'd have to extract by parsing other files.
Would you hide clk_rate for fixed-rate? I'd rather have everything
available for uniformity, even if it's otherwise constant at runtime.
--
Regards,
Leonard
WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Turquette <mturquette@baylibre.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: Add clk_parent entry in debugfs
Date: Sat, 8 Jun 2019 07:26:11 +0000 [thread overview]
Message-ID: <VI1PR04MB5055A1DBAC2C4AAC515CB494EE110@VI1PR04MB5055.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190607190522.D276520868@mail.kernel.org
On 6/7/19 10:05 PM, Stephen Boyd wrote:
> Quoting Leonard Crestez (2019-05-24 01:25:25)
>> @@ -3040,10 +3051,11 @@ static void clk_debug_create_one(struct clk_core *core, struct dentry *pdentry)
>> debugfs_create_u32("clk_enable_count", 0444, root, &core->enable_count);
>> debugfs_create_u32("clk_protect_count", 0444, root, &core->protect_count);
>> debugfs_create_u32("clk_notifier_count", 0444, root, &core->notifier_count);
>> debugfs_create_file("clk_duty_cycle", 0444, root, core,
>> &clk_duty_cycle_fops);
>> + debugfs_create_file("clk_parent", 0444, root, core, ¤t_parent_fops);
>
> Shouldn't we skip creation of this file if core->num_parents == 0? So
> put this under the if condition below?
It's still useful to determine clk tree structure from debugfs fields,
otherwise you'd have to extract by parsing other files.
Would you hide clk_rate for fixed-rate? I'd rather have everything
available for uniformity, even if it's otherwise constant at runtime.
--
Regards,
Leonard
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-08 7:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 8:25 [PATCH] clk: Add clk_parent entry in debugfs Leonard Crestez
2019-05-24 8:25 ` Leonard Crestez
2019-06-07 19:05 ` Stephen Boyd
2019-06-07 19:05 ` Stephen Boyd
2019-06-08 7:26 ` Leonard Crestez [this message]
2019-06-08 7:26 ` Leonard Crestez
2019-06-08 12:19 ` Geert Uytterhoeven
2019-06-08 12:19 ` Geert Uytterhoeven
2019-06-08 12:48 ` Leonard Crestez
2019-06-08 12:48 ` Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5055A1DBAC2C4AAC515CB494EE110@VI1PR04MB5055.eurprd04.prod.outlook.com \
--to=leonard.crestez@nxp.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.