All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leonard Crestez <leonard.crestez@nxp.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
	Abel Vesa <abel.vesa@nxp.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27
Date: Thu, 21 Mar 2019 10:03:52 +0000	[thread overview]
Message-ID: <VI1PR04MB55331FC19551476A6614B869EE420@VI1PR04MB5533.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190321094903.p5smdd43r4tpj2kf@pengutronix.de

On 3/21/2019 11:49 AM, Uwe Kleine-König wrote:
> On Wed, Mar 20, 2019 at 01:01:26PM +0000, Leonard Crestez wrote:
>> Commit d80f8206905c ("pwm: imx: Split into two drivers") also adds a new
>> CONFIG_PWM_IMX27 for the PWM block on recent IMX chips and we should
>> enable it by default for imx.
>>
>> Restoring the PWM driver fixes an infinite probe loop in 5.1-rc1 on
>> various imx6qdl-sabresd boards.

> This is prior art:
> 
> @Shawn: Would you please apply my patches? If you don't have them any
> more, I can bounce them to you.

+1 from me because it fixes boot.

>> --- a/arch/arm/configs/imx_v6_v7_defconfig
>> +++ b/arch/arm/configs/imx_v6_v7_defconfig
>> @@ -397,10 +397,11 @@ CONFIG_SENSORS_ISL29018=y
>>   CONFIG_MAG3110=y
>>   CONFIG_MPL3115=y
>>   CONFIG_PWM=y
>>   CONFIG_PWM_FSL_FTM=y
>>   CONFIG_PWM_IMX=y
>> +CONFIG_PWM_IMX27=y
> 
> PWM_IMX is gone, so this can be dropped (but see my patch referenced
> above).

Noticed that after sending; your patch deals with this correctly and 
also covers imx_v4_v5

--
Regards,
Leonard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
	Abel Vesa <abel.vesa@nxp.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27
Date: Thu, 21 Mar 2019 10:03:52 +0000	[thread overview]
Message-ID: <VI1PR04MB55331FC19551476A6614B869EE420@VI1PR04MB5533.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20190321094903.p5smdd43r4tpj2kf@pengutronix.de

On 3/21/2019 11:49 AM, Uwe Kleine-König wrote:
> On Wed, Mar 20, 2019 at 01:01:26PM +0000, Leonard Crestez wrote:
>> Commit d80f8206905c ("pwm: imx: Split into two drivers") also adds a new
>> CONFIG_PWM_IMX27 for the PWM block on recent IMX chips and we should
>> enable it by default for imx.
>>
>> Restoring the PWM driver fixes an infinite probe loop in 5.1-rc1 on
>> various imx6qdl-sabresd boards.

> This is prior art:
> 
> @Shawn: Would you please apply my patches? If you don't have them any
> more, I can bounce them to you.

+1 from me because it fixes boot.

>> --- a/arch/arm/configs/imx_v6_v7_defconfig
>> +++ b/arch/arm/configs/imx_v6_v7_defconfig
>> @@ -397,10 +397,11 @@ CONFIG_SENSORS_ISL29018=y
>>   CONFIG_MAG3110=y
>>   CONFIG_MPL3115=y
>>   CONFIG_PWM=y
>>   CONFIG_PWM_FSL_FTM=y
>>   CONFIG_PWM_IMX=y
>> +CONFIG_PWM_IMX27=y
> 
> PWM_IMX is gone, so this can be dropped (but see my patch referenced
> above).

Noticed that after sending; your patch deals with this correctly and 
also covers imx_v4_v5

--
Regards,
Leonard

  reply	other threads:[~2019-03-21 10:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 13:01 [PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27 Leonard Crestez
2019-03-20 13:01 ` Leonard Crestez
2019-03-21  9:49 ` Uwe Kleine-König
2019-03-21  9:49   ` Uwe Kleine-König
2019-03-21 10:03   ` Leonard Crestez [this message]
2019-03-21 10:03     ` Leonard Crestez
2019-03-22  2:18   ` Shawn Guo
2019-03-22  2:18     ` Shawn Guo
2019-03-22  9:47   ` Thierry Reding
2019-03-22  9:47     ` Thierry Reding
2019-03-22 10:43     ` Uwe Kleine-König
2019-03-22 10:43       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB55331FC19551476A6614B869EE420@VI1PR04MB5533.eurprd04.prod.outlook.com \
    --to=leonard.crestez@nxp.com \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=p.zabel@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.