* [PATCH] board: ls1043ardb: force PCI device enumeration
@ 2021-11-23 6:28 Martin Schiller
2021-11-23 10:34 ` Camelia Alexandra Groza (OSS)
0 siblings, 1 reply; 3+ messages in thread
From: Martin Schiller @ 2021-11-23 6:28 UTC (permalink / raw)
To: u-boot; +Cc: Martin Schiller, Priyanka Jain, Camelia Groza
Commit eb1986804d1d ("configs: enable DM_ETH support for LS1043ARDB")
resulted in the PCI bus no longer being implicitly enumerated.
However, this is necessary for the fdt pcie fixups to work.
Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
transition to DM_ETH"), pci_init() is now called in the board_init()
routine when CONFIG_DM_ETH is active.
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
CC: Priyanka Jain <priyanka.jain@nxp.com>
CC: Camelia Groza <camelia.groza@nxp.com>
---
board/freescale/ls1043ardb/ls1043ardb.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/board/freescale/ls1043ardb/ls1043ardb.c b/board/freescale/ls1043ardb/ls1043ardb.c
index beef26b084..1764c9336c 100644
--- a/board/freescale/ls1043ardb/ls1043ardb.c
+++ b/board/freescale/ls1043ardb/ls1043ardb.c
@@ -219,6 +219,10 @@ int board_init(void)
ppa_init();
#endif
+#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
+ pci_init();
+#endif
+
#ifdef CONFIG_U_QE
u_qe_init();
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] board: ls1043ardb: force PCI device enumeration
2021-11-23 6:28 [PATCH] board: ls1043ardb: force PCI device enumeration Martin Schiller
@ 2021-11-23 10:34 ` Camelia Alexandra Groza (OSS)
2021-12-06 8:24 ` Priyanka Jain (OSS)
0 siblings, 1 reply; 3+ messages in thread
From: Camelia Alexandra Groza (OSS) @ 2021-11-23 10:34 UTC (permalink / raw)
To: Martin Schiller, u-boot; +Cc: Priyanka Jain
> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin Schiller
> Sent: Tuesday, November 23, 2021 8:28
> To: u-boot@lists.denx.de
> Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain
> <priyanka.jain@nxp.com>; Camelia Alexandra Groza
> <camelia.groza@nxp.com>
> Subject: [PATCH] board: ls1043ardb: force PCI device enumeration
>
> Commit eb1986804d1d ("configs: enable DM_ETH support for LS1043ARDB")
> resulted in the PCI bus no longer being implicitly enumerated.
>
> However, this is necessary for the fdt pcie fixups to work.
>
> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
> transition to DM_ETH"), pci_init() is now called in the board_init()
> routine when CONFIG_DM_ETH is active.
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> CC: Priyanka Jain <priyanka.jain@nxp.com>
> CC: Camelia Groza <camelia.groza@nxp.com>
> ---
> board/freescale/ls1043ardb/ls1043ardb.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/board/freescale/ls1043ardb/ls1043ardb.c
> b/board/freescale/ls1043ardb/ls1043ardb.c
> index beef26b084..1764c9336c 100644
> --- a/board/freescale/ls1043ardb/ls1043ardb.c
> +++ b/board/freescale/ls1043ardb/ls1043ardb.c
> @@ -219,6 +219,10 @@ int board_init(void)
> ppa_init();
> #endif
>
> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
> + pci_init();
> +#endif
> +
> #ifdef CONFIG_U_QE
> u_qe_init();
> #endif
Thanks for the fix.
Acked-by: Camelia Groza <camelia.groza@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] board: ls1043ardb: force PCI device enumeration
2021-11-23 10:34 ` Camelia Alexandra Groza (OSS)
@ 2021-12-06 8:24 ` Priyanka Jain (OSS)
0 siblings, 0 replies; 3+ messages in thread
From: Priyanka Jain (OSS) @ 2021-12-06 8:24 UTC (permalink / raw)
To: Camelia Alexandra Groza (OSS), Martin Schiller, u-boot
>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Camelia Alexandra
>Groza (OSS)
>Sent: Tuesday, November 23, 2021 4:04 PM
>To: Martin Schiller <ms@dev.tdt.de>; u-boot@lists.denx.de
>Cc: Priyanka Jain <priyanka.jain@nxp.com>
>Subject: RE: [PATCH] board: ls1043ardb: force PCI device enumeration
>
>> -----Original Message-----
>> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Martin
>> Schiller
>> Sent: Tuesday, November 23, 2021 8:28
>> To: u-boot@lists.denx.de
>> Cc: Martin Schiller <ms@dev.tdt.de>; Priyanka Jain
>> <priyanka.jain@nxp.com>; Camelia Alexandra Groza
>> <camelia.groza@nxp.com>
>> Subject: [PATCH] board: ls1043ardb: force PCI device enumeration
>>
>> Commit eb1986804d1d ("configs: enable DM_ETH support for LS1043ARDB")
>> resulted in the PCI bus no longer being implicitly enumerated.
>>
>> However, this is necessary for the fdt pcie fixups to work.
>>
>> Therefore, similar to commit 8b6558bd4187 ("board: ls1088ardb:
>> transition to DM_ETH"), pci_init() is now called in the board_init()
>> routine when CONFIG_DM_ETH is active.
>>
>> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
>> CC: Priyanka Jain <priyanka.jain@nxp.com>
>> CC: Camelia Groza <camelia.groza@nxp.com>
>> ---
>> board/freescale/ls1043ardb/ls1043ardb.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/board/freescale/ls1043ardb/ls1043ardb.c
>> b/board/freescale/ls1043ardb/ls1043ardb.c
>> index beef26b084..1764c9336c 100644
>> --- a/board/freescale/ls1043ardb/ls1043ardb.c
>> +++ b/board/freescale/ls1043ardb/ls1043ardb.c
>> @@ -219,6 +219,10 @@ int board_init(void)
>> ppa_init();
>> #endif
>>
>> +#if !defined(CONFIG_SYS_EARLY_PCI_INIT) && defined(CONFIG_DM_ETH)
>> + pci_init();
>> +#endif
>> +
>> #ifdef CONFIG_U_QE
>> u_qe_init();
>> #endif
>
>Thanks for the fix.
>
>Acked-by: Camelia Groza <camelia.groza@nxp.com>
Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-06 8:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 6:28 [PATCH] board: ls1043ardb: force PCI device enumeration Martin Schiller
2021-11-23 10:34 ` Camelia Alexandra Groza (OSS)
2021-12-06 8:24 ` Priyanka Jain (OSS)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.