All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7d: fix opp-supported-hw
@ 2020-01-19 10:09 ` Peng Fan
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2020-01-19 10:09 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer
  Cc: kernel, festevam, dl-linux-imx, devicetree, linux-arm-kernel,
	Leonard Crestez, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Per i.MX7D Document Number: IMX7DCEC Rev. 6, 03/2019,
there are only consumer/industrial parts, and 1.2GHz
is only support in consumer parts.

So exclude automotive from 792/996MHz/1.2GHz and exclude
industrial from 1.2GHz.

Fixes: d7bfba7296ca ("ARM: dts: imx7d: Update cpufreq OPP table")
Cc: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/boot/dts/imx7d.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 92f6d0c2a74f..4c22828df55f 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -44,7 +44,7 @@
 			opp-hz = /bits/ 64 <792000000>;
 			opp-microvolt = <1000000>;
 			clock-latency-ns = <150000>;
-			opp-supported-hw = <0xd>, <0xf>;
+			opp-supported-hw = <0xd>, <0x7>;
 			opp-suspend;
 		};
 
@@ -52,7 +52,7 @@
 			opp-hz = /bits/ 64 <996000000>;
 			opp-microvolt = <1100000>;
 			clock-latency-ns = <150000>;
-			opp-supported-hw = <0xc>, <0xf>;
+			opp-supported-hw = <0xc>, <0x7>;
 			opp-suspend;
 		};
 
@@ -60,7 +60,7 @@
 			opp-hz = /bits/ 64 <1200000000>;
 			opp-microvolt = <1225000>;
 			clock-latency-ns = <150000>;
-			opp-supported-hw = <0x8>, <0xf>;
+			opp-supported-hw = <0x8>, <0x3>;
 			opp-suspend;
 		};
 	};
-- 
2.16.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx7d: fix opp-supported-hw
@ 2020-01-19 10:09 ` Peng Fan
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2020-01-19 10:09 UTC (permalink / raw)
  To: robh+dt, mark.rutland, shawnguo, s.hauer
  Cc: devicetree, Peng Fan, dl-linux-imx, kernel, Leonard Crestez,
	festevam, linux-arm-kernel

From: Peng Fan <peng.fan@nxp.com>

Per i.MX7D Document Number: IMX7DCEC Rev. 6, 03/2019,
there are only consumer/industrial parts, and 1.2GHz
is only support in consumer parts.

So exclude automotive from 792/996MHz/1.2GHz and exclude
industrial from 1.2GHz.

Fixes: d7bfba7296ca ("ARM: dts: imx7d: Update cpufreq OPP table")
Cc: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/boot/dts/imx7d.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 92f6d0c2a74f..4c22828df55f 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -44,7 +44,7 @@
 			opp-hz = /bits/ 64 <792000000>;
 			opp-microvolt = <1000000>;
 			clock-latency-ns = <150000>;
-			opp-supported-hw = <0xd>, <0xf>;
+			opp-supported-hw = <0xd>, <0x7>;
 			opp-suspend;
 		};
 
@@ -52,7 +52,7 @@
 			opp-hz = /bits/ 64 <996000000>;
 			opp-microvolt = <1100000>;
 			clock-latency-ns = <150000>;
-			opp-supported-hw = <0xc>, <0xf>;
+			opp-supported-hw = <0xc>, <0x7>;
 			opp-suspend;
 		};
 
@@ -60,7 +60,7 @@
 			opp-hz = /bits/ 64 <1200000000>;
 			opp-microvolt = <1225000>;
 			clock-latency-ns = <150000>;
-			opp-supported-hw = <0x8>, <0xf>;
+			opp-supported-hw = <0x8>, <0x3>;
 			opp-suspend;
 		};
 	};
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: fix opp-supported-hw
  2020-01-19 10:09 ` Peng Fan
@ 2020-01-20 13:57   ` Leonard Crestez
  -1 siblings, 0 replies; 6+ messages in thread
From: Leonard Crestez @ 2020-01-20 13:57 UTC (permalink / raw)
  To: Peng Fan, shawnguo
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, dl-linux-imx,
	devicetree, linux-arm-kernel, Anson Huang

On 19.01.2020 12:09, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX7D Document Number: IMX7DCEC Rev. 6, 03/2019,
> there are only consumer/industrial parts, and 1.2GHz
> is only support in consumer parts.
> 
> So exclude automotive from 792/996MHz/1.2GHz and exclude
> industrial from 1.2GHz.
> 
> Fixes: d7bfba7296ca ("ARM: dts: imx7d: Update cpufreq OPP table")
> Cc: Leonard Crestez <leonard.crestez@nxp.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com>

My initial logic was that there is no particular reason to guard against 
parts which are not documented to exist so checking the speed grading 
should be sufficient.

With this patch if an imx7d chip with automotive qualification is 
released in the future (unlikely) then dtsi changes will be required 
before enabling cpufreq. This is not unreasonable.

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>

> ---
>   arch/arm/boot/dts/imx7d.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 92f6d0c2a74f..4c22828df55f 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -44,7 +44,7 @@
>   			opp-hz = /bits/ 64 <792000000>;
>   			opp-microvolt = <1000000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0xd>, <0xf>;
> +			opp-supported-hw = <0xd>, <0x7>;
>   			opp-suspend;
>   		};
>   
> @@ -52,7 +52,7 @@
>   			opp-hz = /bits/ 64 <996000000>;
>   			opp-microvolt = <1100000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0xc>, <0xf>;
> +			opp-supported-hw = <0xc>, <0x7>;
>   			opp-suspend;
>   		};
>   
> @@ -60,7 +60,7 @@
>   			opp-hz = /bits/ 64 <1200000000>;
>   			opp-microvolt = <1225000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0x8>, <0xf>;
> +			opp-supported-hw = <0x8>, <0x3>;
>   			opp-suspend;
>   		};
>   	};
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: fix opp-supported-hw
@ 2020-01-20 13:57   ` Leonard Crestez
  0 siblings, 0 replies; 6+ messages in thread
From: Leonard Crestez @ 2020-01-20 13:57 UTC (permalink / raw)
  To: Peng Fan, shawnguo
  Cc: mark.rutland, devicetree, Anson Huang, s.hauer, robh+dt,
	dl-linux-imx, kernel, festevam, linux-arm-kernel

On 19.01.2020 12:09, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX7D Document Number: IMX7DCEC Rev. 6, 03/2019,
> there are only consumer/industrial parts, and 1.2GHz
> is only support in consumer parts.
> 
> So exclude automotive from 792/996MHz/1.2GHz and exclude
> industrial from 1.2GHz.
> 
> Fixes: d7bfba7296ca ("ARM: dts: imx7d: Update cpufreq OPP table")
> Cc: Leonard Crestez <leonard.crestez@nxp.com> > Signed-off-by: Peng Fan <peng.fan@nxp.com>

My initial logic was that there is no particular reason to guard against 
parts which are not documented to exist so checking the speed grading 
should be sufficient.

With this patch if an imx7d chip with automotive qualification is 
released in the future (unlikely) then dtsi changes will be required 
before enabling cpufreq. This is not unreasonable.

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>

> ---
>   arch/arm/boot/dts/imx7d.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 92f6d0c2a74f..4c22828df55f 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -44,7 +44,7 @@
>   			opp-hz = /bits/ 64 <792000000>;
>   			opp-microvolt = <1000000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0xd>, <0xf>;
> +			opp-supported-hw = <0xd>, <0x7>;
>   			opp-suspend;
>   		};
>   
> @@ -52,7 +52,7 @@
>   			opp-hz = /bits/ 64 <996000000>;
>   			opp-microvolt = <1100000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0xc>, <0xf>;
> +			opp-supported-hw = <0xc>, <0x7>;
>   			opp-suspend;
>   		};
>   
> @@ -60,7 +60,7 @@
>   			opp-hz = /bits/ 64 <1200000000>;
>   			opp-microvolt = <1225000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0x8>, <0xf>;
> +			opp-supported-hw = <0x8>, <0x3>;
>   			opp-suspend;
>   		};
>   	};
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: fix opp-supported-hw
  2020-01-19 10:09 ` Peng Fan
@ 2020-02-14  1:02   ` Shawn Guo
  -1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-02-14  1:02 UTC (permalink / raw)
  To: Peng Fan
  Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, dl-linux-imx,
	devicetree, linux-arm-kernel, Leonard Crestez

On Sun, Jan 19, 2020 at 10:09:32AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX7D Document Number: IMX7DCEC Rev. 6, 03/2019,
> there are only consumer/industrial parts, and 1.2GHz
> is only support in consumer parts.
> 
> So exclude automotive from 792/996MHz/1.2GHz and exclude
> industrial from 1.2GHz.
> 
> Fixes: d7bfba7296ca ("ARM: dts: imx7d: Update cpufreq OPP table")
> Cc: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx7d: fix opp-supported-hw
@ 2020-02-14  1:02   ` Shawn Guo
  0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-02-14  1:02 UTC (permalink / raw)
  To: Peng Fan
  Cc: mark.rutland, devicetree, s.hauer, robh+dt, dl-linux-imx, kernel,
	Leonard Crestez, festevam, linux-arm-kernel

On Sun, Jan 19, 2020 at 10:09:32AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Per i.MX7D Document Number: IMX7DCEC Rev. 6, 03/2019,
> there are only consumer/industrial parts, and 1.2GHz
> is only support in consumer parts.
> 
> So exclude automotive from 792/996MHz/1.2GHz and exclude
> industrial from 1.2GHz.
> 
> Fixes: d7bfba7296ca ("ARM: dts: imx7d: Update cpufreq OPP table")
> Cc: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-14  1:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-19 10:09 [PATCH] ARM: dts: imx7d: fix opp-supported-hw Peng Fan
2020-01-19 10:09 ` Peng Fan
2020-01-20 13:57 ` Leonard Crestez
2020-01-20 13:57   ` Leonard Crestez
2020-02-14  1:02 ` Shawn Guo
2020-02-14  1:02   ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.