From: Daniel Jurgens <danielj@mellanox.com> To: James Morris <jmorris@namei.org> Cc: Chris Wright <chrisw@sous-sol.org>, Paul Moore <paul@paul-moore.com>, Stephen Smalley <sds@tycho.nsa.gov>, Eric Paris <eparis@parisplace.org>, "dledford@redhat.com" <dledford@redhat.com>, "sean.hefty@intel.com" <sean.hefty@intel.com>, "hal.rosenstock@gmail.com" <hal.rosenstock@gmail.com>, "selinux@tycho.nsa.gov" <selinux@tycho.nsa.gov>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>, Yevgeny Petrilin <yevgenyp@mellanox.com> Subject: Re: [PATCH v7 2/9] IB/core: Enforce PKey security on QPs Date: Mon, 22 May 2017 10:42:22 +0000 [thread overview] Message-ID: <VI1PR05MB167814F66EEF8A1BD77C793AC4F80@VI1PR05MB1678.eurprd05.prod.outlook.com> (raw) In-Reply-To: alpine.LRH.2.20.1705220959450.3502@namei.org On 5/21/2017 7:13 PM, James Morris wrote: > On Fri, 19 May 2017, Dan Jurgens wrote: > >> security/security.c | 385 ++++++++++++++++++++++ > This looks wrong -- merge problem? Yes, it was a merge problem. I added back the per field initialization of the security head hooks. Paul stripped this (and the same problem in patch 0004) himself before merging. > > >> + if (pps->alt.state != IB_PORT_PKEY_NOT_VALID) { >> + get_pkey_and_subnet_prefix(&pps->alt, >> + &pkey, >> + &subnet_prefix); >> + >> + ret = enforce_qp_pkey_security(pkey, >> + subnet_prefix, >> + sec); >> + } >> + >> + if (ret) >> + goto out; > The above if/goto is unnecessary. Right. Paul, do you want me to fix this with a new patch? > >> + >> +out: >> + return ret; >> +} > >
WARNING: multiple messages have this Message-ID (diff)
From: danielj@mellanox.com (Daniel Jurgens) To: linux-security-module@vger.kernel.org Subject: [PATCH v7 2/9] IB/core: Enforce PKey security on QPs Date: Mon, 22 May 2017 10:42:22 +0000 [thread overview] Message-ID: <VI1PR05MB167814F66EEF8A1BD77C793AC4F80@VI1PR05MB1678.eurprd05.prod.outlook.com> (raw) In-Reply-To: alpine.LRH.2.20.1705220959450.3502@namei.org On 5/21/2017 7:13 PM, James Morris wrote: > On Fri, 19 May 2017, Dan Jurgens wrote: > >> security/security.c | 385 ++++++++++++++++++++++ > This looks wrong -- merge problem? Yes, it was a merge problem. I added back the per field initialization of the security head hooks. Paul stripped this (and the same problem in patch 0004) himself before merging. > > >> + if (pps->alt.state != IB_PORT_PKEY_NOT_VALID) { >> + get_pkey_and_subnet_prefix(&pps->alt, >> + &pkey, >> + &subnet_prefix); >> + >> + ret = enforce_qp_pkey_security(pkey, >> + subnet_prefix, >> + sec); >> + } >> + >> + if (ret) >> + goto out; > The above if/goto is unnecessary. Right. Paul, do you want me to fix this with a new patch? > >> + >> +out: >> + return ret; >> +} > > -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-22 10:42 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-19 12:48 [PATCH v7 0/9] SELinux support for Infiniband RDMA Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-19 12:48 ` [PATCH v7 1/9] IB/core: IB cache enhancements to support Infiniband security Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-21 23:56 ` James Morris 2017-05-21 23:56 ` James Morris 2017-05-19 12:48 ` [PATCH v7 2/9] IB/core: Enforce PKey security on QPs Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens [not found] ` <1495198139-69993-3-git-send-email-danielj-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2017-05-19 19:13 ` Paul Moore 2017-05-19 19:13 ` Paul Moore 2017-05-19 19:13 ` Paul Moore 2017-05-22 0:13 ` James Morris 2017-05-22 0:13 ` James Morris 2017-05-22 0:13 ` James Morris 2017-05-22 10:42 ` Daniel Jurgens [this message] 2017-05-22 10:42 ` Daniel Jurgens [not found] ` <VI1PR05MB167814F66EEF8A1BD77C793AC4F80-79XLn2atqDOzmZAjKwT+HdqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-05-22 20:59 ` Paul Moore 2017-05-22 20:59 ` Paul Moore 2017-05-22 20:59 ` Paul Moore 2017-05-19 12:48 ` [PATCH v7 5/9] selinux: Create policydb version for Infiniband support Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-22 0:24 ` James Morris 2017-05-22 0:24 ` James Morris [not found] ` <1495198139-69993-1-git-send-email-danielj-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2017-05-19 12:48 ` [PATCH v7 3/9] selinux lsm IB/core: Implement LSM notification system Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-22 0:15 ` James Morris 2017-05-22 0:15 ` James Morris 2017-05-19 12:48 ` [PATCH v7 4/9] IB/core: Enforce security on management datagrams Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-19 19:21 ` Paul Moore 2017-05-19 19:21 ` Paul Moore 2017-05-19 23:57 ` Daniel Jurgens 2017-05-19 23:57 ` Daniel Jurgens 2017-05-19 12:48 ` [PATCH v7 6/9] selinux: Allocate and free infiniband security hooks Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-22 0:26 ` James Morris 2017-05-22 0:26 ` James Morris 2017-05-19 12:48 ` [PATCH v7 8/9] selinux: Add IB Port SMP access vector Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens [not found] ` <1495198139-69993-9-git-send-email-danielj-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2017-05-22 0:32 ` James Morris 2017-05-22 0:32 ` James Morris 2017-05-22 0:32 ` James Morris 2017-05-19 12:48 ` [PATCH v7 7/9] selinux: Implement Infiniband PKey "Access" " Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens [not found] ` <1495198139-69993-8-git-send-email-danielj-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2017-05-22 0:31 ` James Morris 2017-05-22 0:31 ` James Morris 2017-05-22 0:31 ` James Morris 2017-05-19 12:48 ` [PATCH v7 9/9] selinux: Add a cache for quicker retreival of PKey SIDs Dan Jurgens 2017-05-19 12:48 ` Dan Jurgens 2017-05-19 16:47 ` [PATCH v7 0/9] SELinux support for Infiniband RDMA Daniel Jurgens 2017-05-19 16:47 ` Daniel Jurgens 2017-05-19 19:35 ` Paul Moore 2017-05-19 19:35 ` Paul Moore 2017-05-20 0:10 ` Daniel Jurgens 2017-05-20 0:10 ` Daniel Jurgens 2017-05-20 0:10 ` Daniel Jurgens [not found] ` <CAHC9VhQtw4fFrCdKcznHrLDkAJVDhi=y9dYMxtOP23XVKq+rCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-05-20 11:56 ` Doug Ledford 2017-05-20 11:56 ` Doug Ledford 2017-05-22 0:35 ` James Morris 2017-05-22 0:35 ` James Morris 2017-05-22 10:50 ` Daniel Jurgens 2017-05-22 10:50 ` Daniel Jurgens [not found] ` <alpine.LRH.2.20.1705221033550.3502-gx6/JNMH7DfYtjvyW6yDsg@public.gmane.org> 2017-05-22 19:14 ` Paul Moore 2017-05-22 19:14 ` Paul Moore 2017-05-22 19:14 ` Paul Moore
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR05MB167814F66EEF8A1BD77C793AC4F80@VI1PR05MB1678.eurprd05.prod.outlook.com \ --to=danielj@mellanox.com \ --cc=chrisw@sous-sol.org \ --cc=dledford@redhat.com \ --cc=eparis@parisplace.org \ --cc=hal.rosenstock@gmail.com \ --cc=jmorris@namei.org \ --cc=linux-rdma@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=paul@paul-moore.com \ --cc=sds@tycho.nsa.gov \ --cc=sean.hefty@intel.com \ --cc=selinux@tycho.nsa.gov \ --cc=yevgenyp@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.