DTC: unaligned memory offset in FIT image

* DTC: unaligned memory offset in FIT image
@ 2017-07-20  8:28 DHANAPAL, GNANACHANDRAN (G.)
       [not found] ` <VI1PR06MB1599BC212592810ABBE36E2D82A70-8LfwjTntTp1Wb/rYCsWsVK71xdIjGZSdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: DHANAPAL, GNANACHANDRAN (G.) @ 2017-07-20  8:28 UTC (permalink / raw)
  To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
  Cc: david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+,
	jdl-CYoMK+44s/E, Babu, Viswanathan (V.),
	Ravindran, Madhusudhanan (M.), Gujulan Elango, Hari Prasath (H.),
	CN, Aananth (A.A.),
	'gnanachandran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org'

[-- Attachment #1: Type: text/plain, Size: 3308 bytes --]

Resending this mail  presuming previous mail was lost

Hi There,

In our  R-car H3 based customized automotive product, we are using  U-boot ( bootloader), FIT image (Linux kernel + DTB) and root file system provided by Renesas provide BSP 2.16.0.  FIT image has compressed Linux kernel and uncompressed DTB. While loading the FIT image, system reboot happens with following boot log.

reading fitImage_monarch
6627756 bytes read in 299 ms (21.1 MiB/s) ## Loading kernel from FIT Image at 4c000000 ...
   Using 'conf@1' configuration
   Trying 'kernel@1' kernel subimage
     Description:  Linux kernel
     Type:         Kernel Image
     Compression:  gzip compressed
     Data Start:   0x4c000114
     Data Size:    6557502 Bytes = 6.3 MiB
     Architecture: AArch64
     OS:           Linux
     Load Address: 0x48080000
     Entry Point:  0x48080000
     Hash algo:    sha1
     Hash value:   2638b7ad761ed7c70d9053908f274e5617e7ae75
   Verifying Hash Integrity ... sha1+ OK ## Loading fdt from FIT Image at 4c000000 ...
   Using 'conf@1' configuration
   Trying 'fdt@1' fdt subimage
     Description:  Flattened Device Tree blob
     Type:         Flat Device Tree
     Compression:  uncompressed
     Data Start:   0x4c64114c
     Data Size:    68887 Bytes = 67.3 KiB
     Architecture: AArch64
     Hash algo:    sha1
     Hash value:   c29c2b38626b8af9cfd5c1b513a179fc6dcd1db2
   Verifying Hash Integrity ... sha1+ OK
   Booting using the fdt blob at 0x4c64114c
   Uncompressing Kernel Image ... OK
"Synchronous Abort" handler, esr 0x96000021
ELR:     50029550
LR:      5001117c
x0 : 0000000000000000 x1 : 000000004c64117c
x2 : 0000000000000011 x3 : 0000000000000009
x4 : 0000000000000000 x5 : 0000000050038eed
x6 : 0000000000000002 x7 : 000000005005aa98
x8 : 0000000000000000 x9 : 00000000ffffffff
x10: 0000000048e2ba00 x11: 0000000000000001
x12: 0000000000000060 x13: 00000000000001ff
x14: 000000000000003f x15: 000000007fe61670
x16: 000000007fe61e70 x17: 0000000100000000
x18: 000000007fe5ae20 x19: 0000000000000000
x20: 000000004c64114c x21: 000000005003e3db
x22: 000000005005a898 x23: 000000005005a9d8
x24: 0000000000000000 x25: 000000005004e5f0
x26: 000000004c000114 x27: 00000000500018b0
x28: 0000000048080000 x29: 000000007fe5a580

Resetting CPU ...

From log, we observed that Data start address for both kernel (0x4C000114) and DTB (0x4c64114c) are not 64bit aligned.
DTC that generates the FIT image doesn't align FIT description text (shown below) hence offset of kernel and DTC are moved to Non 64 bit align address 

        description = "U-Boot fitImage for Poky (Yocto Project Reference Distro)/4.9.0+gitAUTOINC+13e7680774/smartcore2";
        #address-cells = <1>;

String len of description is 97 bytes.  By changing this description length to multiple of 8, FIT image works properly.
Please find the attached .its file used for FIT image creation

In DTC source code, function flatten_tree in file flattree.c, 8 bytes alignment is skipped for DTC version 17.

if ((vi->flags & FTF_VARALIGN) && (prop->val.len >= 8))
                        emit->align(etarget, 8);

May I know reason why FTF_VARALIGN is skipped for version 17 or Is  there other way  this can be handle in latest DTC.

Cheers
Gnana

[-- Attachment #2: fit-image.its --]
[-- Type: application/octet-stream, Size: 1458 bytes --]

/dts-v1/;

/ {
        description = "U-Boot fitImage for Poky (Yocto Project Reference Distro)/4.9.0+gitAUTOINC+13e7680774/smartcore2";
        #address-cells = <1>;

        images {
                kernel@1 {
                        description = "Linux kernel";
                        data = /incbin/("./linux.bin");
                        type = "kernel";
                        arch = "arm64";
                        os = "linux";
                        compression = "gzip";
                        load = <0x48080000>;
                        entry = <0x48080000>;
                        hash@1 {
                                algo = "sha1";
                        };
                };
                fdt@1 {
                        description = "Flattened Device Tree blob";
                        data = /incbin/("./r8a7795-smartcore2.dtb");
                        type = "flat_dt";
                        arch = "arm64";
                        compression = "none";
                        hash@1 {
                                algo = "sha1";
                        };
                };
	};

        configurations {
                default = "conf@1";
                conf@1 {
                        description = "Boot Linux kernel with FDT blob";
			kernel = "kernel@1";
			fdt = "fdt@1";
                        hash@1 {
                                algo = "sha1";
                        };
                };
	};
};

^ permalink raw reply	[flat|nested] 6+ messages in thread