* linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition
@ 2017-09-25 13:54 David Binderman
2017-09-25 14:58 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2017-09-25 13:54 UTC (permalink / raw)
To: linux, jdelvare, linux-hwmon, linux-kernel
Hello there,
linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition: upper. '!upper || (upper && data->has_status_word)' is equivalent to '!upper || data->has_status_word'
Source code is
(!upper || (upper && data->has_status_word)) &&
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition
2017-09-25 13:54 linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition David Binderman
@ 2017-09-25 14:58 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-09-25 14:58 UTC (permalink / raw)
To: David Binderman; +Cc: jdelvare, linux-hwmon, linux-kernel
On Mon, Sep 25, 2017 at 01:54:02PM +0000, David Binderman wrote:
>
> Hello there,
>
> linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition: upper. '!upper || (upper && data->has_status_word)' is equivalent to '!upper || data->has_status_word'
>
> Source code is
>
> (!upper || (upper && data->has_status_word)) &&
>
Please feel free to submit a patch.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-25 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-25 13:54 linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition David Binderman
2017-09-25 14:58 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.