* [dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include
@ 2021-01-29 20:33 David Marchand
2021-02-01 7:51 ` Ruifeng Wang
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic " David Marchand
0 siblings, 2 replies; 7+ messages in thread
From: David Marchand @ 2021-01-29 20:33 UTC (permalink / raw)
To: dev
Cc: konstantin.ananyev, bruce.richardson, stable, Olivier Matz,
Ruifeng Wang, Phil Yang, Andrew Rybchenko, Thomas Monjalon
There is no need for the direct inclusion of the generic/ header [1]
now that we don't use the rte_atomic API anymore.
1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_mbuf/rte_mbuf_core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
index a85cabdd18..9d1609336a 100644
--- a/lib/librte_mbuf/rte_mbuf_core.h
+++ b/lib/librte_mbuf/rte_mbuf_core.h
@@ -20,7 +20,6 @@
#include <rte_compat.h>
#include <rte_byteorder.h>
-#include <generic/rte_atomic.h>
#ifdef __cplusplus
extern "C" {
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include
2021-01-29 20:33 [dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include David Marchand
@ 2021-02-01 7:51 ` Ruifeng Wang
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic " David Marchand
1 sibling, 0 replies; 7+ messages in thread
From: Ruifeng Wang @ 2021-02-01 7:51 UTC (permalink / raw)
To: David Marchand, dev
Cc: konstantin.ananyev, bruce.richardson, stable, Olivier Matz,
Phil Yang, Andrew Rybchenko, thomas, nd
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Saturday, January 30, 2021 4:33 AM
> To: dev@dpdk.org
> Cc: konstantin.ananyev@intel.com; bruce.richardson@intel.com;
> stable@dpdk.org; Olivier Matz <olivier.matz@6wind.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Phil Yang <Phil.Yang@arm.com>; Andrew
> Rybchenko <arybchenko@solarflare.com>; thomas@monjalon.net
> Subject: [PATCH] mbuf: remove unneeded EAL header include
>
> There is no need for the direct inclusion of the generic/ header [1] now that
> we don't use the rte_atomic API anymore.
>
> 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
>
> Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/librte_mbuf/rte_mbuf_core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h
> b/lib/librte_mbuf/rte_mbuf_core.h index a85cabdd18..9d1609336a 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -20,7 +20,6 @@
>
> #include <rte_compat.h>
> #include <rte_byteorder.h>
> -#include <generic/rte_atomic.h>
>
> #ifdef __cplusplus
> extern "C" {
> --
> 2.23.0
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include
2021-01-29 20:33 [dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include David Marchand
2021-02-01 7:51 ` Ruifeng Wang
@ 2021-02-04 10:05 ` David Marchand
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check David Marchand
2021-02-04 13:35 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include Andrew Rybchenko
1 sibling, 2 replies; 7+ messages in thread
From: David Marchand @ 2021-02-04 10:05 UTC (permalink / raw)
To: dev
Cc: konstantin.ananyev, bruce.richardson, stable, Ruifeng Wang,
Olivier Matz, Phil Yang, Andrew Rybchenko, Thomas Monjalon
There is no need for the direct inclusion of the generic/ header [1]
now that we don't use the rte_atomic API anymore.
1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
lib/librte_mbuf/rte_mbuf_core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
index a85cabdd18..9d1609336a 100644
--- a/lib/librte_mbuf/rte_mbuf_core.h
+++ b/lib/librte_mbuf/rte_mbuf_core.h
@@ -20,7 +20,6 @@
#include <rte_compat.h>
#include <rte_byteorder.h>
-#include <generic/rte_atomic.h>
#ifdef __cplusplus
extern "C" {
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic " David Marchand
@ 2021-02-04 10:05 ` David Marchand
2021-02-04 10:26 ` Bruce Richardson
2021-02-04 13:35 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include Andrew Rybchenko
1 sibling, 1 reply; 7+ messages in thread
From: David Marchand @ 2021-02-04 10:05 UTC (permalink / raw)
To: dev; +Cc: konstantin.ananyev, bruce.richardson
Previous patch just removes the last case of direct inclusion of the
generic/ headers.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
buildtools/chkincs/meson.build | 1 -
1 file changed, 1 deletion(-)
diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index f345e87551..f28cfd3cd4 100644
--- a/buildtools/chkincs/meson.build
+++ b/buildtools/chkincs/meson.build
@@ -17,7 +17,6 @@ gen_c_files = generator(gen_c_file_for_header,
arguments: ['@INPUT@', '@OUTPUT@'])
cflags = machine_args
-cflags += '-Wno-unused-function' # needed if we include generic headers
cflags += '-DALLOW_EXPERIMENTAL_API'
sources = files('main.c')
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check David Marchand
@ 2021-02-04 10:26 ` Bruce Richardson
2021-02-05 18:48 ` Thomas Monjalon
0 siblings, 1 reply; 7+ messages in thread
From: Bruce Richardson @ 2021-02-04 10:26 UTC (permalink / raw)
To: David Marchand; +Cc: dev, konstantin.ananyev
On Thu, Feb 04, 2021 at 11:05:20AM +0100, David Marchand wrote:
> Previous patch just removes the last case of direct inclusion of the
> generic/ headers.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic " David Marchand
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check David Marchand
@ 2021-02-04 13:35 ` Andrew Rybchenko
1 sibling, 0 replies; 7+ messages in thread
From: Andrew Rybchenko @ 2021-02-04 13:35 UTC (permalink / raw)
To: David Marchand, dev
Cc: konstantin.ananyev, bruce.richardson, stable, Ruifeng Wang,
Olivier Matz, Phil Yang, Andrew Rybchenko, Thomas Monjalon
On 2/4/21 1:05 PM, David Marchand wrote:
> There is no need for the direct inclusion of the generic/ header [1]
> now that we don't use the rte_atomic API anymore.
>
> 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
>
> Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check
2021-02-04 10:26 ` Bruce Richardson
@ 2021-02-05 18:48 ` Thomas Monjalon
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2021-02-05 18:48 UTC (permalink / raw)
To: David Marchand
Cc: dev, konstantin.ananyev, Bruce Richardson, andrew.rybchenko
04/02/2021 11:26, Bruce Richardson:
> On Thu, Feb 04, 2021 at 11:05:20AM +0100, David Marchand wrote:
> > Previous patch just removes the last case of direct inclusion of the
> > generic/ headers.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
I think this patch is better understood (in git history I mean)
if squashed with the previous one.
Removing this flag is the direct consequence of removing the include in mbuf.
Squashed and applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-05 18:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-29 20:33 [dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include David Marchand
2021-02-01 7:51 ` Ruifeng Wang
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic " David Marchand
2021-02-04 10:05 ` [dpdk-dev] [PATCH v2 2/2] builtools: remove build flag for header includes check David Marchand
2021-02-04 10:26 ` Bruce Richardson
2021-02-05 18:48 ` Thomas Monjalon
2021-02-04 13:35 ` [dpdk-dev] [PATCH v2 1/2] mbuf: remove unneeded atomic header include Andrew Rybchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.