All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Joe Woodward" <jw@terrafix.co.uk>
To: Paul Walmsley <paul@pwsan.com>, "Mark A. Greer" <mgreer@animalcreek.com>
Cc: Kevin Hilman <khilman@ti.com>, linux-omap@vger.kernel.org
Subject: Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?
Date: Tue, 17 Jul 2012 11:08:48 +0100	[thread overview]
Message-ID: <WC20120717100848.280191@terrafix.co.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1207161841260.28834@utopia.booyaka.com>

-----Original Message-----
From: Paul Walmsley <paul@pwsan.com>
To: Joe Woodward <jw@terrafix.co.uk>, "Mark A. Greer" <mgreer@animalcreek.com>
Cc: Kevin Hilman <khilman@ti.com>, linux-omap@vger.kernel.org
Date: Mon, 16 Jul 2012 18:43:15 -0600 (MDT)
Subject: Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

> On Mon, 16 Jul 2012, Mark A. Greer wrote:
> 
> > I'm finally getting around to this...  Unfortunately, I don't have
> the
> > hardware to test it so I can't tell exactly what code needs to run to
> make
> > it work again.   Would you mind identifying the pieces of code need
> to run
> > for it to work?  omap3_has_iva() shows up in just a few places.
> 
> We did a test by removing the two instances in pm34xx.c.  I'm pretty
> sure 
> that the IVAGRPSEL writes are necessary, since the reset values for
> those 
> bits are 1, and those definitely need to be cleared.  Not sure about
> the 
> omap3_iva_idle() call; Joe, maybe you can try with just the first hunk
> of 
> the patch that I sent?

The patch you sent is basically in two halves:
  - the writes to the registers
  - the calling of omap3_iva_idle().

If I patch only the writes to the registers then suspend still fails.
If I patch only the calling of omap3_iva_idle() then suspend works.
If I patch both the writes to the registers and the calling of omap3_iva_idle() then suspend works.

Cheers,
Joe

> 
> 
> - Paul
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



  reply	other threads:[~2012-07-17 10:09 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12  8:15 PM/RTC 3.5-rc5: System suspends fails when not built with RTC? Joe Woodward
2012-07-12 10:59 ` Paul Walmsley
2012-07-12 14:43   ` Joe Woodward
2012-07-12 19:35     ` Paul Walmsley
2012-07-13 10:57       ` Joe Woodward
2012-07-13 18:26         ` Paul Walmsley
2012-07-13 21:28           ` Mark A. Greer
2012-07-17  0:40           ` Mark A. Greer
2012-07-17  0:43             ` Paul Walmsley
2012-07-17 10:08               ` Joe Woodward [this message]
2012-07-17 19:28                 ` Paul Walmsley
2012-07-18  2:20                   ` Mark A. Greer
2012-07-18 10:06                     ` Joe Woodward
2012-07-18 17:26                       ` Mark A. Greer
2012-07-26 21:09                         ` Juha Kuikka
2012-07-26 23:06                           ` Mark A. Greer
2012-07-26 23:08                             ` Mark A. Greer
2012-07-12 18:25 ` Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2012-07-05 15:03 Joe Woodward
2012-07-10 23:58 ` Kevin Hilman
2012-07-11 10:50   ` Joe Woodward
2012-07-11 15:31     ` T Krishnamoorthy, Balaji
2012-07-11 17:07     ` Kevin Hilman
2012-07-11 17:51       ` Mark A. Greer
2012-07-11 18:38         ` Kevin Hilman
2012-07-11 18:48       ` Kevin Hilman
2012-07-11 20:52       ` Omar Ramirez Luna
2012-07-11 21:29         ` Kevin Hilman
2012-07-12  5:56           ` Shubhrajyoti
2012-07-13  6:34           ` Tony Lindgren
2012-07-16 17:18             ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=WC20120717100848.280191@terrafix.co.uk \
    --to=jw@terrafix.co.uk \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.